From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2514CC54ED1 for ; Sat, 28 Jun 2025 16:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A3AD8D0001; Sat, 28 Jun 2025 12:51:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4549D8D0003; Sat, 28 Jun 2025 12:51:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F56D8D0001; Sat, 28 Jun 2025 12:51:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 12AC58D0003 for ; Sat, 28 Jun 2025 12:51:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DF068122FE5 for ; Sat, 28 Jun 2025 16:51:58 +0000 (UTC) X-FDA: 83605401516.26.6C8470F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf19.hostedemail.com (Postfix) with ESMTP id 3B5111A0005 for ; Sat, 28 Jun 2025 16:51:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cuGpmL1m; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751129517; a=rsa-sha256; cv=none; b=UHeDdDse9Ax689vrWVSrgUeyMX9TYdqB1B3z9vOnbYnnlvZFAnZ0cQDRRZiGwhlCMu8B8P Wv3eQhGOlwUz2FVNw0LSPT4TycSoNY4a6uAzVBpdldFDrmxx6eYxv2/gABL+oK2ynkMSdI vSW6kAUcgNkSpriGeKyYW6+U66dREgg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cuGpmL1m; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751129517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Um6XJlFhBMcp3nA0e78DLjmU/GZdQ5+E75sOp+tqnHQ=; b=50wnc5mkMe70G19f/OH3yZEEbhouj0S4xj4SUOuR2uPcBgK8qIuVr5SnGxHZHfSoDRwzpC nFGj8An+criye45r6r4eurga3Bz3lmxnK77SrMny1wo+evO3I3T/etFof8bjMLPuu4Tc0o pTb4nY8XC1+hwt8zSQYjmDU0oZOL1Ag= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5648C463C8; Sat, 28 Jun 2025 16:51:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 114F4C4CEED; Sat, 28 Jun 2025 16:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751129516; bh=AIBeBRbmeSSh7sYS8+FVSI4lH0Rgj/i6prmCLpF8QMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cuGpmL1mJynk5SlCW0enE68mHiib8LrLQH5BBuHmCx0QYi3WTprxvLhjDGwRLqLXt 1RohepaKPT9JSRA/KXO8bBQuR8xlTJtW4TXuqzsLWnNm3Z41kRgNVF52vFkdQYg8ii xdRpEpfpmwn7wXPRnRs/5HQO2zf+GTbYWBPuLWLNHxmkNALaAzHBupUaOu4k1ADoBZ 5c2eAuEBU4o5EeGVx01M1k9Jh7YHRhX+dvV8m7IuDl3JIx5mKpV6i+khgGHKQq24qu mh1vFB0DzqrZfDAwZ8TceX6BYzoGDp8lEbbepnlVRnnz2bPGm8YxuobQk4gygLMZVB Ak0rXqC6k6ksQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 08/11] mm/damon/lru_sort: support active:inactive memory ratio based auto-tuning Date: Sat, 28 Jun 2025 09:51:41 -0700 Message-Id: <20250628165144.55528-9-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250628165144.55528-1-sj@kernel.org> References: <20250628165144.55528-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3B5111A0005 X-Stat-Signature: fh1ik4ksxezmcp5aa9b4jn5f6bsc7w7m X-Rspam-User: X-HE-Tag: 1751129517-915396 X-HE-Meta: U2FsdGVkX1+zlxSwvRr5ELjVGcxmaPb79BU6RsOQpHx+igXLj7dUgZuJw6qGfSqxZSzDkLVsIHTRrS8BI07nsgwwq8I2W4w6yab+vXAlwC6SDrDXDLqsr3BwEoTqr10NWzi7qKFieEaGSlMF+uHvqLvtNmJP1bNWyVbEqd+Yd1VSr5yNNj8wGlXGhBGVg5nbNL9UNVD5y4vTlaoxWcDE0arExh8o9k+P1gmB0FTOhlv537vzdvGLrradHtb4vv+3O3X28yNCmG8gv7whf0qSAQr424wGvWMxVB12qj05fCdzC86KG38GYKm+0EikHQLHqrAyrgmVGuKpHiQ1Y+UisKOaDYGM03n5NYCNkgg6SfevfkFUa2jMf8Kqrmtv3PCiFlTdLoMKh8Ne3jo6NpKOcNNazafCuxpvAeC/IzI6Lrz1EMV4Fwzs5SXhCu6/wk8B78WhbNCm+jXges2pwxp/98d3uZABn0ie2Jm1nzOkoz1S4PVvFKM7nX30lYWVAZHJCcoyLZP7JNAmBVeDikPdzm8CUCjaKczFB0RvoVG+WCmPt7brPLWJYajFJ2PTFrY5tifnC1BPboH/RdrfcamK7Cbrt/eHHTyVSh6pm8BhRMEJIPHQT1or7SyTrsKueFgeqjjPRS2JC/ogUuRbZJEp++TgwQ+trwj1tGRbqIGlmqNVx/BvLitmHY6tXhIrjhsKuYazSd1Kfze8JB8HK925eVJYD48QK1urUd1wQYPXA53s4RhqgwvzWgXdwABEfcpAh2JgCWllHs8N1n4WOJnyK5VgNAwtTifSFyUjPankIG4v52blpDhU5oHjHADkQcc16Drx8OCokHwgeObddfMdZjzSIjh5CRYM/BolzkFxHuADywGOo8RK0an5PnHOERKr4UGPK1w/PMSBZ81H7tENkzujk2tadwvyrQHMT0rKHLxFJamTDtr+tczDBYtFYf939PqGW/aAPO/NNe3NTZL H1rSPYtt mwf9CkcD3CkCEbnt4CGPz7K+yV+06D8NO+AfMG4umlwVD+tbs1a0aoPC+MNPyPF2FlvTwFKmmQIbHoZ+bfpBptqLnDdHGLfRdJ4gUAZTUqloqS15Qw8Rq5PL7PItrAl9033+0mF3YudiE6W+J95aPNz8PGxlNRxwj2I4QhJgoTWFuX/YJhwgdtjLZcJfON+qCdSDy8AonxsGjjfNhCUEiL8aw7wLJ7JNFE1E3tc2e1GGENoQzHOvydQZsq108P4N41NE++56w9Yz+jbI0VRM8jqR6TuDuUAuwYDqFa9ABQKsutxDeVwUpom+cyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Doing DAMOS_LRU_[DE]PRIO with DAMOS_QUOTA_[IN]ACTIVE_MEM_BP based quota auto-tuning can be useful. For example, users can ask DAMON to "find hot/cold pages and activate/deactivate those aiming 50:50 active:inactive memory size." But DAMON_LRU_SORT has no interface to do that. Add a module parameter for setting the target ratio. Signed-off-by: SeongJae Park --- mm/damon/lru_sort.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c index 3ccde23a8566..99c5a22cf3f2 100644 --- a/mm/damon/lru_sort.c +++ b/mm/damon/lru_sort.c @@ -41,6 +41,20 @@ static bool enabled __read_mostly; static bool commit_inputs __read_mostly; module_param(commit_inputs, bool, 0600); +/* + * Desired active to [in]active memory ratio in bp (1/10,000). + * + * While keeping the caps that set by other quotas, DAMON_LRU_SORT + * automatically increases and decreases the effective level of the quota + * aiming the LRU [de]prioritizations of the hot and cold memory resulting in + * this active to [in]active memory ratio. Value zero means disabling this + * auto-tuning feature. + * + * Disabled by default. + */ +static unsigned long active_mem_bp __read_mostly; +module_param(active_mem_bp, ulong, 0600); + /* * Filter [none-]young pages accordingly for LRU [de]prioritizations. * @@ -201,6 +215,26 @@ static struct damos *damon_lru_sort_new_cold_scheme(unsigned int cold_thres) return damon_lru_sort_new_scheme(&pattern, DAMOS_LRU_DEPRIO); } +static int damon_lru_sort_add_quota_goals(struct damos *hot_scheme, + struct damos *cold_scheme) +{ + struct damos_quota_goal *goal; + + if (!active_mem_bp) + return 0; + goal = damos_new_quota_goal(DAMOS_QUOTA_ACTIVE_MEM_BP, active_mem_bp); + if (!goal) + return -ENOMEM; + damos_add_quota_goal(&hot_scheme->quota, goal); + /* aim 0.2 % goal conflict, to keep little ping pong */ + goal = damos_new_quota_goal(DAMOS_QUOTA_INACTIVE_MEM_BP, + 10000 - active_mem_bp + 2); + if (!goal) + return -ENOMEM; + damos_add_quota_goal(&hot_scheme->quota, goal); + return 0; +} + static int damon_lru_sort_add_filters(struct damos *hot_scheme, struct damos *cold_scheme) { @@ -256,6 +290,9 @@ static int damon_lru_sort_apply_parameters(void) damon_set_schemes(param_ctx, &hot_scheme, 1); damon_add_scheme(param_ctx, cold_scheme); + err = damon_lru_sort_add_quota_goals(hot_scheme, cold_scheme); + if (err) + goto out; err = damon_lru_sort_add_filters(hot_scheme, cold_scheme); if (err) goto out; -- 2.39.5