From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA3FC7EE39 for ; Sat, 28 Jun 2025 16:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B99E8D0006; Sat, 28 Jun 2025 12:52:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36BD78D0003; Sat, 28 Jun 2025 12:52:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E3CE8D0006; Sat, 28 Jun 2025 12:52:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 06F948D0003 for ; Sat, 28 Jun 2025 12:52:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C9B061A040D for ; Sat, 28 Jun 2025 16:52:00 +0000 (UTC) X-FDA: 83605401600.23.FAD9D92 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id 3CB7D10000B for ; Sat, 28 Jun 2025 16:51:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lgLtLZ6q; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751129519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7HwIHwtyEHwwzOWr/ChGEAcMFY1bx3m9nOzZDrrjinc=; b=CcI54Py7L21CJSWKymT31LPPMPCnGoRPQcDB/2TZ7QWBapPDCkGjXCFLnTJDSnb+96N+eP HwYak7Hp8tZvRNlj/d2aK4Tki2rF7FI13J344xZ/EehH1IwovfkbZujVbLa7c2St9LqpzM 5+k+tivNdGAkn1bbCPGmA+dgkpkf3I0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lgLtLZ6q; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751129519; a=rsa-sha256; cv=none; b=bNzN/WMqoiZQQNGZIO5Lxy8036+TvrKOK0V1dqQ6xH7wsM3+N0+U29siVt29tTw5AsNXDO 3G/TpwnMg7QV5WshuSjNwjEXHuOjzcgwP6Xo1oXMYFGnP9yO7z40tqE4wq0IBImR02a8UV pv83oAfu+OJz3RsYw6/suS1XJtKsIRQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B535FA52B16; Sat, 28 Jun 2025 16:51:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 405D1C4CEED; Sat, 28 Jun 2025 16:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751129518; bh=tlvqxxIUDAypcpXix4DDUce9Gvf8SrIMBmaTGFZI30U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lgLtLZ6q9JHyXcZE7E3djoYPOZN6LsoO2UhZ5uv5R40j+Kt/aTRhT71X+TgkdBMWc epy51+h6/a+DXlMCvZwjFGaoVr7BNrO9FmPkC95JSnXO5SxX1FE3V7vH7IwNHCUTvy CU1DpW+/553Is8RvXDBb82W4sPBn39AuMfLcZjVD/SQtayqs6319uJuCl+erCXEqpz 7l8usr6qm4bB3L0l2/V6L8WiP/t8ZiRRWuNwy8lKA2HB88I0Omf4IEEt06p7CD/tEj tflx4ALke51tN6w42QYzk5kVHblMRp8csfEYwWLcX/rQavPWGKArTWqJ9Q/4g15EDm X+5qNzFqaRMDQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 10/11] mm/damon/lru_sort: add monitoring intervals auto-tuning parameter Date: Sat, 28 Jun 2025 09:51:43 -0700 Message-Id: <20250628165144.55528-11-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250628165144.55528-1-sj@kernel.org> References: <20250628165144.55528-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3CB7D10000B X-Stat-Signature: sen1bi9awm94fupchikkj9g3tjxby9jz X-HE-Tag: 1751129519-6094 X-HE-Meta: U2FsdGVkX1+gdOQggN6qy/UFbDYFzw3TpgaEMb3JERXWo9/K0D3I5EHefFtaRzVOnc4HzviUNt39YZ52D3Hf0cBNFmJYBegGEDq3/rBY8zwhlT9IpGvdLoNFGjszNSpUkwveXGEEJKjenDAX3oAzE0DGUnC93m5ok26fMAs/jveHpdCxkFaLoDvN2mKkXjEaBFTc/k00bJfzRfeun4mTeg3gBY8zwvrwTnAZFw76VePm0Pc+XAAO39Z0ecqEp+/9P0hGlYEgJcFxeDfI/429/4HW9giyqElqX6mQpoxnEQP36ej150MgCpVBrwRC6ntt6kGziFYVtIZCgWDZcQvcIpCCeUejgPSO9UzTX4S6SXzh6DrUhnuVruy4YDW/6yzdRS/3iLBT4FwcLkWEAHxvTo0MzMMK29YjQyLNO3T2sg/lAIhNtyOpQHK8rDwkPWAPYMYfyLn9qwbLnW1jpSI2wTh6FKc1NgmZlyJTsad9TRR7p2haVvvIpVfJZRCw0OmHGgEf4kxQRpvJrQsjVDJUpiqJ61q1evq5i4krflVITpW3+EVCS1dfhxCetd1weSOBa0j+odU6jk9SZcveTR1dJEwLwaHtZNfWv0Ur4v1xfih2SkbjEDQf00h7xXG5Ab2lytAgUjR3kS82vDbmuE0vU9ScERp0yr2qpD6Z3KzfMRRyldhwgirX0kpXibkyN/2cWTe5l2K2dgk6ecw6b63rXNgCEdJB4l8iJ+FdvwX/fW2uNi8/QMPdxwDTV6L1zzYBfKG/UmvcPG8sv3oOqdpP8Ii+Fr8TbSs4kKq+LedDOgFhFx2qVjTsN6m8yJozQl9TDTKNCktRUgWeCPApqMCBpux8BFZnkWH9pt3nCk2Fb+UCFPBN6EldBpEPlXWSALbUj2zuPY+cC1f2atEbfCb8zaW6U4+iYKjMReVsgIx98uX/JE4EflSmkCHarie07X/xOo8IW9T81kRq6IKzVzn yPMOiXY5 DLF6MxPAlje8w+/0BmC7YrtzhT5bI8nzbataUNQG6T91yj6JPIt77XpuxdcssrzEW8+fBRTxr8jq1N4PlZ/LdigE2Kvuta4Tvi61i/dTlx0e1WU/hLhDw62w39e/8EZdag+QzLr7++KVCHrdxLiPwS9D2jnWv4cKD7A/HOkwGyiT+pt+By9MwCFW7I0U4UXXXVV+eetXxZp/udgs57SrjMnPETMYgInqWC5DJHXRSAldPins1rvh6ee7XeNSJQsZgjG14k0MSUnscKl0b7M+G2BHJbU3FLDxw/NEp5OJdPRRk++/gn9NccxxjjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON monitoring intervals tuning was crucial for every DAMON use case. Now there are a tuning guideline and an automated intervals tuning feature. DAMON_LRU_SORT is still using manual control of intervals. Add a module parameter for utilizing the auto-tuning feature with a suggested auto-tuning parameters. Signed-off-by: SeongJae Park --- mm/damon/lru_sort.c | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c index 99c5a22cf3f2..1e9e19f15b33 100644 --- a/mm/damon/lru_sort.c +++ b/mm/damon/lru_sort.c @@ -55,6 +55,20 @@ module_param(commit_inputs, bool, 0600); static unsigned long active_mem_bp __read_mostly; module_param(active_mem_bp, ulong, 0600); +/* + * Auto-tune monitoring intervals. + * + * If this parameter is set as ``Y``, DAMON_LRU_SORT automatically tune + * DAMON's sampling and aggregation intervals. The auto-tuning aims to capture + * meaningful amount of access events in each DAMON-snapshot, while keeping the + * sampling interval 5 milliseconds in minimu, and 10 seconds in maximum. + * Setting this as ``Y`` disables the auto-tuning. + * + * Disabled by default. + */ +static bool autotune_monitoring_intervals __read_mostly; +module_param(autotune_monitoring_intervals, bool, 0600); + /* * Filter [none-]young pages accordingly for LRU [de]prioritizations. * @@ -261,6 +275,7 @@ static int damon_lru_sort_apply_parameters(void) { struct damon_ctx *param_ctx; struct damon_target *param_target; + struct damon_attrs attrs; struct damos *hot_scheme, *cold_scheme; unsigned int hot_thres, cold_thres; int err; @@ -269,18 +284,27 @@ static int damon_lru_sort_apply_parameters(void) if (err) return err; - err = damon_set_attrs(ctx, &damon_lru_sort_mon_attrs); + attrs = damon_lru_sort_mon_attrs; + if (autotune_monitoring_intervals) { + attrs.sample_interval = 5000; + attrs.aggr_interval = 100000; + attrs.intervals_goal.access_bp = 40; + attrs.intervals_goal.aggrs = 3; + attrs.intervals_goal.min_sample_us = 5000; + attrs.intervals_goal.max_sample_us = 10 * 1000 * 1000; + } + err = damon_set_attrs(ctx, &attrs); if (err) goto out; err = -ENOMEM; - hot_thres = damon_max_nr_accesses(&damon_lru_sort_mon_attrs) * + hot_thres = damon_max_nr_accesses(&attrs) * hot_thres_access_freq / 1000; hot_scheme = damon_lru_sort_new_hot_scheme(hot_thres); if (!hot_scheme) goto out; - cold_thres = cold_min_age / damon_lru_sort_mon_attrs.aggr_interval; + cold_thres = cold_min_age / attrs.aggr_interval; cold_scheme = damon_lru_sort_new_cold_scheme(cold_thres); if (!cold_scheme) { damon_destroy_scheme(hot_scheme); -- 2.39.5