From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8532C77B7F for ; Fri, 27 Jun 2025 20:11:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DAF36B0095; Fri, 27 Jun 2025 16:11:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B27C6B00AD; Fri, 27 Jun 2025 16:11:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EF2F6B00AE; Fri, 27 Jun 2025 16:11:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2BDD46B00AD for ; Fri, 27 Jun 2025 16:11:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DEE1C121E2D for ; Fri, 27 Jun 2025 20:11:27 +0000 (UTC) X-FDA: 83602275414.14.A25AEB7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id 377D41C000B for ; Fri, 27 Jun 2025 20:11:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JQJGuOL9; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751055086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h5v980ExUkELN3QHV3qFZv54rIYSzjPkkbLm8pL8NdY=; b=Mmgdm7KiH2m1Jhm43lJ5XrL0Ca6odAvz9zTHAY+0a5KmPo/ooLyBPriMZktGZ+515pNLC0 WPX0byPBwHUoG3gXO77MOCvvt4M3S+Rz756W8LxludSECJxwjW5gpCGw9Hx06WczziLV6M cHbvqIuwLYWMFJdJvak+5AvjKipvZMA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JQJGuOL9; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751055086; a=rsa-sha256; cv=none; b=BOl9nuz1E/Lzd5cdwWPf3tl034lZ3Olm9v1RvTiCJJThTBhMAbV8gEUCJP6T+tqqvQt1mM WFqfVixQWgy2aCCQCj0EaU1mD4eR+HLRoG9GyUuuSA3NH4Crdvzk8GjJoLU6Pp3dUWMlZU WOoi7aXYxJKaVMXR7vnFk2Xgvecex6M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4392EA53086; Fri, 27 Jun 2025 20:11:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEE37C4CEE3; Fri, 27 Jun 2025 20:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751055084; bh=TxKmAuf22xBHiZt2TNjQfrHx/IQeMmYLYqVEZtL05DI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JQJGuOL9iGOyvbfaVKhUiUdNH9xGOlEonsBstFc67sh7NrAt61+Uc028plbB6N1a6 Vv5lkedY8Nrw4jNkYGAlcZJMr/QrcgZNWQvPaSeYwrKMu/+OUbg1842i3F9QS3Z2yz gW8OHiqprSYWRZWr4inQ8hlRh0wFDZ2ZKuP5QWVhNiT0k/xjouPksVRqgKTadVPKxp fe1inYULNnNGycMYN65/kUDNK7itJ/mSpq4KtFYnDXoxA9nYe5BDamTJNnHIFWMz5h 3vvN2826ADAmSOHr8OQX+E7uRiDzajBvz4jKu+wOXxD9tTPRgz92bUHmOqP9AQZG8k /qbCPLevRS8gQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 5320/5590] mm/damon/sysfs-schemes.c:1622:32: sparse: sparse: symbol 'damos_sysfs_action_names' was not declared. Should it be static? Date: Fri, 27 Jun 2025 13:11:22 -0700 Message-Id: <20250627201122.53436-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250627125731.19f70c310cb4f315177e41e6@linux-foundation.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 377D41C000B X-Stat-Signature: wcbd1d5wbmmzr3i77746gh8fmrfzz9mw X-HE-Tag: 1751055086-786869 X-HE-Meta: U2FsdGVkX191D5avVJ89Dw7hTG4cGM+PV7EjP/7A/jqMbEF1dZiUvz282jqfOMLNRbS406Voi6ZRI80fYLM0g3knX4OwYBx+OC1fMhTum+wNBMv6Ub9G9a4SOE/+pbnO+SKxhUMxaC6iwMH5KlNEInD8+mCSno84DbI0pNMc0wfRMp5Mki3/qiTvl/0Qw58D11FbdK9wra9ZSZiZ8P2lzUjwyoDm/t/5GT3Dbjua9sDKPJ4S6JQc7hOOejY9AO5abLzTczcKeHZ0uHj89oMkSefXZ2ucNEVFoCRDfi5CojhWpP3NQ8ZJ1miDfzGxHbDKUH8WKCEKW3LysIWuAETqMAIyJ77eqQ1Kmnk4q0ucMMHz4wpubQyzPpDX5+rXGDxPrA73sw2yewuBhrC9Zsb1/w/8mf+4tUXrWJfLfVYjmwcx/lPm6TXDOTYKj895dbuAo8NjYFo4W/blk0+gQB/5MOR1Kyy4qntw5+2c42k/8zd1Bua6bOTu1fyLN3aA6rLnyKfPcGb0zHh5esjJicSxFEtPNlsn2+xlT2r5iySGbLDMgf7U6Yh2CEskMnbhlw54AkUvphzzMXfIcAi1sxyCNGBmjC/+u7aumEoiLUzuIC7R7SCqCY6OV+pcHunq6AaWV+vGh5A5FZKdcd2F08OryPh1sxh6ezAkL6EWMFNTouX9m59G0ScKzXd/v9Vqu/VfsexcO0Awoy7muyfEnjOIqg4lcbgTtqYenjNjLx3wYov9g5WgNqivRYlnoe4PBV7A8ePQgqD+KXdZ48271j07H01T63XemjXDNuACg0Jtbjyoy8Mj44QU89HSWyvrFX3lln88J+vPIY/N5uAMwhLWhdXGTtQE0566U+3Vf46NZJ5ZdudUnVIItA6cCcMfgoO4xlHJwRb4y7xCrf9NbkXcSQT0IUzrufg3Fmlfsf0dnWsUpQDisDi/h8cecJAhoOjbjsrEo1n3GzDANNY/aUL h/1EVf2f wJhxznE/i3PC2uoEyT8WMZkkUNAQebWQ9TaABhSe4BtbI5NTcsZ6KHI6TAhTeQx8mTA+lsM2Z2rG919fqMlHdE7vPnCqDYTpZroeUz4Hlk7EZyxgS3FdXmQ8IDhVNESbcjFkMjUPEtvhv6JsI5jpS86xpisKSsalPNPSgGsbDVjwOTQjL3rLNG8swPz9lnrZr0iQpnvXkHQktL7vrt3T6uzJpcThbqdknubm+lUv9lsu5nypfsgF5huVwhDqvZl1HRwkHPf86VpwMHXO50QwErmZFvSVb4NolgIz0IMfVVGUlk8aj8bz9fwWK/DMw2OlFSjtedmpfsnvcntCpebPbtTSC1E4V858eIywYO3s1hVe6dwdhT8ATAeESlbw+c90cUzzKCN4e6BlpjFZ+yKXVjgduLp9vEN+7en+2TWFydMeedOKLmZMtqpS28w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 27 Jun 2025 12:57:31 -0700 Andrew Morton wrote: > On Fri, 27 Jun 2025 16:41:02 +0800 kernel test robot wrote: [...] > > sparse warnings: (new ones prefixed by >>) > > >> mm/damon/sysfs-schemes.c:1622:32: sparse: sparse: symbol 'damos_sysfs_action_names' was not declared. Should it be static? > > Thanks. > > --- a/mm/damon/sysfs-schemes.c~mm-damon-sysfs-schemes-decouple-from-damos_action-fix > +++ a/mm/damon/sysfs-schemes.c > @@ -1619,7 +1619,7 @@ struct damos_sysfs_action_name { > char *name; > }; > > -struct damos_sysfs_action_name damos_sysfs_action_names[] = { > +static struct damos_sysfs_action_name damos_sysfs_action_names[] = { > { > .action = DAMOS_WILLNEED, > .name = "willneed", > _ Thank you Andrew. I posted a same fix[1] but forgot noting that here. Since it is same to yours and yours is already added to mm tree, let's keep using yours unless you mind. FWIW, Reviewed-by: SeongJae Park [1] https://lore.kernel.org/20250627162806.50589-1-sj@kernel.org Thanks, SJ