From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD25DC77B7F for ; Fri, 27 Jun 2025 16:07:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38B956B00C1; Fri, 27 Jun 2025 12:07:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33B446B00C4; Fri, 27 Jun 2025 12:07:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2035B6B00C5; Fri, 27 Jun 2025 12:07:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 091066B00C1 for ; Fri, 27 Jun 2025 12:07:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9CEB856385 for ; Fri, 27 Jun 2025 16:07:47 +0000 (UTC) X-FDA: 83601661374.04.4EBE613 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 68BC6A0007 for ; Fri, 27 Jun 2025 16:07:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TkpjIBTb; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751040465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=7Q+PeekvDh59KWGPbCvR5ACQ5LCiB4fdpxjRPrkbiCQ=; b=gWNQlMB/GiDbYOCr0qegX/sfnJX3vyYwJ2x/nGGFO3wPylsRHlYhTZBAd1OLlJUuHQTCKR pMRp34xH2n2kDXP4iapxJjvX5huKmDEtaIqU5FbWco5A+2V3qHDakIKrScVonlmSEc3VIF jpKBRN2BBen1AH3r3Ae+8JtVmdtdwmI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TkpjIBTb; spf=pass (imf15.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751040465; a=rsa-sha256; cv=none; b=EqVpUZ5AR1MkMi8jepLQcqDP19WB60n6NsIF129CPyE7ElwYdcpFQOHvT8UtR8DC32x+29 46+7vMACOO1FKKbTWRJAtIFYEYgkk1rkgSOA+wxw3kkc9gqoqAK65zMhHniVA1ZwKar+Fx LmGM5i9xIbb7SQd5dObMpAdQFn+FtoA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751040464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7Q+PeekvDh59KWGPbCvR5ACQ5LCiB4fdpxjRPrkbiCQ=; b=TkpjIBTbm6baJz3dfPtXGr/JNfzZShfDP6gc7oATv9XGu9mR7/lGEac/ygPGh5mCWVcz6/ 2Kuwi9bpH1PACgH1rl0tYnLTQvs5ooJaHiOsePLl6bgz16oKNsnATGEhWKMOGRk/CJuwyy VZwywBft3a9/6ytVpXq0lNt2EIHzbXg= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-cIUNHY2YNgm4AGp1ND99IQ-1; Fri, 27 Jun 2025 12:07:43 -0400 X-MC-Unique: cIUNHY2YNgm4AGp1ND99IQ-1 X-Mimecast-MFC-AGG-ID: cIUNHY2YNgm4AGp1ND99IQ_1751040463 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6faf265c3c5so35863066d6.2 for ; Fri, 27 Jun 2025 09:07:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751040463; x=1751645263; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7Q+PeekvDh59KWGPbCvR5ACQ5LCiB4fdpxjRPrkbiCQ=; b=WMw1392negjc/BrmduDdxyHGRwFNKFX2IAz0/I/CU97jYtPZJf7qBjQ5WM9fx2la2k ERTDmf3+ak4pl1H+j4vwos6LHUUXy05PWtVv8r+sC80QMfswCEE86zL1ZC2X72gghUp3 p40cIoW7RyFC6wzi/glaMWptX3pKHsLQik+Xf2PZ/DcueyqxoO5QkIlS7nuMKo8QrnCW fbxCTI+ciZHbGGvNTfha1JzWYhY6hhOxKeZur3BoA6/JCmkVWyXRQrXvJMqsPiKZmU9Y x0DD52qAnQjgEa5mDTDX7ViMsj2JJp/5DA5/DtNNrkNU7Wc5vxRe1lVqrhrLaqR5UHVK jPUg== X-Forwarded-Encrypted: i=1; AJvYcCXjIsgmWfxrbifDixI8Kmomphh0csc/7YxmYs0tOgsaYjInDAHJDI50BVA/xFiu8gb1ddbFpdmS1Q==@kvack.org X-Gm-Message-State: AOJu0YxQtkjWmMn8sD8oZ3gSGHbqZJaxbT+K8GtSUNME6M/lzcYTKYmq eUsmrw655A/93eGc1jMakzErrlwuADfJUMI0rI2mdyZ8eOiuQ+uSwU9UJAcU9mH4kAnLTLrhH2v yCfEcvIq3cKaBR8SLVanEs//rXAODR+S3wbXoQS9vTCTiLBR62s5kjpFqLefb X-Gm-Gg: ASbGncuGL4M8h59kjEFJt4I1+r4dAbBrelOqpeyAhMQZ1+9j2H3Su+adI0aVczLHQW7 ATesu6gnQ02kdhHLJinFEmU7RG7IFH93iIlFEBWy1Hb1lWjdCnYci/wyDozZ11ozKI61k73/UrP KXz/6JTdmD+H8c0cKvU3wHLKkPBNu0xh9j0E+pejm+cItQaNHlMyaIiVTDi6dQOO8cVvVZlZJui 9aQrluaPbzcKUMeji1SSwW48DE/f63dFSUH1c/mgqmAuTjgfi4TklqUJ4KHAoG5XFow2hlZAu4S RXwhA3iRwiY= X-Received: by 2002:a05:6214:4283:b0:6fa:c99a:cdba with SMTP id 6a1803df08f44-7000165810bmr69878726d6.14.1751040462775; Fri, 27 Jun 2025 09:07:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGR2WENa4pYauFQQfbF5bBH3hvcc36vwCQwdDDeTnXz1xb/qyr6ptUTGRahCVjdqIEJh3+U1Q== X-Received: by 2002:a05:6214:4283:b0:6fa:c99a:cdba with SMTP id 6a1803df08f44-7000165810bmr69878186d6.14.1751040462239; Fri, 27 Jun 2025 09:07:42 -0700 (PDT) Received: from x1.com ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd7734122bsm22551026d6.57.2025.06.27.09.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 09:07:41 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: peterx@redhat.com, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Jason Gunthorpe , Oscar Salvador , Zi Yan , David Hildenbrand Subject: [PATCH] mm: Deduplicate mm_get_unmapped_area() Date: Fri, 27 Jun 2025 12:07:39 -0400 Message-ID: <20250627160739.2124768-1-peterx@redhat.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eN3CWc2t2jsp_d9PJOqcm6jveE_eqkwYNKNXxCuzECc_1751040463 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Queue-Id: 68BC6A0007 X-Stat-Signature: 6w194iyb674frchz7ubdudajs54d1btp X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1751040465-181075 X-HE-Meta: U2FsdGVkX1/Mbnfpim+aZJIqyJ9wWms3qCQOmG0a4gdEjVCZVnuqKlAtOnwc60WVGsZeJhwlIh8SanpnMyMh3Y+XYNSAyhmtyLOwQRVlFNT+GfNl4mX2AKD5Ba9AYtVOItaaREtOhUKp3oMngogbDEBqE5UXQKmr3UnRZ+i/nSVyfx49ZlKnERXmRnqyxf/VjcK+jQQ2vX7II3qoZ/LUW360dv2oIAeT4kZ1PhnK+rh84pbqaArbdmygF4A4TKJUFcjIn2412RkxdcpWAhChYKz921oDQLYkLlbsP4QZ6363VkEV776hDtbM98gHQy5AbOh4wjs34YoxSYY3tOdYIxWojppvjWuqSzE+xNLY6NVVVHZsONBHTnOYwLYCKKhl11kU32MzYaSpRRx5Ob67f0/6Zg/9/CLXrmNWbqGnGmlvk7RVDHpQTgJXr0Mn2bNMpSM+x8XRg8nK3yhAIHoOx3tcWUE6Qqh1Q1vI06nP5aw14hpyULs3wYhiSJf+6exZCo3DR1AyfQglD+FqeVnCNG9EMWlMM6Lv3n+jpd5H8Jpl7bYkMMempsTuICeZIfgon05oz1FxIj31O4QP4b+WLnnarn4Fts8kz8zjr+Ky4ep1fKBKjcpsTrDRFKZ6iiwioK8f/oO83ju/7gjOG8A1l2JYrzXGecxnJ0SKGy865gw5xoUiwcbYTnXqHhTL1jldXqEkA5YUtnM/xMmLVKVgknVeSsgjiwobw4uGRwSxOqLdCbgc3uH5JIJUuO4XKffMVEoODu8Z+QGBzUWroKHfPQP2ddTgxnDGGrqMIDNpfWD8TO5nAoL8CyIXeZLyyIk8Jq+SoYHq0+PH9IvDYa1+SZ8IRZ8u9NTLCxbiRWhYNJ8/KZXz5mloOiYS5yJZwsnUhlCfTACTHjtJDRA/nJXtf43GyIRdHB85Ovtwx3nqjkjIMTPbN1j5ZALp+19JRYnMkQxzHn+V5XTxgrzh7s1 H4yifhhu TOPXBKDyU+O2veCiR+RVlOpLflKFJr1MQ154KVpJkJP3gLFGrcM2asom69abu+XUOxRuRLG1tMHMYQnBDSvazO01GQxSGscObDXmVC7XjNFxTyM8Ql76KOC/DFCgUE6lfjHwX5caIQjVr4IDxGYaFrtgkhJDOP+pm7L8AwiYxnqwi1zkADU94jRk+dznYahBDvKDbmivgxVhemHuXVOmyoPfyrzfySAliFpd+77TBr4bCXVV6htS3QSUT77hbJfCasZnCGcF2lATjxK9a8/ZH3pa11Rlh/ZoxI5sN1PyEE2LI6rAol7maQTPMv8bQ/Q+x+F32bb26r9NsqpS2Siko8zjuOe80nMuXEJYnymIdQTyt/xME14VC7jJ8JKRacnf8yjM7gQbXSplhARL9vsu5GmCEiz75MVhWmw6gBZnSxLskkT/XB0AXjXDGUqEo78YJYKpDaHZmVtOBBcsknQa4HHtFnvSIRA28H+LNhq7mildK7LS/JAMqPpHGjiUSxsR+BaVSI//DjkOZaTM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use the helper instead to dedup the lines. Cc: "Liam R. Howlett" Cc: Lorenzo Stoakes Cc: Vlastimil Babka Cc: Jann Horn Cc: Pedro Falcato Reviewed-by: Jason Gunthorpe Reviewed-by: Oscar Salvador Reviewed-by: Zi Yan Reviewed-by: Lorenzo Stoakes Reviewed-by: Pedro Falcato Acked-by: David Hildenbrand Signed-off-by: Peter Xu --- mm/mmap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 8f92cf10b656..74072369e8fd 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -871,9 +871,8 @@ mm_get_unmapped_area(struct mm_struct *mm, struct file *file, unsigned long addr, unsigned long len, unsigned long pgoff, unsigned long flags) { - if (test_bit(MMF_TOPDOWN, &mm->flags)) - return arch_get_unmapped_area_topdown(file, addr, len, pgoff, flags, 0); - return arch_get_unmapped_area(file, addr, len, pgoff, flags, 0); + return mm_get_unmapped_area_vmflags(mm, file, addr, len, + pgoff, flags, 0); } EXPORT_SYMBOL(mm_get_unmapped_area); -- 2.49.0