From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC99C77B7F for ; Fri, 27 Jun 2025 22:00:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B37E6B009E; Fri, 27 Jun 2025 18:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8638D6B00A8; Fri, 27 Jun 2025 18:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77A1C6B00A9; Fri, 27 Jun 2025 18:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5F8006B009E for ; Fri, 27 Jun 2025 18:00:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 690DB1A0209 for ; Fri, 27 Jun 2025 22:00:10 +0000 (UTC) X-FDA: 83602549380.16.77A6EDB Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf28.hostedemail.com (Postfix) with ESMTP id C7C49C0018 for ; Fri, 27 Jun 2025 22:00:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=em8a9Wo2; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751061608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9EP0i4rfDHIgTZ2wSvYlRcR6xetjwfAGKadn2cZhTDw=; b=TUTYyRwxdAJIn9xKhKbru6IqHtBbLt5ktmLq2q23WZp/XYf4wrh1n6QP9hh1/gX/lR7M5Q aEoPcUU5PDpocoKwv99cf3p7RBPLtF+chDG3GfPZvCHRF3TvgPbkcR046vXVClYnlIIqrl EEiIwcLuexNcKE2CX/0zXReUcDBLvMM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=em8a9Wo2; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751061608; a=rsa-sha256; cv=none; b=ukoLoaWj8JwiYfLu7Mfdu3KUiuC1nLHDgOEh85gBywQ0ftIC3sj6Gw6uATLzKBGqAKo99H tzEQGYO7C9cOsc8FUezVDrN1YEdu/n5uASW4tcyWMD3RH1d5kaqOBDV6Vq3yoikWqeovpQ su+VnAy9TM833WJ0bd4QE6tGLvkSxqg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id F291561435; Fri, 27 Jun 2025 22:00:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 719B7C4CEE3; Fri, 27 Jun 2025 22:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1751061607; bh=zteqesbvyMgkkrIURTBfkpVdiIm+XES/1rzbYhou610=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=em8a9Wo2cFhPJZh1R1mkJ4Hm7JEaALBjEXvmX4EV583/ZKvKkCbjWBpgOlXB5BuxF V9iWGNNUsmTzCpOukpJW3NM7Roh4unxkMmdoXxwYiPwGHjlJx8VU7oer6UVWUhK+/2 BVl7+yD/uTy/SVVzHMf8ugN/FdOONlHL6adTzSDg= Date: Fri, 27 Jun 2025 15:00:07 -0700 From: Andrew Morton To: Jinjiang Tu Cc: , , , , , Subject: Re: [PATCH v2 1/2] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list Message-Id: <20250627150007.35d934da6a7a9e3e66488bdd@linux-foundation.org> In-Reply-To: <20250627125747.3094074-2-tujinjiang@huawei.com> References: <20250627125747.3094074-1-tujinjiang@huawei.com> <20250627125747.3094074-2-tujinjiang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C7C49C0018 X-Stat-Signature: jchqdqyfhjia981bihkyibqeki9r41sy X-HE-Tag: 1751061608-197371 X-HE-Meta: U2FsdGVkX19XlUJAQsskuPB5ewhQC1t0tMYYG11qLrA8fYrBi0OBctAxzP3C2vTe1h3MNJxDSQ+o8PRUnvXQAuHnPo4WrZ6/sudg2PNF/gVk0647YApjS/9UNu1mKfK7MnCg30tp2j5UlnDTlsjTAka0gHkrg32Rg/+nBKeQEqQ1bGtw6wUO4bedoDJ8D9IdTXjTabGJMH89xguMr9zKRdeBfA4bvBFzGoyjEyYnx93JtKJDn55OjWCTGaD9us4hJr4claHMIq1KHnqf+GtMX8eAtpTh+Iy1yS3Ye6JEecXeo0NKpk60JlZo0I+cmYGpDabsGFpe1Z1hTt6JySvcUdNZKtLBWJo9ACNDwMU+DlDs1/D6zDp3Jgn6wWRzTGsf0dpJu2vXtjXPrexq8uKfjfonBNgo/JrnuGuF/Coz2rQQYQYHDqsQxFhkuXclUOfurQk1TMo+iZ4613HVeHHC4Hpk6eP56sQ1dSHcCBrdCemm2CHiII+h63x71LN7apavPHCMxhftoCkcPPlzHiRyLeJ9wf0kXFBZuOIgV4tokiKLUmnJUcHkpAB0c+eVm43tfJahn8MGLfvStfjTjAmRMIaKmojNl5dhxmcoqCOt/ZLxxc2aDOhlTndn96I1755sGc22m9cnbouer2+MXHaGBspH5z9MKuqoDJcyIxRqbv+A2i3bY5jNZGABL6OcPgX+o23yYHz+E8CzDPsbXT5O3Rwa1x35PAVblieNfTL37FQfvYd9+BYAkkrut5mDwNuKYubjDzzDm0LOcx29pv37/xiz723UdizR7cGOPoAp1W4yiY+EKGYx1MM/7blfxN1NSOnPu6N9ACkuTbfHEoZOIlW389yNOh10xHrn7olg1gkDGnrYaZ3r9QFmdBaAYzRpPz93B6DOzGSeBA2UztMKn1x7ikdI2djBoMYM3aQcVAkTFXp9sQYIOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 27 Jun 2025 20:57:46 +0800 Jinjiang Tu wrote: > In shrink_folio_list(), the hwpoisoned folio may be large folio, which > can't be handled by unmap_poisoned_folio(). > > Since UCE is rare in real world, and race with reclaimation is more rare, > just skipping the hwpoisoned large folio is enough. memory_failure() will > handle it if the UCE is triggered again. > > Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") Thanks. Can you please fully describe the userspace-visible effects of this bug? Depending on that information, do you recommend that this fix be backported into -stable kernels?