linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: <zhongjinji@honor.com>
Cc: <linux-mm@kvack.org>, <yuzhao@google.com>,
	<linux-kernel@vger.kernel.org>, <yipengxiang@honor.com>,
	<liulu.liu@honor.com>, <feng.han@honor.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Yuanchu Xie <yuanchu@google.com>,
	Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH] mm: vmscan: Page scanning depends on swappiness and refault
Date: Fri, 27 Jun 2025 14:09:32 -0700	[thread overview]
Message-ID: <20250627140932.1278169c50ba873937444599@linux-foundation.org> (raw)
In-Reply-To: <20250627162606.30609-1-zhongjinji@honor.com>

On Sat, 28 Jun 2025 00:26:06 +0800 <zhongjinji@honor.com> wrote:

> From: z00025326 <z00025326@hihonor.com>
> 
> The current MGLRU aging strategy isn’t flexible enough. For example,
> when the system load and pressure are low, reclaiming more anonymous
> pages might be better. But when the system is under heavy pressure,
> enough file pages are needed for quick reclaim. Right now, when MGLRU
> is on, changing the swappiness value doesn’t really let you prioritize
> reclaiming certain types of pages in different situations.
> 
> This patch changes the aging strategy to adjust the reclaim ratio based
> on swappiness and refault values, allowing anonymous and file pages to
> age separately. and it can prioritize reclaiming certain types of pages
> and doesn’t have to wait until all the oldest pages are reclaimed before
> moving on to the next aging generation.
> 
> ...
>
>  include/linux/mm_inline.h |  19 +-
>  include/linux/mmzone.h    |  13 +-
>  include/linux/swap.h      |   1 +
>  mm/vmscan.c               | 797 ++++++++++++++++++++++----------------
>  mm/workingset.c           |  10 +-
>  5 files changed, 494 insertions(+), 346 deletions(-)
> 

(replying to https://lkml.kernel.org/r/20250627162606.30609-1-zhongjinji@honor.com)

That is one big patch!  I'll avoid it at this time, see what the
reviewers say.

Have you reviewed Documentation/admin-guide/mm/multigen_lru.rst to see
if any updates are appropriate?

I expect people are going to want to see a lot of detail about the
runtime effects of this change.  What sort of workloads are being
targeted, what were the effects on testing results.  What sort of
workloads might be harmed by the change and what were the effects on
testing results for those, etcetera.



  reply	other threads:[~2025-06-27 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 16:26 zhongjinji
2025-06-27 21:09 ` Andrew Morton [this message]
2025-06-28  7:32 ` kernel test robot
2025-06-28  7:52 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2025-06-27 15:55 zhongjinji
2025-06-28  7:08 ` Sabyrzhan Tasbolatov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250627140932.1278169c50ba873937444599@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=feng.han@honor.com \
    --cc=gthelen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liulu.liu@honor.com \
    --cc=yipengxiang@honor.com \
    --cc=yuanchu@google.com \
    --cc=yuzhao@google.com \
    --cc=zhongjinji@honor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox