From: "陈涛涛 Taotao Chen" <chentaotao@didiglobal.com>
To: "tytso@mit.edu" <tytso@mit.edu>,
"hch@infradead.org" <hch@infradead.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"willy@infradead.org" <willy@infradead.org>,
"brauner@kernel.org" <brauner@kernel.org>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com>,
"tursulin@ursulin.net" <tursulin@ursulin.net>,
"airlied@gmail.com" <airlied@gmail.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chentao325@qq.com" <chentao325@qq.com>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"陈涛涛 Taotao Chen" <chentaotao@didiglobal.com>
Subject: [PATCH v3 1/4] drm/i915: Use kernel_write() in shmem object create
Date: Fri, 27 Jun 2025 11:03:04 +0000 [thread overview]
Message-ID: <20250627110257.1870826-2-chentaotao@didiglobal.com> (raw)
In-Reply-To: <20250627110257.1870826-1-chentaotao@didiglobal.com>
From: Taotao Chen <chentaotao@didiglobal.com>
Replace the write_begin/write_end loop in
i915_gem_object_create_shmem_from_data() with call to kernel_write().
This function initializes shmem-backed GEM objects. kernel_write()
simplifies the code by removing manual folio handling.
Part of a series refactoring address_space_operations write_begin and
write_end callbacks to use struct kiocb for passing write context and
flags.
Signed-off-by: Taotao Chen <chentaotao@didiglobal.com>
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 33 +++++++----------------
1 file changed, 9 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 19a3eb82dc6a..1e8f66ac48ca 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -637,9 +637,8 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *i915,
{
struct drm_i915_gem_object *obj;
struct file *file;
- const struct address_space_operations *aops;
- loff_t pos;
- int err;
+ loff_t pos = 0;
+ ssize_t err;
GEM_WARN_ON(IS_DGFX(i915));
obj = i915_gem_object_create_shmem(i915, round_up(size, PAGE_SIZE));
@@ -649,29 +648,15 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *i915,
GEM_BUG_ON(obj->write_domain != I915_GEM_DOMAIN_CPU);
file = obj->base.filp;
- aops = file->f_mapping->a_ops;
- pos = 0;
- do {
- unsigned int len = min_t(typeof(size), size, PAGE_SIZE);
- struct folio *folio;
- void *fsdata;
-
- err = aops->write_begin(file, file->f_mapping, pos, len,
- &folio, &fsdata);
- if (err < 0)
- goto fail;
+ err = kernel_write(file, data, size, &pos);
- memcpy_to_folio(folio, offset_in_folio(folio, pos), data, len);
+ if (err < 0)
+ goto fail;
- err = aops->write_end(file, file->f_mapping, pos, len, len,
- folio, fsdata);
- if (err < 0)
- goto fail;
-
- size -= len;
- data += len;
- pos += len;
- } while (size);
+ if (err != size) {
+ err = -EIO;
+ goto fail;
+ }
return obj;
--
2.34.1
next prev parent reply other threads:[~2025-06-27 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 11:02 [PATCH v3 0/4] fs: refactor write_begin/write_end and add ext4 IOCB_DONTCACHE support 陈涛涛 Taotao Chen
2025-06-27 11:03 ` 陈涛涛 Taotao Chen [this message]
2025-06-27 11:03 ` [PATCH v3 2/4] drm/i915: Refactor shmem_pwrite() to use kiocb and write_iter 陈涛涛 Taotao Chen
2025-06-27 11:03 ` [PATCH v3 3/4] fs: change write_begin/write_end interface to take struct kiocb * 陈涛涛 Taotao Chen
2025-06-27 15:45 ` Matthew Wilcox
2025-07-02 14:12 ` Taotao Chen
2025-06-27 15:52 ` Matthew Wilcox
2025-07-02 14:51 ` Taotao Chen
2025-06-27 11:03 ` [PATCH v3 4/4] ext4: support uncached buffered I/O 陈涛涛 Taotao Chen
2025-06-27 17:03 ` Matthew Wilcox
2025-06-30 6:41 ` hch
2025-07-03 11:45 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250627110257.1870826-2-chentaotao@didiglobal.com \
--to=chentaotao@didiglobal.com \
--cc=adilger.kernel@dilger.ca \
--cc=airlied@gmail.com \
--cc=brauner@kernel.org \
--cc=chentao325@qq.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.li@vivo.com \
--cc=hch@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox