From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F55C7EE31 for ; Fri, 27 Jun 2025 07:39:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FCC56B00B1; Fri, 27 Jun 2025 03:39:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AD286B00B5; Fri, 27 Jun 2025 03:39:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39B9E6B00B6; Fri, 27 Jun 2025 03:39:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2474A6B00B1 for ; Fri, 27 Jun 2025 03:39:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9E665104C86 for ; Fri, 27 Jun 2025 07:39:12 +0000 (UTC) X-FDA: 83600379744.16.0205E03 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf25.hostedemail.com (Postfix) with ESMTP id 37181A0002 for ; Fri, 27 Jun 2025 07:39:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; spf=pass (imf25.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751009951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4TDjYpeP5N53AR20ws0IJq7Jc31/qzPDfmbr3FcsGJo=; b=CNvtGfurkg/DvHaaXnj3m2VkxDbm3I60iFiUxtHl0u3lfi0fZ58xjzzp1YwxzjkQ95Xw5Y gklnnOzQYOVnlK9Oe3BaJ0jcI5Nsrnvp1fph3b8UihwVAYTozoQxZZO53TwQ/lvrAKscl5 NFPP5dupF5nvxjY+ylkqbnCC8q16sn4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751009951; a=rsa-sha256; cv=none; b=psCfgNsmdEEYDG8ixdHhbIrFL1SMsn5vmycJ/nR2dLJ+f85W2BAKA95mcx0OZcyh0jqV/F o3yc5qire3eSU3qgqSwj7hZy8IXRRSneWgs0uzg+gXP0lIIgWV0lWqLntXrbcIpJTEP/du 1Ko43K2la/vHm6sQ0Q7ovdnyUrAJz10= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none X-AuditID: a67dfc5b-681ff7000002311f-fd-685e4a9b53bd From: Rakie Kim To: Joshua Hahn Cc: Andrew Morton , Alistair Popple , Byungchul Park , David Hildenbrand , Matthew Brost , Rakie Kim , Ying Huang , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, Gregory Price , kernel_team@skhynix.com Subject: Re: [PATCH 1/2] mm/mempolicy: Simplify weighted interleave bulk alloc calculations Date: Fri, 27 Jun 2025 16:38:45 +0900 Message-ID: <20250627073902.1963-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250626200936.3974420-2-joshua.hahnjy@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsXC9ZZnke5sr7gMg8XH5C3mrF/DZrHrRojF 1/W/mC1+3j3ObnF86zx2i30XgeKXd81hs7i35j+rxbc+aYvVazIsZh+9x+7A7bFz1l12j+62 y+wei/e8ZPLY9GkSu8eJGb9ZPHY+tPQ4d7HCo7f5HZvH+31X2Tw+b5IL4IrisklJzcksSy3S t0vgyngzpZOpYB9vxbpVJxgbGDdzdTFycEgImEj0b+WHMac9dgIx2QSUJI7tjeli5OQQEdCU ONE6ibmLkYuDWeAws8SL+Z/YQBLCAtES+47OYgaxWQRUJTbt6wGL8wKNmf+/lRHElgBqbrh0 jwnE5hSwlzh8YgMLiC0kwCPxasN+Roh6QYmTM5+AxZkF5CWat84GWyYh8JpNomvVfXaIQZIS B1fcYJnAyD8LSc8sJD0LGJlWMQpl5pXlJmbmmOhlVOZlVugl5+duYgSG/rLaP9E7GD9dCD7E KMDBqMTDa6EfmyHEmlhWXJl7iFGCg1lJhJf3GlCINyWxsiq1KD++qDQntfgQozQHi5I4r9G3 8hQhgfTEktTs1NSC1CKYLBMHp1QDY+bltRXLA1N2FQWfmtnlGuqfESBQrzvjpkyj+w+963Zt viX2ewUvPbQLfN0jJaibJHBhRsbFD7wl+S01p09drd9zUNavR8fRTvrDqb9x1bI6ugzz5y1V 9rwZ+Ens/z+p9H3aAbNtZpvPrArn4v8xcdoivqyX8Qor5AwUudz4r8zZO9P1naiNEktxRqKh FnNRcSIA41uoNXkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsXCNUNNS3e2V1yGwc0bYhZz1q9hs9h1I8Ti 3JTZbBZf1/9itvh59zi7xfGt89gt9l0ESh6ee5LV4vKuOWwW99b8Z7X41idtcejac1aL1Wsy LGYfvcfuwOexc9Zddo/utsvsHov3vGTy2PRpErvHiRm/WTx2PrT0OHexwqO3+R2bx/t9V9k8 vt328Fj84gOTx+dNcgE8UVw2Kak5mWWpRfp2CVwZb6Z0MhXs461Yt+oEYwPjZq4uRg4OCQET iWmPnUBMNgEliWN7Y7oYOTlEBDQlTrROYu5i5OJgFjjMLPFi/ic2kISwQLTEvqOzmEFsFgFV iU37esDivEBj5v9vZQSxJYCaGy7dYwKxOQXsJQ6f2MACYgsJ8Ei82rCfEaJeUOLkzCdgcWYB eYnmrbOZJzDyzEKSmoUktYCRaRWjSGZeWW5iZo6pXnF2RmVeZoVecn7uJkZgmC+r/TNxB+OX y+6HGAU4GJV4eC30YzOEWBPLiitzDzFKcDArifDyXgMK8aYkVlalFuXHF5XmpBYfYpTmYFES 5/UKT00QEkhPLEnNTk0tSC2CyTJxcEo1MBrtO+jEsaPY6wzf5Nlsr8TPz050DUo6b3RzLXNJ yuqcL0kzwrqfuCfam9x8NO8hu+WUjOUBTF4WZrt0V+wW95wo8lE1qZ/Ny3P+zRyb8/NN3ikV Vl3b2fL+qeKVGa3bpBYnZiSfnPB+ZtTXGZee/fUVDeB4sq/vYbHsqa5Ym7kp1Ys6VrBs+qTE UpyRaKjFXFScCAB3kTAubwIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 37181A0002 X-Stat-Signature: 8k3c95orsse4wcj43hhf78joyuy1srzf X-Rspam-User: X-HE-Tag: 1751009949-707498 X-HE-Meta: U2FsdGVkX1/VM7i1iSLUJkndjOjIyM1PRcQAKwY9O30zJ1flkqJKwGLlrTvVyuJH1LsJVrBTiO00mnfxNZXDNxDAcxXp4+pmMH3jdqt1B2UW0hqLCTQjhfFYexrctib+yiU1hbXXYML+jD2X+hBW0elF64vSZ4D8aRs00DTjhG7UlR2ZYdUX4tde3tLM1OYE/EoZ40AZHaoPQXrQjDJTpFWDUVZ/Gb4tqfQ8Yrwd9hQvPVI1xOvwnUNA43SOGLgL8/rCKKFKL+klRHdIXyLlTeUHRERHkyvJmQrNLahyW5hgnguXWotzyU0H1+clPUcQc9uijJmeyDqttLKYhRHynXrbk6MXEsvWK8k4nwHr6pQ33ubTlMef8W7DnCk37eugMNFbtIsXh2wyx7JMJqN/Z642KeioERKrUh4iOCkITPGYKbIXnWeMe8GVx/e71JybRt2898+a9TWYj4p91JciQM71UidEXCUXwBQ1lNkeN6eCgBknRhvbsQiglPeGH1VOYKBcMAbYbgaMS638J8HlnmHQrdpfwXqDQ59L3G3fFKkwNQ8mVTtghhEBxOYa8g+/MDD/J99T75sVQQm4ZRKLmumDcilIHi2yBUbBRNSID2Avovs+oDLD2AKMTH7aJggLS6xyVSaj0mtPCIQyGqpLxh+gH41LS4RkF7CsgJFixa/FTcRYxOSO/I6Tc7nXffxmE8ziOyUrBZ8b2BrJFxJFIISDa0FM2zW/GIeUbeknOp/F087W37Xn8JbDsAI+BJoTUOQIMUAgsYmMKoegHKxPPrAUWIUPiNVmwcD4UDLtCCHVy4HhE58QyDrMT1jfLGIKNUzLSFLm2CJbkLCJQxultICsm9Q59DeU8hbHpJsUkq/DLUwk98t9PWOeN1rjmRZ16wfQxWXULpJ6gPlggURidWUuxBIHg2ueM7JFDC2LeFypzhxlv73nVIY5iC/gK7zsAdy/c1Ls3dF1Yq82akU KD5eeHse n8j+VUZa+9I3WvzJHPMJOfcvXN5MpCP8P/eRCo+N8IS1uYZQMTo6Z6FqEpGIJuDuDthQ7RxdB85Wo6vXshIsB9D51cnnTR4zhTtkb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 26 Jun 2025 13:09:33 -0700 Joshua Hahn wrote: > Simplify the math used to figure out how many pages should be allocated > per node. Instead of making conditional additions and deletions, we can just > make them unconditional by using min(). No functional changes intended. > > Signed-off-by: Joshua Hahn > > --- > mm/mempolicy.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 3b1dfd08338b..78ad74a0e249 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2645,18 +2645,15 @@ static unsigned long alloc_pages_bulk_weighted_interleave(gfp_t gfp, > for (i = 0; i < nnodes; i++) { > node = next_node_in(prev_node, nodes); > weight = weights[node]; > - node_pages = weight * rounds; > - /* If a delta exists, add this node's portion of the delta */ > - if (delta > weight) { > - node_pages += weight; > - delta -= weight; > - } else if (delta) { > - /* when delta is depleted, resume from that node */ > - node_pages += delta; > + /* when delta is depleted, resume from that node */ > + if (delta && delta < weight) { > resume_node = node; > resume_weight = weight - delta; > - delta = 0; > } > + /* Add the node's portion of the delta, if there is one */ > + node_pages = weight * rounds + min(delta, weight); > + delta -= min(delta, weight); > + > /* node_pages can be 0 if an allocation fails and rounds == 0 */ > if (!node_pages) > break; > -- > 2.47.1 > The updated logic improves clarity and readability. Well structured change. Reviewed-by: Rakie Kim