From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F15C7EE30 for ; Thu, 26 Jun 2025 15:32:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88DBD6B009B; Thu, 26 Jun 2025 11:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 864896B009C; Thu, 26 Jun 2025 11:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77A9D6B009D; Thu, 26 Jun 2025 11:32:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 667226B009B for ; Thu, 26 Jun 2025 11:32:09 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D0D08C025C for ; Thu, 26 Jun 2025 15:32:08 +0000 (UTC) X-FDA: 83597942736.05.FF45E41 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by imf01.hostedemail.com (Postfix) with ESMTP id E42B04000C for ; Thu, 26 Jun 2025 15:32:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W3yTtEyC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=snovitoll@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750951927; a=rsa-sha256; cv=none; b=AZazDmDWVgMVS2CPwBPDHshf196csSyXNlah+049VZ7ACRGufFdG/hDv7nbzxpOsIeZOWJ 9WJNCkHNTnOZnjDlvvOIsAwMvlJkKXhk2pK5XGVZ3J3x+wWvGdHSTQfPJTcxl/alirceud eDILbZ9NrkeEMZFO2WAiPaIiPI06u1w= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W3yTtEyC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of snovitoll@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=snovitoll@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750951927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=YMfAvEP2mtW3abNAfjIslAPajM3CO1XTnrCn/94UwT0=; b=awS16B6ubvodc1rNho4vDbpWh2aLkh7tkkvAiOZi8laqmnFiKwyc9YFyC3s/8ZcSWzuGDy rCOhyzLZNdSrozIiUxKkuuE0JEPn5iEiobo+ynybcyt4Jkhw11kxVrE1zrD4tT28Q/LKNl Hq5HVr3hhsMHwJadJmKrdU9ZeB0bL0Q= Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-32b2f5d91c8so10271241fa.0 for ; Thu, 26 Jun 2025 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750951925; x=1751556725; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YMfAvEP2mtW3abNAfjIslAPajM3CO1XTnrCn/94UwT0=; b=W3yTtEyC5ofXcn4pKWPzhsjZGjjkIxB3wvBmKMXTi1nyB2sCzLGU+dQI/PwtqxWqe/ 2ay8TJbdOwz+4su1nZil1iL7ePT9cGk3rYq+jIcYYLBGGQWzh15qkYVIpluRXC9baim+ //ia5sUH5DqEN3lW8iJISqAXIsPwNqevHGulBVJau3YmB+POdA8rKj1dMsrW7LE6ORKf V2Xtw+PFhBifGsyxl1JUAMUWcGzoIxAsnaJ1Ck9ZxK/Q3ZiErlkw3fp7KMb1H3XuKdw3 DYapU5P7YZ6kFeDwcfSh3G3RqCJAvmefMMVZcB3wApLNG+8nO7a+O/jUwvH1Kk06blC4 TMFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750951925; x=1751556725; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YMfAvEP2mtW3abNAfjIslAPajM3CO1XTnrCn/94UwT0=; b=s0pTqEFCtvVf87Oa14mRAUSUfLSriqkEhiLEb2PP38U+sa4hyA2s6rSz7z15nmVhkx Ivh4tlmGKiYzgDSzWOzImjsvuBEpwt1OTfexf+ZP4tXRv5FVUnTpFupp7zcZO13qCebH 7eneeXPnMF/bvy3mNdiXDLuLj+NKZz9g86iy8E7AXFo5H/A7OscdZDoETyXuf0BOI+RO YtD4vStZT0IpQKEA4bdWhvDPba7lXELptwGsdt4NMbOLS+MZE0iDErylEipAArE/3GF0 3lQ1oZKbnBZWaNPnKrPEiJjTHyw00tZ2e0oza35+9slv0DOt/rh3o7NaEzioSuA9mNwt A5/w== X-Forwarded-Encrypted: i=1; AJvYcCWV58zoTiGpjnJ2a13sWZVZgdo2FWld/zv2AcmtG4XB8W6hI/oDbQ12VHtF/7yNrGuiiwTtrDl/ng==@kvack.org X-Gm-Message-State: AOJu0YwWn1ATXRLo2+TTxStOWiud48szOCiJppRLr7JEG8lJjTvQbL5t IN5xk+lE4J+np45lceM6hkPXq5BVupkgOj9ZlzynGdM1lUjmu1H91p8q X-Gm-Gg: ASbGncuq/o38FLFGDjoThkxpJDjbchspAfowl289chccNHp3YRba32YUZovFeE7oXM9 JbDdqC/RWJRqsAuBCBWl5DxUT2tIXbmj9ADNCz92zfhwlJrb2WwfGGGRQ6RQTvKpF7tj+dj1hXw N7iFdbmAzE+fkT7qZjEIyrqgV6S7OpaU3ZnhHOJHGUhRwk1rv4ryuvly87mfttUc8Ptbxa9Vxke 98zBRM70xZ77HIuU7nXt7qVrxXW5Sg0LnaKGXh9dhZT1o1Hmu6SXbOm/ApnIuJ4tztQdiab5RRh SeAmNKFaDkQmbhB2Bzjmlpx4Gki8z7s4x+0Oz2kpnN1mRLMzKT961bYVHRBIYXgfLb2EcXiFvep 2/7wh449p8VjZMPwJ/PKcCpS5WlQ84NYlQhaluXuu X-Google-Smtp-Source: AGHT+IHpXirYmk7XDZLOi1Ssi0yS8Ocf718QqXqkpNJ7oPQlT+uR1sIDO9gdQg1tyNmCsb6VEaTfFA== X-Received: by 2002:a05:6512:1589:b0:554:f76a:baba with SMTP id 2adb3069b0e04-554fdcbb935mr2999055e87.3.1750951924452; Thu, 26 Jun 2025 08:32:04 -0700 (PDT) Received: from localhost.localdomain (2.135.54.165.dynamic.telecom.kz. [2.135.54.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5550b2ce1fasm42792e87.174.2025.06.26.08.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jun 2025 08:32:03 -0700 (PDT) From: Sabyrzhan Tasbolatov To: ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, akpm@linux-foundation.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com Cc: arnd@arndb.de, rppt@kernel.org, geert@linux-m68k.org, mcgrof@kernel.org, guoweikang.kernel@gmail.com, tiwei.btw@antgroup.com, kevin.brodsky@arm.com, benjamin.berg@intel.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-mm@kvack.org, llvm@lists.linux.dev, snovitoll@gmail.com Subject: [PATCH v2 00/11] kasan: unify kasan_arch_is_ready with kasan_enabled Date: Thu, 26 Jun 2025 20:31:36 +0500 Message-Id: <20250626153147.145312-1-snovitoll@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: E42B04000C X-Rspamd-Server: rspam10 X-Stat-Signature: bsf4agormegt7wkszxdymsetikq87pq9 X-HE-Tag: 1750951926-386407 X-HE-Meta: U2FsdGVkX19fuCpgplbUxRXKxrLn2NAqwL3dE8/WE7i2G9hhvg5YnLDHz/K5IkUefVTE/FeCBWSVBXymzYHeYKPGtpEqe2xlLV7teC7rnGi0hTnt+PBsbhfYtFvx5f5xI/3Pxb3g0e4xYAED2VqlHXIPrfDnxjz584VlYjPiaxA9/PBZEW5xfCGK5linX8ERYWUfYlORiVk69GhcQ3RVhesARfvSjncnuL8QIyZRWvUXO8mqLmyD5Tig5y+VtWQ5HQrR8y8UCzti7Lv/BGQ3ZQufIF4UR0swgNLWiki88H2JxCkY8Xkfwx+pbkU/ATp5cQ14FGOOL8qqwFuLmtCA57c5eypGffuVwEhfXYodnUJ9fh716234FrEU1uYel3d7lGHq3hpZPz8lQKDRKJkc7RD99WD3ijaWprPc0xmjbnWuBZAyAhtRhbQEsqnJqZ4+7NdCzDS7jsZVeDllBkceQebaiTeoZJsvhJXQfvrjkGpfpgtt8N3Bf7fC88PKCUrxUkVCuhx01cAgRmbXQYlKC/mtsLE8WdnmHQyEK+zEO3DetyMtJ88CU3FLZlhQmbzpVwTxvUs2EuZkgGuMH/rqNlH0fXx2qp37nse512GC6PfZExjGVCbDR9kJPmMqn0NUpl81UFYtZCE3h0ljavM96pk9by4sKVehBvFJOJBs6QYe2+EftvfTR1ZBWLRQxzkIZqNh7MZYgw5FBtx1atuC6LJqU769f41+iwY0IN74pFFdI6ZH+as7+xK3exTrYlgs1ARQZg4yoDp2rbKN3s62l7pkQDC4KS6AVBQkve2hcRQsLSKPa8IAiuURteFfliwqqqe9UWqeiVjiNMt9RzrrRwzPMHyRrj1No6VqshboZLMS753le6tpHyX0KDMUXFPV1olqkjYEAu/2TmlRke3xXvg/EaMnAdKEqpjB5hlV2mwDZcIcCXbSC8KvlF+fawK5s3VBWEBJvG/VNi4fPPF YtfW9+uS V/eEv4aq48yl9kHuLMUKEulgVMP28y0bkC4c/o0QDNUHORaoutDz/JaeJ5ct7EymHRyjCLswjLfpnUG3v0kprDdkqw7Y8vzWie+tvkjJibKO21mk5vA9RRZqbK/uSRKfeK8EwLWnyzoHed29BkWDGMiT9qAP5KMOUr60CfEH10tjiwsG/hhx5cf8JIj+WDQhSYo9MNEtbad5qwSRgTNBrkZAhQMcn1fGWqC84cYpI4rL6DzDDPJUwb/HEeXS04kB9Vc9+vzd6IZTQEsb3rRM/mnaUYNDR3/7QwYIwwqo4EHpRPBcC6eFiLCRF7eTZEsqYemk6IV6BSgim0KBo7apmA7IqS++lo4wrjtFy6/2ZzDc1DFwCLNRHK9cc1pL+epzxkgOD1zaLKPaNEWnBJSPQn7boGFw10SLe1pLaqBQHwoaDeWF/eIBZUUU3idsogSLUnVnEO+bB7Nm7Xxbr+tpVDDnADHPVXePyW08ExRbiRW7E0Ql6cuUh0iJmFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch series unifies the kasan_arch_is_ready() and kasan_enabled() interfaces by extending the existing kasan_enabled() infrastructure to work consistently across all KASAN modes (Generic, SW_TAGS, HW_TAGS). Currently, kasan_enabled() only works for HW_TAGS mode using a static key, while other modes either return IS_ENABLED(CONFIG_KASAN) (compile-time constant) or rely on architecture-specific kasan_arch_is_ready() implementations with custom static keys and global variables. This leads to: - Code duplication across architectures - Inconsistent runtime behavior between KASAN modes - Architecture-specific readiness tracking After this series: - All KASAN modes use the same kasan_flag_enabled static key - Consistent runtime enable/disable behavior across modes - Simplified architecture code with unified kasan_init_generic() calls - Elimination of arch specific kasan_arch_is_ready() implementations - Unified vmalloc integration using kasan_enabled() checks This addresses the bugzilla issue [1] about making kasan_flag_enabled and kasan_enabled() work for Generic mode, and extends it to provide true unification across all modes. [1] https://bugzilla.kernel.org/show_bug.cgi?id=217049 === Current mainline KUnit status To see if there is any regression, I've tested first on the following commit 739a6c93cc75 ("Merge tag 'nfsd-6.16-1' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux"). Tested via compiling a kernel with CONFIG_KASAN_KUNIT_TEST and running QEMU VM. There are failing tests in SW_TAGS and GENERIC modes in arm64: arm64 CONFIG_KASAN_HW_TAGS: # kasan: pass:62 fail:0 skip:13 total:75 # Totals: pass:62 fail:0 skip:13 total:75 ok 1 kasan arm64 CONFIG_KASAN_SW_TAGS=y: # kasan: pass:65 fail:1 skip:9 total:75 # Totals: pass:65 fail:1 skip:9 total:75 not ok 1 kasan # kasan_strings: EXPECTATION FAILED at mm/kasan/kasan_test_c.c:1598 KASAN failure expected in "strscpy(ptr, src + KASAN_GRANULE_SIZE, KASAN_GRANULE_SIZE)", but none occurred arm64 CONFIG_KASAN_GENERIC=y, CONFIG_KASAN_OUTLINE=y: # kasan: pass:61 fail:1 skip:13 total:75 # Totals: pass:61 fail:1 skip:13 total:75 not ok 1 kasan # same failure as above x86_64 CONFIG_KASAN_GENERIC=y: # kasan: pass:58 fail:0 skip:17 total:75 # Totals: pass:58 fail:0 skip:17 total:75 ok 1 kasan === Testing with patches Testing in v2: - Compiled every affected arch with no errors: $ make CC=clang LD=ld.lld AR=llvm-ar NM=llvm-nm STRIP=llvm-strip \ OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump READELF=llvm-readelf \ HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar HOSTLD=ld.lld \ ARCH=$ARCH $ clang --version ClangBuiltLinux clang version 19.1.4 Target: x86_64-unknown-linux-gnu Thread model: posix - make ARCH=um produces the warning during compiling: MODPOST Module.symvers WARNING: modpost: vmlinux: section mismatch in reference: \ kasan_init+0x43 (section: .ltext) -> \ kasan_init_generic (section: .init.text) AFAIU, it's due to the code in arch/um/kernel/mem.c, where kasan_init() is placed in own section ".kasan_init", which calls kasan_init_generic() which is marked with "__init". - Booting via qemu-system- and running KUnit tests: * arm64 (GENERIC, HW_TAGS, SW_TAGS): no regression, same above results. * x86_64 (GENERIC): no regression, no errors === NB I haven't tested the kernel boot on the following arch. due to the absence of qemu-system- support on those arch on my machine, so I defer this to relevant arch people to test KASAN initialization: - loongarch - s390 - um - xtensa - powerpc - riscv Code changes in v2: - Replace the order of patches. Move "kasan: replace kasan_arch_is_ready with kasan_enabled" at the end to keep the compatibility. - arch/arm, arch/riscv: add 2 arch. missed in v1 - arch/powerpc: add kasan_init_generic() in other kasan_init() calls: arch/powerpc/mm/kasan/init_32.c arch/powerpc/mm/kasan/init_book3e_64.c - arch/um: add the proper header `#include `. Tested via compiling with no errors. In the v1 arch/um changes were acked-by Johannes Berg, though I don't include it due to the changed code in v2. - arch/powerpc: add back `#ifdef CONFIG_KASAN` deleted in v1 and tested the compilation. - arch/loongarch: update git commit message about non-standard flow of calling kasan_init_generic() Sabyrzhan Tasbolatov (11): kasan: unify static kasan_flag_enabled across modes kasan/arm64: call kasan_init_generic in kasan_init kasan/arm: call kasan_init_generic in kasan_init kasan/xtensa: call kasan_init_generic in kasan_init kasan/loongarch: call kasan_init_generic in kasan_init kasan/um: call kasan_init_generic in kasan_init kasan/x86: call kasan_init_generic in kasan_init kasan/s390: call kasan_init_generic in kasan_init kasan/powerpc: call kasan_init_generic in kasan_init kasan/riscv: call kasan_init_generic in kasan_init kasan: replace kasan_arch_is_ready with kasan_enabled arch/arm/mm/kasan_init.c | 2 +- arch/arm64/mm/kasan_init.c | 4 +--- arch/loongarch/include/asm/kasan.h | 7 ------- arch/loongarch/mm/kasan_init.c | 7 ++----- arch/powerpc/include/asm/kasan.h | 13 ------------- arch/powerpc/mm/kasan/init_32.c | 2 +- arch/powerpc/mm/kasan/init_book3e_64.c | 2 +- arch/powerpc/mm/kasan/init_book3s_64.c | 6 +----- arch/riscv/mm/kasan_init.c | 1 + arch/s390/kernel/early.c | 3 ++- arch/um/include/asm/kasan.h | 5 ----- arch/um/kernel/mem.c | 4 ++-- arch/x86/mm/kasan_init_64.c | 2 +- arch/xtensa/mm/kasan_init.c | 2 +- include/linux/kasan-enabled.h | 22 ++++++++++++++++------ include/linux/kasan.h | 6 ++++++ mm/kasan/common.c | 15 +++++++++++---- mm/kasan/generic.c | 17 ++++++++++++++--- mm/kasan/hw_tags.c | 7 ------- mm/kasan/kasan.h | 6 ------ mm/kasan/shadow.c | 15 +++------------ mm/kasan/sw_tags.c | 2 ++ 22 files changed, 66 insertions(+), 84 deletions(-) -- 2.34.1