From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A09C7EE30 for ; Thu, 26 Jun 2025 15:27:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB2F18D0005; Thu, 26 Jun 2025 11:27:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8AB68D0001; Thu, 26 Jun 2025 11:27:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79958D0005; Thu, 26 Jun 2025 11:27:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B3B458D0001 for ; Thu, 26 Jun 2025 11:27:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 568381D359C for ; Thu, 26 Jun 2025 15:27:19 +0000 (UTC) X-FDA: 83597930598.13.B29DC71 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 92BB51C0006 for ; Thu, 26 Jun 2025 15:27:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cai0sXOs; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750951637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xcMYeEAZ3rDARrZ7PW/UmKYumCnemRE7wsR2s/ucZJc=; b=6O9y3r4QwPeORGgoWLlOpHJPaV6BoHyP8yRb0EWk7i5kAEECm9Uuxif/6SeR7VDd8hN778 8aUvCSNGj3r0qTjKKB0u4Kdls09EBr/gr7nn0Biwhm/0ie7ur0MYGpdDy5RHmebFGugqz+ 6UHfNH7YTI+gp1nnQRwGRDvxpYzAgsI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750951637; a=rsa-sha256; cv=none; b=CDF87pELPULD+ZSsRTpHfGaFuwdpkRPPS+rEdo8nZa+LHxkIK6QT6OXs/SO43zMWZmohTk RMGQIGdEfZoY0tCdJ5jEZKXoRIeeJSVbOvGWlhp2ngZxKwYUaYVZJ/WkIKDeozgC/XYiGn pQlYRJV1DNI4qffGVIcb8aWXhKB6GvU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cai0sXOs; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 149595C620F; Thu, 26 Jun 2025 15:25:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5EDEC4CEED; Thu, 26 Jun 2025 15:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750951636; bh=7bEQjpoE3Zx5yVy9HF7Vo3sOAzETOsPIYEhDfTzYJ2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cai0sXOsyySQh7hrHfTuGgoPeGqZlpttfsnYMIceh1HIDWKllKXbTUtd4pXziSGQb gWJebCySEEZmqpqR2CUMT4Wr409JCC94uFtinUe1YBS3/qIQglg1VyYaX8mWhJrBjv 8S6t9OrD1QiJLWOXls0kJj/9th4MP20Azr6LiD3tE9tiuBFkyCoQ20dEKj8NMhmbkS y/FMZBi//jyZd4jZ3ad0DUzFtkhoWJDR1EOuuUNef2IG0GUB+bgfCZYXsyy2oPC701 rd2aD15mBPg2jGeF4Q3rdBGu6EJIwLQy7M/QXkD0ItuzvYYaDVpkB7/WQdzDgq4Qud mM4LhdHQZq9+w== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , kernel_team@skhynix.com, damon@lists.linux.dev, Andrew Morton , linux-mm@kvack.org, Yunjeong Mun Subject: Re: [PATCH 1/3] mm/damon: do not allow creating zero size region Date: Thu, 26 Jun 2025 08:27:13 -0700 Message-ID: <20250626152713.333339-1-sj@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <697aed09-80ff-41d4-b1cb-321c9fd9ff23@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 92BB51C0006 X-Stat-Signature: n5c1d3gngt56p9u6738mgxpqud38txgs X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750951637-882143 X-HE-Meta: U2FsdGVkX18pft6pRR/oMwSpn+gZuVbPPLOX9MoGJA8Z5sF5Q1IuTpwAJNeR3ee0NNrzsuNRV5nRJI005VzdN2LlA2bAL2b2NSF+pH6rTLnbvGyZPNJ7i9C5pe521VT4NW26cigjGVmPG/XiasfowSaHSBKPZxoC8e9oT/iCpOz8Jd3Ms/KOCx2wQuFYJqTuOSICJZInIKFcFCIIp+CFKZt/wt4Xc8ABbiPaT3kZuKfuObn/SzgvUnq17bLla/Tq6CR/er/IUweWbqOVwzP7XvuEkHWvdYWaF7igz40pmcX3bMQ88dv/Usk5uS/DSVR0b7uDOUgeu3UECTfAJ9y6vUSn1BGrMjS4JDA2QebFZb8tACOh+YO1JbAENGYkkO5z6qMXyonMxPl7ipATTHsm/wUFIFSRom8MoRZ0BVRSIxSSSItu0CoSrwwl3CACQDGnlBpPsPRGWaRNNG4Vjphr7S7fQDNPTYg9vcddrh9soahZpNo4x8gzm0GCSo7cMqoO6uIKjBqk3eq99pgJYOBYxobivYDY1e4oY0Qvvx1kD5vhj2qTs9uEdtBBCGAsgUqzUoFJO76gOA/jiW4UysUJLXjTNSItEu59B8liuRoYVClnkmtkVqPxGz8ZltHFPoA7gX9WRxESy5V+bKwa3Y70hOAW5eIEnIe4oVqvlsA01U4l5dD0SgTN4M2TlWk8ipYtXgxO4K/gegFxO14MtyvMeGsSnR2g0+0F2stpr0tfBSAIoriOdNUHObDvT1a3j1oY8syYSrnpNcoxqGh+neUgwKoZNPmBQfLKJkcWCaeu6w/zu8nalz7RTKgypDoqG9swtIIL4X/D5ja6y7BhIK3Uxh2FjRDwJhKRcn37QAvLTrjxpDlenzL41YAPvbuNHAbYXkeEhk6Q3CHOBwhK3JZBzNuLdX74wr5PManyR7QyVqvZaK1TXLESyx+/Rj86PkqLTO1ULeRFfvhaP5KPFyG 8TbqZaDW mGcXcTrYYNp6C9R1TQsazFmBzyM2Qu+jWYrmTgRNqE3aUJ+DwzOWgXlk64y1VaMY4gljuHJHN2978gM7BAKah9B50UD6XXF223RfiHe4uuZ5PCLChr3nv56H6oVFe6lUOtLIron4Mw+J8URvQBCj04WG8/I08KXUVm+7XIIlhwSAVbuELwOjsrWOXDzpmQajtV0XM3qOoQMD/j0mASTBTf/P/hbw4uyob8Qt06DCH/nKr8zZsb88DmltczDt7rqx+Y1HGGDna6o4C6D8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 26 Jun 2025 07:24:14 +0900 Honggyu Kim wrote: > Hi SeongJae, > > Sorry for the late response. No worry! > On 6/24/2025 3:03 AM, SeongJae Park wrote: > > On Mon, 23 Jun 2025 11:58:53 +0900 Honggyu Kim wrote: [...] > > I mean, something like below. > > > > @@ -1449,6 +1449,7 @@ static unsigned long damon_get_intervals_score(struct damon_ctx *c) > > } > > } > > target_access_events = max_access_events * goal_bp / 10000; > > + target_access_events = target_access_events ? : 1; > > return access_events * 10000 / target_access_events; > > } > > I actually didn't mean the code, but just wondered if setting > "target_access_events" to 1 makes sense in this context. > > I now think that it doesn't make any difference because applying DAMOS actions > to zero size regions as it's just no-ops. So I can take your change. Thank you for clarifying, looking forward to your fix! :) [...] > > I still prefer fixing the found bug on the spot. I don't think having zero or > > negative size regions is really somewhat we always prohibit. > > I can split "target_access_events" change patch from this regardless of this > with "Fixes" tag. > > But I don't get why you think zero size region is acceptable. Do you see any > benefits or have special reasons allowing zero size regions? In short, I don't anticipate special benefits of allowing zero size region. But that's smae to this change. I even have small concern about this change. This change might make people assume any damon_region would have non-zero positive size. I think that's wrong assumption. Any DAMON core and API caller code can set the start and the end addresses with arbitrary values. I think making the assumption true could be beneficial since it will help writing code with less corner cases. But to make the assumption true, we should first check if any existing code is violating it, and if any existing code that written with current assumption (region size can be zero) can be broken. After that, we should also prevent future code violating it. And if the assumption becomes truth, we get one more rule. I, at least, prefer having as less rules as possible. My taste may be weird, but this is my humble feeling and opinion. Thanks, SJ [...]