From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 820DDC7EE33 for ; Thu, 26 Jun 2025 09:29:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BE198D0002; Thu, 26 Jun 2025 05:29:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 094EE8D0001; Thu, 26 Jun 2025 05:29:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EECFD6B00A0; Thu, 26 Jun 2025 05:29:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DCEE56B009D for ; Thu, 26 Jun 2025 05:29:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7AA2B1409B9 for ; Thu, 26 Jun 2025 09:29:17 +0000 (UTC) X-FDA: 83597028354.21.2793078 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf25.hostedemail.com (Postfix) with ESMTP id 801EAA000C for ; Thu, 26 Jun 2025 09:29:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=X55aUBBM; spf=pass (imf25.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750930155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vfPg1bPzYUgjbdKxXUbIHHPyI6o1ylxUcethQzPOy2s=; b=vxd0ILIndZWsfvEVHSarfDw/UCNfXbI9S0FWoEn6pynjiCsM3iJCn/fNOiQb9uwX042GwW lVTFA5fczpd5SM5aJUwfZhSYruydmNBTzDUEuK8XhbDRrWTJBgtKcYBZtuuFjd2At+KpSs 1H3Z/PrrJjuxyUghtl59ridR2pmBsMs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=X55aUBBM; spf=pass (imf25.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750930155; a=rsa-sha256; cv=none; b=2sfO+kxv+G+QkY2wxPRVekBg4JJ9ehB3ae4r6ixNd02Km7uvvjo2X740Z8ZbVbgTASz7cy eamUOuOfk0X93I4eyMmy2I1juBUv40EV3451hwIa50Dv78aGSWi9u/Ta5alcMQi3m4a2wd IEFNLfsKKcROyv9d7Wb9Do5z0zMOtkg= Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a50956e5d3so589719f8f.1 for ; Thu, 26 Jun 2025 02:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750930154; x=1751534954; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vfPg1bPzYUgjbdKxXUbIHHPyI6o1ylxUcethQzPOy2s=; b=X55aUBBM0BaIrrJnLwgHn2y0I3ABm4s2aj64E1mlrXdtCWQpMjYrrzE9wIQKu1tHMd DqovAWe6Tg5ReO4CvwSeujQN7TNXVBO8CwdIQl6KU177K+sd1j1VhXvGeD9ffP7lbiy5 sfGGtT/w8CWeFUuJTwxoKM47GxHuuhMqwoGS5w2yNLLTiv2HcPFV9zKIQiymD8ysBgji KWfsMTYB+8gE04oFJeysrl/E17QFOyCQWL9yiDdxJPujW+NJ95axiJzJveu0ji0JSZIq LNZ3WWoLw/u2Zu+HrRrkqgnyluR80fqL4njIJsncbZKAPZ4lE5XxUjA+D82JHtU6rkyH kp5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750930154; x=1751534954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vfPg1bPzYUgjbdKxXUbIHHPyI6o1ylxUcethQzPOy2s=; b=clO06JwoVmvuR6fE/Z5ct37IYkK+8T6Y+D9sMKop4jvnJWeMN9cQPgk++mlnvyl+Es xNldpNXgouJcYBu9JLJAPGSsUMtioE9h5/KCa5mL3t4ZqTd8Z3oOClQppvsIZgb+Flr1 D7Wst/xtlueKyhY5BSFAxPSpZDeNcQ1Ce0ilhG38Hz0Cdqnmo1h3bsJwnbNNwqb2InzJ t4pZOcx11gE3WBEtzPCHJPyK7ispTU+vuhEJ2OkETlv37OX1urIytStzWWpPDajW/9ci mig+WpsqBQ3jt/M8DXuwjFaYzfCNCM3NOVEaz3JyYb//9tqqrh/G/Vja32XOzNCC8G2v gA3g== X-Forwarded-Encrypted: i=1; AJvYcCWJAIpN16Emcu9F2YEJl8mUR1NlbdY6c22ZBlianChikLu4nZLZi0CxPW2zHMxT+Xb3UyaCCAbFmw==@kvack.org X-Gm-Message-State: AOJu0Yy/MUvYjXeBOZQxLER0So+7gKpr9WJbyPAAb4T2SW3PDs1At9cu 6qLlX8NDe0ogZ2XBELf3mnDbic4LTNre+9+LhezI0EuyKMo4sr6yWqMO X-Gm-Gg: ASbGncvQbLu1h1d9pdCWybeMQrfE9X/AfDffnJRA5Ja9em2hmUuJvTwEr1ekMkMajUy N290FD4o1h1YZW9cdeccw/urWvfS7k1J2C1fC5jHNHu+20PGXzFsu7cYoZaN7XrR2eZ0ggU5jAb gR6dJQm2VzBAyPo8HDd4aJqjGPduE5426PRQjmE2uNpuvsuh3G64nsWjuDG/TA2PXRfN5oH9wve wEx0IjscRHHcvL3ZjtZRrs41oZvnHCckMS2dKlyixdvWk9XM/rNROcNHzsR7No6jR1Kiooby3Zi /qyzI8QheJc1rYQAAShv4X9Z//g4pbnkyHRZkx+348R80pE= X-Google-Smtp-Source: AGHT+IFKXFVQqQF/e1a/uqOSmFAWHw7Suwi2bBnIU1uj7qmwG8d6IbJ3C4uZB9qONaL/NItzf1KkxQ== X-Received: by 2002:a05:6000:4112:b0:3a5:8905:2dda with SMTP id ffacd0b85a97d-3a6ed646c23mr5123244f8f.43.1750930153481; Thu, 26 Jun 2025 02:29:13 -0700 (PDT) Received: from EBJ9932692.tcent.cn ([2a09:0:1:2::3086]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e8113b00sm7002427f8f.96.2025.06.26.02.29.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 26 Jun 2025 02:29:13 -0700 (PDT) From: Lance Yang To: david@redhat.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, ioworker0@gmail.com, kasong@tencent.com, lance.yang@linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation Date: Thu, 26 Jun 2025 17:29:05 +0800 Message-ID: <20250626092905.31305-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 801EAA000C X-Stat-Signature: 46pxu4o6ce97i449qfgs7h4i7tsryid8 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1750930155-918953 X-HE-Meta: U2FsdGVkX1/9lkaSzu0HwdS7E4gcBTrC98N+cCO4MbBGsG6A8YSaXxvKU5XdCPHLdGtLhO8N14Qz0EaiiWJjKSf6IM3zjDev0pXsm61UV29R/yVGXLP5tayiKg0RUe5EewibSNI7bhF7NregFgiPjh92QXvhHMno9MRXt1Aj4w6ghGecVExJ9Tn/N+LaPs5zc5pR83pSViHau7c2+zCi1tN12YS5C/fVYqhYl1bvRyKwUCYVZfaTO/50gR/2aoSh7ZeW6wJ6qwFF7uEQHDVIvvVHwnmTylwrEAsHPgGV6DosF2MDLmbi2/qHsmOyi8aqD7k6JXCcsXfm8TTS6azJtcCO57pXomOsFq4REcj3nntO8jN24+MYSudhaqI11j5gq4dL9xC7zVuxjKASq5NxIKlqxBEVp2yrC2IIFNoeqt7mP7PMdQFDui4WFHL04MqNQYFdb7NjZmjTfi4XgzOPYYuwhypi+stsVg4qZBOBEvz1TiDoSikUXx6DColfRtb85hVm+aNpZwHL6FDKWznjgEoc21QQBO4XuuNsMpa48D5Vgq/ApGKgmyx/LYcH387WEnPj73/iUpE5ULRcbWO7H9L33+yTGsvyqCmbOzJCc0oeBRCu/J6aYvKmiHF6JeL+kGUsP9wfGomWfNejE/3eoyjlLtHehPuGgEaqjKEJchK1p/6fGHB0nAaIFWy0XiMeNhIvpuC+WUu7WKUzliqXW2LBgwNLK1zhdci15b7sx3E0cPqTFE+Im8loPH70O+vKtaThdu0ul0CUjCMYvEPs/tiG7TZ/8HBvuD6hOWDwjvrBQd1/qVHIXRXVcXJ574FfSoW/Atke5rghx+X5GBJ0BEI1NzquHtnRvi0WmhPUYWm9F/5y4JDacQoJI2vw0CeuXoKhmOhW9TZ7Am6zfGVOxFwtO2hnXL5h1q47l5dG+WIzdvOxrsB7OVnxkGvjr+2hnlqkQAIdbZ0zpTlPgxO EaIs/wD5 B+XXf9+8w2xFBiCDUKj7qA28ovERlxhbewBrPVojV9Q3CjZMGR1UWWEZL2lGBH/IVFNkp1eVDbFy34YaYSLkcfsHTro8U6iVSe3XfQCAeR9czDiTpwKafK9fP6K/MpsZfhwvM2n9aLj/UEdIa4b129h61/16XUPyQItcyR5FISeuO+IL0z+wZKM1iRRw1x+BwbGSbBU3ussWKZPplhgdLRPCE7O8DEmRcxdSqrbn3i/CvrA/RIJSeEGEMBrMWY4FiSBDy5p/GmVTAcXyvU9oHQlGSVqkyyj/DbWaVtvU02sqvoOmA5U78WRCKx1upLrkbEG/yQnCTtDxrOltZAv9iTfzZsPjMDdWl/ubk/7Hhy3NiOOfGn7CVMIN0VGfeXcDvxhDMfUBBrDDhNcFX2qEIqhr+6l4BSwCmPOwp6I7RjTc7Ym6JjzQGVMCqDHHQKg696YDTNfh4AjJA15khCHxMnLZorg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Before I send out the real patch, I'd like to get some quick feedback to ensure I've understood the discussion correctly ;) Does this look like the right direction? diff --git a/mm/rmap.c b/mm/rmap.c index fb63d9256f09..5ebffe2137e4 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1845,23 +1845,37 @@ void folio_remove_rmap_pud(struct folio *folio, struct page *page, #endif } -/* We support batch unmapping of PTEs for lazyfree large folios */ -static inline bool can_batch_unmap_folio_ptes(unsigned long addr, - struct folio *folio, pte_t *ptep) +static inline unsigned int folio_unmap_pte_batch(struct folio *folio, + struct page_vma_mapped_walk *pvmw, + enum ttu_flags flags, pte_t pte) { const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; - int max_nr = folio_nr_pages(folio); - pte_t pte = ptep_get(ptep); + unsigned long end_addr, addr = pvmw->address; + struct vm_area_struct *vma = pvmw->vma; + unsigned int max_nr; + + if (flags & TTU_HWPOISON) + return 1; + if (!folio_test_large(folio)) + return 1; + /* We may only batch within a single VMA and a single page table. */ + end_addr = pmd_addr_end(addr, vma->vm_end); + max_nr = (end_addr - addr) >> PAGE_SHIFT; + + /* We only support lazyfree batching for now ... */ if (!folio_test_anon(folio) || folio_test_swapbacked(folio)) - return false; + return 1; if (pte_unused(pte)) - return false; - if (pte_pfn(pte) != folio_pfn(folio)) - return false; + return 1; + + /* ... where we must be able to batch the whole folio. */ + if (pte_pfn(pte) != folio_pfn(folio) || max_nr != folio_nr_pages(folio)) + return 1; + max_nr = folio_pte_batch(folio, addr, pvmw->pte, pte, max_nr, fpb_flags, + NULL, NULL, NULL); - return folio_pte_batch(folio, addr, ptep, pte, max_nr, fpb_flags, NULL, - NULL, NULL) == max_nr; + return (max_nr != folio_nr_pages(folio)) ? 1 : max_nr; } /* @@ -2024,9 +2038,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, if (pte_dirty(pteval)) folio_mark_dirty(folio); } else if (likely(pte_present(pteval))) { - if (folio_test_large(folio) && !(flags & TTU_HWPOISON) && - can_batch_unmap_folio_ptes(address, folio, pvmw.pte)) - nr_pages = folio_nr_pages(folio); + nr_pages = folio_unmap_pte_batch(folio, &pvmw, flags, pteval); end_addr = address + nr_pages * PAGE_SIZE; flush_cache_range(vma, address, end_addr); @@ -2206,13 +2218,16 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, hugetlb_remove_rmap(folio); } else { folio_remove_rmap_ptes(folio, subpage, nr_pages, vma); - folio_ref_sub(folio, nr_pages - 1); } if (vma->vm_flags & VM_LOCKED) mlock_drain_local(); - folio_put(folio); - /* We have already batched the entire folio */ - if (nr_pages > 1) + folio_put_refs(folio, nr_pages); + + /* + * If we are sure that we batched the entire folio and cleared + * all PTEs, we can just optimize and stop right here. + */ + if (nr_pages == folio_nr_pages(folio)) goto walk_done; continue; walk_abort: -- Thanks, Lance