From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A598C7EE2A for ; Wed, 25 Jun 2025 14:36:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98ADA6B009A; Wed, 25 Jun 2025 10:36:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93BC66B009B; Wed, 25 Jun 2025 10:36:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 804126B009D; Wed, 25 Jun 2025 10:36:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6BA1F6B009A for ; Wed, 25 Jun 2025 10:36:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1B76E1604B3 for ; Wed, 25 Jun 2025 14:36:25 +0000 (UTC) X-FDA: 83594173530.17.3748401 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf01.hostedemail.com (Postfix) with ESMTP id 5D4E84000D for ; Wed, 25 Jun 2025 14:36:23 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750862183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IerHjt+L4eSycKPHLXH/8ttSeTl7fSSTXg2G/ZICCEE=; b=xI+6un55yTx8yoIqQQ3Lm7XF1r5LFQbkBqabQnwG2l21kq8G1TJP1s+hKlwbNCy3i6gddy 3FxxrxPLM/Ahu0BnmjxS6b5MW2c4H4eM9GOv0QY3AxoAyRoYAVFUV0S8NtaeAM1YYkd1s4 ZGYZZKy0RNwDfGW66RK7csMJHwS8HPc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750862183; a=rsa-sha256; cv=none; b=eO39jdeb5MZ5u+ohPN2VLBAfFDVtVQ1DLQtAUIJyX4bTpkShWK14hmSfppypsdXr4RHW1c WZmOjLu2Ao10iDVjKUyxDmJ+bzm3+0EenX0C9ThpWYraP9F5yHr/QixgSZVbk/HXjWTrUM 1VWzJWAe3+XxeHnuyfs3T0DgV341Cg0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu Received: from trampoline.thunk.org (pool-173-48-82-219.bstnma.fios.verizon.net [173.48.82.219]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 55PEZxBr000389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jun 2025 10:36:00 -0400 Received: by trampoline.thunk.org (Postfix, from userid 15806) id 660662E00D5; Wed, 25 Jun 2025 10:35:59 -0400 (EDT) Date: Wed, 25 Jun 2025 10:35:59 -0400 From: "Theodore Ts'o" To: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen Cc: "hch@infradead.org" , "adilger.kernel@dilger.ca" , "willy@infradead.org" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" Subject: Re: [PATCH v2 4/5] ext4: handle IOCB_DONTCACHE in buffered write path Message-ID: <20250625143559.GE28249@mit.edu> References: <20250624121149.2927-1-chentaotao@didiglobal.com> <20250624121149.2927-5-chentaotao@didiglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250624121149.2927-5-chentaotao@didiglobal.com> X-Rspamd-Queue-Id: 5D4E84000D X-Stat-Signature: wos7e96ujx6bs9w5gcwpqy3czhsnsibd X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750862183-477635 X-HE-Meta: U2FsdGVkX1/GsBdsB8IgPEQxSNJ8gKvnOSz3FU02Qa1G625vxhhf6FDU9WnO6JHnb3rm0wPquZ0LMQgho5XL3tNfznCU5XP1ZmwABZLK2/zfRaU+HbydvyK6H0r5hP3NDnFvyQYyfo8Of2gMSFYfrmQSux8bd5FHUhdU2jzqdxhEZ1IDsaB46NyhcGuuNwcg/xJzE6OIODqYgW/xAfAvc02k5/FJ8H6RkEwpDfGv1SCzX7cknwAJmDHBBcSlcfksSclUkdNbWIOscf4ozruZouGBoTU183/inIL+N4Dmce4mLQc3GPBpkWeVlg1U2hLnX9Mb/sniDREL3m85nd/KasKkOC9LajW8f74sRJP2RqT7+EG2iMEKteQh7Kz3m1mod4VHnmaIPGtermf7/1R2RinSVJajbLlNrlGXXY81a+iyGycCz0Q4G7wVdTumVBxSllpqKQmuvk97xJx3sSjX4jquWerUzX+W9YmA8m5X3g8kYpm3cHRDfGXCiQxE+Ej6B3U8MSZ7N4qyQnAhhnMl6BbcRefX8B0E7uv99xRUl1D+DLGvqQ7t0m4nyss3IuMrKCA0hxgx1WPVTj7vyusTDi9o6kvWhcFNOdqdkkOK5ikgzAZ/d9i/4Zu7ined5iYXgpGKBHr32Kq1eSq68BjBbf56kF9zgFZNA8F2YIiROdGGAc9UrRGDZ84+Po4Zrz306Znh046R+UxRIfU7kuRltt+Q4pyN+LVmZaEHUkvKYxqHwf0yvi6h7r65SKNVQLMlYszb/e79e/OZgQXLiQh4hfRNPi7GrllHMRwATnU9Sxpw5DanAldBbVjYeIPMSrkm6pajipYkogYHXiv/x5f2xUG1tuN7+waAsm0++6KQOZonyPGlkOiYRQfgXOspu3x32yUMb8rvBaKRwZeSyKtzE/c1mbfRuBkRWnAuvDdORIzCSDQoI6KK9TF/ldPgezgdvLaQJjiaV06GAmxcUFQ 9El7ak/h apKzAQNQ5f4tg1NYZRiGerRwfsAsofYN9xqSOI9PM/kkZL/Yk+GxeE1IeFdg/Xd47WpojnvSuWSdDDXQttB21EvMJ7hoxv+p7OuD9m6vCPXQeKDikuhC4o7qxz7IhyfV6rHb+qh4OstqncL0bagwZ+oJgBydkudp8C5xhbr4lpVqeSy6TRzriBhne8deEwp/ILzwneGXoLPsXeJRgFW6qC81VIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 12:12:09PM +0000, 陈涛涛 Taotao Chen wrote: > From: Taotao Chen > > Add support for the IOCB_DONTCACHE flag in ext4_write_begin() and > ext4_da_write_begin(). When set in the kiocb, the FGP_DONTCACHE bit > is passed to the page cache lookup, preventing written pages from > being retained in the cache. > > Only the handling logic is implemented here; the behavior remains > inactive until ext4 advertises support via FOP_DONTCACHE. > > This change relies on prior patches that refactor the write_begin > interface to use struct kiocb and introduce DONTCACHE handling in ext4. > > Part of a series refactoring address_space_operations write_begin and > write_end callbacks to use struct kiocb for passing write context and > flags. > > Signed-off-by: Taotao Chen Acked-by: Theodore Ts'o