From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E5CC7EE2A for ; Wed, 25 Jun 2025 20:46:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C6C96B00A1; Wed, 25 Jun 2025 16:46:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4765A6B00B4; Wed, 25 Jun 2025 16:46:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 365AA6B00B8; Wed, 25 Jun 2025 16:46:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 21EE86B00A1 for ; Wed, 25 Jun 2025 16:46:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BDCBD160791 for ; Wed, 25 Jun 2025 20:46:56 +0000 (UTC) X-FDA: 83595107232.10.0F2DC11 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 106548000D for ; Wed, 25 Jun 2025 20:46:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oVF8Xpcc; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750884415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2A8WPY/b1osMUB4jbilbJXXVd3djjn+61R3XJTQxXrk=; b=Z3AsfjiWtPlqi4wKq8Ppq9HIeK6zpV9tGuS3aShegOq//YF1kXNR7gkgYMFeNAAu6wcQYz 5/OSq2aPDq/7A1Kx7GRAJvSrOtpEToPCTVguXuqCVc596r9Bxr6mMh04gNTA2X4N/MiEKb yXD4Qo/YTpLp2ygLdEtYdIJgl2p4i2Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oVF8Xpcc; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750884415; a=rsa-sha256; cv=none; b=RroKgMH56SQBY0G29aXeuoa/jRhgWvYEW/FWDLg/TeXfQEQ9XaTBQXHhCEsLv1Nh+tzVwt wGhJg+2d+YJdTh/8BMuM+FpKJmQ549L0PFdf/l5zpkufT+InD8T26w9BpF0eDnMySNsVZT RMR7UFt0WoHKesNkUqESWAqNyPDJC88= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7B2745C4A90; Wed, 25 Jun 2025 20:44:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 568BCC4CEF0; Wed, 25 Jun 2025 20:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750884413; bh=K/l1wB+Ll5z0Rrr61fPVSHVcYgvKnqIg1GCwc9WsXqA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oVF8XpccIvNhd0EcVTboutnMegqMhcbuI0u3d6XUy6xfWTTiXk3S+EQdgLJ0ahUHB ibgWZ7pColS0VatdOP7u68/KM2+2Cxo7p8MGrf3GVZU8LRtGD1JThVgTMS7H+3/4Nl qi9jhlmgoC2co9CDiwPQLVrakTPIF4cOsy+z9SGI= Date: Wed, 25 Jun 2025 13:46:52 -0700 From: Andrew Morton To: "Kasireddy, Vivek" Cc: Anshuman Khandual , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "syzbot+a504cb5bae4fe117ba94@syzkaller.appspotmail.com" , Steve Sistare , Muchun Song , "David Hildenbrand" , Oscar Salvador Subject: Re: [PATCH] mm/hugetlb: Don't crash when allocating a folio if there are no resv Message-Id: <20250625134652.b9184bb34e073bd7cb014844@linux-foundation.org> In-Reply-To: References: <20250618052840.1036164-1-vivek.kasireddy@intel.com> <99b9f7c8-62e0-4500-b4f1-0efdb73bf502@arm.com> <20250618170248.89ff5c3d3fe23233424fd4da@linux-foundation.org> <20250623163546.ddb768e0833f7a19af259a43@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 106548000D X-Stat-Signature: wigxebiwkeo1gtkqfdxf5fm4rbhqkdat X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1750884414-897883 X-HE-Meta: U2FsdGVkX18mLKzCcu8Li1h6OkhUdz6sxXr05mZ30RAK2EBu1Mqst5Eh0pAIVtHyNgrzNuaJ3hOOfXIQTu1eLMvc+wE9OJtfjpVTvyJ4hziI8QKxIRrZ8vPiF8rv2VSPkctdZGoTOPZJGVx98xxN4wtd6PkE1e7uOUAh2DMT07/RnKMYDbT10OcVIceqI5PdziJ9pDsKGIf2wTPiTqkdjh8dcO/22OV8OiRvMQXp52o+3/ld5Y+d4hqOJqwFylALlMq3+UHCG0U+e56RZzCDgIegOsFXrAn4XXcZLqIwOOXA+aAztwaMXadFRSPD2QCzj188e2Jk5anKfmzMbBmPy6JVzmrH/PyRLICs5xmMNKEKNzwZKauE+kj3IrOomFbM0pPFzLHooLPAi91fqnEJ01LFKItx04xOWuOxl84iCETbKjqPzY2SGd9mI6gF1EwyTz8hchFYsh62kuVblTVvR2ABFHG4RKvSXXhnKTlcTXW9ITocSeVVxiCSCCdVdJXtvu7sfWV7MCigZxAqsLbSKazAPA0DBg4lErL310gSy7zzxVvD9QX7o6noMttU+lv6ATA9/IJ+qByek6AtD+Ms/UjmE0soA28GEHrQdrscECvp20B88cNT/45Z2vtOjbcuHMaX5ODhRYc3JPM30QxVKFUMP0gmpSmXziMs38anq7eiDbiZql6ZhPFegWfsXaqZCzq5iLr9t+pJoapPqdIwFJv7ro9antUQf2puHF0IxWE38zkfMHTcb78lkkTtYbSDUdLtBJEBYsl3JcppPCbNNAyENHAawtMpPSHJ3+ituNeVGiEKj7AqDEAntzQ48LVEjBekgZjMIDcYfblIvBII9pIvhTeiP6g/F2U/W+Z0bx4USaAogxmAOQc96aqetowywZymhlXy5HLOYEtcLqACRSmu6RjrbE2GQ7hONZXnov6q4gvMQvdg8u6TtNM9TjgcUFaBL0/DAzzxnEARV2J ab+nhtN0 oj71hnzzzsaiHzzOQK4E6dfNVtd9cG4tMlLsKjqSW9fBaJCBEjcskr4uOasfa7OjZ9GDSfqNBg397nBtg1iFVd4idDSWMu7uJJ649cmMbiUWvGmXk62qgUxYMgOIQH5EWkhCBcFnrPMhYAu4utaOVhAeFimQy2nblxic4kPIXAFLfVPAWmzq7ilVWbDk9Kb4nXVucJHkgjypeinkWJ2fNof6BvpA44q/+/UXonJz1oVgRyn4iLXINLb/2JQe8VyXFYVykz3bHXx0ROtlT8rEfTEd78i1Bu5ozgyMl3Bnj4wryqQIgrxIWx2XM0RUJVFzkTOH7juHSbsXji5Bv/TcYICh+N7HM3JQCcU3Y3xuRZGXeIeqOJ8mmIaSgtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 25 Jun 2025 14:18:28 +0000 "Kasireddy, Vivek" wrote: > > Cool, thanks, I'll paste that into the changelog ;) > > > > So if this code path is rare but expected and normal, should we be > > emitting this warning at all? > I think it would be OK to drop the warning. Otherwise, Syzbot would continue > to flag this issue. OK. Could you please propose such a patch? With a fairly detailed changelog explaining why the warning is bogus? After all, we don't want to be removing our ability to detect a real bug!