From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6722FC7115C for ; Wed, 25 Jun 2025 04:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01A646B00B4; Wed, 25 Jun 2025 00:34:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0B826B00B7; Wed, 25 Jun 2025 00:34:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC1796B00B4; Wed, 25 Jun 2025 00:34:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AFDAE6B00B6 for ; Wed, 25 Jun 2025 00:34:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7EBD01D9777 for ; Wed, 25 Jun 2025 04:34:10 +0000 (UTC) X-FDA: 83592655860.06.1862161 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf05.hostedemail.com (Postfix) with ESMTP id B121A100002 for ; Wed, 25 Jun 2025 04:34:08 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; spf=pass (imf05.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750826049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WqQTdtmJfIpNPJKYwBk0X5UjY+30Zte8xXVtxC4VkSU=; b=yqvL/GieGOUzLV7l8+nn8l7+p+ibKYSQzUNMvbr0thcj1PJFyOaGCj88ulXRL8NapbncG/ jNJ+n3fmJWAaLYi+qrZx9OPFpss8x6alOTm9cLrFrHqRTcumnsaQqUky2UyWDQT0eylPGD j2Oba5Sr+6wcd2VdDNu9JaNesz1cs00= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750826049; a=rsa-sha256; cv=none; b=iLWyYjbOU5p0G554MHsAmZmVS2zQaCtw9Ukfkum38HhvY0bNBYtUFWX4fB5CEgrtLkHtTt CGyerFt4Mkn+Ye5nB9r8dwA7ypVrZUlHXR5jK4ruRnE57YnYGpPBp9fb0K2sVYw6gxVs5V 6V+sQZ3d1UOUwuHLKjyVbiKqdAgmfKE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none X-AuditID: a67dfc5b-669ff7000002311f-1d-685b7c398dd5 From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Subject: [PATCH net-next v7 6/7] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Date: Wed, 25 Jun 2025 13:33:49 +0900 Message-Id: <20250625043350.7939-7-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250625043350.7939-1-byungchul@sk.com> References: <20250625043350.7939-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG++9/ds5xODguy1MSxigKuxpd3uiCWOD/Q0FgUOQHW3lqKy+1 pakUWDqilTNKyrZVM6nMKatlbd2k1kpNo1LUleVipRAzu6zMqV12rMhvD8/7PL/3/fCyWFEu ncxqsvYI2ixVhpKWUbIPkRVzlu5LVc8v+zYBLPYaGmyDeXDpjUsKluobCL6GuhgIehpoqKwY wGB5WkzBN/sQhp5HfgZsjrXgu9hLwZ1DTgz+0kYaSoqHMdwN9TNw0FUlgWc3jFIoG7qAwVn4 hoG2WxYaumt+SaHXXUJBk+kyBT5jIjyyToSB5j4EHrtTAgNHz9BwotVKw9tiH4LWB34KzAeM COz1XikMD4YZ5ofdTOI08qDvIyZ1l19IyE3Ta4ZYHTnkWlU8MXhbMXFUH6aJ48txhrzquEOT xvJhitx0BSWkpKifJp97XlLkY307Tex17RRpsXqYdVGbZMvThQxNrqCdt3KzTG3+1CnZZZTl uX9CIXrNGlAEy3ML+Xp7PTIgdlQbzetEm+Zm8F5vCIs6mkvgg/4GyoBkLOZqad5T08WIg/Gc jnc+bqZETXHT+UBbJRK1PMzRv69j/vDjeNuVe6OgCG4Rb/EXjeYVYqbjAP6Tj+KbTr+jxBtw eLH9rEK0cbhadN2Mxb08V8fyAaPtL3MSf7/KSx1DnGlM3fS/bhpTtyJcjRSarNxMlSZj4Vx1 fpYmb+7W7EwHCv/Lxf0jqS705VmKG3EsUkbK5+s3qRVSVa4uP9ONeBYro+Unl4Qteboqv0DQ ZqdpczIEnRvFspQyRr5gYG+6gtuu2iPsFIRdgvbfVMJGTC5E691lO5N8ntm1gdVbbaqebP6I YXfbtXspLf3Bq2VHvkdlz0puTOoudm77FSuRJ5Po1LPDKwpifUlNieNyY86xi2NelOo7y+3X 15imulJCq+5OuQ2z2isCMxassVm2xOvNHwoq0o4+LY37XDoz+fbItjmntpzfMLF92cYdT4yG Wz9/PFdSOrUqIR5rdarfs7vEXysDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+e//39lxODstqYMRxUiSIlNKfMMQ7UunoPCDdFEiV57aUGds ZrMLaV6ikbOr1DZlYWleYrFMp1jINK9lpWiapjLTbqKWF3RathmR3x6e5/c+7/vhpbHUSXxo pSqJV6vk8TJKTMQHQtK37rwQrQi4kUuDyVJGQemsFooGbUIwlVQgmJrrFcFkfSMFBfdnMJje ZBCYtjgxDDc4RFBq3Q8DhSMEaq5UYnDkNFGQnTGP4fncmAgu2x4JoC6vWQhvK/RCuO18iKEy dVAEHdUmCvrLFoUwYs8m0GwoJjCgD4MG82qYaR1FUG+pFMDMtTwKbrWbKRjKGEDQXucgYEzT I7C86BbC/Kyrw/iyXxTmy9WNjmOuvLhHwFUZPoo4s/UM9/TRZk7X3Y45a8lVirP+vCni+rpq KK7p7jzhqmyTAi47fYzifgx/INz4i06KK/gyIeAs5Z0kQhol3hXLxyuTefW20BixwjjxXnBa L9baf0Mq+kjrEE2zzA5Wb4zQIQ+aYjax3d1z2K29mUB20tFIdEhMY+YxxdaX9YrcwSpGw1a2 tBK3Jowv+72jALm1xNWT+bV8iWGZ9Wzpk9qlIg8miDU50pd4qZvpSsN/+ZVs871PxH0Ddi22 5EvdNnaNpj8z4utIYlhGGf5ThmWUGeES5K1UJSfIlfFB/po4RYpKqfU/kZhgRa6PKLy4cMOG pjr22BFDI5mnJCAzSiEVypM1KQl2xNJY5i3JDXZZklh5yjlenXhMfSae19jRWprI1kj2HeJj pMwpeRIfx/OnefW/VEB7+KSiw1nDO6MOnfDy6iRbvplqrPhBeEXvE+az2dA/Sb/JcfjZYotO hh6duzJIt++OoXKL5QfbDGWRd4YKDTLpyOuO6Ir8ddq+Rac6snp/uIpfrPUfePU7+BTkZ284 ouu1e6c4AzKntu8NXXiX9Gv6eJafNrxlytF26ezG8z2eZ7UhK2REo5AHbsZqjfwPwi3TdA0D AAA= X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B121A100002 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: goatmrf1fp3jrdkocbnkbo45ff6fhn9h X-HE-Tag: 1750826048-223999 X-HE-Meta: U2FsdGVkX1+aqKsaUBWR/Z/85W2/aCAmlZgTO0RBsv/M1Zywxgn0QVJsnsDOoOJ3xs97SMbz3j3liNXGJexEd0UJ57TUFMSGKarLdYkUU7e8b1h8bBErtWysjuc6MsNowcR4FADNlvuDQ/oYiHT95Tp9eRGJRkaIjevDl6sjykdusauoO538RYHezGRkyf9Qeolozv5l88llDgATRdu9n6wPUgrXRU1yvguWYuDQEMfwnXSCrs9t7fsYgoPEakn2DqzVl8rpeENdCexpl4Oe+/ygJmjoihW434YGiDUsJ5wg6+TaRRrv6MvSEztv7//tPgYhxJW2cPQ5Tj+EcvlEUTsGtQ54GHkjbvgCOKsnTRgbpKAOfM5DZ5xdlHuKQJcUkLf2SiAG5MPKa05HlaSTQB3L7aFH+eGL0MkLODRPT8E7J2j0xXjLS/D2/2lfjuKv5cFVMSFu69gJl7kwgMEvxdiBCxRFiH7NZVFhanbnAwn+Wf2z4JG0/RLtGL9wuCLOWi3S2F3sdnFv97BKM4YJfLtRCBP8zJWi4wDDOWPI2fnn4IYDHIAiY4Mt1eHdP4niC+3Kxf9TqUhdO2AkQJUigWvMNhNA6SzZ19JHL1EeB96w+73Y3BNBJDSMF9iRFonABxyqrwpL1aD+nYREMLsVBp2qcvTof3FVLMZzHo6KM/g8pjiFlZ4yrcSDYOVOUvKsE27N6ZIwnSgf/yz5868PZP2R0lxC8azh5i4CmtQ1BKERE79NGYFBsT0gt/2Gi3W4eLwOA8yYRYrEKWxcx/q9KBF6nmEy3Vfobkm4nPSgWTHEQcWL2ykrJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The page pool members in struct page cannot be removed unless it's not allowed to access any of them via struct page. Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but just wrap page_pool_get_dma_addr_netmem() safely. Signed-off-by: Byungchul Park Reviewed-by: Mina Almasry Reviewed-by: Ilias Apalodimas Reviewed-by: Toke Høiland-Jørgensen Reviewed-by: Pavel Begunkov --- include/net/page_pool/helpers.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h index 773fc65780b5..db180626be06 100644 --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -444,12 +444,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) */ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) { - dma_addr_t ret = page->dma_addr; - - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) - ret <<= PAGE_SHIFT; - - return ret; + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); } static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool, -- 2.17.1