From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77BF6C77B7C for ; Wed, 25 Jun 2025 01:11:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDFEC8D0003; Tue, 24 Jun 2025 21:11:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB8248D0001; Tue, 24 Jun 2025 21:11:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF54F8D0003; Tue, 24 Jun 2025 21:11:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C1FB78D0001 for ; Tue, 24 Jun 2025 21:11:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 68F06C13F9 for ; Wed, 25 Jun 2025 01:11:49 +0000 (UTC) X-FDA: 83592145938.13.CC33BBF Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 5F73D140008 for ; Wed, 25 Jun 2025 01:11:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BZI9hCu3; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750813907; a=rsa-sha256; cv=none; b=A/f6GJXM4rwe1+l3xbFNWHM2bdFZJFxiS0hUC68bGd++84/LmZRBaS9t/RFyCNVmfbnQxD z+oZP5uCy8jd6y+Y52Y1Dt5hY6R1PaoradHSK5P5Aa+LvAGUaBJZoy9eHWR6ZtWYfhp5Xz KU0jy3751+Gkm7cWUIWuI+0RIYr544U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BZI9hCu3; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750813907; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3lyY1/4XkISIwcvjIG9xP2V70CKcNPCDYCT6Z7R9Jz0=; b=Ej+Jy0iujBI101artItFVTMd/Cf+kafG7yiU3lFwbJqj8g0+dDPWwe0pzuHIdVse+OsHjh BPse1PFreJpW4YPGDfe/2ISspidKPDrGnbi6HApxuqzFVls0QQl9hNMK/uEb/Zp/FL4YLs WIBCD4YBlsn0MKi4GARgRh8qGWqVktE= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-60700a745e5so11744646a12.3 for ; Tue, 24 Jun 2025 18:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750813905; x=1751418705; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3lyY1/4XkISIwcvjIG9xP2V70CKcNPCDYCT6Z7R9Jz0=; b=BZI9hCu3+T5A8sk251XauzOeC36QyvKTx3TyM2FYXH7qKM+oyp4xzrttnkTy6WJLtv io+cEUVtWTgC5gX+JyPd3QY4OrBJUdloXMHO8EeJSWvA8e9/9MsdH10gIYkKvySDnpsG IWlP7g5UDzLIfmgPj57IkYQhdYMMHW/eW2QmLCY3kBJ+hblpW3gm+GLHT0G7Fmyttebn zqkOzaRoIY6KdR/Z6xa5GXl+8LfnSQrsH4AUru5OgSELBFXMJF33FgYtTQHVc4GVLcpu uFfnbg6TV8vfYJbbpmvnY9mozZpgzsf2100LtK7SFRwZF2xjujTEEt7/f7kvhQhg6/pD P17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750813905; x=1751418705; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3lyY1/4XkISIwcvjIG9xP2V70CKcNPCDYCT6Z7R9Jz0=; b=VE5sPBfw97ho4trowG0/U+ngcWHrmzfqVCgBIPJhASUaognWREW+I4LfNOB+f82VKr OizdGD2br1HzrpE/VxAhi5HLVzUb7yIG7X8kAZTUArObJ/7Yl9wrOC2hpF5TIu5RvSR/ 2y8uaeZI18FCrw6IirVD00LT39UnKVNIdPoF7Ytiq5eN+SRTXGpXSxNsc2lHO0Qrt/xM XCHrYK2xYR6RuwSx4oQDNJyilDbYgDsHEodBg8Du+/gEO+tFK67l5zZDt1lJgCxe0VF/ MVCfamIx3tLQEO3ENTnbNLqZSQJZ9LnPWv1etSPFf4hnMKD1cubKGjactVr0JKF4HcIQ 5efA== X-Forwarded-Encrypted: i=1; AJvYcCXCe1boTdzodjwSdhTiguokG9VCu3P88C4Brotfg66gSTkgxaOSkN5mZwez6SW6rnA1FQe4EJqqqQ==@kvack.org X-Gm-Message-State: AOJu0Yy5enJYSD4YUGMxPOJXU5Bpuowomk8K8xUsOZYI+LXpvC2dDwov 9y/0xfLHPiv7mcyj/fzWy1e6ADeZNyZbK35+fx396SNCU21gOa+9aS2q X-Gm-Gg: ASbGncsFrNARWprBV/oz0fZjgUclsKo4w4GK3Q/fxrfs3bbx19gIK1DAqAzYHUnKMHr 522RmNALo89lKi6mcrFi22AGaYMwi8wMRUtzeWnP99oKuEihRyj4RXQldmDyt8vsum5qoKi60Lo Z40ShwwphJMoBf7gpLBGhbWI6TmFEivEBySXccRjxsSVH605ShthVkZHx1U+w2oV1ZlXDcS5Bnb W8v192/Cu2cuyA+k2zpmxgXsdb06zTa6RitFlKApJUUFa+05D0o1B0X68YJj1yNDcYKT1X2PdtC QOiNm2xe7KnU6ceZfhgg9lvsd0FQvdsWPrQL4qPBsGA74oV+Xdi0FETAi+X39iJb6m800iIJ X-Google-Smtp-Source: AGHT+IFLAmx29NavZbv239W1gzdZmTcw2tAykCTpUwRFpZC1YrPYZxXJIajZ9rR+HIqgWZUKGcmtUQ== X-Received: by 2002:a17:907:cd12:b0:ade:9b52:4da0 with SMTP id a640c23a62f3a-ae0beedec57mr97958166b.60.1750813905241; Tue, 24 Jun 2025 18:11:45 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae0541b75bbsm952860466b.130.2025.06.24.18.11.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jun 2025 18:11:44 -0700 (PDT) Date: Wed, 25 Jun 2025 01:11:44 +0000 From: Wei Yang To: "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wei Yang , kernel test robot Subject: Re: [PATCH 1/2] maple_tree: Fix status setup on restore to active Message-ID: <20250625011144.n7rb3fejm35d33oi@master> Reply-To: Wei Yang References: <20250624154823.52221-1-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250624154823.52221-1-Liam.Howlett@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: egg1wig38bc6qeo7dks6h85oj5dxugzh X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5F73D140008 X-Rspam-User: X-HE-Tag: 1750813907-526147 X-HE-Meta: U2FsdGVkX19/wqFYi8IrbevGmXqmGk45HbZbOTdC1roUZeL0LfFST1NygFRI5H1Dablr2PfTTnv6PrF9+WgvmRpjX38hrTLsKAbdhtvqEPW/rxW8rWyQ9XcBzxzVsVWPYS9dlc3Ewy8ByJHKJRU+yJpiJPSmuNGB+MopifPS284N3b4cLFuX/6NWgwMtoY+kVrDW5cNQEYVWHcFtQpKNJftNPVQx601esuggHmx8tO+HBwTl9zmuScT9/0GATpE0fbqb5vhNQMx5xbhlVwIsFT9IkMyVynAOsGcxHYFM6Xs7AkJb/Za7N1sDw2YvkuHdUgptJYC3V7o1t7gBRQ1Wi69jC3th0raGAtgVYfFBP0Nf6S7pW+FK7rANnbgq6XfF5uqM0nIMVZmGzax9DMjSwXguCYGlDYhfHKD+YqwzwcmJJeLsrmzN8XRRcYQ7M3g93aLhFXH7S9cdq5o04DC+uComVtINzB0brNE2eFchKg7s8HC0t1HnA2+Bo2xKyYOFQSoyM8ehFrQxR7giq0pYHtYZv4MzVwOAyTQ29gJ7+4neFwQWyni/V/Bt6Hn/7CMazhkVmFrVYg1NqLu8sa1JzoYg83AaAzP2iFDjMNCL4ZOrb+/A6yz4shUS8TqgIU7Odvx93hPwSZkvP17x4a1QSE2kH5bdxUtD2tVzJja1wuKnj5qMdZEj76ZRVYCJ5SJqn2ulv1N4QUYhHrv2j+ulgysNeALApRsfqJT7rgmS/ChSkLytPc8jI7WYK89sqTQYK9tOYC+lv3xPfPYfIim1lljN74gRhznv9vUZCEobMpX5FjTeleMF3hOI+8I8rAOBj7/VVE6AqaqpPwjuvmtpH3DWVOMkENVvJxt3d3Me2Q1WvKbocmGd6H9LSCKaw5ijDAqjufExufHszDHqSnm0IMB/Nr7T3b0FXO/ivej56L9jsa9Pu4hx97aU222R5RGDFCaTmybgac5WytVtmwy K94u+hnh eicU6ficnMJMIuTbkKk/EUjHnkgbONEZrub/ZZrlrbzUNpAGtA2kxjqA9TtFUXJJE0p2rY7xuEsAw8ieHXE3o4oDDKvUyjbctBeATuPd9L6dwojIR/qAQme32IoqsajYhnlPle6/FmnZOxOw/M+PSHP9h65Yjgnp8OPElTVsMbRwcoDX9QWZW1Ej/6xvq6qVv1khA4VnYpMitLld78JZUHFAwIOoPW0l1YIaGJmExep6R2ag+vVxCPXijQO7/JDCTbFUoTyJYoKOy+7L0x82yb2QBHG/dHbdgeIYsqXO2vVac/IW2Z3I8FR3xKev8OVKEU23d4QzIEp5+z8ZvymH5PBVgz4COpY/DfKW6ZDS37sF5OjVHMPE0MliPyCfHCdPmXweNAAlIfEjFeyF0B2ZiLtTTG6JiGk3wfA4AkKIsJNw9/wRry+VW1zOz5tLiuf1cfHan1O7oiP9/0q4jA1tcoS/X5UUrtJto2tfZYi+bUzi5fZDweM73uzQ6UydCr8lBXTiqZQrDhsJBH4EiBu4XhmDoOoHEQCEbNoAMUBxOvLQ4XnvIlXSFRWZWMchNvnVsgfzfNyvJoio0h+1YneIu+hfoUyjuCIltxvJD/6usOwmmvwO7G7CRsdbbmqt6tfJLtxy3N50Cc8XHqlbk/ExN5GmA/1gXr0eXc4uZAoYlR2E6VT5fPlupRxabMxLKJOdAStMyBDebLAJQvvENxqZtRPexpW2//MJYgF/3vCslvCj7Uj+Epnx+NsJLLUyUpGVkUtNMZ4HZ+rk3cYCiqWl0yimi4WZCRrkrbbL9m2/XjZD7+ZVRtK8YDs+fCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 11:48:22AM -0400, Liam R. Howlett wrote: >During the initial call with a maple state, an error status may be set >before a valid node is populated into the maple state node. Subsequent >calls with the maple state may restore the state into an active state >with no node set. This was masked by the mas_walk() always resetting >the status to ma_state and result in an extra walk in this rare ^^^ Nit s/ma_state/ma_start/ >scenario. > >Don't restore the state to active unless there is a value in the structs >node. This also allows mas_walk() to be fixed to use the active state >without exposing an issue. > >User visible results are marginal performance improvements when an >active state can be restored and used instead of rewalking the tree. > >Stable is not Cc'ed because the existing code is stable and the >performance gains are not worth the risk. > >Link: https://lore.kernel.org/all/20250611011253.19515-1-richard.weiyang@gmail.com/ >Link: https://lore.kernel.org/all/20250407231354.11771-1-richard.weiyang@gmail.com/ >Link: https://lore.kernel.org/all/202506191556.6bfc7b93-lkp@intel.com/ >Fixes: a8091f039c1e ("maple_tree: add MAS_UNDERFLOW and MAS_OVERFLOW states") >Reported-by: Wei Yang >Reported-by: kernel test robot >Closes: https://lore.kernel.org/oe-lkp/202506191556.6bfc7b93-lkp@intel.com >Signed-off-by: Liam R. Howlett Reviewed-by: Wei Yang -- Wei Yang Help you, Help me