From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382AEC77B7C for ; Tue, 24 Jun 2025 19:34:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87EC26B00B5; Tue, 24 Jun 2025 15:34:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82F586B00B6; Tue, 24 Jun 2025 15:34:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D0086B00B7; Tue, 24 Jun 2025 15:34:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5620C6B00B5 for ; Tue, 24 Jun 2025 15:34:14 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2559280FAD for ; Tue, 24 Jun 2025 19:34:14 +0000 (UTC) X-FDA: 83591295228.20.1AEB424 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf11.hostedemail.com (Postfix) with ESMTP id 589C440012 for ; Tue, 24 Jun 2025 19:34:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FebIuVTk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3s_1aaAYKCGQUWTGPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--surenb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3s_1aaAYKCGQUWTGPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750793652; a=rsa-sha256; cv=none; b=GIAfA06OHTzuHZVSykQuxP+ZA1/44TInlwB6ZnJPANomle3W4VB3Pg3c3Ym4HIbg7OXh8W 8PgqwDm33lZyA/JHY/rLrwnyDF2Iug2uRaQNj/3pQe7cqgHrNXKiQUTa4YNdCIHNEiLAHv fhnoqqoCz9zkf9P7tn9QOymck53K9Js= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FebIuVTk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3s_1aaAYKCGQUWTGPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--surenb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3s_1aaAYKCGQUWTGPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750793652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yLtEbRv6QyxPjsf9LVAPVV2LoLwOWyeMLnVsJ44IjdU=; b=xPULnbQT5CxxynrX6zjroFl86Lx/TV4mr15YMXIzIuqkg6BdXhvFq2wk90NeT3ldWBgvJM /i5DAwQqIYXwtex5lUE+lkmbu+9/oIyUBb1rRsuaiCmQK2Wr3AEsZTa+MbzfKAOBOm/vVv 9OyPRoCSD8pqhj1oZQwE69/GSPr0nMU= Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-b34abbcdcf3so332674a12.1 for ; Tue, 24 Jun 2025 12:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750793651; x=1751398451; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yLtEbRv6QyxPjsf9LVAPVV2LoLwOWyeMLnVsJ44IjdU=; b=FebIuVTkbEnw8JcpqTBugWH1Gf+QMRmb8QbsDBMyyTMgtr3Dyt5IkgXi5OdImIG4ET Kskxla4S6snkVir3HLrejF5oKv1yHTK++hi3pwpYEhnHKl9E8NizM3ay1u4Im/a9ySkI xjIsjThrjcNuehZqyLtIrk0Nk2hB3w015F7/+HP6UzQpS0vV4d79Jcv8VPKGo90mf2BZ gcQMcScmTqU1m/eNmHMF4nyjnWPFmynqDT9od7jPQExEzE/M4pdBfWzTa3HeHP9Qy/M8 3BhJL8qqrMA9z/j2FthrSZcke0FIwVzGZUmyeeaLaAtEBT6JAuArBhBNjn6Xy+kJgay2 EJoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750793651; x=1751398451; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yLtEbRv6QyxPjsf9LVAPVV2LoLwOWyeMLnVsJ44IjdU=; b=Cku2bQj8j0LiLoAATqvmy33lI4nraQlzFvi1gtfxMHOO3WvJGLOZlqWiUQ1r10c75q kfDHJ3P594IrcXutzNSqmmE1eDRokan9Vq1g/bqMK9l0MBl+cmMrsQ3paC4z7hPKxRa3 ifB642ZVB0oxsqbNzjFfKGGJz0udNbmvFmWKXMRGwUqTTJDPWuivnes1xnzysd93q8Bv 3PIwfpm0mav9JYqosqav+16fciooo62yAXXVk9kdG4xAX/TUg9H2VeBZ4to+g9ma8D4u m48jyf5K6EOrH3AndffI3J8/6+M0O9Ium5CeOw4jGurXUwnEV7LVYdedg9SNSWuRWAkl X0dQ== X-Forwarded-Encrypted: i=1; AJvYcCUT+lsSBOSvYioIpTBufY7uwCfRrJMVpZRfiVgdy6xyAxsJDfhmPdB67UKGKdgha/BmV9yHavl9ag==@kvack.org X-Gm-Message-State: AOJu0YwFRfhX6n9ZCMn8UyKruenF+D/NsWE0Aq0XAkc37rEc12vl4ieH OwiIsC6wkgJA1whodz83Gg3aTD6glAkndNIAIC5OaWj4GUtq7tAxxHeLF3QlshV0lLkgKLPoUqb vgV9NqQ== X-Google-Smtp-Source: AGHT+IHClWuGmDdB+MsMxoQpT43VMdFBAo96rsx+K87NYCqHXT7J+KynqmIRFatckh9qdl8zl/G773J5x/U= X-Received: from pgww20.prod.google.com ([2002:a05:6a02:2c94:b0:b2c:3d70:9c1]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:9d8e:b0:215:e43a:29b9 with SMTP id adf61e73a8af0-2207f2a49ddmr205722637.33.1750793651161; Tue, 24 Jun 2025 12:34:11 -0700 (PDT) Date: Tue, 24 Jun 2025 12:33:56 -0700 In-Reply-To: <20250624193359.3865351-1-surenb@google.com> Mime-Version: 1.0 References: <20250624193359.3865351-1-surenb@google.com> X-Mailer: git-send-email 2.50.0.714.g196bf9f422-goog Message-ID: <20250624193359.3865351-5-surenb@google.com> Subject: [PATCH v5 4/7] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: 83nmx1brz68j1fpye64ybenznbkntrzg X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 589C440012 X-HE-Tag: 1750793652-77558 X-HE-Meta: U2FsdGVkX1/qRkLgjZublOVfUc2OBR/7cw0YquDj5LPiW6H7iZLCWaDfm7rxw7WWlej1NgIN2wJ2RltwqjFO9B+LggI6Ch9k+bqf9bQybumweizb0DvSPdBpVFpQWpLAu+JaMIkXWJfENu6qZY46AvMMLYum3prsCc/3KIiIqbIDVi/OQVBhOEWxCHTxwsvICGaNDoLTUdxHCwz1kRl3G9AFTqvx9wdTEYuWhsFYEeuS5bBRyjwo2J59OM1/snckah8FbaW/PACSMUraUxBDMWeKffobp+jz+3dx4kyuOdD0weqEgAujArkons9SfJlBA0CVjWdJ9emlbpBDOpaH+cLgeTuQYwFS4Tfm2CPkcRgpIpddzkNrDBmMuSAMlp8k9Vs+0HpWqkkYl/yH/+aDevulSSn8aclOZki5IJeaziB2Nm1ytepfhNac/SnsjI5MTwIVZKsGZcEFUHR4cm5zXZ6N+6GcNjJ1d99fLaelW68CKps9GvkCzhGswb1a+JKjhqoKTJRFurYGwrqjyXrmJgCh9LoHm/LqiCjlwI5kX8J3L5QCRKKGPbW9Z//JSTIrl5el4DaRzA3Te0Eb8HKQGcwZTikQa3f5zQ/NnqcFuNqQJBStBMC5Amqc0c4YC8Ahgo+rz/OuFoJM/MOJJ7nejpWOdX6cIJ1CqPEQCZtVKNNvQLBO8QvP2Phmiirt+HVFevsRQCi3UpAUy20lKX1HttOCXaJ1Mk4jfHR68NP48ZNRwkOqRVsJGd/hwijYAkbAf/ABWT4ArFzNauRmDc5RFqQBV3dO3gKvQM51VDTbPoSBzHTcn3JVrHuFWVYVc4eecbjqKqSM73CMvJZfT7Z7X3izrOaDF/NUNxfEgX7LZIEA0860Pdvh6uh+YhXtf8zAMt+irGAFKd8CXcw02lldxsD3BnQzZ1Kv73c5XhxaNLMBqcqEyU0NbVtwhROr/GCerH8GXy/EgOmjdPrPGUe yNdfRmRq d6k3gnynNnE9LQwuBP+9FCp0qBBBt3tWJmx9BHTo+dZtN/SMpP6qmP4GawceHZRF5mia4VmyEAxEszLzpJJqpawBYfsqj30hLg36PlJQFlx5xvYOLDni1PVbBq2w7XO671mXe7YpLtZ+OnGWTujBb6tD7JqVTeM7Vs9xDJVPyjsA4C7Mt7l0UeCfrd24OA4fBCR5PDs1GmoIZje7cLIIYkWI2WxeF8mOR2WrHEmjEBasr8dHFMz0OjmvJ85uMgJVguTYwImbI/cVCxliKNESzISPE/0KCCC7Y2eouiwIUwZLwrd3i2FijzRr9rzAw3yOyb+Tnq1yRST1PV4PO//idxwSMI8scZYyWg+Wj1hqj2Gf4vnYkGElSWMse9QjQw/Cl/AYRHWQB3WQUaDfv5T2HMr72qveRO1tmYFv63vyTPoP1KN1zAfIsUB+lc0uMUBfZPABz6nB0pyxkmZzKT1WxPl9DEJb0B/qZa6SJlwRy5rz2tykhd3Rtsj0Ozqs/w1h/XA2pDKIe73Fn8+cwwXh6J8USJ8/duOocw8f7pCVZ9Qw9wN5rKFCo19OWaZ4fTd1Ltf1s9jneYZ93eM70l9OIeSUxg2wi+Wzj8oIUXxRRIxPQtXPzqFyQhkmM5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Extend /proc/pid/maps tearing test to verify PROCMAP_QUERY ioctl operation correctness while the vma is being concurrently modified. Signed-off-by: Suren Baghdasaryan --- tools/testing/selftests/proc/proc-pid-vm.c | 60 ++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/tools/testing/selftests/proc/proc-pid-vm.c b/tools/testing/selftests/proc/proc-pid-vm.c index 1aef2db7e893..b582f40851fb 100644 --- a/tools/testing/selftests/proc/proc-pid-vm.c +++ b/tools/testing/selftests/proc/proc-pid-vm.c @@ -486,6 +486,21 @@ static void capture_mod_pattern(int maps_fd, assert(strcmp(restored_first_line->text, first_line->text) == 0); } +static void query_addr_at(int maps_fd, void *addr, + unsigned long *vma_start, unsigned long *vma_end) +{ + struct procmap_query q; + + memset(&q, 0, sizeof(q)); + q.size = sizeof(q); + /* Find the VMA at the split address */ + q.query_addr = (unsigned long long)addr; + q.query_flags = 0; + assert(!ioctl(maps_fd, PROCMAP_QUERY, &q)); + *vma_start = q.vma_start; + *vma_end = q.vma_end; +} + static inline void split_vma(const struct vma_modifier_info *mod_info) { assert(mmap(mod_info->addr, page_size, mod_info->prot | PROT_EXEC, @@ -546,6 +561,8 @@ static void test_maps_tearing_from_split(int maps_fd, do { bool last_line_changed; bool first_line_changed; + unsigned long vma_start; + unsigned long vma_end; read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); @@ -576,6 +593,19 @@ static void test_maps_tearing_from_split(int maps_fd, first_line_changed = strcmp(new_first_line.text, first_line->text) != 0; assert(last_line_changed == first_line_changed); + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, + &vma_start, &vma_end); + /* + * The vma at the split address can be either the same as + * original one (if read before the split) or the same as the + * first line in the second page (if read after the split). + */ + assert((vma_start == last_line->start_addr && + vma_end == last_line->end_addr) || + (vma_start == split_first_line.start_addr && + vma_end == split_first_line.end_addr)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -637,6 +667,9 @@ static void test_maps_tearing_from_resize(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after shrinking it */ @@ -656,6 +689,17 @@ static void test_maps_tearing_from_resize(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr, &vma_start, &vma_end); + /* + * The vma should stay at the same address and have either the + * original size of 3 pages or 1 page if read after shrinking. + */ + assert(vma_start == last_line->start_addr && + (vma_end - vma_start == page_size * 3 || + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -726,6 +770,9 @@ static void test_maps_tearing_from_remap(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after remapping it */ @@ -745,6 +792,19 @@ static void test_maps_tearing_from_remap(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, &vma_start, &vma_end); + /* + * The vma should either stay at the same address and have the + * original size of 3 pages or we should find the remapped vma + * at the remap destination address with size of 1 page. + */ + assert((vma_start == last_line->start_addr && + vma_end - vma_start == page_size * 3) || + (vma_start == last_line->start_addr + page_size && + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); -- 2.50.0.714.g196bf9f422-goog