From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3430C77B7F for ; Tue, 24 Jun 2025 15:51:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35B016B00BF; Tue, 24 Jun 2025 11:51:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30AF76B00C0; Tue, 24 Jun 2025 11:51:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FAAF6B00C2; Tue, 24 Jun 2025 11:51:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B5826B00BF for ; Tue, 24 Jun 2025 11:51:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 79BA9140C2B for ; Tue, 24 Jun 2025 15:51:50 +0000 (UTC) X-FDA: 83590734780.08.A2DCFA5 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf19.hostedemail.com (Postfix) with ESMTP id 8407D1A000F for ; Tue, 24 Jun 2025 15:51:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750780308; a=rsa-sha256; cv=none; b=vkIZkxIrhNaGIVWU+dn0s7Niv1rC7pilzxfHLfv1LElo5xQvPEK71i2d5IkfjQPyim48A/ BhQYpgzPsNvEazs6bA3NowxzvMHUK2bgjlDEvs4ctHZWomtlSZopkA2CnQOPo1IlPqCvvG uskHc/IW3OBw+JeRqroP2ahaO+4f1Qk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750780308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Idml5fJ4A2/YF53oxD5PVExkb/KhlNWhIcLUgTblqn4=; b=UoiMtf6QXF9+pnlyBlOoRjPlXvR5qaO40myIkIR6/iteNxrqXlk+3QZ0GgjHzXGz3jbrfQ t9hPfg3uqtJekTfoDK+tFILnBKDsb1E8JpFzt550sdBbLCcAL3RyF7qdzGTH+NBGRrHYZz ymRAKA7EvEQ0N2gmi3g/e61M+mtHSyc= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bRTvB4BR1z6GDsx; Tue, 24 Jun 2025 23:51:02 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id EBFF51400E3; Tue, 24 Jun 2025 23:51:46 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.19.247) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 24 Jun 2025 17:51:46 +0200 From: Jonathan Cameron To: Catalin Marinas , , , , , , , , Will Deacon , Dan Williams , Davidlohr Bueso CC: Yicong Yang , , Yushan Wang , Lorenzo Pieralisi , Mark Rutland , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , , H Peter Anvin , Andy Lutomirski , Peter Zijlstra Subject: [RFC v2 7/8] acpi: PoC of Cache control via ACPI0019 and _DSM Date: Tue, 24 Jun 2025 16:48:03 +0100 Message-ID: <20250624154805.66985-8-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250624154805.66985-1-Jonathan.Cameron@huawei.com> References: <20250624154805.66985-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8407D1A000F X-Stat-Signature: dkfixxjq9qn1s7n3xyszozeoddnzkwtf X-Rspam-User: X-HE-Tag: 1750780308-606269 X-HE-Meta: U2FsdGVkX1/H2kVlhYL4W19hrVofU/ExFdfZBM5HKwCpPH1KvLOZ9VQcZdbmGo6HMZs2nUeuBNmvl6juj8ATLQH9aJaqLw7rOKrq58hs061K3d3G8h1Q+uBLViE/o+LJG0xswZZrCilQX3Jb0dD+MDwATggcmlaV25UJfTUQZkq2GKSuVgBg/pF17YZClBnY2WTvpdK2E0nD1ozU8nLH5P2d/ytPDtqHAEpz0YU8UMw1pEr+BsW5ZFS24p7C9Jog8pdpUjtrBFrWgB+OdrHQZgzR68a0J2kYCV0uZ1ZIt/K9tUzaW6PXzxoYJoPsEI/A3xuwxS+e/JG19s5XpxjLBzARgCjPNsoVq/sDWRuRfXfnZx4ruMdKTl1IT/7bNoQuRhQw9IaIfH/LiRr6cxDHndE2YRPXpM/Pg99oByWmU1EgXqLDfyPZvzA2VhfmEm/91LNLRfh0j3Bg90V5DLczqXEauft2/tjPp2Ws6P2+GwLSm8oEKlH9q5M+CQUe/MHXiMiK3W+PzSKb196YMWIIGsPQfPT5pBXnA4jJb+sSa6FKZneMplfQgGLoG6GzHKjnYttOeSnnAtr/Gl27q6tXXSwwgTFVMHjMZf9DHLh2A+gVeOILAAsW164kXREzok/G68iWj5TDlY4X2noO6DrPVKcv0YqNGvKB6IoqFwhCs3o9ihltDyDYhabIC0N4f1Xs0kmbYqK3IpPJH9wEbFLlwCfmxzO8Mq3fnJLOF6XqRebcn1Y04RpSxfAH2LzwdhA8TDXSpKCIEdOsRUYjisa9Odv2xKoVPFAuM13UX1IXkgV5N8BxVq/FJoISErMrgzpZv0A06ebOB3JRy9lbxTkOh+qm64rbyqpezo2grkafI18lAbbR2+YFklKisz+CLZFHzD/9NVnMiem4AthTjgY9ZfmKE0Puq4Mm0qhl3rJGLTIaejg5/1b5h9vcbzqFrBvvAMQ2Jyt9UsC6fNlgdkW QIv0xPqG Y7jl0I+xFyOA4GUbwgx/Z6JXBW3IsQJn7NMAB4EtqGl1x6qw84rSdVCt0HNb+JowsqFc09iP/dbqn546Q2KpxYuYTEs+YC7DyfVv38qdrikgxopzfRgqqW0U4apSH1WwGdRDVgZNPLoKDwIuj4z00YZyzWQwGYwRt8gS1gVjib6mu2FAZWhoeH2buguL0dkfFO3a6MLf7tmGA1We7/aoIdPTd5TKofFbItG4ePek1aPhMGALaZ6Idlvz6z8+Or9lhogWRps9FaaDRuwLyGcmHMt2GO9L9rK6BKbkC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Do not merge. This is the bare outline of what may become an ACPI code first specification proposal. For that reason it remains an RFC and is mainly here to show that the framework is flexible enough to be useful by providing a second driver. >From various discussions, it has become clear that there is some desire not to end up needing a cache flushing driver for every host that supports the flush by PA range functionality that is needed for CXL and similar disagregated memory pools where the host PA mapping to actual memory may change over time and where various races can occur with prefetchers making it hard to use CPU instructions to flush all stale data out. There was once an ARM PSCI specification [1] that defined a firmware interface to solve this problem. However that meant dropping into a more privileged mode, or chatting to an external firmware. That was overkill for those systems that provide a simple MMIO register interface for these operations. That specification never made it beyond alpha level. For the typical class of machine that actually uses these disaggregated pools, ACPI can potentially provide the same benefits with a great deal more flexibility. A _DSM in DSDT via operation regions, may be used to do any of: 1) Make firmware calls 2) Operate a register based state machine. 3) Most other things you might dream of. This was prototyped against an implementation of the ARM specification in [1] wrapped up in _DSM magic. That was chosen to give a second (be it abandoned) example of how this cache control class can be used. Link: https://developer.arm.com/documentation/den0022/falp1/?lang=en [1] Signed-off-by: Jonathan Cameron --- drivers/cache/Kconfig | 7 ++ drivers/cache/Makefile | 1 + drivers/cache/acpi_cache_control.c | 152 +++++++++++++++++++++++++++++ 3 files changed, 160 insertions(+) diff --git a/drivers/cache/Kconfig b/drivers/cache/Kconfig index 0ed87f25bd69..e4c4ebb01135 100644 --- a/drivers/cache/Kconfig +++ b/drivers/cache/Kconfig @@ -12,6 +12,13 @@ config CACHE_COHERENCY_SUBSYSTEM if CACHE_COHERENCY_SUBSYSTEM +config ACPI_CACHE_CONTROL + tristate "ACPI cache maintenance" + depends on ARM64 && ACPI + help + ACPI0019 device ID in DSDT identifies an interface that may be used + to carry out certain forms of cache flush operation. + config HISI_SOC_HHA tristate "HiSilicon Hydra Home Agent (HHA) device driver" depends on (ARM64 && ACPI) || COMPILE_TEST diff --git a/drivers/cache/Makefile b/drivers/cache/Makefile index dfc98273ff09..f770bb1f314f 100644 --- a/drivers/cache/Makefile +++ b/drivers/cache/Makefile @@ -5,4 +5,5 @@ obj-$(CONFIG_SIFIVE_CCACHE) += sifive_ccache.o obj-$(CONFIG_STARFIVE_STARLINK_CACHE) += starfive_starlink_cache.o obj-$(CONFIG_CACHE_COHERENCY_SUBSYSTEM) += coherency_core.o +obj-$(CONFIG_ACPI_CACHE_CONTROL) += acpi_cache_control.o obj-$(CONFIG_HISI_SOC_HHA) += hisi_soc_hha.o diff --git a/drivers/cache/acpi_cache_control.c b/drivers/cache/acpi_cache_control.c new file mode 100644 index 000000000000..563afff37df0 --- /dev/null +++ b/drivers/cache/acpi_cache_control.c @@ -0,0 +1,152 @@ + +#include +#include +#include + +struct acpi_cache_control { + struct cache_coherency_device ccd; + /* Stuff */ +}; + +static const guid_t testguid = + GUID_INIT(0x61FDC7D5, 0x1468, 0x4807, + 0xB5, 0x65, 0x51, 0x5B, 0xF6, 0xB7, 0x53, 0x19); + +static int acpi_cache_control_query(struct acpi_device *device) +{ + union acpi_object *out_obj; + + out_obj = acpi_evaluate_dsm(device->handle, &testguid, 1, 1, NULL);//&in_obj); + if (out_obj->package.count < 4) { + printk("Only partial capabilities received\n"); + return -EINVAL; + } + for (int i = 0; i < out_obj->package.count; i++) + if (out_obj->package.elements[i].type != 1) { + printk("Element %d not integer\n", i); + return -EINVAL; + } + switch (out_obj->package.elements[0].integer.value) { + case 0: + printk("Supports range\n"); + break; + case 1: + printk("Full flush only\n"); + break; + default: + printk("unknown op type %llx\n", + out_obj->package.elements[0].integer.value); + break; + } + + printk("Latency is %lld msecs\n", + out_obj->package.elements[1].integer.value); + printk("Min delay between calls is %lld msecs\n", + out_obj->package.elements[2].integer.value); + + if (out_obj->package.elements[3].integer.value & BIT(0)) + printk("CLEAN_INVALIDATE\n"); + if (out_obj->package.elements[3].integer.value & BIT(1)) + printk("CLEAN\n"); + if (out_obj->package.elements[3].integer.value & BIT(2)) + printk("INVALIDATE\n"); + ACPI_FREE(out_obj); + return 0; +} + +static int acpi_cache_control_inval(struct acpi_device *device, u64 base, u64 size) +{ + union acpi_object *out_obj; + union acpi_object in_array[] = { + [0].integer = { ACPI_TYPE_INTEGER, base }, + [1].integer = { ACPI_TYPE_INTEGER, size }, + [2].integer = { ACPI_TYPE_INTEGER, 0 }, // Clean invalidate + }; + union acpi_object in_obj = { + .package = { + .type = ACPI_TYPE_PACKAGE, + .count = ARRAY_SIZE(in_array), + .elements = in_array, + }, + }; + + out_obj = acpi_evaluate_dsm(device->handle, &testguid, 1, 2, &in_obj); + ACPI_FREE(out_obj); + return 0; +} + +static int acpi_cc_wbinv(struct cache_coherency_device *ccd, + struct cc_inval_params *invp) +{ + struct acpi_device *acpi_dev = + container_of(ccd->parent, struct acpi_device, dev); + + return acpi_cache_control_inval(acpi_dev, invp->addr, invp->size); +} + +static int acpi_cc_done(struct cache_coherency_device *ccd) +{ + /* Todo */ + return 0; +} + +static const struct coherency_ops acpi_cc_ops = { + .wbinv = acpi_cc_wbinv, + .done = acpi_cc_done, +}; + +static int acpi_cache_control_add(struct acpi_device *device) +{ + struct acpi_cache_control *acpi_cc; + int ret; + + ret = acpi_cache_control_query(device); + if (ret) + return ret; + + acpi_cc = (struct acpi_cache_control *) + cache_coherency_alloc_device(&device->dev, &acpi_cc_ops, + sizeof(*acpi_cc)); + if (!acpi_cc) + return -ENOMEM; + + ret = cache_coherency_device_register(&acpi_cc->ccd); + if (ret) { + cache_coherency_device_free(&acpi_cc->ccd); + return ret; + } + + dev_set_drvdata(&device->dev, acpi_cc); + return 0; +} + +static void acpi_cache_control_del(struct acpi_device *device) +{ + struct acpi_cache_control *acpi_cc = dev_get_drvdata(&device->dev); + + cache_coherency_device_unregister(&acpi_cc->ccd); + cache_coherency_device_free(&acpi_cc->ccd); +} + +static const struct acpi_device_id acpi_cache_control_ids[] = { + { "ACPI0019" }, + { } +}; + +MODULE_DEVICE_TABLE(acpi, acpi_cache_control_ids); + +static struct acpi_driver acpi_cache_control_driver = { + .name = "acpi_cache_control", + .ids = acpi_cache_control_ids, + .ops = { + .add = acpi_cache_control_add, + .remove = acpi_cache_control_del, + }, +}; + +module_acpi_driver(acpi_cache_control_driver); + +MODULE_IMPORT_NS("CACHE_COHERENCY"); +MODULE_AUTHOR("Jonathan Cameron "); +MODULE_DESCRIPTION("HACKS HACKS HACKS"); +MODULE_LICENSE("GPL"); -- 2.48.1