From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0522C77B7F for ; Tue, 24 Jun 2025 15:29:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EC256B00B2; Tue, 24 Jun 2025 11:29:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C3266B00B3; Tue, 24 Jun 2025 11:29:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D8856B00B5; Tue, 24 Jun 2025 11:29:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 597A36B00B2 for ; Tue, 24 Jun 2025 11:29:06 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E0CC710498D for ; Tue, 24 Jun 2025 15:29:05 +0000 (UTC) X-FDA: 83590677450.15.0E8F174 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf30.hostedemail.com (Postfix) with ESMTP id E88D180014 for ; Tue, 24 Jun 2025 15:29:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KelxkUyD; spf=pass (imf30.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750778944; a=rsa-sha256; cv=none; b=4S4wmw4XoQSMDgrqm99KHTBhYmZ7z5dRNPEmPZq8SBg02bskq+7eCNcVHiSBBAXTV+Gk+n JuEq98F560CqZ+weKDD+z0H35aUvKjaXpxfF4K3RJNabaOpl8zzH/Fn6Gqb4RvTf1IE91E HC+KmX/V7ajzlcty9AC/j6kR52pq2ek= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KelxkUyD; spf=pass (imf30.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750778944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5HKZOMizjC+LML2kgDOmX49x7zP8t7J7YW3XavcrCNs=; b=2sWwbzndmCqlF/e8fXTVMlhK/YTWJOjFjwu8M5d0drAOVtt332V3xWeoDL+grLHEBe0RqU C61DBBsMGSXHnCre02G6atRsvVtpbuHzrufFxxdLeOD4zOCtpJu46BBLkz/EZ7QB8Pg2+1 VprNxRvpdCQvgfBAI4ewuCfTxIB4hK0= Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a5257748e1so3679334f8f.2 for ; Tue, 24 Jun 2025 08:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750778942; x=1751383742; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5HKZOMizjC+LML2kgDOmX49x7zP8t7J7YW3XavcrCNs=; b=KelxkUyDdnv3mmGZXQeTpb2kjOUpBgBSS0z09Iw+YX5cy8CKMuILJr8IrUBXI2tylU SEEiuqcxa9AKlAxOTLxDTrW9ucClx3calSmuzjpaxru+SjEjM6GoEux97ABe6+18/FrG 7UqhSGuqLGriwgMw6Op/4y879VAxKAyEUp2D8V59ug4NroJrjz4hxkUCJf858jJm+IVn L6SBoGcetVZWYK+vchNpmnGViqEiSGHD2kJHNiN3fb94kcE9IZA9nGXNpmhbzsiaWARw W6iDgsX+L/uoY9WB3QFM0wj4eSAX6rsOTCQob939de5NwN/gYPekWC6J3V+wJ7eeSgrA k7WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750778942; x=1751383742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HKZOMizjC+LML2kgDOmX49x7zP8t7J7YW3XavcrCNs=; b=GNrb1JlQo6LlWTfrZok/yNX7XYEwqvajmy2zXf7U10tY8fM8OaaaldRlWH4pMhDXwN KOd8P5qwT1f3obk140fjmBmAQVVxDuTFvrkxPuZ/g2drSimSRIUke44XIryKriid2oCF g9nog8jH3iXeZVr3PMDxZbpuBr75bXyAa66iHwpIiXjrw8hW5+n/c6JMp9J2L3ZUeqGS /l9M046Q7K2Flcc9W5bzqcU1n6Oabu7tFgKO1BuHSo40cCPnQo4Ktcl8gpy3kTVjVfDZ ziYogito08xROOngbiWwR6byaofsgPMHg2qq4FVqbkpHJs7284e//bWR9dPUtgwv5FAW UrAw== X-Forwarded-Encrypted: i=1; AJvYcCV9BlNZKToTXqJb/nV5JWat6OMCLrQGpR3nRJRe8X+Ewy7lNLVqf0LH6fcis078qwUe7tN9uX55lQ==@kvack.org X-Gm-Message-State: AOJu0Yy8vRsSM2Af3swP7JlNvtyZWJ5WCHsVXxWtCvDf4+T95o349ZG/ kwDrUW3ZD3ElPfJd6rM5TXMMjL3C0tR+42CafUqrUoSCt6BZSqcBPbMD X-Gm-Gg: ASbGncvK57wVM42hLvv2MnF7eKz54ncqYUz7nPPtt7nP+Psl9kswbuTbBHTKAP+emEr 5QWpFUopKh6OJus+UA8FmaVYi2UjzbytoTVd4ukSfVXF6KASMwjXanQB27vV2B69e6yZmkjNXYM YWeQF2smYu4kO49tJu6RY0MO+eWupmBX1x3iy9D0omiwnqbW/De+tcby9ywsH4SVh2jE1M1duLd bzamW7pAClOjkaMgJSPXizJ6IneMjhphiZZf/fkTjDPRSaZ0CvE4c5OdL/svTt4ltAv/QrhK0vn p8DBrvRQhSJoKKoZBa7sLTRrKiKSraBY/YH+HLqoGO+1THqpTC32E1yvSCgL X-Google-Smtp-Source: AGHT+IGcrYUCG4zfszj6fg/blm8ReRuQCCQCBeOsqMPtqwdTWUylx1xgbwj//MHlp30gYyOjSUtesw== X-Received: by 2002:a05:6000:178f:b0:3a5:2257:17b4 with SMTP id ffacd0b85a97d-3a6d1319d72mr16109499f8f.55.1750778942035; Tue, 24 Jun 2025 08:29:02 -0700 (PDT) Received: from localhost.localdomain ([2a09:0:1:2::305a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e80f2977sm2272345f8f.63.2025.06.24.08.28.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 24 Jun 2025 08:29:01 -0700 (PDT) From: Lance Yang To: david@redhat.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, ioworker0@gmail.com, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation Date: Tue, 24 Jun 2025 23:26:54 +0800 Message-ID: <20250624152654.38145-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: e13nzogxuohmo1hh1tey79m5woporar7 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E88D180014 X-Rspam-User: X-HE-Tag: 1750778943-528504 X-HE-Meta: U2FsdGVkX19nmrG8kOMp2H0XLhs0NcpGQfhhzihczglce/oFw88kYcVrshjFwjJw5CJdqYhqWjS+EMt1TdKoLJ/qe9NTYoAbWyEuKUTfhBmqacAH5FJ0tNXc/T6UEvjEi1e4Sq5w8PP1GMYP12/lCiZngvjz7yTpUkfzFkqUa2YCDgmHP67qYSDd12uZOXX2cPSqDAxInV4074vyWcV4CnhfPgimdaqBndG3CxOh4Yi+9M1gmvXOcBYFuQjwq/kT0Ix3vH+PnRUoYTfAkoWDcYBzJNM1Gf9uiR0B1EE4bqt69e+Ka/qF6Vb4fpIQNrOo3UWDGf1WBWACU0lcf/i34WATwGPYUwGXErmG9a9bpskh7HwskWTPRjmj7hEBwhBNXrw71vsukq/85UNKWRdfZCYbWZS4cjfe00QI9Lh7u4rsv4IcbwNPhTO7j05PkGzZ2K4fxiYaTzZOSYRfDkIiSfZ4+qIQH/YFkxi7ZxgMfFOW8ZoZl7h3wmaXQvxiD5po3q/QNRQu/48Aepm3aof98hnnlPpRSw+1YCwEa9MvvVoVs9Xyk/B6MQNrEfEoGL1nS+b9sH61bSvLYJgNL2iLepVEyjer0Y9z1A8eq9s4B1SEc9AprKVi/NivPRAnUc5bFVznMifFOPelN47jjAIx/+BhChcqwdShViCdVvCUSU1FEkA8qvSP6dJYnTytX2FHSfPBsa1PhYWKAJ4zrtxbVgBPWy7ztlkFwMq+hru/xzYdowvSJgI/vpFLlagJ7n61ORJX73W9njQjPqpW0++44fqzZR3hzPjQIns4d0aaqOObl7Ps+6R3NN5mfo2HKrFW7gshJ5+hIYUsNquJPzaw+L2PJqcue5G5E8xllL0oLqryG6htAcx3axLnBIwmPiNewX035UZlvfFba2nOdFv48HFkgW2Ty9VO9KHAuFtvB5o+lBSVZeEEQKG+NS9AYt79Ae6UPTJ4of9rw1xoKt+ N1vy2rGk 7Da8AJZVfqvGqFmqHdy6297R50m0dW/hrqMXj4B3WS6eSTrvOEIEbJEs9S5EWy8GzIGv6abaXhahI33VXzqXKcnR7lsFfPuU3HG6D1RqnFC9sfgNfTLbP+1H+eHZLGC0WXu2zy5xZ2MomTtwJyNtEhTemCXJrEp3FbSUW9VTY+GUHuxs26XPvVDGjx788AoxZj/3RFvAMjP+XKRl4bIPdUxFBoCexcTfV2DYYSBSMd78y7yXD0CGcRwGHPFPv+qsgDm8Vvtdnm8JK+r+Eahfc3ZOqmDjpE+262HLqxzFsIKeK7bXFKyR47Y/+A/AftS7es96nFr21CpCZ7fv+dZ6M42Rl4Uevw8wq42BIoH1Rp28x9h6UtZ5iOo0qofIAn3mrWKhix4xE50ZLkdJiL2jxFw9rVhCR6iqLBljZVc9ZNY61heQb0TEUQZzY/rNGymvNdOc62jMBDLOKU8Kptqlr1In1YGWnpby6JFh2Gq/pcwLIZQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/24 20:55, David Hildenbrand wrote: > On 14.02.25 10:30, Barry Song wrote: >> From: Barry Song [...] >> diff --git a/mm/rmap.c b/mm/rmap.c >> index 89e51a7a9509..8786704bd466 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1781,6 +1781,25 @@ void folio_remove_rmap_pud(struct folio *folio, >> struct page *page, >> #endif >> } >> +/* We support batch unmapping of PTEs for lazyfree large folios */ >> +static inline bool can_batch_unmap_folio_ptes(unsigned long addr, >> + struct folio *folio, pte_t *ptep) >> +{ >> + const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >> + int max_nr = folio_nr_pages(folio); > > Let's assume we have the first page of a folio mapped at the last page > table entry in our page table. Good point. I'm curious if it is something we've seen in practice ;) > > What prevents folio_pte_batch() from reading outside the page table? Assuming such a scenario is possible, to prevent any chance of an out-of-bounds read, how about this change: diff --git a/mm/rmap.c b/mm/rmap.c index fb63d9256f09..9aeae811a38b 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1852,6 +1852,25 @@ static inline bool can_batch_unmap_folio_ptes(unsigned long addr, const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; int max_nr = folio_nr_pages(folio); pte_t pte = ptep_get(ptep); + unsigned long end_addr; + + /* + * To batch unmap, the entire folio's PTEs must be contiguous + * and mapped within the same PTE page table, which corresponds to + * a single PMD entry. Before calling folio_pte_batch(), which does + * not perform boundary checks itself, we must verify that the + * address range covered by the folio does not cross a PMD boundary. + */ + end_addr = addr + (max_nr * PAGE_SIZE) - 1; + + /* + * A fast way to check for a PMD boundary cross is to align both + * the start and end addresses to the PMD boundary and see if they + * are different. If they are, the range spans across at least two + * different PMD-managed regions. + */ + if ((addr & PMD_MASK) != (end_addr & PMD_MASK)) + return false; if (!folio_test_anon(folio) || folio_test_swapbacked(folio)) return false; -- Thanks, Lance