Re: [akpm-mm:mm-new 203/215] memcontrol.c:undefined reference to `user_proactive_reclaim'

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 25 Jun 2025 02:57:13 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new
> head:   d1c90ab3cf156e6dcfb3b74bbb1fc26d99cea303
> commit: 67cc9632fbf2d4095ced88c37130de79914140d6 [203/215] mm/memcg: make memory.reclaim interface generic
> config: i386-buildonly-randconfig-003-20250625 (https://download.01.org/0day-ci/archive/20250625/202506250208.ZOcoZLb6-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250625/202506250208.ZOcoZLb6-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506250208.ZOcoZLb6-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    ld: mm/memcontrol.o: in function `memory_reclaim':
> >> memcontrol.c:(.text+0xa06): undefined reference to `user_proactive_reclaim'

Thanks, let's try this:

--- a/mm/internal.h~mm-memcg-make-memoryreclaim-interface-generic-fix
+++ a/mm/internal.h
@@ -517,8 +517,16 @@ extern unsigned long highest_memmap_pfn;
 bool folio_isolate_lru(struct folio *folio);
 void folio_putback_lru(struct folio *folio);
 extern void reclaim_throttle(pg_data_t *pgdat, enum vmscan_throttle_state reason);
+#ifdef CONFIG_NUMA
 int user_proactive_reclaim(char *buf,
 			   struct mem_cgroup *memcg, pg_data_t *pgdat);
+#else
+static inline int user_proactive_reclaim(char *buf,
+			   struct mem_cgroup *memcg, pg_data_t *pgdat)
+{
+	return 0;
+}
+#endif
 
 /*
  * in mm/rmap.c:
_