From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C33C77B7F for ; Tue, 24 Jun 2025 10:47:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 082AC8D0003; Tue, 24 Jun 2025 06:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05AC28D0001; Tue, 24 Jun 2025 06:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9A38D0003; Tue, 24 Jun 2025 06:47:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DB3388D0001 for ; Tue, 24 Jun 2025 06:47:13 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8790980432 for ; Tue, 24 Jun 2025 10:47:13 +0000 (UTC) X-FDA: 83589967146.14.BB5F109 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf02.hostedemail.com (Postfix) with ESMTP id CA2788000A for ; Tue, 24 Jun 2025 10:47:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E1Y2Mdkz; spf=pass (imf02.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750762031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q9YNLRyxz8U7WyFP8P37wvG+tQymx7Vu2sHvl8qoV8A=; b=Z86hb7gWti8adniiom+Tt2Er/n76Y9YuFh4CLh6DdCPvSlgZDOPeOZOS2gkV4TMsqAsNuj yZwdCbC1ZGD5c94GKbPjbeZhEqi1GLdXJjyT4zuR98DcmhOF4XlbrsLxwqw4rWYoX7+ygh G3kL1t8XhgLRktD/nFX9tvsVPQfPjI8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E1Y2Mdkz; spf=pass (imf02.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750762031; a=rsa-sha256; cv=none; b=Ux+JrR+KWFN7P/SkY2nLXGx3yELB7h/wCwyPGa4fv6SrYqpAOAxsDglu7uBF+K/89/QWH5 1RCzKK6kR51cTY5BeRbvMgDK8gTkt+lUlTChZTPneuLjvkTNU/tYVRkn3YNyJr3+W/erv5 qJ+nlc6X+I5kX/+kkceSOmBZWaipb7s= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-22c33677183so2437025ad.2 for ; Tue, 24 Jun 2025 03:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750762030; x=1751366830; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q9YNLRyxz8U7WyFP8P37wvG+tQymx7Vu2sHvl8qoV8A=; b=E1Y2MdkzDjnPdzvRwd4KMJxZdQpkZkp3CnYFvdjbbju+vm7P1alBw4caPEf8IbpK+1 p/oh2NL6BjS07uAGHk1hu8R8Y6j4cdniR2/a7GqLRXslqupWJfKTDvIYP8ogMHkD6ehn LB/I1clKsbRBzMr9tep6HW50hSN80KwOBJgrQZhGrtondlmjIcHhA4sdYS9NkEOI3tiZ zhfgYqpM1gOv0bASK0X+Viv0id6rMnHSYF1hou/GzA+CTPuD8JyJHgkqvWphxESuOBc8 z0gr05wJxfz+jzkJT1AS9S/ciKfJV4YXJby6XrdLFFgZ0OXAo9miY2yiDkCXRO8ftyyg aI1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750762030; x=1751366830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q9YNLRyxz8U7WyFP8P37wvG+tQymx7Vu2sHvl8qoV8A=; b=bk1AQw4O/1/ycTRDZq/SnB7o9i1kK/UzX7RepnkIrjiH9ivZw45YVDKabYhSXZMt98 uDcaZLH94XrBhoNuywf/Ir3FHDVvEEp673OJjR4C6P039oAVKX1lZu/gPrHGzCh4Jmrg b/KqC3sQOxArPzI5pZVr1/lSQHDOGIMSpNF7KqIPVbYk1S2gW6uEWrvDJgUXGBfRn33q KCwivhG38rzBooMKA6XHKDHcQ/oqqUBIwReSVIp9WlwEKHMhe3BfM/bTNlbvgCPawRhV iOHPEivMjtwgBmRPlIn5SB2HAEHha6F0F55cqHi3e93l0lCoFagzObZukWtgfYGkG5R9 ecOw== X-Forwarded-Encrypted: i=1; AJvYcCXbD3HgxBNvg9fxZPLSrrOBlm/GKEFNm5E3voDgVQLF1s+RkbkTFDC5wq17R8gYh+keajGojUTysg==@kvack.org X-Gm-Message-State: AOJu0YzNzdyHOnomm7XJGfSfOO/Tpy9UGuB1CkB7n5wEqoGGbrL7zYNs RplkFCzYcOt7O0x7PyGIdav5RdjCnewjrDz4O7AaeYERXnDWfxaevQR7 X-Gm-Gg: ASbGncv6rO1fKJXsUBO3kT2j61WsZiEd1wU8f7eCFglQYfK0aqVyp49K7Ec9bVYCnD0 K40568rYO0tbN9zRhk0c1qU1RkAXYEcAaYgphEYHZpIWAZPF+C0ANNWuc65oJDyyD0xgtaVfY10 EtLHXVTdarekrCvCEDNoOmlSKzEolWDva8wDZaRAWTnASnv0dzzP9asB3eMYc61LF1DHxObhGci uxm9ItZsUtr0e9bhvbhI49/Us2eoGdjdI2L0Wst/4dBmqr5049rQosxvP6TexWKjJ6x5DD/vXwd LWWiO8qO47grPz/NauVNFagoHqPWDiLlxPI1ozTNPQisVSjXp0HYOq7lJTLgTrpri10Vqmzci2M OA0RPsg== X-Google-Smtp-Source: AGHT+IEAuZlnLUM/Oq3ydavrFM6HAFPj4rQDIaVo8ArRUvugCEeLHAbS8fik1d5nYG9tGqisHGfz/g== X-Received: by 2002:a17:902:e54a:b0:234:f6ba:e681 with SMTP id d9443c01a7336-237d97628bfmr283468345ad.5.1750762030536; Tue, 24 Jun 2025 03:47:10 -0700 (PDT) Received: from DESKTOP-GIED850.localdomain ([111.202.167.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d860fb58sm102904785ad.99.2025.06.24.03.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jun 2025 03:47:10 -0700 (PDT) From: wang lian To: lorenzo.stoakes@oracle.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, david@redhat.com, gkwang@linx-info.com, jannh@google.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, p1ucky0923@gmail.com, ryncsn@gmail.com, shuah@kernel.org, sj@kernel.org, vbabka@suse.cz, zijing.zhang@proton.me Subject: Re: [PATCH] selftests: add basic test for MADV_POPULATE_(READ|WRITE) Date: Tue, 24 Jun 2025 18:46:54 +0800 Message-ID: <20250624104654.4418-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <4af59ef8-bbea-48f7-a207-8a92284fc34d@lucifer.local> References: <4af59ef8-bbea-48f7-a207-8a92284fc34d@lucifer.local> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: CA2788000A X-Stat-Signature: 918shsm9x7czbqk8gf98pm3d8ibxwket X-HE-Tag: 1750762031-547921 X-HE-Meta: U2FsdGVkX1/FXNvNuezYKvi5wEl5fULdmQ4nH2O70t0uGnXduKg4hiROzOpS6M7GgNcKf9Ya/rG5tDBxlb+EkeaMys440WhRcM6d2AG8XgRT7r1AEVcpDbY4yWidWyzOrp1QliOvuVqkpJVF6oI7t7Exodfu85JRql8uR1S8r2WRLWJ2DXrR+KnkCGCf6RF50dvVjaliWqAGwBEm+0KN9MqmBJ5qryvR37+PQahxL9OXZPV3pB9mUn3DXBllML7sWlt7pHJ1dVMuSyuykIejjCWFa/dmbOJCvyapdbDojW8FQO2jK9U3gmwfZAxFznbuWDPIxaAymltYFBcv0RENkGzp3ySpSBtFPK1m4RBfQgaapiMmS9CI+1QoZNeolKKX17+biXmgZkhzZjNo9QhcfUjgi3oR0hNmbtFAMhkZgEw+avX6qiWYgwqSXkOSCtDGt8a9wFS0RNPXi/y4MnVgi80BjZYezcP/ifbBg91fysie4eCjSxSf4I4yet5R2f/yKIl5Fimd/ErO9zlm4QUSPZOEdz5U6TJKjIRrhneudHrLq2mTLCRPgl6+kYUds86GVf7AwWWfAICFJqYjCTz8Fv0pwZLTVQ2ImIPvkG2ZJL86Iq3wSjrze+P7L6WVA9kcnRVaj8pvuUvw9dkhf83Kow+o7E4WraaOGYjfF8tAz0v4TUSXHIGTV7gZySa6EsJGuf6rVPF7q5iIVwILFVXXe/tQTeXpieThmdi+xmbrW1nZbQskdoRTKoF0I4a/+sCJ2FHNQF4AaDg0rdCs+qVAEaojAvVjp2x22F/5W3lsl1CvJJTs5r0HMJR1jsfYHivx5RPQQjfdwtt2tzuv7iT5VWftYa1ZiL49yHwOax+35Q2RV+sWBB7+WeT8oFeOMf/zQ2PF1kItpJVo6iYuyxOFkeAOkH2XMho889SnVGr+7PswY6kYfZpYpXYvvizyg/qDcLTfAzyWQ/lDzRNSQ6P w+9UaIRP zvDQADeEN859N7R2VoyRQSRzj2XGgCm+usMQIKI5Rul90cIJ4dC6L7ERwI691XwIb4UWKE0/NRKWn66J70G59XxSX79m9xPGDt4eAlK8pRNmPJhik1zGzm0U6Jvk3ad9a10wIbVD3F2xrGMNrTL8xm395W67qxkYk2H0A0fd/xSgA1So= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2025 at 00:00:00 +0000, Lorenzo Stoakes wrote: > Sorry if it seemed harsh, I appreciate the first patch can be difficult > (I still remember mine!) but hopefully it's clear the focus is on > getting things right technically and this is all :) > > Overall I think something more like a generalised test of > process_madvise() behaviour would be most valuable, as David suggested? Thank you for your helpful and constructive feedback. I understand that getting things right technically is critical, and I really appreciate your guidance and encouragement as I work on my first patch. I will revise the patch based on the suggestion to generalize the test for `process_madvise()` behavior, as David proposed. Thanks again to everyone for the insightful comments and support! Best regards, wang lian