linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: wang lian <lianux.mm@gmail.com>
To: lorenzo.stoakes@oracle.com
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org,
	brauner@kernel.org, david@redhat.com, gkwang@linx-info.com,
	jannh@google.com, lianux.mm@gmail.com,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org, p1ucky0923@gmail.com, ryncsn@gmail.com,
	shuah@kernel.org, sj@kernel.org, vbabka@suse.cz,
	zijing.zhang@proton.me
Subject: Re: [PATCH] selftests: add basic test for MADV_POPULATE_(READ|WRITE)
Date: Tue, 24 Jun 2025 18:46:54 +0800	[thread overview]
Message-ID: <20250624104654.4418-1-lianux.mm@gmail.com> (raw)
In-Reply-To: <4af59ef8-bbea-48f7-a207-8a92284fc34d@lucifer.local>

On Mon, Jun 24, 2025 at 00:00:00 +0000, Lorenzo Stoakes wrote:
> Sorry if it seemed harsh, I appreciate the first patch can be difficult
> (I still remember mine!) but hopefully it's clear the focus is on
> getting things right technically and this is all :)
>
> Overall I think something more like a generalised test of
> process_madvise() behaviour would be most valuable, as David suggested?

Thank you for your helpful and constructive feedback.

I understand that getting things right technically is critical, and I
really appreciate your guidance and encouragement as I work on my
first patch.

I will revise the patch based on the suggestion to generalize the test
for `process_madvise()` behavior, as David proposed.

Thanks again to everyone for the insightful comments and support!

Best regards,
wang lian



  reply	other threads:[~2025-06-24 10:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 14:36 [PATCH] selftests/mm: add test for (BATCH_PROCESS)MADV_DONTNEED wang lian
2025-06-23 14:39 ` Lorenzo Stoakes
2025-06-24 10:46   ` wang lian [this message]
2025-06-28 11:39     ` [PATCH] selftests/mm: Add process_madvise() tests wang lian
2025-06-30 13:51       ` Lorenzo Stoakes
2025-06-30 14:02         ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250624104654.4418-1-lianux.mm@gmail.com \
    --to=lianux.mm@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=david@redhat.com \
    --cc=gkwang@linx-info.com \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=p1ucky0923@gmail.com \
    --cc=ryncsn@gmail.com \
    --cc=shuah@kernel.org \
    --cc=sj@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=zijing.zhang@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox