From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8565C7EE2A for ; Tue, 24 Jun 2025 06:59:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E68DC6B00A5; Tue, 24 Jun 2025 02:59:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E193B6B00A6; Tue, 24 Jun 2025 02:59:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE19B6B00A9; Tue, 24 Jun 2025 02:59:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BB8E36B00A5 for ; Tue, 24 Jun 2025 02:59:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 48C20C1B1A for ; Tue, 24 Jun 2025 06:59:07 +0000 (UTC) X-FDA: 83589392334.03.917D287 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 55B0A40004 for ; Tue, 24 Jun 2025 06:59:05 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=idEJzWJV; spf=pass (imf27.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750748345; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J10DU5OXaaKa8pBSa+RxsDs9i+snlpwIzDAMR9hFHps=; b=Pd8Ybghls6ttBSOdfAE8+VVvAdlQpyV2DEkRNNvIkWZrWU/+87QwgoH2gWYE4+8btRM1Pq 8x5VnUrVpmJNZH064NHLjg4qg7qQaeLnY6W3EDowoSuP9ZbDpLx9sf9F/xs0EL3TjifjBS 3QCOJ7hXAWt//3Lu7t8Ce90q/RiKhcA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=idEJzWJV; spf=pass (imf27.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750748345; a=rsa-sha256; cv=none; b=QgjECwKmJv+xT5Y+p77KpPrDENAWe+zm/x2XFEsAJckb8na7gNUTdS6bTjr/lTXUnLZQ6F jZp3mUeCkHSBmUilyIS9loCyWByVDKNBDGa6B4djKpBTxJxjYW97X0p/lG6d9Qn15PhERq TTPo1lW2pwHZd5Hprc7tlTQHjwt4PW0= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ade30256175so884872566b.1 for ; Mon, 23 Jun 2025 23:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750748344; x=1751353144; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=J10DU5OXaaKa8pBSa+RxsDs9i+snlpwIzDAMR9hFHps=; b=idEJzWJVdnU4XvnRn9LD0mzLOYdFS+iBa+S6b56xvRDtJ6L4D+Eu6Q5FpawcxmecqD FqIfQxEGnGPEnihMAhj4p/7goG92tQwSiNkt1Pq9/B6azt3jZYf6EIhNwszJx8GXWwnW yoVXNh7A1WmwhcPy8qSNEeD5Aqbfy4qHB7s9yG8oBThsWyTZ+Tv8EEu2zoczvp1IJi7s NXBD2O87XIPDyA+hh4sTSY0rHCvQ0SUAFLJdDGurDNjp8alZjF4ktDWg4gl2Xf0gX+c9 ZokW5/wQNqnFXI7L1Nv05JPasBO/4MukkAqvLRFMoUIl5UytPZkgTEjTVtt27girRiHQ DJlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750748344; x=1751353144; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J10DU5OXaaKa8pBSa+RxsDs9i+snlpwIzDAMR9hFHps=; b=QflyUHmrDdjj30GmOCfGUpnLb6s1cVwPVOFVastnO3TyxYy8ljdCfnmOz4/VZPLTqZ DbkE65RbelHWizwlgJ8BYDwR+ti9v/abyTK+fQuq9CR9PWs1dDqnaO+jGGMzU0KYtIaN 7fvXiPTya3pqvzJuILece9bPJslUX63DlKO9MTbBJfrsJwzHsJbh5BVFOOtr1mJZBMY6 mqez5OP0KLdcIaEUjRYndpnNAmkoqm01eJhAwPywnZ55QK8BcZpLqx2onVeMJOxJ67OO EISrFu1cYzyj28n9a6mGYO9zqMp3xTv7+u0sGX+19l73jSdIKd+lhouOdPXoYPtIvDbq 8Xcg== X-Forwarded-Encrypted: i=1; AJvYcCXPQotFwHge1S3h4I+rswi02q/lKMRl7NlMovavR5fN1yanP2ivbPFj5mFWV5O+60cw6QDrhRuHjg==@kvack.org X-Gm-Message-State: AOJu0YxElSZW2BzM3folFd/XbuL5SsDoRGJ/KD70D0lnrTtcFQkqK96H qqBX0DO9/bcVTG9/5Wcx1TBDd0cxHD5q7zr4r0jsGeul+3dENww2MHcQ X-Gm-Gg: ASbGncsMhCmZFPfLn6LIXIgud9C6/U8l2K4Ihgwp8p9MgVHSPNdafnnt2Qqfsp4QY5S 7SUprG7ai5tFhU0DHancXpMKNLnMa+gaf1+o05FCcOSbMQUma2w7n40TmuRphOA0dyjX/3LS9Ge QZwJNOkD8hYGRA53oFAEZ3fJ3aDdtHA0xSlRmqAeeYf+9r32tJ+OgcZTdL3V6Sez4h0PaBPxCRF r7xawbcT4rpokFGGzanZHyZrzjz5ThWh3ZgxCryF+4fY9sPdp8ql1JUAsDqKDCbE8qQdU57uwfI hZVxvgzonPpe9Qd1B2KWwTCBYCz5yamU/n7d+1GwYzxOZu8iC5Kj6g5TRNfs+A== X-Google-Smtp-Source: AGHT+IFwJOaJYP9S+dxSSVpj8CnOJAOB3ww0QgJEVnw1xT1fcg5wPQQC/3ofWO1oGDUbSh4Oq4GnNA== X-Received: by 2002:a17:906:6a11:b0:ade:44f8:569 with SMTP id a640c23a62f3a-ae057bc80d4mr1389882266b.42.1750748343397; Mon, 23 Jun 2025 23:59:03 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae05407f52dsm833354966b.105.2025.06.23.23.59.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jun 2025 23:59:03 -0700 (PDT) Date: Tue, 24 Jun 2025 06:59:02 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , Andrew Morton , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Matthew Wilcox , maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [linux-next:master] [maple_tree] 540335e987: BUG:kernel_NULL_pointer_dereference,address Message-ID: <20250624065902.7c5d5jrhjxvwjvpq@master> Reply-To: Wei Yang References: <202506191556.6bfc7b93-lkp@intel.com> <20250619154446.e9543f52bbc47e4bbd2cec29@linux-foundation.org> <20250620021420.7rgehvgrveyagqdd@master> <5f5fyv7kcaah4o4lnj6mc2zpptu5v27iajbpahykgakgzz3z2w@spevx4qf2aph> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f5fyv7kcaah4o4lnj6mc2zpptu5v27iajbpahykgakgzz3z2w@spevx4qf2aph> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 55B0A40004 X-Stat-Signature: mj8xe9eo8pfx8pch777iragypny8gfks X-Rspam-User: X-HE-Tag: 1750748345-573593 X-HE-Meta: U2FsdGVkX18SKAoXUj0L2q5fndFa8gua27zGhkKi+bD3fuUHkYqAjESsliRIRR6PBq9v+tkxdPnMgDJaiacsW3bavlqf2EBWvQBJ5nlMSLePch8s8reElWjVdp7pYmoTbFqLSTXUjWuXd0PKodh7WXPP0OKL/bEn5J9LzDxo0cdkdU7l2SbOi184c6sc2mFI2mn3KhMVBcjDf7F3CDxDPfhGM0XztHZkCB0sQi1ku9UFWPoaprnTUlgaIElhWHfnoXwFqNZiUI4WKDw/LG80ckgseD+e6zz+VSr6VQPcDpYObEva5yKiO3zC2DCzByxEB/1dczGazvJg6TkU48emaj4KLddCLfGh/scm5Q+yA96r2llVxwk4kgUMp2RJYF6mV+uR8QF6JxuZa7gX2NHtv2kxp81RIHegTcRaw6emSOEZsQB8YO+8bwAokhbrt8LpW38M4mzzvIm621HMb3hlFQm+jWEWL6q5BMR5c07ZpoxV3laCeuBdbv56oiQPuoFqqTkkHrvfu312QzVzrhv4G6AP2dSVDyDRLWue2XG82m5LZPd8W5tPkdsGAe3YTLTggtVmUuCTcF/rLLmaPKY6HCDAGP/xzVeDihHXMpP3ocKtyjESKa3tecbEwHhoaFTARlw1Vle9NH77arsfYonCbzfNDrKAJzSjQmgKMbFXr9RDygh/JHrerM92BfopxyV6xqwixd6dwIiL8YxMPispWn35u2gbAc7TloKxOMDmQjzVHHjgfd05LlFg5PbJczHeJcZgWttgKpYPHctc2MWKdrvUZ3XRlQXgLpyq7KmxrFYutiIjXFtqrnSCGCSF5/e3+cfGCM8a7AJCciMkgi1A1c05i82u+O+2FfjXPdZzDxyxQ5NgTzxw5AqsqYYByZAUMiRJ2dGVIXswrUK4Dviy313zb9TkX3SIS5aJaFZNH1A4wcTF8qvvTPNc3mGva05Xhfy1dzi0vpd6AFFUolE OiBuxZs/ +tbJVW0gSF3qZYirQdeqGS5naEY9cEVJ3VVqyIsGw4s67pQ/8SoVpja7vRqtQoRummvVaOyKfM9c7HjyMUiOLRaaNmZgpSLRPV1y2xvnnKAYJs//oahWV3+gjFYdeTDvLc6aRm8V2hBh6dqbhHYYlQwUTbllHhQbPqiWRZUOJlsPfDy4/EoYFcLYEpq3qabVbzrpq8RaiGQ7eLjrHFkbH1hA7xnkVB3QQC2nXZRC4OTbBmmUiuKiN2BwPzhK0ISy5mGzMQ7Tc1jgYNVrBzahY8J9zVmhoPc7gTorCD7P1jiBon5NRe0zAwAPt++5FtS9XACSJbc5K2GAfZyUz+1ZaefPFAi7gpjnMWtY2qwioXEiz551OVd4AOxdxWFr12q8NqtZBDP5r9Fjuxa7p40GlVjRvncdANICEWz93mHOdpGGoVnyz3OSQEMAuEgeMZhyhedFyZrqH3W7YuJgbfYrZ5RPxQ2JqCMcVh9Phild61mWXMvF4VtHA93x5SqA3253BQUyHoDN+lQzJubg1YjAnMf8EZTOCfURa/Mr1DAvvdmlAAKcdV0AEaMnVMMCcOaxWgCs6R/cbyJEMw+RN1EQ3jYl2rhBnhBELlrOlGAPglQJF09ndlCjRDXHKcUa8FQNf9rxHwcaHl986e9s6Ip8VPZ98tNrO1mejWsPqrSmegaV/4w24LgjTRpc8sg0XeF3vr/43LioCBTXkZzQeCAsvf0gMHuSmUjwb79DABp+OFsjoDWquhB7BNYF17Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 05:19:07PM -0400, Liam R. Howlett wrote: [...] > >This will need to be addressed once the dense nodes arrive, but it >really should not happen right now. > >I don't like the idea of checking this every time we walk a node, if it >can be avoided. > >> >> Sorry for the trouble. It is better to drop it. > >This indicates another issue exists which was exposed with your fix. > >I've tracked it down to the maple status being restored to ma_active >before the maple state node is set. The bot looks to have hit this by >going mas_prev() on 0 and getting the status to ma_underflow, then >mas_find(), which restored it to ma_active and tried to walk when the >node was NULL in mas_find_setup(). > The analysis looks reasonable. Thanks for your time. >I have a fix for this and I'll roll your change into my fix and add you >as the reporter... and add links to the resend, v3 patches, and this >thread. Stable will be excluded because it's really not worth the risk >- the code is stable now but just suboptimal. > >This still leaves your initial patch 1 and 3, which has nothing to do >with either of these bugs that you included in the patch set. It is >best to keep patches related to each other together, but not include >things you find while developing those fixes, specifically for this >scenario. > >I will grab those patches and re-examine them before sending them along, >again. > >Thanks, >Liam -- Wei Yang Help you, Help me