From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 727ABC77B7C for ; Mon, 23 Jun 2025 23:36:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1174D6B00AB; Mon, 23 Jun 2025 19:36:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A0D96B00C3; Mon, 23 Jun 2025 19:36:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAAFD6B00C5; Mon, 23 Jun 2025 19:36:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D743B6B00AB for ; Mon, 23 Jun 2025 19:36:37 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 979A1C0F9E for ; Mon, 23 Jun 2025 23:36:37 +0000 (UTC) X-FDA: 83588277234.27.58487AA Received: from shrimp.cherry.relay.mailchannels.net (shrimp.cherry.relay.mailchannels.net [23.83.223.164]) by imf21.hostedemail.com (Postfix) with ESMTP id E5B841C0004 for ; Mon, 23 Jun 2025 23:36:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b="YYCy+M/P"; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf21.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.164 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750721795; a=rsa-sha256; cv=pass; b=i2ztaei1ouB18fP9wixspD1QfTa3Lgth1915h0jLXSgRdqKAuCixRdKlMoM4MN/a0wd7+5 KvcxPf0xJeGOAjReexRDToB//THXgXlnRcKXA6KIg5VYQOBqnp6/6QZWgPGyVkgolz65Pk bHBnEMm8A5i6MIg2hYRu2vQbtXqX+LI= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b="YYCy+M/P"; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf21.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.164 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750721795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OQyAC5Zwg9VOAoEoP5oerQJSnLa4XNp2rsgYqfm0n0Y=; b=75vKLn5hvIJpgSd0yoRqnM5yogYj7bkti1T8HkPlyhNX88/g4MB+EziWYqMbs5woUHynpS we4LUhlF0z/dGJAMAvdTG5oEPKeFZ5152luvoT0sBnH+kyoBH3eL+AEu3AOeWB0Aa4KgTs wQ7QjAgAlA4IXk6rg9A3D1qhRpzErss= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A0D1B8450F6; Mon, 23 Jun 2025 23:36:33 +0000 (UTC) Received: from pdx1-sub0-mail-a262.dreamhost.com (trex-green-0.trex.outbound.svc.cluster.local [100.108.88.53]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 31072844C67; Mon, 23 Jun 2025 23:36:33 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1750721793; a=rsa-sha256; cv=none; b=ivaUBsjtTbFvqsZZ3zABvVqqFNtEFPUW8hlSIdfDF2SsKzUfEhXMJh1kWAqVCX34EYmtYt soFAjMRbyu4cInZZEe6AWqTDl133QifvHb//IlJLS2oe4ReqhlLbHxKis897NFWfe3yj5f p0yTfBGF0l0j2GR9R91Xh5MSXcEFEBx78OUR8NbzcYOh0o2J0mQonAd/t/AwX5eGkfKc77 Yui3QLQ43pkn/78Ej8sFX9TSFnCocvyNHxHsin1Bnsk7btuN/zzWZwyIyKokUjG04gm+NF sQfQzV4Sk56kA2WwQpQCe3uJcOCe63CF+6WsiYK+8UrXCL9mqL+B51OOp800lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1750721793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OQyAC5Zwg9VOAoEoP5oerQJSnLa4XNp2rsgYqfm0n0Y=; b=OvB9uYJT8ebCAZ97f8O0O35OWyFw1TNoI2deW2RV8cI2YpES1MqpEepU6XEqQYGRY7NXJd OuDTrGNmrdOsy+uz8ywDyqpEmYhgKpChw4p0nOu0GbIWWLKkjEY1DXhKls1LUHICoE0xXp FeRWujjuFbYPSzvJDTv2QnMaxDz6EfGdL/Xa30S8X1tL+PSVVUS30Q52VYlSD3L/h2VDuM svzRe2RRM/TNqYbnHFqRr0daQZ0nKqjoirLVMS0XBG10rmENf7Bhw37wHzrlA+JtEsgHWq DoIOi9jkWeBHpt1/Xa4yVkD/VNteKBXqlpZy2er+AnuhgnCpgsbnA0AdJyAfSQ== ARC-Authentication-Results: i=1; rspamd-6597f9cdc7-tzmdw; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Slimy-Juvenile: 562a32f86304b267_1750721793479_2456449309 X-MC-Loop-Signature: 1750721793479:2756345217 X-MC-Ingress-Time: 1750721793479 Received: from pdx1-sub0-mail-a262.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.108.88.53 (trex/7.1.3); Mon, 23 Jun 2025 23:36:33 +0000 Received: from offworld (syn-076-167-199-067.res.spectrum.com [76.167.199.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a262.dreamhost.com (Postfix) with ESMTPSA id 4bR4Gm3W1sz9v; Mon, 23 Jun 2025 16:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1750721792; bh=OQyAC5Zwg9VOAoEoP5oerQJSnLa4XNp2rsgYqfm0n0Y=; h=Date:From:To:Cc:Subject:Content-Type; b=YYCy+M/PJOzIJse6rDHHkkQvVR/gdqh61FsOaFOZrONM4ymwcVRIxBwjlBT9jIk5C ZT8tVlBNo84xY4dNmwxNwYL4+N2DQfYbLMhR0PSEL8AqYCCcYLJWLGfxezgNg2EKGA +8Z51B+nRl74CNRicejw9UjlHRnS6/g2QRFBx+fYO+ndRymNArIIZzIi5L+uAZ7Yw+ Ilci6qzCU5zD67JFWoGP1/QHmTCl3SaHEQtRhH+PWF9u+sSngi7JBGFCTGgNIsyFMD dq9ZfFdQuw/D+Fh9PNnuOmOi5Ez6SuaFGHRNbOcYlWQmYexvEGb9exuN3QBcyrtqje vZwo8seBqWEmg== Date: Mon, 23 Jun 2025 16:36:28 -0700 From: Davidlohr Bueso To: Andrew Morton Cc: mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/memcg: make memory.reclaim interface generic Message-ID: <20250623233628.kv4c4k74rdpfek7x@offworld> Mail-Followup-To: Andrew Morton , mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250623185851.830632-1-dave@stgolabs.net> <20250623185851.830632-3-dave@stgolabs.net> <20250623144528.19721543236d8a0165df4cad@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20250623144528.19721543236d8a0165df4cad@linux-foundation.org> User-Agent: NeoMutt/20220429 X-Rspam-User: X-Rspamd-Queue-Id: E5B841C0004 X-Rspamd-Server: rspam10 X-Stat-Signature: hc84k54o9t56k44yzbm1ocj69p7sixwu X-HE-Tag: 1750721794-985355 X-HE-Meta: U2FsdGVkX1/GMF8BSUWpYn+E7ho7fehx1Z9oEudkmvTxTH1xQwycBCNqPWqgapvSh99sx2fiylEvdRo3he/UcUTx7ZoyYbFJSlBiAhW1GlFQy/ceomphd2bEMhQtOad+lRWiDdnJ+aZ4yNJuUKjN4zW50fnC84Mw7srwr6zuSIbZcI63bqBD9zxlCPSMSsOqPT7jvnYbBUtf6uKBu8RcBmT9pRWdrXC/LPJX8E2Edr4RDLc7+UEcsyPgboK1IKazQxagaoL50lWx7+qmiEJN1ttIDF5UjKWZkr5lBhjXwj/DBZhxpV6WLRb4j1ZF7AG87ILU0gJwwud3Giy+BwrV8nKjYfe+M8xGLJoGkv3ZAesN+5FNZ/lJuvgug6/FDFoTTL2pisLZUwlFB4OyWs/LL9KEBynP4rj354zpXwU7ptNKFBd90V0DCa4XuQKz0W3ddzGGYRJZh2hrdxwrsMoIQTCrZ+P0hquaoKxkEDWJWVAsxgO3eRPVZPDv/fDAAqPcv0xVZVSTNKkMhGFrf9e3GKXpsZGhSbd9FUdwSGYpN3k8wDpq6kw7aCxWqwjA6GIjtjNGaTXSvlnMatNJXzRCeAsZ2nVF+I5KPRY2BTF3TD9Kq/dhq0VvnxnBDXziG878czsNYreTalnhkr7AowDso598Q8Ig7bLidhvJfgwtFffimnEojxBNuQyxUkOOHceReE5+jZS7SZnpcixE3wiK30l2CM1PAmcRbH5v28VR7Mn1gJk+61omBkIfO0wHtGF/61j9zLmzXMvDEwfRkAcJCLfTXrt6GS0CkSnqF+WLz9ByN9hYppY83p4TTMKzHL/qsxELdta9WC7rN+90rbVTPtXAHeGGmEasetzd1M31wn0tuNiowb7u6rR+CrtaFIsfoX412sKqrC7XJ2t7BGDaSSnLTpLaBPPoada94HngplLp8DopgqWYeUkpVcLKlXGP6NrrhUlsP5DR0GxAWl5 DRxL1mnP viXsOUsBtlU4+HbxiP7zl9oSW5F9KMwqL8AandeNqWHqNaSqXfBwCIGyc7sX/HkelC4YniieRyvnTbEN88BbgXhoygaMujgdFvZPIJF1hXdF9gdo1S39yHguyyZ+XJCbgkwH89vc9fhXFiCdmFXZzIPXwjkqkMWGi7s3Jz5I8a9k6Yzfqq6X4HwO7oJVm+QBhVf0cFvDUCcUSaXaFnILAO3R9g6R/k+jY7kwyBzAUDUUVf47ZUptwCeAZvXWMvqSGCAyeOLyoX66w1yfYTm/v8Lvn7UfTmQK0XYxIL8g89SCl8fnM/5EKGN6KIzSDyxCFFhneYPPzQJMHbeWfCrwakHOXs8/eHErG2Mn2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Jun 2025, Andrew Morton wrote: >On Mon, 23 Jun 2025 11:58:49 -0700 Davidlohr Bueso wrote: > >> This adds a general call for both parsing as well as the >> common reclaim semantics. memcg is still the only user and >> no change in semantics. >> >> +int user_proactive_reclaim(char *buf, >> + struct mem_cgroup *memcg, pg_data_t *pgdat); > >Feeling nitty, is this a good name for it? It's hard to imagine what a >function called "user_proactive_reclaim" actually does. I'm open to another name, sure. But imo the chosen one is actually pretty descriptive: you know it's coming from userspace (justifying the 'buf'), you know this is not about memory pressure and the memcg/pgdat parameters tell the possible interfaces. Would prefixing a 'do_' be any better? >That it isn't documented isn't helpful either! I had done this but felt rather redundant and unnecessary, and further don't expect for it go gain any other users. But ok, will add. Thanks, Davidlohr