From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2792C77B7C for ; Mon, 23 Jun 2025 14:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 888C76B00CE; Mon, 23 Jun 2025 10:28:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85F926B00CF; Mon, 23 Jun 2025 10:28:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7760E6B00D0; Mon, 23 Jun 2025 10:28:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 60D346B00CE for ; Mon, 23 Jun 2025 10:28:46 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2AD02121361 for ; Mon, 23 Jun 2025 14:28:46 +0000 (UTC) X-FDA: 83586896652.01.8CF5EBE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 097A91C000C for ; Mon, 23 Jun 2025 14:28:43 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IZmcRgw7; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750688924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y3weVWwBOUYIW/Nf1kizuLqzTbeJjj2BrNnaadbwNoE=; b=eq9Z7VgOYlefu6ZhooBY9gCYwBwZVdKU2nSML9FQ/G1kBASaP994oFr+y3cemiY9gVtvGF OZPSKNUJjSK1IqmKn5F0AizpuR6w7RjorgQxAwrM9ZSXxfFLaiEr/NHZzZKE21JrGwPljv shVOVXtu6FuDJVtoNcgzgySHSu9Y2jM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IZmcRgw7; spf=none (imf20.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750688924; a=rsa-sha256; cv=none; b=k74MOtz6qUC07F72j1+jH1Z+FZA9SxEffHbpZRNSFlXyCaZiPAVfkapKqMU/238XCCoWvU dhmtXoi8612lC4d+WWNW4sQuGIYadqa3AYS9M1/WFCCyC/DGiHNbZ2KjQc7rScY3kPpMka +qe1ndatb2NOUUZpXNZnFHq+9TVYpJk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y3weVWwBOUYIW/Nf1kizuLqzTbeJjj2BrNnaadbwNoE=; b=IZmcRgw7N+Xa00EMi8GPuMLYgd HPnauGCGdBXcl4Aph05+5vuwgj8gGgye4hIILbZZs+qTcn2XNDon8u9UfOKJ0QI3cQol3s2fVB5SY +xkdHm4YdZ/eRpohX9V7lG2JWhYhvFX4Q6x4axidiKEylraO1KI6HY6TaSyEyjZwMETfafzPQ3CL5 xKXH/NAs+jGBiZVJZcmqv1XexddcM5wC4GGpipWTN4mAIClKKSiFgXB8HRq2jkCwwD4vBfmn8E1b4 iP3KECNmomjCtWTAY1VWXsriUAlD0liquNgfhWg0rV2Wn2eY3CQT+x2xYYKVFcS7IyEp4FhP+sJp5 Z04IstBw==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uTiA2-00000003gMC-1oeA; Mon, 23 Jun 2025 14:28:38 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 978EB308989; Mon, 23 Jun 2025 16:28:36 +0200 (CEST) Date: Mon, 23 Jun 2025 16:28:36 +0200 From: Peter Zijlstra To: Vlastimil Babka Cc: Christoph Hellwig , Christian Brauner , Sean Christopherson , Mike Rapoport , Shivank Garg , david@redhat.com, akpm@linux-foundation.org, paul@paul-moore.com, viro@zeniv.linux.org.uk, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Message-ID: <20250623142836.GT1613200@noisy.programming.kicks-ass.net> References: <20250619-fixpunkt-querfeldein-53eb22d0135f@brauner> <20250619-ablichten-korpulent-0efe2ddd0ee6@brauner> <20250623-warmwasser-giftig-ff656fce89ad@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 097A91C000C X-Stat-Signature: 7btf36yxpq5pebq6c7f1cq8373s9oxcs X-HE-Tag: 1750688923-385335 X-HE-Meta: U2FsdGVkX1810iuVqNgItA3xQEBSHkjGJToOPMotreltCKvYTIl6lJmu5mDacy/QBTUS60fAL03Iz/28rerQ2EiQmntF1EPFBRPRPdpZPVS2RHIwv4Yw1zvIMhAhYhiPaImmIc90sUcz9f3vB2F1HeMLmhCr3bLtcYRCYi/6slOiZV+xGnO2RU+tvqdG5iBiw3wosA5OjaDBFkYFNGYwQv57a1VsITRixdESlN/YdjXtqXZDEO0/dvo2O8FUR+JCwyAhPlF+Ik2uN0WNLSTipXjCSdLGxeu/K+y6VTRiYh8SaFY1V/ZVLYs9509/ejbjcjt2ZClYdWoypsPcGdxsfFS/WgTauPCsJZwDDqJGu//kZoZ1Aeh2q+Yqpg94aSWkhcuK1bMlNUROQoYTUA3n1Vy57WxeOdrejJPC7YDotdn63i/ijlnJTq3J4UUtleH0/PgC5U5ozDkAY6nly6RHBgWCwMgEshZS7yKoSOkPCL/xf+xvoo9tbUZMg4tgRcFRoA6e4jq42fCwzr2DPJjHTjghSbya8EPWnnfRw9lhI7C9VPfTpf6yR0Ru3JxIV1sM/OqfXLhappN0NzsrqJgELUP0JOSPulvt8+PtmFicaTenxFdol1Nm3vw6W7q/BhhCgrmRnj8/uYYEi+Jeyj6P6uzEFl0coQzoqlnYfdSg1A7u+k/rCHnM/xWHLSx05UK9d9gFPl/Q3R07Bqz44GZUi1Wn3Sl8CtYoxDk2GW+NvkZXfT/VeaHQsOsiBiqmS3k+n5iXB+5PxV5RuQesr0lsPxeIS6PVpa7Aup0i2R1p8ZDLkgPLuxOpKxy0sdjVm2sFN33f5lSiqtKDm3Wty5qPRXW9Z19KqPfz2yG5TH3pWZ7Vsts4tMQdlOPZqFMMHurScqQm5DnjwHjPu19R1CkIuvsmnyqfQfIr4/cpom6iLeYwjsyaCcbKfZjjdyEaWnYlbi//V6uT6U3WTKSuBnp sWwNt1eW 2Ib4E0jkp2wgxJybU00Ps3e19craY1SPv5qPG2pqK2w4PZxicMn40twzDIZzxsORxW48tkRe/iwc5PA8OwCksv2dtxhF48SaZjbsX8cb1RhepP2+dD/UAy8VwCscN47QOQ+n9+00NGOrHdlIagOD1sP0MqXCgfxp94uBbfu4rTl9jzD6uCbBKfRKBv7yfuTiSg8cP2MCdOO2TgJ5qnmWFKMYJnLug0kADiIwM38KfMbPmegI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 04:21:15PM +0200, Vlastimil Babka wrote: > On 6/23/25 16:01, Christoph Hellwig wrote: > > On Mon, Jun 23, 2025 at 07:00:39AM -0700, Christoph Hellwig wrote: > >> On Mon, Jun 23, 2025 at 12:16:27PM +0200, Christian Brauner wrote: > >> > I'm more than happy to switch a bunch of our exports so that we only > >> > allow them for specific modules. But for that we also need > >> > EXPOR_SYMBOL_FOR_MODULES() so we can switch our non-gpl versions. > >> > >> Huh? Any export for a specific in-tree module (or set thereof) is > >> by definition internals and an _GPL export if perfectly fine and > >> expected. > > Peterz tells me EXPORT_SYMBOL_GPL_FOR_MODULES() is not limited to in-tree > modules, so external module with GPL and matching name can import. > > But if we're targetting in-tree stuff like kvm, we don't need to provide a > non-GPL variant I think? So the purpose was to limit specific symbols to known in-tree module users (hence GPL only). Eg. KVM; x86 exports a fair amount of low level stuff just because KVM. Nobody else should be touching those symbols. If you have a pile of symbols for !GPL / out-of-tree consumers, it doesn't really make sense to limit the export to a named set of modules, does it? So yes, nothing limits things to in-tree modules per-se. The infrastructure only really cares about module names (and implicitly trusts the OS to not overwrite existing kernel modules etc.). So you could add an out-of-tree module name to the list (or have an out-of-free module have a name that matches a glob; "kvm-vmware" would match "kvm-*" for example). But that is very much beyond the intention of things.