From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FC1C7115B for ; Mon, 23 Jun 2025 07:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C62876B00AF; Mon, 23 Jun 2025 03:57:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C130A6B00B2; Mon, 23 Jun 2025 03:57:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B50686B00B3; Mon, 23 Jun 2025 03:57:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A50E36B00AF for ; Mon, 23 Jun 2025 03:57:33 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A720F1223FE for ; Mon, 23 Jun 2025 07:57:32 +0000 (UTC) X-FDA: 83585910744.18.1593320 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf12.hostedemail.com (Postfix) with ESMTP id 5A95040009 for ; Mon, 23 Jun 2025 07:57:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XxsLu8t7; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750665450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=YPdulDJST/MYB5N+2axWZHF9joXKWut0/gJi/Y3I0go=; b=KLAn+5ehR2opHzCERltB66vNbxM/+/7zk4mWWec1XiqsnE7f/3udyDMvwFMz8Bq/FPRdOZ xS2G9ceZL2S6MR52crncLxlTMSSr6eEmKmIx/8L56n5McjUtaRm9qk28xYL8eL/2xfJfn2 c6W62aFB+km4AD6dJbAYxPUS720tPRg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750665450; a=rsa-sha256; cv=none; b=A7YJgVdpHBuIyzDMNeRHYqj3jR5JeBQIP9+LN4Cle1+lWD7d+j5q/hs7es29Vfh1WSsVS5 O21XTfmD4w2vyjR3PCtrhDnL6dYEw9FSeBBdyBAbcR/tZRtaZH2z84BIEddds7hO2vkMPW eho4ph5nUNwSv78AkAiMU758U8HDvV0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=XxsLu8t7; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55MMbiim001960; Mon, 23 Jun 2025 07:57:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=YPdulDJST/MYB5N+2axWZHF9joXKWut0/gJi/Y3I0 go=; b=XxsLu8t72mJNfQdazIxSKQoyPHZVBT24zRMn8yEEi12uW8eDgccR/EiBZ 5/DXATKJhavhmHD6Aj7fT4hRAH8iKike9cL2X+uQvnyuLRW9qtogXSG9zkhsc6dS qTXrnb29zvfhzJVWU1ENOf/LZFl6JMhouIKhOabMlG+zWBVXVRTnIW5dlkorUVkD /ksPocdXYvzwqLT+JzFXty0/Olt+aT3BiQTU3yQSbrrHK3T1c0ra4hKPFmAargIs UiHoYuucS0gdOPVSZCWaNLMfexxd4LqIlkHGXscfThzaUCJvOhEk32jkxhFg+amq 0Hi6oCcsMt5nqi864Z0r7tHM87Qcg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47dm8j01se-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Jun 2025 07:57:25 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55N3cJR3030546; Mon, 23 Jun 2025 07:57:24 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47e7eyn7gw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Jun 2025 07:57:24 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55N7vMus56689148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Jun 2025 07:57:22 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1EE702004B; Mon, 23 Jun 2025 07:57:22 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0D9C220043; Mon, 23 Jun 2025 07:57:22 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 23 Jun 2025 07:57:22 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 55669) id BEF46E073A; Mon, 23 Jun 2025 09:57:21 +0200 (CEST) From: Alexander Gordeev To: Dan Carpenter , Ryan Roberts , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/vmalloc: leave lazy MMU mode on PTE mapping error Date: Mon, 23 Jun 2025 09:57:21 +0200 Message-ID: <20250623075721.2817094-1-agordeev@linux.ibm.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIzMDA0NSBTYWx0ZWRfX8n+4OSozYeGt e/rF1JCdvt0BW7YfVYoxd95A0fljuJoMXxAFsbu7fZeg5qayarmR7Wca7dxusgiPKjjUH8F9rOp b9BuRscKDcbt26pOiAz43hW0RC+GbWKs5nclFuUNIlNzyw/hUmwWm6SLZbwmAhAKdJNV6s8BThi lLdyBhldtGDpUi9kqzTlj6+rUggRC6Kb+TRE01hhVEOOzHQRDtTKgeJF38rM+FH3EziSGjPrXpN M0kxkIS/ExhGj8ikPCDhYYMsl3/iwIyXuUYKwy+aVGtwmEcBbniurPeJuxDt+S6DlEWX8vLsEoY 6LOAio9co02q+UH8ZcdBeAUoud+jD6AA+zlEKT37CESBJ3jXJ/Zhk1rITypXkzyfoPuSwffWcYK 7WYotWWlIYGio2+PPHHVd9WOlvq/abp3ICEe97SZ/m3tKX/7m46hXLa+jkEOq717J+GIRphJ X-Proofpoint-GUID: x-Tuc_yaAqSuHokEPm-6FAbJSnQsjEl5 X-Proofpoint-ORIG-GUID: x-Tuc_yaAqSuHokEPm-6FAbJSnQsjEl5 X-Authority-Analysis: v=2.4 cv=combk04i c=1 sm=1 tr=0 ts=685908e5 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=KKAkSRfTAAAA:8 a=VnNF1IyMAAAA:8 a=68ZgUnyOPooGnTEZb0UA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-23_02,2025-06-20_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=785 clxscore=1011 impostorscore=0 suspectscore=0 mlxscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506230045 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5A95040009 X-Stat-Signature: nqhybmgtizgm5q6wc5xf45snzsej4cxz X-Rspam-User: X-HE-Tag: 1750665450-85651 X-HE-Meta: U2FsdGVkX19S77Msc/iWPncT6ZaDD8JJ3b1LuQPezoOODLTVgs4Lgiyz+zPvJBMiFPROjAAiP5w+QXK8+wzf22wVa4EXGqKcT1k2bWjaQbeAqUhZgea1t/oO1CqlR/8Xip+WGd4C4wqSnW/8jr9Guh98haTLh8+Qrc2C2SCNVAdBJ0tppwIai7oUjzdDAkAvHtysC7fW2w2Vc3Fq9YT4LgApRw261lHjSnt0dWVqmMrvkV6Z9bCs4qmRFBH7orWz/JhL6e2WzBWglRnmqu3iJ3xYG1a5QBzqw2dOCmAwxTFctpTDe1hiFwl1OXkNPPHeoLTbnhnU3MQrTiyH9vVuuZvdwuPuD2+La4BnfjHDE1yM+HI28UDnkFwtA3PIEeP4XurF5ZJ8dr9w3iCq3uht+XktCCBi7HQduk7exa/In3q/PDpMHWpYCdvsni+ihJk8v1Er/xrCn79PFAao7PfWHwekV4vJNzG1bIjwn0ns1rjIoHyyCOfPcUBHhYSP9sTGvm48YcHirUjtf/UrqeBooV3fB7Nvt+XJDL+6aPLNUQOzeJ+xROXTxbunzzaEWhb2TqGhNJ5NQIIf2We3GRvJLvpY/edCX4gizd/1uL0cdx/3NEL/fSRRCp0kKZ75DdBbL4aozXGWKJ0x6Tps9tu1fQb9f91gp5Vw5L6wfsxPzceVdFmUm1WzSURfYahIr1+rMIG44AiuIflZbECk8DR4Yc/JXKz2JN044GqRzfOiryuXMpdxaFWRTHMNnhBQZR6WF/QrAARt/jw47irxAAqP/ap3GgehrbfI1oIgZgg7yorzqBMU2QSVDybqaMeI2dio7jO5TR2eXWngIjPIwsmJT3+Vi0e2bNvr9yqErHC+A1S6LpWYtb0s7Gst2z9zmPLinw6Ub5X9CdSjzN5QrwL0IZap1uVRlVy7zTfdqn9OmQoNkG+CiLre42UHfJ+2Jdhtwiagmc7Bqd5dboL214u qV8xbFoz XM5Bkt5vL15An+xOVUszaqqcUhwEY5R/xW+fiqyC/GxPj6TKUn/2CJMi+WG1an8sdzucuCdht7igBd+ljv1sxaPWdIIvD5I/EJSmIdYeXqmYWGqhq5WQ78TsWZADqncA9nJgabb+nwvzZCEKgvLBo32S6O5SjzGNw/BZ1qwoVgpJNLQtpHnL0XTobdXf3SPY9whZOUie3Em307/iINfBfQix4uuF3Yk/a8HEB6f8OCTJWaQ4l8n/gHDpaU/EZSX/ttEMzAbBPsCBCckY+2bm96vrClhTm/WjSNTPiO+Tegi65OvT2DdYAkjuFng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Function vmap_pages_pte_range() enters the lazy MMU mode, but fails to leave it in case an error is encountered. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202506132017.T1l1l6ME-lkp@intel.com/ Fixes: 44562c71e2cf ("mm/vmalloc: Enter lazy mmu mode while manipulating vmalloc ptes") Signed-off-by: Alexander Gordeev --- mm/vmalloc.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index ab986dd09b6a..6dbcdceecae1 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -514,6 +514,7 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, pgprot_t prot, struct page **pages, int *nr, pgtbl_mod_mask *mask) { + int err = 0; pte_t *pte; /* @@ -530,12 +531,18 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, do { struct page *page = pages[*nr]; - if (WARN_ON(!pte_none(ptep_get(pte)))) - return -EBUSY; - if (WARN_ON(!page)) - return -ENOMEM; - if (WARN_ON(!pfn_valid(page_to_pfn(page)))) - return -EINVAL; + if (WARN_ON(!pte_none(ptep_get(pte)))) { + err = -EBUSY; + break; + } + if (WARN_ON(!page)) { + err = -ENOMEM; + break; + } + if (WARN_ON(!pfn_valid(page_to_pfn(page)))) { + err = -EINVAL; + break; + } set_pte_at(&init_mm, addr, pte, mk_pte(page, prot)); (*nr)++; @@ -543,7 +550,8 @@ static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, arch_leave_lazy_mmu_mode(); *mask |= PGTBL_PTE_MODIFIED; - return 0; + + return err; } static int vmap_pages_pmd_range(pud_t *pud, unsigned long addr, -- 2.48.1