From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D45C7115D for ; Sun, 22 Jun 2025 16:36:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A49F6B0088; Sun, 22 Jun 2025 12:36:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 756216B009B; Sun, 22 Jun 2025 12:36:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A176B009E; Sun, 22 Jun 2025 12:36:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F1A76B0088 for ; Sun, 22 Jun 2025 12:36:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A573103AE9 for ; Sun, 22 Jun 2025 16:36:00 +0000 (UTC) X-FDA: 83583588480.27.FEBEF99 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 1FE3C20006 for ; Sun, 22 Jun 2025 16:35:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OqUZFpn3; spf=pass (imf13.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750610158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k1oa4nNQ6OD1xXNiA0TVTj0NDdNUr9/eQINchl8HXO8=; b=MrbPGc/GNy3e8LFXqDo+1Pm5O2F8k3QCMhTNNg2AP+IbOjVUGG+R+Ks+joTQzkT0eC330i F0+7H1dyE5tyVJvBE6WD0J56bmpTCmB7Ytq/mCGuc+LEiDRBOlXyIt8wR9PQhx5gnAGA3o OM8sYOIHdR+s0lGfRMCGcnX6e1fM43Q= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OqUZFpn3; spf=pass (imf13.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750610158; a=rsa-sha256; cv=none; b=PKsLMjxrZYBrdNlTD2Jt0vb6zSP/4cCoypYdWlyOdkKZ+ZpgN2IK3HZBnoEOTsEb3bEUAM F4cXdQeIcwD91Coxdjh1Qofws0R9/pBfRv8rr8bHE0eF5SpsasJ/Im8gf4fRrrmK1EpZj8 lCjzNIQhB4bQERVYJBg4XWjhOgMDYzU= Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-45348bff79fso38591745e9.2 for ; Sun, 22 Jun 2025 09:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750610156; x=1751214956; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=k1oa4nNQ6OD1xXNiA0TVTj0NDdNUr9/eQINchl8HXO8=; b=OqUZFpn3GYUJP+56GGKzloE8Qxy0Gft6iUtUliRZBc0GLMc+jkhxzsfr2ApKjm7umf /VmXpR0iDcJZuGf5itbopNTfq4tRsM8EjhZH5BOLvZs2q0rsryJ9NHEV14p0oT+zOKXF xg+ucr37YCkSH/OK4kw2m+te7j9AR6iP28XBQJ9BYeSqrSxV3OWe4mAFiCe6c7ddLsX3 h5Nthhq8sHo/FWLKqEbFF+CScZwRtlDhN/hOtHV2h8E7bcwwU1xQKu4XV92izmZ9iRBv T4Q+2+JtAcUVQVEQ6hHM3g9y/MP5dgCJuUE2haFm5d+RPBiOsYZtSo0IeF04QYPnaNmt /NqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750610156; x=1751214956; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k1oa4nNQ6OD1xXNiA0TVTj0NDdNUr9/eQINchl8HXO8=; b=c4J3oGKU6bXnP51z1BXao6pZyf3w6WMxTNBOdHxEc6x3sT0/FIEWKePIrqsdqAJiU3 64E5Gc8V6nEZvEIgMv8CsqlftLawfFQfvSN9aj35A+Dd786ecNkU0oqC5VfV3bMqdXmJ C1q0UwEa6VMpIWBZNDAiQfkwNL3bKsoow2mmM+IV88lZ/fzXMEQ+9urg0yXM2PgWHyLI +DffQX1K82aV9OqJ61bWGUEnrxVSsdVmL+MR8KbNjScXUl9pgoUOWz3xV8n0CSG7j33J FOKjCUKiZCN2m7D44MRq9Cm+c8gP4fb5M8+n7co855tBRrlzR8JmW6WBHmbo+tGhQ/Xm SItQ== X-Forwarded-Encrypted: i=1; AJvYcCVKIOKKZFmAgUSxRyLSDqeOm+7YzEdF2Imy2t6LFWQ5KMIlb3/um5Q76BWkQoVB9nHfm6xcp13+4g==@kvack.org X-Gm-Message-State: AOJu0Yysvgm5JAllFDno3uuj2bPHe2MDQSahz2ldcvWzqVgSHwcfFYkE gWK+pa0qkafVZzRGQ5eS+cuYd0WH4jpK6F9JyKDAcK1eLIl4X7RrzGjw X-Gm-Gg: ASbGncun4cxT1jJustgzVnnVmSVgHuhWesdkBg5nQe8Q4JpHDsIL3GtcH/pvCklKi2Q GtcviBLRwKfLHnhF+zD9O1Er0g2PtZEyig6hyluA0SuIh0DlgDMALFhnEq+lKh5qw/w7QVf8aKv I0BiCs5Oj5vKTDvS7RzRNeyHccdJjPUqWVsePdLCRZ+C6MmMJ1I3k36PypOfBmAidN++N/S4v/a ltpua/CqVXwJxgPs+N12tJf26p2JvEABVG/FGgQGI5L7QuMhkLt34dabpGda6iNkOgZ/fozYrcK QwOmoAG9WZWmdqNwtc2yX+L79ad4D0LQbaR8ssslcaPW/mFkzHbZ2sBj+g5vypPgbn7Fdb2ueYj LnENH2f/qwKEbIThz+ybZ2siQ X-Google-Smtp-Source: AGHT+IGIT3mcJ0gknkqPxwnQDk3KNRNpW3ykVb1rF9fBn2/P8z4fr9bdSWKQ+VnywD6VovL+QSHlYw== X-Received: by 2002:a05:600c:b86:b0:441:b076:fce8 with SMTP id 5b1f17b1804b1-453659c0bb9mr104566595e9.14.1750610156286; Sun, 22 Jun 2025 09:35:56 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f186dbsm7175528f8f.26.2025.06.22.09.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Jun 2025 09:35:56 -0700 (PDT) Date: Sun, 22 Jun 2025 17:35:54 +0100 From: David Laight To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , Alexander Viro , Christian Brauner , Jan Kara , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , "Andre Almeida" , Andrew Morton , Dave Hansen , Linus Torvalds , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] uaccess: Add masked_user_{read/write}_access_begin Message-ID: <20250622173554.7f016f96@pumpkin> In-Reply-To: <6fddae0cf0da15a6521bb847b63324b7a2a067b1.1750585239.git.christophe.leroy@csgroup.eu> References: <6fddae0cf0da15a6521bb847b63324b7a2a067b1.1750585239.git.christophe.leroy@csgroup.eu> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 1FE3C20006 X-Stat-Signature: 1ua743cynn7tgyxsu5pnbd8o4j7emm4t X-HE-Tag: 1750610157-813212 X-HE-Meta: U2FsdGVkX185ssdTnMobboYl4pPWVe264AJU6SGEwCb+u7xMkSLoaq+BVOf26Lp+rm/M7NsLP/PEuV3txhsxPSRFtK6rk5X8I1HETS7g+eC6DMMNl67kWyufKgCM0SzzcbE220i1KjMhTnGsWhnvhS/adSeQ/pELibZJ4+27UPb6vEqMfYkVcp0JEa8Q4nWmA6vpi7eIBLjNQVLZo8q+WX5y3oE1H2BOl5kkpa6wWUAuC04ShmAX1oVTYN/GSlS2kAk4mS6akPvMpXSEaMuXKmKmYDbo25VhECWvwQdGXslJ0ea0eznWfv3fqmSmbGyjlM0BN5pVC1UqXA74PLz6/GINUvU6770gW34VlzXuOHYkk1lXiddnaYWC3V7i0MFTYpyp01lsccm/x9W4lrbUwsQDlPk+I83x3eHCYGX5TYdIQO1J1l3mHWJO/D9dtPDjZsYJVzV2LrI8fxFxwFqcjvYpigeODWFxxoP5R0ZEO+1k8rsCGUIYY7djZ47UpAP/jbQUotVtv8mkg6A1GZvf89IyroDAsOOdD2VpELyLfELYHSVNAb6yKSQ2ua5Bpq9ULGYU/TQvWhmJQu9jSIWqFVO+dr+VeXmIImfA7YjgaWT2dcdYL70C9Seb+TOBjO+XywBqSUObcOhe0gI+4juH9r0LKWG6nzf/Ie0n193pnHaxlQY+YO9NkWmJgoFhfhAyas0f9xtOeiaqmOi65vyQDeTvYsD/7nyzBAQUJBcHI7aRpTW1JRaiLOXQ06MvTkGxpc3hZ1eS85mDE72w45yRwYXnK4JyORIaN0+g0zFqb4A6/61NUQhD+ug1ZLgYIxUwIlHqr/QHBNwUmD9F9aOwOwUTvRBqn8z0D8uEq6uW1Fj2Q3E72Kp3yZ5spJ4XqUjOOdmqLrTHmxjGD5eb5BPimvG6ngyYQlVe1TtgbQTWqprI2i/psw6/dNCpdjuXDB4QMZHEg22oqU30q1tm9SB 5UWSScqP c8bwoT7WlnmwlhOiCS1zQh2cXlgw9WFFjwkXpNN9lAtnvp8nxlENFiN43hHjbgT3Uji9yaEkto/V1VFS1uYxGRkbdUec4d48rI67qgjqa85rFdU5ZCXSd4TyIv9qLkyppW11ojPZRQXzSl2sF6UeSOsvecpZ4p6KzcMTA0vQJM8lLK4iexEmDQ5VwqpkadEgpP47W94X1FugXbKG2cypcgr4eg3sg4quZFRJan2azF2MF9oBw5aTQPk3bmczBJk3oZkyqp4xa7nzaKxMngfo8nmWHeGgJm/WkkPVcS34YHvdlk2PLCYY4YHcRiIvH+y3uJh4/ED1jJ4uFePhm4zJxjJf7TNPdOgaMJRfOZy9T/fJ/rTbAnSICD032wlA8NVMIdA8i3s8cyjmkKACMvXXFRajPHV8+GjJ1eZqy+algo5iOyAYGSHyfMiga8GYCkmTd1Awcy3pL3cyC+hygMLoLfPfZf4xX4JFfIgzdFOV4/06mMWPDNBrlAp1/WA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 22 Jun 2025 11:52:39 +0200 Christophe Leroy wrote: > Allthough masked_user_access_begin() seems to only be used when reading > data from user at the moment, introduce masked_user_read_access_begin() > and masked_user_write_access_begin() in order to match > user_read_access_begin() and user_write_access_begin(). > > Have them default to masked_user_access_begin() when they are > not defined. > > Signed-off-by: Christophe Leroy > --- > fs/select.c | 2 +- > include/linux/uaccess.h | 8 ++++++++ > kernel/futex/futex.h | 4 ++-- > lib/strncpy_from_user.c | 2 +- > lib/strnlen_user.c | 2 +- > 5 files changed, 13 insertions(+), 5 deletions(-) > > diff --git a/fs/select.c b/fs/select.c > index 9fb650d03d52..d8547bedf5eb 100644 > --- a/fs/select.c > +++ b/fs/select.c > @@ -777,7 +777,7 @@ static inline int get_sigset_argpack(struct sigset_argpack *to, > // the path is hot enough for overhead of copy_from_user() to matter > if (from) { > if (can_do_masked_user_access()) > - from = masked_user_access_begin(from); > + from = masked_user_read_access_begin(from); > else if (!user_read_access_begin(from, sizeof(*from))) > return -EFAULT; > unsafe_get_user(to->p, &from->p, Efault); > diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h > index 7c06f4795670..682a0cd2fe51 100644 > --- a/include/linux/uaccess.h > +++ b/include/linux/uaccess.h > @@ -41,6 +41,14 @@ > #ifdef masked_user_access_begin > #define can_do_masked_user_access() 1 > #else > #define can_do_masked_user_access() 0 > #define masked_user_access_begin(src) NULL > #define mask_user_address(src) (src) > #endif > > +#ifndef masked_user_write_access_begin > +#define masked_user_write_access_begin masked_user_access_begin > +#endif > +#ifndef masked_user_read_access_begin > +#define masked_user_read_access_begin masked_user_access_begin > +#endif I think that needs merging with the bit above. Perhaps generating something like: #ifdef masked_user_access_begin #define masked_user_read_access_begin masked_user_access_begin #define masked_user_write_access_begin masked_user_access_begin #endif #ifdef masked_user_read_access_begin #define can_do_masked_user_access() 1 #else #define can_do_masked_user_access() 0 #define masked_user_read_access_begin(src) NULL #define masked_user_write_access_begin(src) NULL #define mask_user_address(src) (src) #endif Otherwise you'll have to #define masked_user_access_begin even though it is never used. Two more patches could change x86-64 to define both and then remove the 'then unused' first check - but that has to be for later. David