From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78847C77B7C for ; Sun, 22 Jun 2025 22:16:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 821C36B00AB; Sun, 22 Jun 2025 18:16:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AA416B00AC; Sun, 22 Jun 2025 18:16:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64B366B00AD; Sun, 22 Jun 2025 18:16:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4CF446B00AB for ; Sun, 22 Jun 2025 18:16:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1D1DAC0750 for ; Sun, 22 Jun 2025 22:16:31 +0000 (UTC) X-FDA: 83584446582.18.B0BB545 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id 587E040002 for ; Sun, 22 Jun 2025 22:16:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UnkMEMVn; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750630589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RjBebZMmihLIv1ulRNQv+N5pGmi1XBiafPR72hF7BoM=; b=UDoN0ji5ZCPYR5xjkPnjfcd5PnCp7GNeAkIm9moGgi8qv4Kq9djRWbYOIWBaDC0DeGS6El 0i617BciTexoWQHVpBDz701/rITzazyFPUSuyosP8cCmYdNex/jx3Aw53P65nfXAzGdaXT rMbyxUd0DEFvxLvOWkC2Dv3kGvZBpA4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UnkMEMVn; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750630589; a=rsa-sha256; cv=none; b=hhxsaZBIIgna9SOLLa2QnfMdrg8RWScmldKRG6Bh0vmk/uvrv9MkeNH7X7gWTywHkLtl2p 0MRJQZRxLgQZhPARtBDH4mqUphg9NYLPXrxG9h1dwMCZopA0wjgxi59BZ7AWhhQdt9wTg1 OcDp+ad9C/mD2YDJiZJzPG7i6jk/BbQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 69E28A4F04B; Sun, 22 Jun 2025 22:16:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38383C4CEE3; Sun, 22 Jun 2025 22:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750630588; bh=tLByNlqUAJAlwrRiurqr1Tlca7v3+MRaflGdBfGFrh4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UnkMEMVnPEVFZ/TxLkdkQxWUL8j100frOJstemv+j6qBeTRD2ky7OBir7vvHPnDxU ymtWmkFNLPhS+5J1oheVqlqb2kITNwDebPJCYbA4HxBEXkTU7RxEQh56IlEPOJv9I4 EVWc61+GmVWxZEQpnxD95rkcfhnT2nbXjczFwLXE= Date: Sun, 22 Jun 2025 15:16:25 -0700 From: Andrew Morton To: Shivank Garg Cc: Matthew Wilcox , seanjc@google.com, david@redhat.com, vbabka@suse.cz, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Subject: Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol() Message-Id: <20250622151625.fb5d23362c2c3d1af22878d2@linux-foundation.org> In-Reply-To: References: <20250618112935.7629-4-shivankg@amd.com> <20250620143502.3055777-2-willy@infradead.org> <20250622114322.c6c35800e01e4cc4007a0f89@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 587E040002 X-Stat-Signature: 9gpbko8ijq3y8e4eecqjyghoszxc4jyp X-HE-Tag: 1750630589-600072 X-HE-Meta: U2FsdGVkX1+I3qpw3k9S0M8D7xpluI1TmQ7I6q4ZYUmy7VDapUzVScYHTjsurhGMX7rJXM+suygZCusgLz4dn1CDdnYX7wY7uKPOpLHare1WxdA0NxPB6H5jV48G98A2xr/QyoiBKq9Xw+QDcA/R2g4gywzi1Wp4+CGiqgZlbZ9gvQKT4qe024fkxwrxloTSeBR3EBXTur5y8bn/Rt/gEL4OCsC3ch0Sf/cOc/VLOQRxjkkyVrBO7SBq0SCDQgtfjOxjLzdXoB6IKF1g0onVOxShVTLM8SnTOOFmgq3J1VlKHtNIeUO5OI0WLP/YomoiTvBjOq8eBDDtP7o1UgnV811HOreY71U7pmJXGlQqhkoSWzqC3TetzGE2hJz8U6WyErLQPZ95oQGFKGUvTiHPP3xfdDxeyWIoUAlDfSf2Q6z1XWQpvFMC+K2Lsv9QACd68nnAezhpuOCqem6TDASKngRwPc4puFqUiVnOVCxIpJBVByJnyOF4ZBamRj8VZKqnNSj8jqGuviBKt9wbUHZ4N8vP03fMVGNigIDFxXvnkl4KLOtzfbpj7t+XyC9wLtVEM5WkFgy2ruPDjp5M9dXtApJlTwgjdSPawziBBE+URvnHmJ2Hz64MQiLr4w3aFOBwFGUovTnI8ObWhXC3Uq+PDGPYXvTgy6bz+wYExpDGvSB6Y/QC3c2OWv2HJ4z/e9vpQMVCgY7hmIV2W8ZIoHgajlrKMAYG+Nh2K/XEwYsSovsyvTbKNnuxq7A4+v6kWQuYqwTO+Z74AEPda4N9Yfyxx2aUr5QjPI8uQZBxKB9UtR+hQqNJhZUMy8My1GskN6tS9NoOlpERC4zkph1YdPJo3TG/Aa2mg50gKMZnYxSav4aeokrx+W/a8xoCQPOxJ+J5cDNscLcpxmIZ+4jE1brQl4YjoDXpu94qKjwnAYI8RSQRT11DukH6sm6Let6M4omMQwr2Py1pWQMjApxY6zp maihHMz4 KQ8bFDQoBdBzPNEjLbVH27fnNxmL82oIaYHFUe0SUhXXP5cPFd3ZwwRptSNY2u32DsHgeWQMAqX3HHOqGoUEeHyS9cnwaU667H6OV1R4MWzbSNjmpWxcwHWkqhZ1lVaHLuPBIO725bc+HWW+y9pZI5p6xquwgN+Nm9mrqtvdWvJoXYWVmZ5ucTm2EHh1N/Fj15jJkQK4XRah8suJC7778nqbQKwXDQfzeMAPCAaDS7ay2LDxqmwtqNSNqRIXNjFpppTuNDV/C3kzg9hb5n1hmhIB6kuhAguQF+ZMbfcm8saEHbrXpNOCYRY9RCZet2pfPuKdzJRJ4+q3XtIrYd22MkzBu47FdqLXwJ0nvcEJ2ighQMHPRHC/WrDK43fETSDT5zhr6klCi9/4E8gyAiJIvIkHXoYwE1FPiK8SN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Jun 2025 00:32:05 +0530 Shivank Garg wrote: > > -EXPORT_SYMBOL(__filemap_get_folio); > > +EXPORT_SYMBOL(__filemap_get_folio_mpol); > > > > static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max, > > xa_mark_t mark) > > _ > > > > Hi Andrew, > > Thank you for addressing this. > > If you don’t mind me asking, > I was curious why we used EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL here. > I had previously received feedback recommending the use of EXPORT_SYMBOL_GPL > to better align with the kernel’s licensing philosophy, which made sense to me. Making this _GPL would effectively switch __filemap_get_folio() from non-GPL to GPL. Leaving it at non-GPL is less disruptive and Matthew's patch did not have the intention of changing licensing. Also, hp2:/usr/src/25> grep "EXPORT_SYMBOL(" mm/filemap.c|wc -l 48 hp2:/usr/src/25> grep "EXPORT_SYMBOL_GPL(" mm/filemap.c|wc -l 9