linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Honggyu Kim <honggyu.kim@sk.com>
To: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, kernel_team@skhynix.com,
	Honggyu Kim <honggyu.kim@sk.com>,
	Yunjeong Mun <yunjeong.mun@sk.com>
Subject: [PATCH 1/3] mm/damon: do not allow creating zero size region
Date: Sun, 22 Jun 2025 21:09:23 +0900	[thread overview]
Message-ID: <20250622120926.1712-2-honggyu.kim@sk.com> (raw)
In-Reply-To: <20250622120926.1712-1-honggyu.kim@sk.com>

Creating zero size region leads a divide by zero error inside
damon_get_intervals_score() as follows.

  static unsigned long damon_get_intervals_score(struct damon_ctx *c)
  {
      struct damon_target *t;
      struct damon_region *r;
      unsigned long sz_region, max_access_events = 0, access_events = 0;
      unsigned long target_access_events;
      unsigned long goal_bp = c->attrs.intervals_goal.access_bp;

      damon_for_each_target(t, c) {
          damon_for_each_region(r, t) {
              sz_region = damon_sz_region(r);
              max_access_events += sz_region * c->attrs.aggr_samples;
              access_events += sz_region * r->nr_accesses;
          }
      }
      target_access_events = max_access_events * goal_bp / 10000;
      return access_events * 10000 / target_access_events;  /* divide by zero! */
  }

This patch makes a NULL return for such cases when creating a region
inside damon_new_region().

Signed-off-by: Honggyu Kim <honggyu.kim@sk.com>
Cc: Yunjeong Mun <yunjeong.mun@sk.com>
---
 mm/damon/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index b217e0120e09..44740da337fd 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -126,8 +126,11 @@ struct damon_region *damon_new_region(unsigned long start, unsigned long end)
 	if (!region)
 		return NULL;
 
+	if (start == end)
+		return NULL;
 	region->ar.start = start;
 	region->ar.end = end;
+
 	region->nr_accesses = 0;
 	region->nr_accesses_bp = 0;
 	INIT_LIST_HEAD(&region->list);
-- 
2.34.1



  reply	other threads:[~2025-06-22 12:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-22 12:09 [PATCH 0/3] mm/damon: Enhance damon and its samples Honggyu Kim
2025-06-22 12:09 ` Honggyu Kim [this message]
2025-06-22 16:04   ` [PATCH 1/3] mm/damon: do not allow creating zero size region SeongJae Park
2025-06-23  2:58     ` Honggyu Kim
2025-06-23 18:03       ` SeongJae Park
2025-06-25 22:24         ` Honggyu Kim
2025-06-26 15:27           ` SeongJae Park
2025-06-27 11:29             ` Honggyu Kim
2025-06-22 12:09 ` [PATCH 2/3] samples/damon: change enable parameters to enabled Honggyu Kim
2025-06-22 16:14   ` SeongJae Park
2025-06-23  3:04     ` Honggyu Kim
2025-06-22 12:09 ` [PATCH 3/3] samples/damon: fix bugs for damon sample for start failures Honggyu Kim
2025-06-22 16:29   ` SeongJae Park
2025-06-23  3:16     ` Honggyu Kim
2025-06-23 18:11       ` SeongJae Park
2025-06-25 22:27         ` Honggyu Kim
2025-06-26 15:28           ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250622120926.1712-2-honggyu.kim@sk.com \
    --to=honggyu.kim@sk.com \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=kernel_team@skhynix.com \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    --cc=yunjeong.mun@sk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox