From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE6BC7115B for ; Fri, 20 Jun 2025 17:56:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 606D46B009C; Fri, 20 Jun 2025 13:56:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DE856B009D; Fri, 20 Jun 2025 13:56:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51B5C6B009E; Fri, 20 Jun 2025 13:56:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3EB8F6B009C for ; Fri, 20 Jun 2025 13:56:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E66971A043A for ; Fri, 20 Jun 2025 17:56:29 +0000 (UTC) X-FDA: 83576533698.26.C5BF4EC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 35137A0008 for ; Fri, 20 Jun 2025 17:56:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uNuXudnY; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750442188; a=rsa-sha256; cv=none; b=P14zOFUWv33dXjEbqPy4jOhv7NIBe8r7j//Gqh/oMW7i09m4RiNVSN/GFFxSPxffhXue7g gmH/h1Dl2J65lfBOFcWQm/eQ6/XFvxR0EatzsT/S56BdU74A2nTOGWPelEp6JldAarGCwI +BTTlHukmVb7XfOwGvgPsZTDBasVDqc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uNuXudnY; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750442188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S/66D38K2vQkR+dKpsECt3a6/+8NBtRrrogjBqAoRA0=; b=hRRHyAbcdM0ePUmooC+QJyGCIs+QgMYEDV3ef52xi4RpID7y0gvfoeo9r8tMwxSDMN3DJo djFeHHF2KR23gs4qUaRMt3tiB/3RL32wo5SBUFiFjRCVxmdPyIF9APeY6KL/IjK90f7u8c 0P1jPI8IBF1N9GBfTZYM4lybMlRg6Y0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C19D95C6327; Fri, 20 Jun 2025 17:54:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC664C4CEE3; Fri, 20 Jun 2025 17:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750442187; bh=Wkc/tqdrdZQXATgu16su4gqQwzb6rMAGxAVUJLWfZDo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uNuXudnYV6BaF4jJ6bg7mCFJ3GnV2CYHEPCi4L5NxEe3+t1u+Lt0QzHBJgzs1Yz7W qW+X+qKmAJhXto7bvQ2H6HS5bpFvS91QRJmU1xrEi2qnEGes3D7tBUhMJ5vSRCGbdv jMH7MQOVE7UgKcH1JIUoTrPoR15UUxXGzE6S12D842CDua4miNjHmWgaPcSbMeBrPO BQwL1G9hfDaTpJGaUZXDMJnAHVmUgCxtZxwdVHU4DGGSWwW7VBL8LZb3udpA+5wpZL lf831z3e0mdbQIUWOwdj+DjFXAg7g+bE428IRCFNzDlgjXbxdm7HTXXsC6+U3kcS0+ TBEmqCSw5MU4Q== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang , Suren Baghdasaryan Subject: Re: [PATCH v2 4/5] mm/madvise: thread all madvise state through madv_behavior Date: Fri, 20 Jun 2025 10:56:22 -0700 Message-Id: <20250620175622.96449-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <7b345ab82ef51e551f8bc0c4f7be25712871629d.1750433500.git.lorenzo.stoakes@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 35137A0008 X-Stat-Signature: 7w5pd81qbq4up8nznwyenyocyn53xr8d X-Rspam-User: X-HE-Tag: 1750442187-608663 X-HE-Meta: U2FsdGVkX19go1urw7mwrb5S1Fvt1SVUg1KC7f1jcnJWHF7S1pACb80xk7zIN/GeFSxoBi3bIN9iaxK5WNzi0+g3QtlccLtSMMXyfg/1xl8HIXMA6t1Xl0i0nibE++Hxll92scW+rIFSheDGjjMRpfVTcd+scQJyFw7Fa9hxkYrTZ4RAZQrq371yMTlz512sYLvahm3Wtkg3tIYalhgzRtuUNw5lI5gdnL4rwLVWyQmAwWgHNTy0UhDuZGFrrYV/hhW/kwj0tTHp+D1stP9vFS+AGfva//M4aOUa6lK4BYEvlFFDKD0swfbbCpnUClgrJGqc/VOsYIaTxeC0pLteZO7+7SOkvf2xPid5u0YfyDFhiByyB9HM16xlr+of6OafU1fYiSbZ/ua6b99X2eX9anIDijJD5ihgiuQAcjxGYEoZqVIU3Mrhxm0RrmgyKdMfReCy2/J7ihszrxnSX+q2+51DvmzBoAsTNGlyVRTDOvhvUdzH/NvlRIBoOb2MX6KUHP9C2Dos8dpclM7/nnd+oPktIW60XAEBwiZMVs8BGgiYjCNTYkF3rykYXWmKEsJemXEnK2Y48FT1nt6Hz+4SUfTAc6axHyho2DSCnSIoyazrNC4wdEhimvbnGoWISher/E/6vpPnAAoTXrKQ3BoAzD2lI+XjFr4MyKLn6qa+RjbMZwI7l9W/XNAZTB+mLuBa1uxkgAFueWZIO68ERv1cOnMXLqTmBPtXLDGrRGxixGF5eJCoR1FiEF/VnBgdCOaaXKCSjnQd1YosD+ZMaOL64iUBpV6honmf+ozxbYu3XBUCV1Seuszux/I6ljMR7tW7Ly7Ej/WZAadIaLPBVslD53LMrc12dh5ScXs3IdEahEQ1ddOaR4kCp8n6B829wWkQk76A5VRk0klG3Ck+aG1vNrAjHjxpuAATgN4xefZUy/v9h5Gkk3+H7cl/qKzJBXq912R8fXIkFeR2lGLZMyz IIjprUCh QY0Ix6Rdzc6GMwC6EsNrIPtFs9CCB7siPLNa8h8w7J63HoASo7rq3BUXpad7c3y3KfjqieOt8IQTGxqRD8tK+at9D6aASM01rQI0iUxccHefDtPbIYWFORa7JMT0fU63MPKKDzkVKg1vYACtHqgMaqAl8AjfrPXZJKLWPrN6w0Vu2hvx2F7IdBUaNhCo8vYrYxAK9JSekY+MuruvaBMY5DeyHltr2rdgcCTbKGDUpdXWM62ymsYC7tvzfC9H6iOryy6KQP1KjQG9eRuTVpWr6CoyERctDnotgvA9/CIWZB6Vlfw9pnrm2GbOSwvw9JnUfozQb551gtYEpSeQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 20 Jun 2025 16:33:04 +0100 Lorenzo Stoakes wrote: > Doing so means we can get rid of all the weird struct vm_area_struct **prev > stuff, everything becomes consistent and in future if we want to make > change to behaviour there's a single place where all relevant state is > stored. > > This also allows us to update try_vma_read_lock() to be a little more > succinct and set up state for us, as well as cleaning up > madvise_update_vma(). > > We also update the debug assertion prior to madvise_update_vma() to assert > that this is a write operation as correctly pointed out by Barry in the > relevant thread. > > We can't reasonably update the madvise functions that live outside of > mm/madvise.c so we leave those as-is. > > Acked-by: Zi Yan > Reviewed-by: Vlastimil Babka > Signed-off-by: Lorenzo Stoakes Found a very trivial nit below. Other than that, Reviewed-by: SeongJae Park [...] > @@ -1607,23 +1615,19 @@ int madvise_walk_vmas(struct madvise_behavior *madv_behavior) > struct madvise_behavior_range *range = &madv_behavior->range; > /* range is updated to span each VMA, so store end of entire range. */ > unsigned long last_end = range->end; > - struct vm_area_struct *vma; > - struct vm_area_struct *prev; > int unmapped_error = 0; > int error; > + struct vm_area_struct *vma; A very trivial nit. We could just keep old 'struct vm_area_struct *vma' declaration. Thanks, SJ [...]