From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE8FC7115C for ; Fri, 20 Jun 2025 15:24:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE8986B009A; Fri, 20 Jun 2025 11:24:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4A816B009B; Fri, 20 Jun 2025 11:24:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEB306B009C; Fri, 20 Jun 2025 11:24:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A91176B009A for ; Fri, 20 Jun 2025 11:24:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 693E2C0CEF for ; Fri, 20 Jun 2025 15:24:04 +0000 (UTC) X-FDA: 83576149608.05.DE2FC16 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id CFF34C0002 for ; Fri, 20 Jun 2025 15:24:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=utNbcnMD; spf=pass (imf28.hostedemail.com: domain of frederic@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750433042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=snqHl80m/aBYp7c4piln0m2ff20kqE3Iji9VwSdypSk=; b=eV4rGyu8+fN65PjpERzWWWuP6PImVO3dmr/FTn32b7vDFWSk4GyihBLReiEhd2vif0K9/2 D/26w4+2LtJQwqYAALn/TGO1Z1z5KXXf0mzighD///28Af21G5czs/aomIZT931WMSJsKR UVRJypqsL0bdldCJggNLtYmO76OwwhU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=utNbcnMD; spf=pass (imf28.hostedemail.com: domain of frederic@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750433042; a=rsa-sha256; cv=none; b=gDdRFcH2JIuWIPDJ83BOgAAXDg3KgmVnV+ruuLrWU29YzV1uFNDg2byhuP2fQ7Kb0JYJLn nOsu7U9DUw6nDa3Et8S0QFXIBSTS7VSKlf8s5dAtwDHSQAjllDvjpGCRB4e0TUYqstFijP euvw3T4O4iNRj51DkZlQq/kI91bWUng= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2FE0CA52581; Fri, 20 Jun 2025 15:24:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74CEEC4CEF0; Fri, 20 Jun 2025 15:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750433041; bh=7S3CpVL6musulW7mm8cZzqVZcBLY7SkCm9k5f0nN0Cc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=utNbcnMDJu/YLI/m4XSsSSTIdVdwIeqVEAjH7AgIx3D6VKXFn4skDnOTrHOoCMbQk 01x9V0JVqAdLoqkVCsc+E5oVb5/Q0yXNy0+GcoGkuT95M/n56WSfDzV+ppSIHh+8eH WMedA5yPeC7mYpiNxNcSLKMUn+/6EcyqUUkKUotROdtp+84g+mFY/wegouzQCLqfHF k5A/nQjSvEyGtlKogMlvtUEMc5G9CamOIRrNGhPjAw7kyRZXkDqDZ8Ym9t/tAm1RH6 IND+cMVAvxDqjBuULmW5YFVCGzO7SQWECP2ple3oRL/wIEhXipu9Pqd4bZEdzPhDKd ZDi8rwJfD4wDg== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marco Crivellari , Michal Hocko , Peter Zijlstra , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Waiman Long , linux-mm@kvack.org Subject: [PATCH 17/27] sched/isolation: Flush vmstat workqueues on cpuset isolated partition change Date: Fri, 20 Jun 2025 17:22:58 +0200 Message-ID: <20250620152308.27492-18-frederic@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250620152308.27492-1-frederic@kernel.org> References: <20250620152308.27492-1-frederic@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CFF34C0002 X-Stat-Signature: uw91w7fkh4wcoggbeczgm136ffjtiasm X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750433042-15202 X-HE-Meta: U2FsdGVkX1/glJkZ2OeItxu1f/pCx+Zrhc+TXTiRxJVfDguB2wQMqjbV4KDkWW8t4J3no7spHCYrQ/UaqnNmmQkSBkciTzJK3vu4vnYEW5TN1iUKn1FXp3WgOaybbOd4V+Tp7m/iihsrf0e4E9Qfb3j8SRcjb3TkidEH7g5nzkaeh8iH2/wunfzkqRQqrFz90af7/TJjb3iMIkm+PeyeQ0cTA+nQHjq/lWDMqI2MMwIk+YmVkWXpZJTdtlOg6dGg/dL/zb+70gq8hPf3O3Yg/wm1gdwY64LRKYrc3H6RugFeyjZopXLHRGaBf0dcxu40ZyTakg2BVr0EcLY8B3enYaw43QWQTbplB58nngI41MtbpLUlR+ZmEw/Wp16QpyTPUZ6IMLCaJotkkyldevDHdceI2afP8L2VfLG8MC1bt+++4ZaOYvvZPUg0MQuNm66Y97F0OAtU3MrsoNrvIDZBPy95SjRZt69nIHxHq1BRDfV/KzFcTD3kFyZnr+hsC1omYOxaZtbQmEN/k8lUIrWmJ2C092mbfQfFC9GAlglPX175dKKFJlkvUwN+Cih+UlzEhKldaRyab0+QaaMmcwmSB3EYA+8Q74Cu9Mmstqn2XxMjOfeh8LGR02dhjkkC1KPhOyJatMQK2vf3HcKmCfi5wYACDO0pjjUlkEgsWwYp/9iYlRvitG7kO6gWFSYHVU0/uQlXgjZToQNIT1tdC5hwNJsiXkylS8FSucOdUzVry2G6orWrrRX9P2iPyvyHdGky4uv0rlnr3wcv/i+n3T5gUuTrcKPQgo66b+et993G2Q1ypPKIx5w3eakiu9B1LoAcaTCOf3R3esOqr7CITeRz0zURi4J0B1YFp1DhX1O5gZQxMO1ZhazQbGvlQYHoU20oh80Q74LAvf8K0ZhjQXEyueBPJX5iONSjMgxPds1Ck+AYy4bKF0AGsveFMhZBSArBlCEzu+0B61NcE67tGQw 8k4TgDZu NDXikvcCGfigeoxcMB8+Sq7N++oicc5sXwas3t2Ady0R/8lHKX627/oq2L1gBvG9UV51AjiLyQYupT4OeumyQSG69igBdtlDKn1dWCyZih+Gqpz2FYfrQizXN/yTPFmSll0u1hnmwsb/c7YktF3mSSERLxDcyOwzbzCUTcTN71yibgal9DaqT6NANNKsDNTfN82zsFzrI1TswuzfIHpZFnrXOZIaK0obsAIAUqmJRwIkbXiF8h8Jal3/szBRZqmD7HmvVp68yNXpiSNo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The HK_TYPE_DOMAIN housekeeping cpumask is now modifyable at runtime. In order to synchronize against vmstat workqueue to make sure that no asynchronous vmstat work is still pending or executing on a newly made isolated CPU, the housekeeping susbsystem must flush the vmstat workqueues. This involves flushing the whole mm_percpu_wq workqueue, shared with LRU drain, introducing here a welcome side effect. Signed-off-by: Frederic Weisbecker --- include/linux/vmstat.h | 2 ++ kernel/sched/isolation.c | 1 + kernel/sched/sched.h | 1 + mm/vmstat.c | 5 +++++ 4 files changed, 9 insertions(+) diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h index b2ccb6845595..ba7caacdf356 100644 --- a/include/linux/vmstat.h +++ b/include/linux/vmstat.h @@ -303,6 +303,7 @@ int calculate_pressure_threshold(struct zone *zone); int calculate_normal_threshold(struct zone *zone); void set_pgdat_percpu_threshold(pg_data_t *pgdat, int (*calculate_pressure)(struct zone *)); +void vmstat_flush_workqueue(void); #else /* CONFIG_SMP */ /* @@ -403,6 +404,7 @@ static inline void __dec_node_page_state(struct page *page, static inline void refresh_zone_stat_thresholds(void) { } static inline void cpu_vm_stats_fold(int cpu) { } static inline void quiet_vmstat(void) { } +static inline void vmstat_flush_workqueue(void) { } static inline void drain_zonestat(struct zone *zone, struct per_cpu_zonestat *pzstats) { } diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c index 6fb0c7956516..0119685796be 100644 --- a/kernel/sched/isolation.c +++ b/kernel/sched/isolation.c @@ -141,6 +141,7 @@ int housekeeping_update(struct cpumask *mask, enum hk_type type) synchronize_rcu(); mem_cgroup_flush_workqueue(); + vmstat_flush_workqueue(); kfree(old); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 53107c021fe9..e2c4258cb818 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -69,6 +69,7 @@ #include #include #include +#include #include #include #include diff --git a/mm/vmstat.c b/mm/vmstat.c index 53123675fe31..5d462fe12548 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -2095,6 +2095,11 @@ static void vmstat_shepherd(struct work_struct *w); static DECLARE_DEFERRABLE_WORK(shepherd, vmstat_shepherd); +void vmstat_flush_workqueue(void) +{ + flush_workqueue(mm_percpu_wq); +} + static void vmstat_shepherd(struct work_struct *w) { int cpu; -- 2.48.1