From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D37C7115D for ; Fri, 20 Jun 2025 11:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7ADB6B007B; Fri, 20 Jun 2025 07:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D50BA6B0089; Fri, 20 Jun 2025 07:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8DF06B008A; Fri, 20 Jun 2025 07:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B7D826B007B for ; Fri, 20 Jun 2025 07:20:10 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 61644BAEF9 for ; Fri, 20 Jun 2025 11:20:10 +0000 (UTC) X-FDA: 83575534980.28.792C7EE Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf14.hostedemail.com (Postfix) with ESMTP id A32C9100002 for ; Fri, 20 Jun 2025 11:20:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzzisRUr; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of arnd@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750418408; a=rsa-sha256; cv=none; b=MApNu2xaHQ3QuXkuAPyt2XxDQqtNAXZXZo5ilwI3NpAxcgqdgfQA5QoA8GpIHjW9f+oTox KyVpmmreJR7PmSUxEMxHKlmR6l2LR0CAKUgiokqTI6mmXy26eLuu4Ju1l9/v+i/YG/fMrE Cpxe5lUffQqSA3gVgrDmfpbGEm0DEsM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzzisRUr; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of arnd@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750418408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=byhLYMA/zdi+QqumRaAUJRiHWy0yBNCnjQEUiPMIepw=; b=faOPO77hBeizeUX039B/cYQNMhIZtWX+LsW7b4puyKAh3d2Za+ZHNz8R14dnFSYX7JVZNF suVJPP9rourzPHJv9ga2cIfwwuxw1Z9t2LpdmVgZuQZmU8qKgETU7UBalnapZewiKcichp dOv7FHBX78y1cSEIamcOuh849femL58= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5E1C34AEC8; Fri, 20 Jun 2025 11:20:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C18E4C4CEED; Fri, 20 Jun 2025 11:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750418407; bh=lrY3AgKwDr2QnUYeMAu9baBFC0TNe1uwbz5QnFOlaB0=; h=From:To:Cc:Subject:Date:From; b=fzzisRUrhgjv2O7fszTxjloAcgWtEadSboNSrZUxsnMMtS5TfbkONQ7BpGsCQlgeD XQ8Xaovvm1yBLdqF6cFvfx3g3aPsGs8PWoXmUviSnyHMa9auI58Bu5y9ZvCXoYp6aS ObkifRnkI4QTjwAMUCmH0KO7FK9yKqNZUhDG7kNx2ju/+i6BD51AWghA3gsc4nMPkd Vv9NIHmmRV9TciY1hcxwutHSGFTj0c/7uwNRSEPs7RRwMfZiDYsnv7i0CAZvnseKEl MBEU8ZVCPlBSZLQ26w0GKBeeZWAolm7w+Invto+8QoOwCanXVHzDb/T4S9JJUpWT7Q io6AaZSeIPnVw== From: Arnd Bergmann To: Kees Cook Cc: Arnd Bergmann , SeongJae Park , David Gow , Christian Brauner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] binfmt_elf: reduce stackusage in kunit test Date: Fri, 20 Jun 2025 13:19:58 +0200 Message-Id: <20250620112003.3395792-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: A32C9100002 X-Rspamd-Server: rspam10 X-Stat-Signature: j1sazzfeifpd9mnrafdaqbeqcx1sjjko X-HE-Tag: 1750418408-749602 X-HE-Meta: U2FsdGVkX19r+Wizm7tYIXlaexe1wMVRTbxvC25tTGJ0D1XLI9HFsyJp567nVY5zFM4twY8JlxbK8w3qsAKfDx1z+zSswAzaosBjYyB8R2mFbHVVtdiRRekUgACN9r80oLGY/9NBwPnl0Q/10iDBTecMcJoLCylwxw8Yci4q+kEpWogFBZzlWUVfwlYWP6X56FvFozyVmzNgUMFRQ9Iy8FWAzE7seLxVqykmCUsHGoqzTInAMCSRjFcK4NgIgDtFjwltAZAL0wIsIgPK4PrFLMdwOMJ9AzJLRA6fwaJwjTM+7I8DXCBkMSr6RxzurQjyK1ulDZwKy1wqTaRYbIAdl9ruy2BCAGsHIEgfRFuj638l2V/+T1ZtPuAdtgcr0CFjWCRr4DRIyNLEhosO8RRAFIspwg0tLDtyvieH2Z/4WwiIOwuT8y65KNNH0B5QjOEbRaNs1QNqA5Cl/aIO6Pll1jUDMuepxtX7yTzNzLItAJAS9lxlvItJr2jsfWfqKgX+Txw6xCcgrhZlS+Om27IAL45+4hVNPAJD2vsRPL3MqCmFqCIElvjjmlFgQaqIwfszLkGp4s2ZG3h9NVWmzAAn3Gl9CqeKDTQBBmBEJfwcx0YLLX8Ln1hSB9tkXYDO/PmDEHRYK9tpgOO2Oz7bHw8KRCpx2R+v1Soun+LPr2Ie0HXp6Z134eTeWs8c4VsGPaJfIRCkTrsTMq5qEMGym4wYOQWVDA6qvUOdLgIeRRu6BVWixSZcJ8cDeSKmPn4UxRp0rhjUBZo4RBXu1++PnkiY444Xf834XXQjEbMdtTnFrfwj4BNBQNdST6UVO3FlZqXY4xXjFuHU/b54pl8I/H1lHR+8hnOAlR1TrEeU9kFd3wOTt4dyGwGmP1OPfr/SXNJLXDPDTj2u5B0Tk7M1vkGPykylx/i4kGNP6qFKKZYk4f2OyVq5SLkx/7USK5O5sCl9p3BYTm3yvRgw5B0spGE aQOZuK2f c98yvmz54zRx4E8gt5L3DvIfhTLDqZKgHpnAeRax1DASlXghmUrZHC/AUHmkseh2vttp2lCG4a72j9m8PqxDmXgQTocR1XLXQYn0t7T4hyTNAtzPqhi6y11nw6VZMMpqSg3aq46s51kjBw1jPo0TPdqcLDRZwKdTzIgOWQ/eA5PoyL7y83JtbBvWDrQdvkaEO9xMjYJXwrlW5iu1sNszbkl0W2FGQn+TMP5to/1ieKhrwc7k3Ypmc+lIp2iuCYZGIPiHZm0wEZbcq5NjFS+rCY/XB0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Arnd Bergmann Constructing arrays on the stack in the test case triggers a warning in some configurations: fs/tests/binfmt_elf_kunit.c: In function 'total_mapping_size_test': fs/tests/binfmt_elf_kunit.c:52:1: error: the frame size of 1448 bytes is larger than 1408 bytes [-Werror=frame-larger-than=] Change the arrays to 'static const' to not use any stack space at all. This is possible since the contents are never modified. Fixes: 9e1a3ce0a952 ("binfmt_elf: Introduce KUnit test") Signed-off-by: Arnd Bergmann --- fs/tests/binfmt_elf_kunit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/tests/binfmt_elf_kunit.c b/fs/tests/binfmt_elf_kunit.c index 11d734fec366..023042f6aeee 100644 --- a/fs/tests/binfmt_elf_kunit.c +++ b/fs/tests/binfmt_elf_kunit.c @@ -3,7 +3,7 @@ static void total_mapping_size_test(struct kunit *test) { - struct elf_phdr empty[] = { + static const struct elf_phdr empty[] = { { .p_type = PT_LOAD, .p_vaddr = 0, .p_memsz = 0, }, { .p_type = PT_INTERP, .p_vaddr = 10, .p_memsz = 999999, }, }; @@ -11,7 +11,7 @@ static void total_mapping_size_test(struct kunit *test) * readelf -lW /bin/mount | grep '^ .*0x0' | awk '{print "\t\t{ .p_type = PT_" \ * $1 ", .p_vaddr = " $3 ", .p_memsz = " $6 ", },"}' */ - struct elf_phdr mount[] = { + static const struct elf_phdr mount[] = { { .p_type = PT_PHDR, .p_vaddr = 0x00000040, .p_memsz = 0x0002d8, }, { .p_type = PT_INTERP, .p_vaddr = 0x00000318, .p_memsz = 0x00001c, }, { .p_type = PT_LOAD, .p_vaddr = 0x00000000, .p_memsz = 0x0033a8, }, @@ -28,7 +28,7 @@ static void total_mapping_size_test(struct kunit *test) }; size_t mount_size = 0xE070; /* https://lore.kernel.org/linux-fsdevel/YfF18Dy85mCntXrx@fractal.localdomain */ - struct elf_phdr unordered[] = { + static const struct elf_phdr unordered[] = { { .p_type = PT_LOAD, .p_vaddr = 0x00000000, .p_memsz = 0x0033a8, }, { .p_type = PT_LOAD, .p_vaddr = 0x0000d330, .p_memsz = 0x000d40, }, { .p_type = PT_LOAD, .p_vaddr = 0x00004000, .p_memsz = 0x005c91, }, -- 2.39.5