From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C43C7115D for ; Fri, 20 Jun 2025 09:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 164D56B008A; Fri, 20 Jun 2025 05:32:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 115D16B008C; Fri, 20 Jun 2025 05:32:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 033216B0092; Fri, 20 Jun 2025 05:31:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E6C526B008A for ; Fri, 20 Jun 2025 05:31:59 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 65AE6803D1 for ; Fri, 20 Jun 2025 09:31:59 +0000 (UTC) X-FDA: 83575262358.03.9D9935E Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf15.hostedemail.com (Postfix) with ESMTP id B3748A000D for ; Fri, 20 Jun 2025 09:31:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Lkj/KpvE"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=hao.ge@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750411918; a=rsa-sha256; cv=none; b=ZElHkViIgysBsqrn3sANB7UUAWKlVWZBMoQGAghyKUTuNed4j0qZMHC864quGurZcepO9w iYWTXwMOH3mnk2fZne5prH8naSDixlCliHtE/bPRQb0rw6a5xR+DCdaBm2nKD5uhl6CB57 oNF91pgERlCfmI0sRO+qTPNYKvM0oOw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Lkj/KpvE"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=hao.ge@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750411918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=JSrfooRxbJAPfYLGYoCEg7yApw2xfcV1oU74eYA2IKM=; b=gbvXWTq18/Hz1eHrTdkwlo+SfWfGrr7XY03rGOne6dXppOM1LUO85jDU+fCG2/1orUjW3K T5wxsQkyt3MwuGmUB/Z8YWOEKoF+LCFaZavjyP8wVX3FLGjkoUXABbfQIBnrCZI/W9Bf2W nUCJVEXIo+0n1RsfFpHwNR1Qfx4a4OQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750411915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JSrfooRxbJAPfYLGYoCEg7yApw2xfcV1oU74eYA2IKM=; b=Lkj/KpvEQDKcnmusuNEMd2D6o/UIc2xayaM2jY2cIrkOOwmxdmNgofUtAJM28lrAVc3gYn VJgd6MpwBmwZq8T7Gc8iIXCvcJ4jxe6m8BQBGbkKhj+IawCK+TY2xBDsj7hSvonBqDK2gR Zzcrn+NgOg2mHaruIxXkvGpVWy6YcOA= From: Hao Ge To: Catalin Marinas , Suren Baghdasaryan , Kent Overstreet , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hao Ge , Hao Ge Subject: [PATCH v3] mm/alloc_tag: Fix the kmemleak false positive issue in the allocation of the percpu variable tag->counters Date: Fri, 20 Jun 2025 17:31:02 +0800 Message-Id: <20250620093102.2416767-1-hao.ge@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: kms8p7y85gzxb5cqri713ooqas4qt3b7 X-Rspamd-Queue-Id: B3748A000D X-Rspamd-Server: rspam02 X-HE-Tag: 1750411917-888601 X-HE-Meta: U2FsdGVkX18CIEg1mf3L67cDOvdDCQJfnWIGDfxNWShbx+HYH+n5nD2fWWMXUwnMWdVBzxOavtLVXRql++jpTPdrexFCmhY7kf5QYavwXw6upr0sC8clPjaQgjwv48BkEfGNCWkWpaz1sBMK/NdX7aGPxsJdo4TH5bkcHoLCXJ6LorX95CBmQHBZpHl9OdJlMciyUO+ov3EtwOyd6RjkbNf8Ldv0EfWtG8f7d1wQCkK2C9zLXOz0ewR+f0B4qwrPPXJYE+dHHmp9jBAALztxN+yfdyN8INXtPiz3GhqfiIldMmMH0vWCwXO1qXQiUsWOXUTo3AnGbQ//+pDfpiTivIUhRbSPKpMCzLjHODsMOV51CeuqATBF9bL83SQ1c95ei2Em8qqcay9krppR+Ej/tMQXHnWrFHz9yisUAAVghnVC2Oh39+VtvOknifw41XJIPnC/7gUYM7jGIcM/rMfNAdWmZFo45kbHT29loN6BJQHQjgmgsWt74OO0+2PwyuZGMfFZSEJDpYik9oTjQ/rNwb25bIOQTmHdHjyaCcF9tqighO8zTA+A8Qc6/2zyD+sU48BNbCwcevZMuUMPv2BT5hJZhbSiIMGdz24YC4T3+pe831OLkqz4PnpHG5bDoS074XfCoSGJNjS4d4q6d76lapyYGLKv0Oq6vSBiH+URifu9dVM/KbYhyEaft6LgQ9VauGDoTxqjMUpXDB+YffnkiZ+4wLzU+WEhmcr0NZCMvsfWTWmMfIEF8Tn8S7TSH463oqrBtmdExWi76esExYT9USN9UeTRAwwgy6DNqXgCN7k+sAXUz9yT20J0jta7GcmLUm/dib8KIBKdAsz0WkomAQJsn7jvaYRnnlyJi155Mb7x96cT2UkVpEi0kLw1o06LllozFooVrAmYFAnyfdgZdgpy5l+BHTMVHj9IyjbrKY+tocvNYKHd+XXtQpBC+2xk+LhOuMygD8aymztDdlf xAI1gqcS bnbM81FgDn73iERsb+3TbhkorRpzlZ+HhiexVc4io4CqD8KrI4zA1dGSWaQC5Cnxqi7E9PQsz96fNMxbtXxPY2BoKniAo/GVm/SkWA22jogbzSv3LuQDXE+P+67790vuQGkznXbIgIGL9C/kxVf1BZWLmdXzbvn4An+RIitvcX7SwEo8yw++1n88jQ2X/6ME/43/JkNACx+w1iEkOQpTo2iVY0qaO6zAeK7yEvb8J1zcvOFTm5J2Yb4/Pnik0NWe3UQQ+5Q7yh77IA7YtNc5UvK/9DIbgUuw0RcGFu6eBjvBdCJudm9LRn20OvFr+QH7Hho27/m/+E3vcP/0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Ge When loading a module, as long as the module has memory allocation operations, kmemleak produces a false positive report that resembles the following: unreferenced object (percpu) 0x7dfd232a1650 (size 16): comm "modprobe", pid 1301, jiffies 4294940249 hex dump (first 16 bytes on cpu 2): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace (crc 0): kmemleak_alloc_percpu+0xb4/0xd0 pcpu_alloc_noprof+0x700/0x1098 load_module+0xd4/0x348 codetag_module_init+0x20c/0x450 codetag_load_module+0x70/0xb8 load_module+0xef8/0x1608 init_module_from_file+0xec/0x158 idempotent_init_module+0x354/0x608 __arm64_sys_finit_module+0xbc/0x150 invoke_syscall+0xd4/0x258 el0_svc_common.constprop.0+0xb4/0x240 do_el0_svc+0x48/0x68 el0_svc+0x40/0xf8 el0t_64_sync_handler+0x10c/0x138 el0t_64_sync+0x1ac/0x1b0 This is because the module can only indirectly reference alloc_tag_counters through the alloc_tag section, which misleads kmemleak. However, we don't have a kmemleak ignore interface for percpu allocations yet. So let's create one and invoke it for tag->counters. Fixes: 12ca42c23775 ("alloc_tag: allocate percpu counters for module tags dynamically") Signed-off-by: Hao Ge --- v3: Fix build error when CONFIG_DEBUG_KMEMLEAK no set Report by https://lore.kernel.org/all/202506201556.3CQsVRca-lkp@intel.com/ v2: In version 1, I mistakenly wrote "ignore" as "igonore", and I'm sorry for causing trouble to Andrew. --- include/linux/kmemleak.h | 4 ++++ lib/alloc_tag.c | 8 +++++++- mm/kmemleak.c | 14 ++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/include/linux/kmemleak.h b/include/linux/kmemleak.h index 93a73c076d16..fbd424b2abb1 100644 --- a/include/linux/kmemleak.h +++ b/include/linux/kmemleak.h @@ -28,6 +28,7 @@ extern void kmemleak_update_trace(const void *ptr) __ref; extern void kmemleak_not_leak(const void *ptr) __ref; extern void kmemleak_transient_leak(const void *ptr) __ref; extern void kmemleak_ignore(const void *ptr) __ref; +extern void kmemleak_ignore_percpu(const void __percpu *ptr) __ref; extern void kmemleak_scan_area(const void *ptr, size_t size, gfp_t gfp) __ref; extern void kmemleak_no_scan(const void *ptr) __ref; extern void kmemleak_alloc_phys(phys_addr_t phys, size_t size, @@ -97,6 +98,9 @@ static inline void kmemleak_not_leak(const void *ptr) static inline void kmemleak_transient_leak(const void *ptr) { } +static inline void kmemleak_ignore_percpu(const void __percpu *ptr) +{ +} static inline void kmemleak_ignore(const void *ptr) { } diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index d48b80f3f007..3a74d63a959e 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -10,6 +10,7 @@ #include #include #include +#include #define ALLOCINFO_FILE_NAME "allocinfo" #define MODULE_ALLOC_TAG_VMAP_SIZE (100000UL * sizeof(struct alloc_tag)) @@ -632,8 +633,13 @@ static int load_module(struct module *mod, struct codetag *start, struct codetag mod->name); return -ENOMEM; } - } + /* + * Avoid a kmemleak false positive. The pointer to the counters is stored + * in the alloc_tag section of the module and cannot be directly accessed. + */ + kmemleak_ignore_percpu(tag->counters); + } return 0; } diff --git a/mm/kmemleak.c b/mm/kmemleak.c index da9cee34ee1b..8d588e685311 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1246,6 +1246,20 @@ void __ref kmemleak_transient_leak(const void *ptr) } EXPORT_SYMBOL(kmemleak_transient_leak); +/** + * kmemleak_ignore_percpu - similar to kmemleak_ignore but taking a percpu + * address argument + * @ptr: percpu address of the object + */ +void __ref kmemleak_ignore_percpu(const void __percpu *ptr) +{ + pr_debug("%s(0x%px)\n", __func__, ptr); + + if (kmemleak_enabled && ptr && !IS_ERR_PCPU(ptr)) + make_black_object((unsigned long)ptr, OBJECT_PERCPU); +} +EXPORT_SYMBOL_GPL(kmemleak_ignore_percpu); + /** * kmemleak_ignore - ignore an allocated object * @ptr: pointer to beginning of the object -- 2.25.1