From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F01D6C7115C for ; Fri, 20 Jun 2025 04:12:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F32A36B0095; Fri, 20 Jun 2025 00:12:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFF5C6B0099; Fri, 20 Jun 2025 00:12:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B11676B0096; Fri, 20 Jun 2025 00:12:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8EA976B0095 for ; Fri, 20 Jun 2025 00:12:45 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4EBDF160C72 for ; Fri, 20 Jun 2025 04:12:45 +0000 (UTC) X-FDA: 83574457890.27.DB340D0 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf20.hostedemail.com (Postfix) with ESMTP id 4950A1C0003 for ; Fri, 20 Jun 2025 04:12:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750392763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WqQTdtmJfIpNPJKYwBk0X5UjY+30Zte8xXVtxC4VkSU=; b=hQo69vk+NpI+SpRqSiQK7Q6UtokqdsyKi5SmbRh3wdPmILTms+yX+3gVK0NOE5LOd+jV7j P7LiMxwkQDSCDYxz8uFpgd8uAtOPuPNakfxt/vi0I5fFURabMw/xCM6l4X7DkLw6q4u5sD 81pEJI6bFh2ch0wDIxBYzyrFfYI+EbY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750392763; a=rsa-sha256; cv=none; b=P87RjDTmztpjHQe8qOlu4mmsAmdLtNxR7rLHN9vIiFhbTAqaiz5Pyb1EmpfxWgntjaHogX NBio9+Zyfb4Tg0sXIA6pzLyxoX6ToBrRsvrBiw7GCtKWR3CQha/3+xKBfT/GAsBU19kahj j/ws88AMkBzq9I2BE+rLDwu5zwQhf3E= X-AuditID: a67dfc5b-669ff7000002311f-97-6854dfb383b2 From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Subject: [PATCH net-next v6 7/9] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Date: Fri, 20 Jun 2025 13:12:22 +0900 Message-Id: <20250620041224.46646-8-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250620041224.46646-1-byungchul@sk.com> References: <20250620041224.46646-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHe/eenXO2XJxm1Ek/COtGdwuLJ4joU50PFYVBUHQ55aENtymb rhlEpoPI8rIuYNuq1SqXGpO1dGZJzZUTjczSlmtOtILANLNMnV02Jerbn+f5/37Pl4fG8nJx Eq3S5gg6La9WkFJC+jnh+sp7kd3K1HP+WWBzVZNQNWaEil6vGGyVtQi+jYcoGPE3k+C4PorB 9sJEwHfXBIYPz/ooqHJvh8jtjwQ8PF2Hoa80QEKxKYrh0fggBQVepwjaa0vEcHHiFoa6/F4K Xj2wkdBT/VsMH33FBLRY7hAQKdkMz+xzYbR1AIHfVSeC0XNXSLjQYSeh3xRB0NHUR4D1VAkC V2NQDNGxmMP6tIfavJBrGhjCnOfOWxFXbwlTnN2dy91zLuOKgh2Yc1eeITn31/MU967rIckF yqMEV+8dEXHFhYMkN/yhm+CGGjtJzuXpJLg2u5/aOXuvdGOGoFYZBN3qTYekSuuXN6LsEqnR 9wvyUZguQhKaZdJYm6uN/JvPNjlRPJPMEjYYHMfxPIdZw470NRNFSEpj5i7J+qtDVBGi6URG z5o+TbEEs4htD7WI4lnGrGO7BxvQtDOFrap5POWRMOvZ4YKGqb481hm7YRJP92ezLZffE3El jt11XZXHxziGFt634vhZlvHQ7I9oOZ52zmefOINEGWIs/+GWf7jlP9yOcCWSq7QGDa9Sp61S 5mlVxlVHsjRuFPuX2ycm93nR1/Z0H2JopEiQeb+lK+Vi3qDP0/gQS2PFHJkjsEMpl2XweccF XdZBXa5a0PtQMk0o5snWjh7LkDNH+RwhUxCyBd3frYiWJOWjFM82yVXJgQWHM2tOnt1DpS8O h2rw8qWFM7Y0a7rNFdvaKm5MtqS6bypI7UIq19y0wi7fmjxQcMn48nur9nXZT7w/Yg4Y8p47 AgeubTDnDNnTQ4qjHjNfqu5NzniRUjhQK3Xy2TMnG4+z87qywgmOjbsSulr3k4lrKUe/Ndyt IPRKfs0yrNPzfwD/hsCVKwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRiH+++cnXMcrk5r1EExcSGBoDXK8UJRfetgJFJKdNVTHdryVpuZ BtHSQeRlXQnbZkxnNS+xmKYzTWKabkVkk8y0OVkZFeUlTVxatiVR33687/M+75cfhUkCeASl ysnj1TlclowQ4aLkTcXxjb5U5XprKphsDQTUzxbA3RGHEEx1zQimA0MkTHX1EGCpmsHA9EKH w3fbDwxGu/0k1Nt3gu/OBxzaL7Rg4L/kIqBcN4fBo8AYCUUOqwA6K91C6G3WC+H6j9sYtGhH SOh7aCJguGFBCB+c5Ti4DbU4+PTboNu8EmaefUHQZWsRwExZJQHXPGYC3ul8CDydfhyM5/UI bB0DQpibDTqMT4bJbbFs55dxjG2qfSNgWw1ekjXbT7GN1ji2ZMCDsfa6iwRr/3aVZN/2txOs q2IOZ1sdUwK2vHiMYCdHB3F2vOMVwVo+TghYW9MrPEWyT7T5KJ+lyufV67ZkiJTGideCE3pR gfMXaJGXKkFhFENvZEo7rSiUCXotMzAQwEJZSsuZKX8PXoJEFEbfI5iuhiGyBFHUClrD6D4R IQanY5neIbcglMV0IjM41oYWndFM/f3HfzxhtIKZLGr7w0uCzGy1TrjIL2fcN9/jISUW/Gu7 JQmNseBp8QMjdhmJDf9Rhn+U4T/KjLA6JFXl5GdzqqzEBE2msjBHVZBwJDfbjoKFuHN2/ooD TfdtdyKaQrJwsWN6t1Ii5PI1hdlOxFCYTCq2uJKVEvFRrvAMr85NV5/K4jVOFEnhslXipD18 hoQ+xuXxmTx/glf/3QqosAgtqrBWpwe+LZtfsqD3y0+nkVGRSdKYg77C+LSvUdTHNfjwp9Yj uc8+J3dxkSc9Nc/lW59PSFxxW+b61tZsdStSUemNtA0R+/u9o9qY1T9HdE9Ld/SanIcijw9O Hj6TfSDl667KPO/ZTO7c9rG9ioToA2WKQd5WdU9zcWl4ntFbZHkpwzVKTh6HqTXcb4JAdcIM AwAA X-CFilter-Loop: Reflected X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 4950A1C0003 X-Stat-Signature: dhemfigan51pxnfwjbtzkhkos6jse8ny X-HE-Tag: 1750392762-778970 X-HE-Meta: U2FsdGVkX19i6CXtefroW2QTu2HMZe+enfr80KVOXDVSS1iwji0POhfNcEfh+F1P1yKwGZx5EsaSIvynf9sNu38O6NxjLhzkqInBxnhReMTWKGYZw+LrqR1kUjj47aAjUrBH/lq+n9vP9oiWaFSSFAHGothJd2Mk95XDF3+U/UAH0xtje3U1obpgPha6+9EY7MY1Cm9pt/2KbUD8uVgXrZkbIdZbamgFRcF+/LQCh0LPDSwLp8dllOfIdbVEBE7iPTkGcbW5wBVUkO/YNQmp9eeLwfv1aKDxPfyKeMZrM+wHPOL2e1eYgVoIJYvJXuEjvbhxg0lWBivqrYjEJZQYJ9ksY/t4O8afh2Kq85PhYv54tksyfMJtZwjo3SS+es+UQJzQuXqX7HxKjUWA+tNU4YkhRCqm/eagr1we5B+KWiDBI4K5mwDmZy391QVcWY4z2FsuCY3LHzilWOTM/dEwcG2W1g4qGwOSCZH8Y5NbIHLT/RaCIBE+8AdIQvWBwjQ6sV5NjFoMKf3yktKKwYyJQ/AwaDJpgepXm0wTwYLxCnzodbZdCp25o2asWz741eNlx/almYhhSV4EKF2aFOWOg/kKoQdS5lArSUbTjvSAZ/eDzdoIoZdvGUNCtA6yW+vVsuqqpud+iuuEr1YBGNL/+3lybAphC2NwGzk4wCUrRHWFJbxCf0m1IvI36aOf/StxvLXVmQv1kKEwinpVyYqD7gQERhbjt9cekppqF/W9IMVV/EW0uW5SdCbji+zbxkorg8eLOALgRT7X/e2l3zY5fRVVSUuMOSSTyXDS8jZeJnYPTrFo2tsnV+STsKl6E7PGn5VXBtqQcd/cWjo1DYSfkL9qNbe+KHLslK3g9M2Hs7fOZVex8+QPg7vfpDgNgV4M9fFCB+wbu9KSccO2tDQlU8NaDXk2YnE6/bIWBF9eetM/YgG47UGARdK+dKGghbt56B1i5aaCV8aU/amgyVw Cu9nEp8S DBaoI2FNA2r/zv/Jw7gBuEuNQQh5T4QjCtw36yqTpjQuyv04W4OHeEdtFo9MN6MBqgODGK24nHRNxuid9lKnP+Pw68dK+QdSn9s7b3IQNhZ0aT5E03da28I8cI2eUsUmXsLBTQYDQXLoN6pfkv+aYQK8RgOWjPdnq+/yOQpqbM0Jv+pUbHhEk5Eu0naZqDY9m02tgNtKTMrgwugAjPfZpuOLSm8Anrd3JG1DhzW25EkTjtyWIv+BEM0rSYunct0ck3mm2qXLTOSDFD0FnX/jW3Kmk7I6JpJ+e//eRDtC3gEcqVfrF8IXX+BLCdVtWINajzNFB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The page pool members in struct page cannot be removed unless it's not allowed to access any of them via struct page. Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but just wrap page_pool_get_dma_addr_netmem() safely. Signed-off-by: Byungchul Park Reviewed-by: Mina Almasry Reviewed-by: Ilias Apalodimas Reviewed-by: Toke Høiland-Jørgensen Reviewed-by: Pavel Begunkov --- include/net/page_pool/helpers.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h index 773fc65780b5..db180626be06 100644 --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -444,12 +444,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) */ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) { - dma_addr_t ret = page->dma_addr; - - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) - ret <<= PAGE_SHIFT; - - return ret; + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); } static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool, -- 2.17.1