From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB156C7115B for ; Thu, 19 Jun 2025 18:40:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 451BE6B00A2; Thu, 19 Jun 2025 14:40:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 406B56B00A3; Thu, 19 Jun 2025 14:40:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A35B6B00A4; Thu, 19 Jun 2025 14:40:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 12D286B00A2 for ; Thu, 19 Jun 2025 14:40:56 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5194EB780B for ; Thu, 19 Jun 2025 18:40:55 +0000 (UTC) X-FDA: 83573016870.06.5B4ED92 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40]) by imf14.hostedemail.com (Postfix) with ESMTP id 62E4F100004 for ; Thu, 19 Jun 2025 18:40:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ubSsC6Xk; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf14.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.40 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750358452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pwrbRhSITiFUmkTz2iXOX5glx7JheCBiKAgbaR8OW64=; b=zOxVnYsWFl+hr0rSDh4/Nx5UPa3+5GXTGFbqa8ztrr37lReBc7CKnsixUmYSMD3tFLPydo S/oh/XMImTY5TPkMIvVsqlesrGOV2JqHIxLCjePv9Q2kG+mJRs7zjUIrtLLuuc8uO6MoSI Uz7BRadRzz3D2oljLX8ARgjXOdVltWg= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750358452; a=rsa-sha256; cv=pass; b=NPFeYwqXn0nmOfUFXR1LcNm0WMg35WAF5+KVCwp1OYQSHahpr2lfeovIpIKtKNNonlBXfH f/CwH1y9ek6so0Qm3tDgixbQHFLyFGivkLxQZFbMZusTDaKAeIMnHX2tSFi2e+jB0pExxc dYvvlPA6DBmebfKHZ5igSnhRwluNr84= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ubSsC6Xk; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf14.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.40 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qAKl9ctQ5whXFAAgCKVf5NW5yWK5UTK+DA9Sj384GNRLxiQufZHsTRgUXC84p32MtKLTS2/17DNxKqpEBBmSSPkpv0kXJjhk1ths3Uev0mHlcwe2MPhtHqt0EgFTnTg8d9J7JtqPdT9yKkrzMeRjeWQA8Y6zbNFIN56ce0HyPsX6y+d6ZA+94Te3HV2d+GP4K6yIbLYcvtmPOax5z8E6djBve/VthDBHgEFpn0rY+DDRzpAbHO+x9Xj6Crnpxlp73dP4nVqyS5zh0jxVKq96PJwGWYONSQeRwUZcw2Pb6mv9ALLtPMspjJb7ISNz6GPaFAwdHe5qPt6PyluTLTNk/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pwrbRhSITiFUmkTz2iXOX5glx7JheCBiKAgbaR8OW64=; b=u+tdZL8+VjLvBAkhCCozez0g4bE2bxoKuJpofzGZNycQklxYSfN9suA30wz7+PCPJGocwTw+Jja2RfZ7ED7VS/Oq8CMkn3z+QI0jiS5ylVWqGwi1Z3IhLewjqx7MmwtaHBxhfhQcn+Kwih+UkkvQTSaVyxiKjdhDJQtbo1M8gWhll8YEi8/AM4jNacg4slnzwiMJjHwvRWe3gFCEOd7QaD+LvRDBqt5hPrLJBlJZLIGR1zr7FXpHNxWnR2ll/IYjvUa+KHkmtWJX4XwVOjoI4pxLMIOUwPyKX9E9UelgPOlXfx+5Gn0WYXC2sLl+AljeWVkgfkd1Tt77cLH3oora7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pwrbRhSITiFUmkTz2iXOX5glx7JheCBiKAgbaR8OW64=; b=ubSsC6Xk4f3stOb1kNSCrl0hsH83m11uTSxv5yOPRf/BmQ9MxswBbj14nbtsI5Xt/mR31SbvCLoLXvNe4qIo8sS6/zp3vw2Li4fD8/e/x/HNh7mxBJ+AC/c8YLQxqmJtR1UI1uU58pczAL1bSZg8gIRsoiZ+Q1qQCOhI29o5xOmodW6fQZeew5eG9TUJG3hB1fsRlSfGQzqfDITNLXQd++F+tnk3spwkQJMaDLKhc/ZXDXKQakUyS1U36UWHBfilL3xWhN+JfyhLgeB3lgi+hhYKEJYusrmSTQoiMmSYX4HclOZy4hfZ1N8RtylTpRmMw1d8RXrAGZbGzpIIQj+MRQ== Received: from CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) by PH8PR12MB7183.namprd12.prod.outlook.com (2603:10b6:510:228::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.19; Thu, 19 Jun 2025 18:40:48 +0000 Received: from CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732]) by CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732%7]) with mapi id 15.20.8835.027; Thu, 19 Jun 2025 18:40:48 +0000 Date: Thu, 19 Jun 2025 15:40:41 -0300 From: Jason Gunthorpe To: Peter Xu Cc: "Liam R. Howlett" , Lorenzo Stoakes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Zi Yan , Alex Mastro , David Hildenbrand , Nico Pache Subject: Re: [PATCH 5/5] vfio-pci: Best-effort huge pfnmaps with !MAP_FIXED mappings Message-ID: <20250619184041.GA10191@nvidia.com> References: <20250616230011.GS1174925@nvidia.com> <20250617231807.GD1575786@nvidia.com> <20250618174641.GB1629589@nvidia.com> <20250619135852.GC1643312@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: YT4PR01CA0214.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ad::21) To CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8659:EE_|PH8PR12MB7183:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f7e6f7e-092b-4187-0d95-08ddaf60ceca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zIVT1Cims04YIorFZdNI/xoGcaG/DvRDrNdO3hHNVKbk+RHhDLJYbjwaxwCO?= =?us-ascii?Q?w/MGiRNaqwQ6YuRfe2z8xYiJS3T/HtG1McJe70o4FK1iIaWk3fJCc2J3WwGm?= =?us-ascii?Q?e2XZlEI5tIOiARMdGJ3OLOeaNUflE5Qjk8mdXLxk+pIsdyOaRH1vv8tLxVEK?= =?us-ascii?Q?csoJHXA5ZZQYWmf0kL7tdBy2gsc8tVt3KYC1hWHAcyGnezUz3pdEsvHOEmoS?= =?us-ascii?Q?DugMJmEdrDUHpY9VMAf/zefJwSROcUesYFxJ9gNlheUnyE+4gzoRUez4IguN?= =?us-ascii?Q?bLaTQc0AaWYixlJpGbT2i+qFn6cEAS8Ai/FJ5h/yr4Cgoin4nRPl7SOzLt/T?= =?us-ascii?Q?oJSfAYBZAJehh9PjDkIQROXxR4Vd4ACgfoo/QuxRpnjC6Cbc/KMEnMu0nGgK?= =?us-ascii?Q?pTqG0xFYChwEDIuUzjDWtbTXyj6h+ws+leajlSkIiqe00pquPccLhVHR5TGH?= =?us-ascii?Q?4evvYZLzpGCpe059VU+CkJ4VuMSJ3XNvuXBPumYsvOUgtEZWatNOBOfKUBGi?= =?us-ascii?Q?CNxEmJDChxXnJqTfLmylAJTewVY7kynptNkJut+G2CSgO1+LJfxu4AgQlk+Y?= =?us-ascii?Q?FawXPEcKTXJad4SFLyOswKQzjEBGJqxLc7YSAwSDExGT7ewF/GHfkftBSW6m?= =?us-ascii?Q?6D0GZt2SyG60ms342XRqntyHv6Y4V9VE4hn3MFUsH72KgfgQ96POfS27rX41?= =?us-ascii?Q?0voioIhJ9LONLGvN8dAzhUDK5QwsLuDbIKpn7Gd0DG2pvO4QM8cmk0DG6GHJ?= =?us-ascii?Q?jnuP3S7TKaMcpy6u7lcX9i0E861uGA71inhfzMSmZnx6Dd+gwF8vq14pT3Z1?= =?us-ascii?Q?Yn5f8BwLFmMrUFRqM1sb84+SvTl9Wu19mVTh6czXXcIAo3FvrAZU9iXB2zFy?= =?us-ascii?Q?Pbqf/fEERoE7IZ0m2CYTfzYHmxyenVotawsNarL/SJleYuiF/MPbpIib65CR?= =?us-ascii?Q?MvkET1t8ThZtXxVwNKo5NLS5HOI01yN1C0+0/39tvK245Sj1El9v8jSV7tvj?= =?us-ascii?Q?yPThL2bmMG6tWYaPRGruS+Vgkexu3BndhZpLFfVv+nZdlY7NX9TmHzzeKVx8?= =?us-ascii?Q?ZVgtsnBWDDtzcyfEbKQRS0Bm0rCY4XHhTcjoIh+fKqFmU9kPnoub+xw09H2N?= =?us-ascii?Q?WSlSbR6mfoEfR893lvbIynxjPMMrrAW7X39v9WdH1aCTVWyI1hahlzU5oHIW?= =?us-ascii?Q?+jV/ro7NekbDQpoTuvbyv8lo5As1fSj4pqhR3Qcfoy9eo/kX8Fpc4XqS5kWd?= =?us-ascii?Q?JK+k15rxNCh29iA7bBzZzvfivgkbPH88PNwh7AzWLHizrN/wx5Z6fcVl9kh4?= =?us-ascii?Q?4zmVuxDV2nCHHEK1Dwi9ChD+tGOMPyPKzEQ9KlXW1Bzd96lFUQtpSXYF329L?= =?us-ascii?Q?ka3pEy0RBC9iJQgcDLSa0xarLdAqrpfYlzOWKX0OVqDHO3wh9pkVMlOmjjjP?= =?us-ascii?Q?Wv/5/cgCltg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB8659.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d/PeYEXJFQG4kudz9j+wskDr7m8aNQUucIeYxwq9Py1Vr9Pu4PJJiA/avuWA?= =?us-ascii?Q?k+hKQD/+BJHRporxYXLC//vBarFiBqZgh2HS8p2DmLVQgwLaOiD8R7ugYr9X?= =?us-ascii?Q?Mv2DrmgdnXnTk0uTW69z2CnRTJx02bQewsWd/Ay8WTppzYo+DnOIhRAn3ctP?= =?us-ascii?Q?CsOKOQ2FpaAt0X8K8F6gaBo+LhqTKbp15mRu+fjeOGQPKmocIq90xYMgx1GZ?= =?us-ascii?Q?0C4IY2JzNnGGEp1C6ktDgB+d5UPAyqoRGfMQD3Z8X6lFKFFP3dvXfMpEWud/?= =?us-ascii?Q?BtGyh3D+CL69tGPh6slZjzfZX5srRdJ+vvGuGvOkEyL418RVAhHXKyUEwvKb?= =?us-ascii?Q?TFFQWMbAWJrLSZWgENqrtfaq9M1+4xpSkFSSrTCHYREKzwp1O1vI5aSxOek5?= =?us-ascii?Q?9+t/QoStkfIbwYMqLzEQO9oSO0TpkaBJpIVnKt2aBGK1k7Mj/afdehghgzth?= =?us-ascii?Q?/BBiEBYQkI+6LqNEkfpghogKZck94SBvwJ1AwiJe1rz4/Xzg1Ih0t4V8iJmw?= =?us-ascii?Q?N6CatvJidA4ZlWRdQgHMrrBPzqf/oEddj53dcWxsFPyc4gySo/3UTUyoujmM?= =?us-ascii?Q?DhkGa9CUSKYOZBSzPHlPkfewmTlLEP+BvoqJubiOZIS/majz50cSxZk9SeE8?= =?us-ascii?Q?SDK6vAJP0LzvdNcNCdzD/l09T0aLfGBJwj+JaoSERHnFb83u/PXRPGfCqumI?= =?us-ascii?Q?cb5pf7tg1pJo9dVQVnzmeCSGB3Bg7d/oR1yok12RarHfFEKFgrNRkYKyCfYV?= =?us-ascii?Q?YWWybe7KN4HgU0AbCdEck2XHNNb/21G5lOiBNL77egaRUfW5UQmT+s7O0u51?= =?us-ascii?Q?a4ThEJ0MaKUr7inapJgWJhcWRhzDMb2FhjSICiCwslOLNxWIySVytf6/3ujT?= =?us-ascii?Q?hoB/f+/319aBgckLa7X3lSqfv6KuPJT6I1ze2IBopNWSxGPSNUCxPS8k1VTo?= =?us-ascii?Q?IqsJRVuuj3IhdzN7aeRQTpKc62r4dUpexVI96O8e2sdeqSbaxTZtPpA0TVzb?= =?us-ascii?Q?kH139SeilTPT4iNSZkquENhuk1AlIP/5WKQMYj4dWcAwzgLGj/WomWNqyRLT?= =?us-ascii?Q?jnDHeSohe1NpR9AWmqS+gtOjpfhxbSsh0n0+vbLmLy5H3Kcp0ssPU8q0lAze?= =?us-ascii?Q?X/wAGjOLVnts6oucnwj/Sdz9fe2l6Zh2oj+Gpj1bKDhIpAXhjHTz1raXFx6t?= =?us-ascii?Q?v1ak6JWNxsGviB7JAz7AKa/jpmldMSdE+S6ucNEsYWwkicWDAsjTnz0EBS5T?= =?us-ascii?Q?zzLp6JvgsS/BBEgoqZMBnMpAfqAHe0Xe81B/lPrehJgyzyfmyqSffxmXA0o0?= =?us-ascii?Q?uvNtdJuCPRnK40kOHUJiRYTz80egSQCOamok64UD9k0bAr90qAnDgBSVJWWJ?= =?us-ascii?Q?TKpcVmQW6LFkzLyKNrdrrvKX+jVk2yhchYV0sHxChHMdtVuou4v/YLrIZfqU?= =?us-ascii?Q?5O6AEtOejExuEH3S8CDVrnKePqKYAkkFkRs5sqiNKV7kNyv8j7Zkp8k2+1ss?= =?us-ascii?Q?JAaoUuFzV5l+HZ9ZQvvHocI+XwmXXHLFPL5gqyNzG/84RoKPHC0S1AJR0qlY?= =?us-ascii?Q?MN98wfGEA6rp+pqS2TyZkicbeqfX659AYMCRx3Xd?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7e6f7e-092b-4187-0d95-08ddaf60ceca X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8659.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 18:40:48.1777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L5zFIBb7MvgRYM47JH2+g4UgeUNhNIoOzrxnDlIIyXidXFLHWCHRBbjZeA1e5OkS X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7183 X-Rspamd-Server: rspam03 X-Stat-Signature: qwyf493xok9a5fn9ya7sntfdzcmsnty1 X-Rspam-User: X-Rspamd-Queue-Id: 62E4F100004 X-HE-Tag: 1750358452-102214 X-HE-Meta: U2FsdGVkX1/v/gHlt2JdK9RX1XdI8yTaVdEOTGOzCjurGI7qFvmptupmAUIWXgo3EY5ngF8qsWHIdADuEtNPwAEdYcxqtARlFql1m8ZvZnBzUhec8y6IA82ru9XV6eDmnceJH5lHsXoBXRauqoOBua1UN/lbqbEnYFbszWb2xyy8/WFUb+JM9ejaxCAVAJRPWmlb2400Hzq71FDNf6jfPFfHqMgkhjUC/claWpWWrnueP8NAeI5KBv/zFNhRzikAbQiuASEN3dR2A/SL4NA96Q6ANvGhpOWWz+o4Bs9XWc0bwiO9ZoxPHQIiuPBfjeGbhwTcQQuKv7flvTowhMgtiKYhX8+Fy7g6tMLFoDOP05jCoKGzrHgyhLLpIl2ZqtMT2b7FI/wxFMhbGmYT7HO96sM0RuNd74mAH12mMlK/gKz1ngEn1yzeA7VOKSypBmvc1aHq/FyAjMF4uJ1Tk8somHyhoe5B0LrY/NFCkB6l/xWb8nEfpXzBUKGsDugskzyUPEpPnQK0TnzLptR7TgehGQ/MIpVKnIno2qCM6vVybW7ccNCIc7UxmwfBIHCi4iHo8HVfCSIWohiZV47g2j/TjKnoJzyc1gm8E0SVJH+kqJUgTlLCMw3HrXNWRtc8pew7ujRiG6S0+OfwOv76YbGFyP7BeCmodvQyB5Yxn0PgUlWjD7WOo4CHNsDId1XLiUeWTnvk1jYROMA8t5VO5LN5QInXRtGKLkNX4OywVYhh9kB2ECd1o+3S/NxJUXMNNVuPB9/suEHok4o+KfEyKl95V6/0q0x5DLe1wqbeJVx0kqDnAjR6h5qYHG8SIqRRsGTXUNg9VmqvWAFhDeiGVxcetzyQ8aZoazleB+/MiJu7yy4MVxzo8XYiT4IZ1rJYD4CnDB1+UxKe81wE2jap4zF/28waFzsd15DCau6zwOjbxeOPrXSFM6G1245MQ3FCTPkM5mt+w3EauZuKIm/p5X9 EOGqO57K BBECfZCBAOVOL8tpWaTItxorIQNxx+9d392Y+Z5vNe7rpITEUbZqtz8nnNDNUWljfc/DuWSPp3tgJfIoZP2aU/hEQXiHu5vkFFDHGyyqGzhqgvy9S4KL1LZwSnzXTztn6DDi6DIpqNQK+JAfoT+UnEaf0Rn0dyGDZu3CkLgmQWhLdD9hsrGErwo9a4yvlovZhRs1bk1CDg+rI6tUdncFmaya+VHDsnpWouNWL8B4Y9QwtXtCRindCzLtfaCnrouDZypR+qGdKPuadsaxaAcfg3YwkRIbc5ebPIMMcGt+p5wknZBPu0aHEFEjqyqmiUPMjyks/p0YWCFtDLgDroKfAuNur+TwvyTRSSuTZ937FoiRQ9kOD0uSaU1tq1uyevcFHbJ2yEx9fGVTTNHigzmoKOolST7sWpDJe6dvAKDVJPaJSDY5YihgzB/8OYDEYvrnJsQVtwumFPYkFH/kji0qvsmAqvJ8pUfvj1NSePpzRcv+NS3gSHfTM0opxCmbWiqabL0XdKA3f5Krr11LnR1Jrid9IRrm2azcmZTKIbGdSP9H2/r8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 19, 2025 at 10:55:02AM -0400, Peter Xu wrote: > On Thu, Jun 19, 2025 at 10:58:52AM -0300, Jason Gunthorpe wrote: > > On Wed, Jun 18, 2025 at 03:15:50PM -0400, Peter Xu wrote: > > > > > So I changed my mind, slightly. I can still have the "order" parameter to > > > > > make the API cleaner (even if it'll be a pure overhead.. because all > > > > > existing caller will pass in PUD_SIZE as of now), > > > > > > > > That doesn't seem right, the callers should report the real value not > > > > artifically cap it.. Like ARM does have page sizes greater than PUD > > > > that might be interesting to enable someday for PFN users. > > > > > > It needs to pass in PUD_SIZE to match what vfio-pci currently supports in > > > its huge_fault(). > > > > Hm, OK that does make sense. I would add a small comment though as it > > is not so intuitive and may not apply to something using ioremap.. > > Sure, I'll remember to add some comment if I'll go back to the old > interface. I hope it won't happen.. Even with this new version you have to decide to return PUD_SIZE or bar_size in pci and your same reasoning that PUD_SIZE make sense applies (though I would probably return bar_size and just let the core code cap it to PUD_SIZE) > I'm a bit refrained to touch all of the files just for this, but I can > definitely add very verbose explanation into the commit log when I'll > introduce the new API, on not only the relationship of that and the old > APIs, also possible future works. Yeah, I wouldn't grow this work any more. It does highlight there is alot of room to improve the arch interface though. > OTOH, one other thought (which may not need to monitor all archs) is it > does look confusing to have two layers of alignment operation, which is at > least the case of THP right now. So it might be good to at least punch it > through to use vm_unmapped_area_info.align_mask / etc. if possible, to > avoid double-padding: after all, unmapped_area() also did align paddings. > It smells like something we overlooked when initially support THP. I would not address that in this series, THP has been abusing this for a long time, may as well keep it for now. Either the arch code should return the info struct or the order should be passed down to arch code. This would give enough information to the maple tree algorithm to be able to do one operation. Jason