From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 189E5C7EE31 for ; Thu, 19 Jun 2025 18:36:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5334B6B009D; Thu, 19 Jun 2025 14:36:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E5976B00A1; Thu, 19 Jun 2025 14:36:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D2A56B00A2; Thu, 19 Jun 2025 14:36:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 24C6F6B009D for ; Thu, 19 Jun 2025 14:36:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BED1AC0975 for ; Thu, 19 Jun 2025 18:36:16 +0000 (UTC) X-FDA: 83573005152.12.30B15CE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf12.hostedemail.com (Postfix) with ESMTP id 395B840006 for ; Thu, 19 Jun 2025 18:36:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GQfzEKei; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750358175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LNSuPfTIjBxqykrFA3lj5QRYXx1CTzVXm8n012Z8VzY=; b=nZKDgEtMGyawIXDQhoygFeekbeliqsBu5C4l9rCqeo2wkA+yyr8Od7s2yAu7rkGdtNUBXd uxcnTnDv0MGZnt70wic2C4DFM+jt/6Q9pEy94UQpJRx3xq5uITjwSYAHLrF1h04EXZCvGa Um+CqUgqql19LSBE1yUzHYTWCTlSlAY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750358175; a=rsa-sha256; cv=none; b=A4Yrb96s/CT/B1UzyTWS3kDYhhkdtcZ5/tic6CuW6Rgc97m+UWVLekoKvzxYOtwNvTvK/Y a7A5Zy3GbnUogMSq7vaO8P/rR3Rx/UIlxhX/P7RflqTEKH5rCmDrT0vfqj34IcspfFc9/Q 3ekhLQBiXvX5a4KC9XMMNz0HBtyVcNk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GQfzEKei; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 96B31A5469E; Thu, 19 Jun 2025 18:36:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 342A7C4AF09; Thu, 19 Jun 2025 18:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750358174; bh=h78HL1yhuRvAVMpXPcUMwO2YijRYqZLpPbhvfJ9cjQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQfzEKei/1zZvyDY1Tb8HPf3vF0y7sqyzYcDjV7tdUQzqJqKIiyuhNH2RL8fj3Zes DCEJOEJGdipAMa/jEHbzOxx5hhpLLlv/H9dPUpBcX+9s5uBCq7IUUr7CwPe7LIBlQN pHF+f7Di90RTr/5Yv74webbgxBPoOZ5aui4Q2hKn9b8kl0EGEC/Hym/MzFsa0ZiUZZ S1uklJjU4bDvLsRK1qt/HHGq3KSQ1cb41oJJp/f/ontLZVZ6yBUgAecGtMyM9/WOVf uo2brww9xsSdNIX04UFXEeAzBF+HTD89CR1vvwdkzwQE9D8sx/Vu3A0eiqdCBnRm2U 2alJ/tI7VSwCw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/2] selftets/damon: add a test for memcg_path leak Date: Thu, 19 Jun 2025 11:36:08 -0700 Message-Id: <20250619183608.6647-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250619183608.6647-1-sj@kernel.org> References: <20250619183608.6647-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 395B840006 X-Stat-Signature: smo15ugk3ne6rsbb77x89os4eyjw6sko X-Rspam-User: X-HE-Tag: 1750358175-37364 X-HE-Meta: U2FsdGVkX1/EyKcQIsNgsEQsO8SYHjrqaKIfRC30jzxlPc3H7mhkxm/1RW0NlP/HuE9CpA7l8mvPqftfPBQFvZn3sQxMF0YZWfF9M49uoHcs55Uc+tgitfCsDk8WP5bKiIvKo3Ss69mlLrk4/kdhyooC7CDRUwqn31TaTb3JpSmb7oJHdeZcTy507MDJZAcFMPHccPV6CCWJBW6/Rh7xtaeXrdzD5obsNc+wcveLVrb6XHCvQZUwO1YG9BPA/xQmL2f6dyQ8h0nwC/Gjik3G/pLHpw2TQCF1B8B9eeTigb2ftbPT3XYAFOugOtmFVj0qEHRArwKMS+Yr7P4o843Xxgp/OnYykcikB/Rf1qblh0rxr7w5fJTntkXZX2fDqydkLjY5b3yYWHIlsGBosvbd/uZZvWqnGmkalJOMzyDdqDHc/VNVCLz8zuTF3fnHwEnoUjnef/9V9//XSTSTqrP8CNCxAvQ7ffjy/LEVnCNoKe+oEbVSK8M3sXPuTtTHSy6p5T6B2CnQIxZV6GepnRrutBhoVL6jAbfX9WUZMwr8EnRt4GG6UzJwljiZhQnm9TxMUJTI+3VkeAxPU7wNYe4y3Q/5WMHuEXPAq2fJwyUz8n4BnIJlad02RBckobpbaMRLrJLAUlHH0bkyBiAHJkeqgGyEH3TUWOolx98zDdIXqxGD6jvIckP2TQQGAn96xvJpKnUBx4EP+EgWfmuSJMrhad2dfrqXw2vNeVoAm9GGme2Nb7ZUOKbndc5f9TFcppuMFKsxkWMlGOHB2VYpXTzItpoZ5L9RQup50B0wUbgViOcDHkhqVITL5NeeSI0Ot1renMg6KhWU6o4JhOdIZOFsHujyMyqdq6hlYwkWCdv9LJJN3+IDUVnCFLcpT8eE7X6aO6FsBxehsyHO3mgLYPpuQ4anqvX5rjrAxqSOrt3QPphUl4jdRMX77Q8eZzWH+qgo+YFmwVzMThuehgNxms7 +yJvyJG4 NKEJ81Y5FNvb/AlGHkO5yx8NFh6aN2ObY1vsgfvqkpUWUKZefNgLTh3MyajOEpP3W16o6YtVSE6yn4btStuP4GFn6xcgPoNbnTutfatfioXwM9wcJQGYOJIB8s1gijKcNxeZoIAWhEV/pw9iYbMsRzuxXMK5fdAU3BE77M1ye5JzLNEUWQNyP5YEBscVJz62SGDbwnvJS2lTUY06r6ckTK6na7c1U/NEL4gDVWHR/Ywsj1PLucc8JlcdBItFr3PW8XKYHpHX6bIuhCtrLh1+bhVSZmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There was a memory leak bug in DAMOS sysfs memcg_path file. Add a selftest to ensure the bug never comes back. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/Makefile | 1 + .../selftests/damon/sysfs_memcg_path_leak.sh | 43 +++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100755 tools/testing/selftests/damon/sysfs_memcg_path_leak.sh diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile index ff21524be458..e888455e3cf8 100644 --- a/tools/testing/selftests/damon/Makefile +++ b/tools/testing/selftests/damon/Makefile @@ -15,6 +15,7 @@ TEST_PROGS += reclaim.sh lru_sort.sh # regression tests (reproducers of previously found bugs) TEST_PROGS += sysfs_update_removed_scheme_dir.sh TEST_PROGS += sysfs_update_schemes_tried_regions_hang.py +TEST_PROGS += sysfs_memcg_path_leak.sh EXTRA_CLEAN = __pycache__ diff --git a/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh b/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh new file mode 100755 index 000000000000..64c5d8c518a4 --- /dev/null +++ b/tools/testing/selftests/damon/sysfs_memcg_path_leak.sh @@ -0,0 +1,43 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +if [ $EUID -ne 0 ] +then + echo "Run as root" + exit $ksft_skip +fi + +damon_sysfs="/sys/kernel/mm/damon/admin" +if [ ! -d "$damon_sysfs" ] +then + echo "damon sysfs not found" + exit $ksft_skip +fi + +# ensure filter directory +echo 1 > "$damon_sysfs/kdamonds/nr_kdamonds" +echo 1 > "$damon_sysfs/kdamonds/0/contexts/nr_contexts" +echo 1 > "$damon_sysfs/kdamonds/0/contexts/0/schemes/nr_schemes" +echo 1 > "$damon_sysfs/kdamonds/0/contexts/0/schemes/0/filters/nr_filters" + +filter_dir="$damon_sysfs/kdamonds/0/contexts/0/schemes/0/filters/0" + +before_kb=$(grep Slab /proc/meminfo | awk '{print $2}') + +# try to leak 3000 KiB +for i in {1..102400}; +do + echo "012345678901234567890123456789" > "$filter_dir/memcg_path" +done + +after_kb=$(grep Slab /proc/meminfo | awk '{print $2}') +# expect up to 1500 KiB free from other tasks memory +expected_after_kb_max=$((before_kb + 1500)) + +if [ "$after_kb" -gt "$expected_after_kb_max" ] +then + echo "maybe memcg_path are leaking: $before_kb -> $after_kb" + exit 1 +else + exit 0 +fi -- 2.39.5