From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0340C77B7F for ; Thu, 19 Jun 2025 18:36:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F8136B0096; Thu, 19 Jun 2025 14:36:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 498896B00A1; Thu, 19 Jun 2025 14:36:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3358D6B009D; Thu, 19 Jun 2025 14:36:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1B22A6B009D for ; Thu, 19 Jun 2025 14:36:16 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA8E01608CC for ; Thu, 19 Jun 2025 18:36:15 +0000 (UTC) X-FDA: 83573005110.24.2718828 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id 579BA40010 for ; Thu, 19 Jun 2025 18:36:14 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rQwpdIDK; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750358174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dZz7s6KheTFRzyywjVNHAOLvHjbaKAdMVAyaTqt+KrI=; b=4ST6d0gBzxvUrP3xPTOvm2iZYo0uLXzg+/5Xwpk/RoDc6BQ36qie8EmTF05AKs8TEenwL9 APwV1gBNADYw32aE+i/gw+2dWCD9XH4UHTvoteYOmjyAXzT4mbyRWXJGa6JrdRDsF000en vxldrLXC5GWBcIk0QnfQ9D/PrzicNqE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rQwpdIDK; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750358174; a=rsa-sha256; cv=none; b=u2ZjqbOFoW/EbaFyiRX1AWimR4M9laex23RgBLv3wf+C4KSVEsMMdPhejrHFwXJ19s0VGg LgLF7zHvXC2DkmAAQv+MFtBsB7CifHbZxboEzf0Oq0AvKLwcuL+eoQFch4IulHDdG4C+HE FJtl92GiMLhg8X8h/DPQLo05vEjBMcY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 97978A544E3; Thu, 19 Jun 2025 18:36:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21FA8C4CEF0; Thu, 19 Jun 2025 18:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750358173; bh=840kYlQBtIBzTuRYCK9lIr3LHivR6lw5teUqKnxye1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rQwpdIDKorXZCCEmcC9gDf34jdNZfCzbWg3Sa2AD2DnScGZOuQTikh0cNLCrKiO69 Zg1YBPEW5repRKJBEH5seo7ppGRb2OMIYAw2m0u7sJfpiDaDsqU+YHRvwD5Nmw1F1F 1CNZNdLS9AF7pl8nChA6rR/MEDJC3CHHeLu91Ajo+spw0rZJlC1hSN183gDuV5wkwi O1/eiorO0eL1WNxQdAaJJjsZZ8cCnw4flmMwpYGvXP5tL7/fyqEkjlICmlv3+QlioJ MyVdRAOz7w1wIDp44/johcURMVlHyruhHApN3gI4TxTHMxCgDQFIfHdxC9G2y9x651 bwm09RvzfyjEg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, #@kvack.org, 6.3.x@kvack.org Subject: [PATCH 1/2] mm/damon/sysfs-schemes: free old damon_sysfs_scheme_filter->memcg_path on write Date: Thu, 19 Jun 2025 11:36:07 -0700 Message-Id: <20250619183608.6647-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250619183608.6647-1-sj@kernel.org> References: <20250619183608.6647-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 579BA40010 X-Stat-Signature: e3pg9fazdx6tga1nxznbzp7pbpntpg7d X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750358174-847057 X-HE-Meta: U2FsdGVkX1/WItVNFZ0UJr60ZP88nhlh0cuUTH8/CQURYFaWIj3JWftwPgEVn90uElbRT6uL8DmRhHsrLiJ4DC8LV14PYlJznftjhitOKe8FNAzby3MQyK5B1TjWcza/MdTpYtSQRDHVRBSyfnTUHnra3W7VIUoMKHjkduZYHCGy6t5fCJUA8Y0trD6XNRVjkb5TlStuUxaROOOlcS00fi+pQZP8/ccgn2bVgMTKgDfCBUHfi8AdK+MJ39aW2Z1f4CsYornUkWGMKCwl+oOjE+TdE13E/gcU+sZlGf3pVxpZ2FTqQSpPpKveULM0FEOM8MyCvsUddxc/Bv6/eNr/E+mkxJfzu/3Ruru59QGSvy1kgIupmPwDoEtuiTKxb40CbZ/BS1YBnouLuT+eKL5mqlbWMqbTlghmy0lnIeko56plOYmRb2/B74d047bZuEyx9F2zvbnH+enWl9VtI8G6rvecKUYgh33yVYCODx+b8RZco16xnny/0I9rSvQD3P66ekchW1VinCzito9uC/KNT7t5rPD9IH98YeIywJFld3L/uPqJV0s5aZgjwDCffEqzk7pFPqa5EpkAhVRA+UzL+jSb6Q/qucseBFrDxPFyGw3Cxnj8LZZncXtZJ/SWh6e5PPw4d799F57XTWKHJnIMaIokBfavViGbUgZhh1eyuuhkX4B51/ZW9TN7H1HXgReJ6mtv7nCMnb/1RpwT8Wa901bvPSi+FkNtIXP8Fx9Zw+GYLSP0TEeI5A6FD1bDacPyktIiANOzPM0vZYkMIDIDezd9WNiJM2dBC8OWG25Y7QEBz1wouEDkeVJta1w2BY8Kbv7almYU/EiKvsnykQ2g3krQ3WEL2/ug8niPjc4yiwZcnbaEuJZMwVrKO5QhPSm6N+Zi3Svwc1/X6eulD/zBAY4ctxGetqxkOXHNIDxJnY54zdeyiw4wpzJrHaSc+IgBbucdwBj9Ubx1z66Q5wA tFfmU295 7+Vz2LYrtsuA/wscURJWykt9KgdQrp0t6Zb/HVs9Ue+bWVpXCkA7/bzDifYg4O+aEg1wBvKCw7rtiYzWZ0dnfJtroPKuos+kmpxNsAFcMfuIQsvQwlJGhH77uNgvmer6+MFJEuUPm4yXZ9p0Po5rVSOmeBvazUhGOdgBsuln4gzNDbX0sSQeKd/FdP1XNr0jxvLyG8d3GvYgiRu3A5Se5ZK6BauSsb2xtJUCO4A/w08V4HRFnXKKiqbSeLVkRKqysS59NEgoSEW5pGa3f1165xn85+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: memcg_path_store() assigns a newly allocated memory buffer to filter->memcg_path, without deallocating the previously allocated and assigned memory buffer. As a result, users can leak kernel memory by continuously writing a data to memcg_path DAMOS sysfs file. Fix the leak by deallocating the previously set memory buffer. Fixes: 7ee161f18b5d ("mm/damon/sysfs-schemes: implement filter directory") Cc: stable@vger.kernel.org # 6.3.x Signed-off-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 0f6c9e1fec0b..30ae7518ffbf 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -472,6 +472,7 @@ static ssize_t memcg_path_store(struct kobject *kobj, return -ENOMEM; strscpy(path, buf, count + 1); + kfree(filter->memcg_path); filter->memcg_path = path; return count; } -- 2.39.5