From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B80C7115E for ; Thu, 19 Jun 2025 08:45:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93F8E6B0096; Thu, 19 Jun 2025 04:45:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F0C86B0098; Thu, 19 Jun 2025 04:45:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82D526B0099; Thu, 19 Jun 2025 04:45:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7735A6B0096 for ; Thu, 19 Jun 2025 04:45:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB1291207B4 for ; Thu, 19 Jun 2025 08:45:45 +0000 (UTC) X-FDA: 83571517050.05.53C9F7B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id 1D07280009 for ; Thu, 19 Jun 2025 08:45:43 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H15O8R4H; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750322744; a=rsa-sha256; cv=none; b=pWhkzSjWer6zWo22WZNa46AoVPq73uVd34yEktT/X7szA4/sT/J2BRJA7ZLBS5/5JqF38C rHr20PAIhUtuACv3HSiqabLwRNaeGxmazqUrlzpkc0eSwD4IBKb87+w7XbVLZokG6gA7KH 80T2XNkA2mi+y2sWuPd4YctCsReF0lo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H15O8R4H; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750322744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=68q3kf2ysImSHSLaK18R7hHrL4Tf0K+iQIJUreFQ+vw=; b=LnbncEc5AFfH6MwaxvdQXFQAjHlYdIJsxj362bEkLbyG0XBNIUqKDA9ukFxupw60T6D8yc VIuut8AEqXFL4wPa7vox4pb913JDl8V72+B5FJ+tpzvl+wycaYZteKpr+hZUUgyALe3niK LKrFr1Bp+gA8o08Y23WHSL+3QGitW5Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id EF2A44511B; Thu, 19 Jun 2025 08:45:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04606C4CEEA; Thu, 19 Jun 2025 08:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750322742; bh=ETZAfHfnmnB7/VJHWpx7jZwUc3d27vyxp4OFrpnTGNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H15O8R4HsWsWvzkoB8mcKBdWkY/qdSTohtFHiCM8PljYIRIeAXDgaSSYKs2m+ZB+j StXkAxdlDws7yJpjXOEml/YZndgtt89Pu2ZfcwbtQZ058umd3G6i+IQki8Grn0YeWt PgtgBj6zPk4oJDhso3ufO+svvOxiV5OnHdqBl/tlA7oQ7ie8L0TkELhcrX6TfnmCHC hv0CHgRNceqnZ0JWM1+lDtmLwHol2EikLoEDnPTKC6Fl5qAzzHfcAue7CZxcWCaz4m APzdkSeOCrYs0AnojcTCvwMvwVtDhh/LgqnEkySxPbrfv7Kcm41rYLc2ndvtyEg99b 8Sl4n1na2QGow== From: Christian Brauner To: Shivank Garg Cc: Christian Brauner , seanjc@google.com, vbabka@suse.cz, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, david@redhat.com, akpm@linux-foundation.org, paul@paul-moore.com, rppt@kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Date: Thu, 19 Jun 2025 10:45:16 +0200 Message-ID: <20250619-zerstochen-lamellen-b158317258e6@brauner> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250619073136.506022-2-shivankg@amd.com> References: <20250619073136.506022-2-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1342; i=brauner@kernel.org; h=from:subject:message-id; bh=ETZAfHfnmnB7/VJHWpx7jZwUc3d27vyxp4OFrpnTGNY=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWQEn1MTW6W6ZIpV9/31tXHvQuf5/ug5y8eQ7brj/sRl+ wOMqy586yhlYRDjYpAVU2RxaDcJl1vOU7HZKFMDZg4rE8gQBi5OAZiIuznDX7Ha3VZdL663Wb3r Fpt8OCWwZqeC3KXIif9P/911OrA/spqRYathwLNXS0VvKOeLfWVemD7j7O5bu40kX2yy2Zn/7QX LCz4A X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 1D07280009 X-Rspamd-Server: rspam10 X-Stat-Signature: jagh1ob1j1bajqpui4mxspkxp7dnow6t X-HE-Tag: 1750322743-137452 X-HE-Meta: U2FsdGVkX1+rrRxMa0dFo4Y3ObgpNmk2H+c5uW0QPB57jjJ1qCcRMHiIcnOHsHL1T9/a5T+4Ok7haxCGhhaAKT5XIMLZr4vuYF/UIN9+z2O3MHHOB8AoZsG8Kow00sA3cppmwGT8TJxGfiwmyQUmY9QAjql5KwFYiXe9jzkzt4qKEy3B0TDe5siC4JkQ2X9sOs/U5M+lAxme929BaU8qfNoEEtXbcGixsyQm4IqfPoa4wNjwGIvQQzDzTNb0poswhjAARjtYPVR3649TWs8m9QHHqtQRA0QrAoccsADagrji8awMJq2Aa+4rROwJKk7c+AtOv9zArKDoK2NTdkN3hs236U2QdioGKxB9TAKI7it9WB1R25VJCsYNJeAeKxyCvFK7Q7RrvSTh/7kpuyXZpbVvSCbOZFiUG/VHiKSAOs81qAgHYdfVyoGhJnMsGVoR25eo0+hIfe1CEkbtjHEyz3VWSwig28Kj1vHMDkljWNjrtRVJRv+fYsqCmmAoDAj1RLCeWLUOVRsl5TcuOqQQaN0NYmm9GoBHznwHL8Q9Eiz5g2kr712L/xMRyvfeM8YO3jnT43LhFCSaezlF7DuyQxz0JBHWZYPsXNKeq6JkOvGOT+tsBvMKEDMfOh9/hwVgVSctQnSsYVEpUhh+vnD3ggwYSeCiMyY0YmmOm1/7opxKXWu2x/NngQ5cg6yd10hB421V4+WH86d6GYOoxJ/CZW7e9APejKUC8AZX5FcieY5KFy72N7fLCRFU2of4UCBGq9K4VOvz1PADg8+A27rNkLC7riIjdmEpv37qa0tCqz4sHMp+xVBbl8fK7AVetohOdjdmy2ZOzJeHwSUQUQFngawbIFrWW9RKD6etrlcE2WWGhrTwk/ca6ZQCmd+EenMAfrujtCH1Mw66GjM09uaoioYWqEsJN4PXxaCw1F3f1s9gFs7YfHloaZMz0uX2jtnxmnLH7Ue3ZWn7CzBYvM8 5s69TuSL JOi3Nt39TvnD6m01jGb51pHS/0ANUCwzE3L+O5RGl5vOWIM7TEE8Ogn3t7UKbK4kHMB/9/aw6vFd6mAzp03sTmkMPNWrAa/HTQzVti1nrVGSsGZ687pOhZeOk2NcUo88Acc0g8esPcOdgcl5dZwm652KuViRoNFKyHUN+ZmSbXPUtvUUsGGYr/q39Kmq7rlVULA0fRtiym97KwVdp6abeqq7dduLvF99pySuA4kxi4v64KqYFskIv+ZI2HjyBJTYfPb+5iHRNK1ee0pCitMjEjjsun+TLMs+RBZKdGgpNh8gZwD1GsPp+jm8tTnLiF9BTe/Sl7p9vDlCiVWH0FJRjMqeNMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 19 Jun 2025 07:31:37 +0000, Shivank Garg wrote: > Export anon_inode_make_secure_inode() to allow KVM guest_memfd to create > anonymous inodes with proper security context. This replaces the current > pattern of calling alloc_anon_inode() followed by > inode_init_security_anon() for creating security context manually. > > This change also fixes a security regression in secretmem where the > S_PRIVATE flag was not cleared after alloc_anon_inode(), causing > LSM/SELinux checks to be bypassed for secretmem file descriptors. > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass https://git.kernel.org/vfs/vfs/c/c696307648ea