From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D70C7115B for ; Fri, 20 Jun 2025 01:25:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 105926B008C; Thu, 19 Jun 2025 21:25:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B5F56B008A; Thu, 19 Jun 2025 21:25:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE6F86B0093; Thu, 19 Jun 2025 21:25:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D3E286B008A for ; Thu, 19 Jun 2025 21:25:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6B4D25EA9E for ; Fri, 20 Jun 2025 01:25:18 +0000 (UTC) X-FDA: 83574035916.27.0555C60 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) by imf22.hostedemail.com (Postfix) with ESMTP id 1DC6EC0004 for ; Fri, 20 Jun 2025 01:25:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=b3DP1ef0; spf=pass (imf22.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750382716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y1DbwL1SG9nqQt6rgisMJIz4Tza+3QMR1zphzABvsLI=; b=fcu6Y9MHxEeYOf4dmaM/pwScNpf8Q/zJOqWHeKpVsvhyTXGf2wvqlzoopemqw6AWBzD5Wo PiS5sUhIMxTAgCmDeZILEXg2g0WJXkIuwdDuYkktlU9muCrSOP82gKZIrl+6vQG+8vbQCB BgWFY2nl4UgIQtCwJ316LsiHr3CxOLg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=b3DP1ef0; spf=pass (imf22.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750382716; a=rsa-sha256; cv=none; b=UWe0/4xFhIUBoSA6afEkTlZseNO1CuJOEFtnL0VDO+PfJBVVBhGDHMgeSni1sS5+XHyjkm bbU/yh2xotjYV9ci+KVUYAPDx7CuSqC4lItRzlEKlGSI05YXCdrlCt396O9A11pLJ91d6L 1mDvE7YY14bfPpvvPYB4gL4hSboiHAw= Received: from pps.filterd (m0167073.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55JLHrSi015885 for ; Thu, 19 Jun 2025 21:25:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=pps01; bh=y1DbwL1SG9nqQt6rgisMJIz4Tza+3QMR1zphzABvsLI=; b=b3DP1ef0ovPOnRNKCRG6SoL/WKc8apVbD69DjCrOT1sKDWfiKnlKsdrSy15K1J6h9SBb rlbQmR2U5e5jWz2wWyc5pIH6UIzQbI8fjaJoAoAtyMTbAj2qvGxTvhnEJYmJ1UbyTCfs XaCyPry8N6NaPpHtcDSXR6T8cXLjDC9ys5hidB5oSYU/hGEEqXGmonhRdDPmA/MTVq2G hAMmzDck/158YxVKophyvUhtaLp1x+k7SJQrXhe0d56Y2CRuawSGcpw7+4ApGutRxOsh tEQrq2iP+qRBf+ute9KIfZ9kwVi8+qwNH4WJLCQOKAnKrCfSeB624CirQhmE9K9YqP/P 0w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4794yg4h7g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 19 Jun 2025 21:25:15 -0400 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a587a96f0aso34068571cf.3 for ; Thu, 19 Jun 2025 18:25:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750382694; x=1750987494; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y1DbwL1SG9nqQt6rgisMJIz4Tza+3QMR1zphzABvsLI=; b=sbWIldIvaHF8G6UMOHfYdzlEHUrJVMrhzuQoHbyxS/WkgsWCaO4CxM87PHNFiy0jtz w1wzwq+Onu4qV5zv2Z8NmOjlZd1wr2tE1wI4UunselqO4QE3u4xXNOfawhNbVeo9GtNp 3EBdwiyg0vizD+IHi2v3sfDfpfGTLLh3Xk1q06PqGariQY0TPB2EPwzyz57L2/Jn68TC ZOOsMQAuRcohR0J9t/3IIdT5dTU3gWyoV3uuLgsjAqD05takdWNBVT0TfY+EnTDyJruf 7cGAwrRU0mV/PENVxn8DHKIyJ3n2Z1nQnMJxV4ti0MjOFMqbjzXDluEONpodGKHk+xu0 +d9Q== X-Gm-Message-State: AOJu0YziN4PuXMeAI/pEz25qKYrUdKOA2yZPKFlDRoBFK6ImjdkcRJUU wOuagCq/1S1caJK+GEJ9EdrnMS5Pwf8fxCq4lW7e2DlSKwFWC7i6r5/BbuKySc19ZCwWvARmaom qaBDNlpi6dKwiYFw+hLAHhEUAx3iryQtVlv0U/zsVvWFr7nHk X-Gm-Gg: ASbGnctqAtpL5W4L8ZADcsdS2MwfLicMpYYDkD8rPiz8llVLpWXmtee61Y2zm5qa1WV 5SZpSvhqAdGktUhpJJpmrb+XYGAiRQZN+eUCaLAwhBMK4G3H1bYbRFVzZ7Dew3FoggwAHJI/Fk8 gSeLRTpuXqGkziYk1eRTitawfQgBRKwngCVlH6SlmvOsIckmC3deWL3v2kiIWW6wXho09IcHBfd NHovKANV+vzccdA8mmDmPl0kYPnLh+YIoJSLbJ6AK6rZ+rMv7cmjwgKibJB93MvXhXcB/zDwWtc akTu2H5Ogq0lr56Fvx9ELOTtnwDHwdlyVDzMAlUduKUtl08KXyUeadtwp1kyVnpqloZk X-Received: by 2002:a05:622a:134b:b0:4a4:2ffb:5482 with SMTP id d75a77b69052e-4a77a2cc1a2mr18298071cf.38.1750382694504; Thu, 19 Jun 2025 18:24:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdvZEXi3Vbfe/ihSwyAC6bOFZTIRmYu8oCTMk4/J2B2hDJEgqywAAZZz5rCDXLHlNnuSS/tA== X-Received: by 2002:a05:622a:134b:b0:4a4:2ffb:5482 with SMTP id d75a77b69052e-4a77a2cc1a2mr18297771cf.38.1750382694086; Thu, 19 Jun 2025 18:24:54 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a779e79c12sm3794321cf.53.2025.06.19.18.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 18:24:53 -0700 (PDT) From: Tal Zussman Date: Thu, 19 Jun 2025 21:24:26 -0400 Subject: [PATCH v3 4/4] userfaultfd: remove UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250619-uffd-fixes-v3-4-a7274d3bd5e4@columbia.edu> References: <20250619-uffd-fixes-v3-0-a7274d3bd5e4@columbia.edu> In-Reply-To: <20250619-uffd-fixes-v3-0-a7274d3bd5e4@columbia.edu> To: Andrew Morton , Peter Xu , "Jason A. Donenfeld" , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Andrea Arcangeli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750382688; l=1546; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=EP9W1OmB+wcjXQYUgIL2fq+FEVkI22zf392uYjNc/Kw=; b=4m0MC8lpRu7JrFBUgKxSFn0CjaKQkdAzLnQAQrVX3RoGclBRGauwzPiHVkIISeEUPOieusAn7 OZo32XipF0HBu7kDSe/Y3EbDpYR9WkGa6j1Q0UCU0Gc17bcAwqbVtH6 X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-ORIG-GUID: b-R7StN00I2UPxf2Guk8waq1Rv3sstLc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIwMDAwOSBTYWx0ZWRfX4kbNR3yZ36iP ZAJv98VQwd2MYdCc4SPiqoAMPvw1uSMqfBsMt/Q2qFPU0ofa521roDvu0CiPHw94KedqqvRfzFc r9smMFbWi/UYGKZelaBqjaPmZLaGwOwxGhH0Ejj4QZcYhF1vb/+3F27tnD25QFjJSg8DLXHkfdf aAgHgZlbKi1YJ3dNMlA+GNwhRocLs4i8qRw5FoSLbm/72tMlMCLg8GsdoQbchSlJmvU/ToSll8P 13JVa2zaYW4sMWtqgK9858sOW0a6ObKOTZU/awx9eAarwNTMKPK5taDEgRX6/gqt7fWUgssK/BL txapEWWI216xj91bWvR9sSj3osL3di3G8PU/SRRueoh+0M/92svPI1vo1Y/O6jCfrFVN/Ig1uv+ ifVHM5ah X-Proofpoint-GUID: b-R7StN00I2UPxf2Guk8waq1Rv3sstLc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-19_08,2025-06-18_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=514 clxscore=1015 bulkscore=10 phishscore=0 adultscore=0 mlxscore=0 spamscore=0 impostorscore=0 lowpriorityscore=10 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506200009 X-Rspam-User: X-Rspamd-Queue-Id: 1DC6EC0004 X-Rspamd-Server: rspam01 X-Stat-Signature: j3iqwdmi3m91iawionbcso3oom356rd3 X-HE-Tag: 1750382715-568402 X-HE-Meta: U2FsdGVkX1+ZaOqp45SlE6O4e295gO+UbN7B6KSPcwCkrW1BeYtT077VWk8JN5eyAAglRk+2yrvGuLA8LoE0S/jH4/DBIzVUVBG6CuuxgMPt9HRJ3RrqIVtzAETsctgDkXgcxkKjGIHXGmkcnL2bB78121tGRIzotL5xlEJXn4gETw3iAisLUudaXHa9xPuvH2fj4VXW0lBrTKN8eoiHtviYUwgvU2OyN8iq/FNG3KnLHDObMbb6ZwPwWkUL+/7eYvxYj5sn60WnEZ3IS42sZBq98lvztguaSXl/9384Hsv4ZoJ+cEs8S9Q5kZPDQxerupo/Jy/r1kwYOYzT1SfXJ/6vueU5/wjkD2gr2lSOUf7oiawNfWYnZED5VLLwqBebBKZO1AzjjpMQxmjW3pfK8XueB7NsOQKj/5/PQFkJsTvUNM5ixoYWod7Z4cooiZcStC996F54Wjouu5hh1fghlM8HNNwPkCuzIevFnsev4kMXl13FGnxUY94NzYlwy0DemFrSNiUjTalDvpEAJ5g2zZoXGUSSERXBkoQ48RKMbq/KNfywHDSntBxKUqQRuXhalJ4qShgsmeu5n6B8DUJE8Amc09TtTO7yRZLXDS2jLXhOU2/IeybhIJ1kadcJ4Eq5Et8ELK0sjNMiYtezjlwcD3SxZ6OO4fFtb2O8PWiXUXUcnZaQzC7u44ZwVLOZnqjz/5VilBDapfE1HxI+b/fEqU1FfTAAHyym2afaOxOiMP+JeyBWeJUkLO22rB4zDiZEG5AmOg0uz3/BgpE4pgwe9L/qL0kVak2pERvNg6MkxBw+lcGcYSZiYmCAmdNlcsJWQxviG3elVz19R2qu2lu3R4Tb/j+CnK3UTJKrooMucwC//CtELASDR+I2Fsn7SjiX+RLUcoChqRxSPdMcHdRNeZtVniGhqG3y7upZTeloSJdQa86kseOFz8IlyHWILp1TeduShtqnkt2wPaadgJt aLSMMcld aTyi9OQWjLRVMJs2jhx/2F04lk92etHJKyXY1ZesmOL9pv2G3bAbuEC3xmlQT0aUztJlbdlFcFQX3JPu4/Qas+Oqj2iQGPRg2ZgFHAR9BbxVCVRhEM4yDZHjhj5suUo5JN7hoZu8fGqI26MewqVOHF7LwjOqOXl5q+P/sQiT1QQ/f5YDjNHdOEPw/Wfn4Rv4W213Pu5qsgwgSzbSx9hyV11qVzFD8e9YEOsg7sMHSVGAjkUsclrV2H95XUJSzkmFBQz43+B6k3qi5QGEwCUygDkc5efwF4q1Ei8gmVy1rxbmhhn9/KTEGJzmBZxauZOE8tlzNmkq2hK94f3B3OMJsEC3bFeJUboUFYKQZHjk5VbuhgakzRH2ND3XiXu4hfYbQLK21TR3pClst0eNEzyIpOmsZi8Oa/B/n9KX8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET have been unused since they were added in commit 932b18e0aec6 ("userfaultfd: linux/userfaultfd_k.h"). Remove them and the associated BUILD_BUG_ON() checks. Acked-by: David Hildenbrand Acked-by: Peter Xu Signed-off-by: Tal Zussman --- fs/userfaultfd.c | 2 -- include/linux/userfaultfd_k.h | 4 ---- 2 files changed, 6 deletions(-) diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c index 771e81ea4ef6..a2928b0aec6f 100644 --- a/fs/userfaultfd.c +++ b/fs/userfaultfd.c @@ -2114,8 +2114,6 @@ static int new_userfaultfd(int flags) /* Check the UFFD_* constants for consistency. */ BUILD_BUG_ON(UFFD_USER_MODE_ONLY & UFFD_SHARED_FCNTL_FLAGS); - BUILD_BUG_ON(UFFD_CLOEXEC != O_CLOEXEC); - BUILD_BUG_ON(UFFD_NONBLOCK != O_NONBLOCK); if (flags & ~(UFFD_SHARED_FCNTL_FLAGS | UFFD_USER_MODE_ONLY)) return -EINVAL; diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h index f3b3d2c9dd5e..ccad58602846 100644 --- a/include/linux/userfaultfd_k.h +++ b/include/linux/userfaultfd_k.h @@ -30,11 +30,7 @@ * from userfaultfd, in order to leave a free define-space for * shared O_* flags. */ -#define UFFD_CLOEXEC O_CLOEXEC -#define UFFD_NONBLOCK O_NONBLOCK - #define UFFD_SHARED_FCNTL_FLAGS (O_CLOEXEC | O_NONBLOCK) -#define UFFD_FLAGS_SET (EFD_SHARED_FCNTL_FLAGS) /* * Start with fault_pending_wqh and fault_wqh so they're more likely -- 2.39.5