From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 861A7C7115B for ; Fri, 20 Jun 2025 01:35:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2504C6B008A; Thu, 19 Jun 2025 21:35:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 200F86B008C; Thu, 19 Jun 2025 21:35:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 116A96B0092; Thu, 19 Jun 2025 21:35:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 02DAA6B008A for ; Thu, 19 Jun 2025 21:35:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B3EEC121326 for ; Fri, 20 Jun 2025 01:35:18 +0000 (UTC) X-FDA: 83574061116.13.D3E2257 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) by imf11.hostedemail.com (Postfix) with ESMTP id 5D59C4000B for ; Fri, 20 Jun 2025 01:35:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=Wl5qVVaj; spf=pass (imf11.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750383316; a=rsa-sha256; cv=none; b=wdKEWgz1k+UBw6pJ/j7dWLHx4P1wNxpYf3bNLpvMgd9EUl7LJfecuP+8EjvN/xbj3h3uBe yCQrZj1BVbudZf9GnHOvjKaisjPyj8+fCp1gFavt9XOjy04n54bMOpTbnKBDgEM8X17eve KF1qpys5UZJv+DpoM61wrUD7pRpNSVc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=Wl5qVVaj; spf=pass (imf11.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750383316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=GOxKSLo88/sXZwWQN7+1MNoBNEcUs8IGR6idhRWKuT4=; b=L9x1FM82VDbeeRdZfJq/Filt4yxhmUW+QjrV2xam8/IvD+hbb5JMHhsJO8+PleIIxfo30P he9+3vSyErlccuz7DltTOLklRXs4I5ryPpHE/a69nWoTlLlafZTmkqvoMZgTc203DgNNBS PGRW5Y/RudwoNFU4TqWH58/DUgtpq1w= Received: from pps.filterd (m0167073.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55JM345d018804 for ; Thu, 19 Jun 2025 21:25:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=cc : content-transfer-encoding : content-type : date : from : message-id : mime-version : subject : to; s=pps01; bh=GOxKSLo88/sXZwWQN7+1MNoBNEcUs8IGR6idhRWKuT4=; b=Wl5qVVajGyapEOBP/ZgYDieFsd7UvqoNRUOm0bpseTC3OM+CKNoaDul3A0QuQO6vJnmz TzFZhsnsZCsvk8O/AdfQVO2mrgVkto4l22ZM7YopRLvF8vY3mlOvrjGXJMXwkm5igrxk Esbu6SYWjtqkxxDTsgM144AsGcPz5+VqlsbzPwOxFb/Ba0uQYBCQTeyqVQG4jM4t0OZ5 FauKl5ZaCCjFTFEQUbZw+ZtUDrachxlOwvnLrZKnJzAliHeXyNuJKO/QzSTPxMPjehCk DV8SrrOIZ0N4mWvX1Um87vUSGzl5VUph0pVgwAGKdJ0tEcUxjNKPtRuhBOi4kxI0fNxr 9w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4794yg4h76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 19 Jun 2025 21:25:15 -0400 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a38007c7bdso31506221cf.3 for ; Thu, 19 Jun 2025 18:25:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750382690; x=1750987490; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GOxKSLo88/sXZwWQN7+1MNoBNEcUs8IGR6idhRWKuT4=; b=LxLoMyUfVaOBQxKgIyHMffsIKrPiw39WBpHcNvuuKrzPFVO4dnVL+BqkTCy3O6SQlP Or1cflkykNsQa8I8H9pRRLYunGadxuJ9SYYNj7n//FucTU94kSS2dSJovHcFZuQDMj6v FkJKUwc9t4aQh/pPgpZZsN/psNOaH/2T2tE2WufNWMNOX+H6xvXqtvNNfFgVS+mR2rGG kqV4x/6khv2zUpFGlDKBu+nMJJFnQuELXPkBY35esPGg/g9SL+gXMHS82HOcNLBrMpmN I5guLoI0sJk7iF/gw7kMemRAWkwySbe4I1CkcMb0uoOVlOf8X39lQO/6whSGq4LQhdml 4JrQ== X-Gm-Message-State: AOJu0YxKg1kWGYdT442LATIQYzI5B5NT3b4dCVICOSlKx6FDhOhr0eEm ysmVKwHPPxHZTUxsXxpJ+So6fH33CgD27q8Q2ikYI5CHgIp+Ba6sKEinqMjpO1S8lC09I9pKkdd SvyhIdspg40M0gloGZluMdfWoVuA/pFICVYoOtEJqB6aLbkEd9cewO1u9 X-Gm-Gg: ASbGncsbyHCAZkn2UQREu/LIMucx1QfWp7x4QXtx7D6SwtOVPEbVEeT8dniGmDfquzX 2Rk+ZI1cw61ZYsDlY9c5OjihlyY1EmJQrONZqyG7Q3hnt7mb+iPsztkI2OPPOiQgo5ISnOnrV89 yTcfxLrGBXk1we4ft2bB1b4NVzvzjtkNpUFNpk7H1p8+40oOIIUFsfYcIsHYoN23CxDnoMc377u Xlm+NqTlJwJcRjZTo2PTisHe0wqREgy7D+dklkcLeWJupAxLz3TwBPbrk/MqW4eouDSJXNwbcCo v1NNH2TaJL+d9I0CiQi+xDZnd0MEuSZsW8o5ep9j+CayjVbw9tRdtXEqujrcCvy70rPH X-Received: by 2002:a05:622a:180b:b0:4a6:f416:48c8 with SMTP id d75a77b69052e-4a77a21e7a6mr19249401cf.23.1750382689868; Thu, 19 Jun 2025 18:24:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEC9jHCGCp55sYm55ro7Kc20y+6lcgDMG8zlg8paNloPrfi/X7/VdzRZ4ySVIX6xJuzroxtdQ== X-Received: by 2002:a05:622a:180b:b0:4a6:f416:48c8 with SMTP id d75a77b69052e-4a77a21e7a6mr19249191cf.23.1750382689454; Thu, 19 Jun 2025 18:24:49 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a779e79c12sm3794321cf.53.2025.06.19.18.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 18:24:49 -0700 (PDT) From: Tal Zussman Subject: [PATCH v3 0/4] mm: userfaultfd: assorted fixes and cleanups Date: Thu, 19 Jun 2025 21:24:22 -0400 Message-Id: <20250619-uffd-fixes-v3-0-a7274d3bd5e4@columbia.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAEa4VGgC/12MzQ7CIBAGX6XhLAbY/lhPvofxQGGxm2gxYImm6 btL66V6nN1vZmIRA2Fkx2JiARNF8kMG2BXM9Hq4IiebmSmhKlGB5KNzljt6YeSyVACykxXWwLL wCLg+8v58ydxTfPrwXttJLtdvphawzSTJBW9NDQfTgBNlczL+Nt470nu0I1tKSW3t5sdW2QZor XbYauXwz57n+QNJ5y/i5QAAAA== X-Change-ID: 20250531-uffd-fixes-142331b15e63 To: Andrew Morton , Peter Xu , "Jason A. Donenfeld" , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Andrea Arcangeli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1750382688; l=2062; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=ZE6H1UsaemZuuFtMzSuGkSE5yaVJfmesBRedgaKkURA=; b=h51Sumoe8WMQI0ow4ldHFipUTQo0+KGud2JGMHV3Z4Jp/FnieXctvfS3G6UIcUk8KBHKmttXs /uxZhxMsgciDp/5JmA2w18lXCk8p26Nd2DbvPPJsyobMopV4CLUTM+O X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-ORIG-GUID: W2SToroWKHMtRq1ZyVqQJYbuZUc4aqoG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIwMDAwOSBTYWx0ZWRfX0AL7JxmnYMmD 3+w8JhCtU5rrjZigZAq4Xzdjs/r2SX70fqirib04arHCsKPMOsNDyKWdXzo81f0/DzgZRLHGF+N RvY+ycJzeVV5KLK2jsHHjR13yIsbAdoZ5S+WI3X+4/rf0YZQ0XbU+WOBGd39Sz0cXGnBQYZhfuf ul6CjDOLi3VoYBomdlukFjUoCjlPdJfy+Zml3FIy62vLxUtUj4dWZEOmkZbWAz+qo2T7brqSz3q X5QbCYbyXFAv6+hsVxIdGXLxjQzAiJW4Sn61kXCbAINWoUdwLvomG258i1aIB7Gw0xSe3m+9I7I aPX9WvsKjONzCS8rBR8BoKlEGdB5G+JryrbOzPSMCpznPIxDtgDIq6Zy3br5CpMS2j3V1mfmV0N dhPHApuN X-Proofpoint-GUID: W2SToroWKHMtRq1ZyVqQJYbuZUc4aqoG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-19_08,2025-06-18_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=593 clxscore=1015 bulkscore=10 phishscore=0 adultscore=0 mlxscore=0 spamscore=0 impostorscore=0 lowpriorityscore=10 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506200009 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5D59C4000B X-Stat-Signature: 5k8rqpikk4gg1tj3sm8ioiqk89kxirew X-Rspam-User: X-HE-Tag: 1750383316-952715 X-HE-Meta: U2FsdGVkX19aweF2YZ8130dcV4PA6HhBYmqsq4/j/1PcnIj73CeiVMJvgScyTWAYSwNhFurcL+7hW2LnJ30IaFYDMqVnR8tZ/YupoMLTFwXJtUgn0gJeYV7cCvDXaJbxrNxQ2OtqDoS/E7TEYMsLUJHsKT2pRSVnU4OQRQjEedYU7bgp82EhU9XgVyO03k2y9l0k3DrvaR/JxJKW7ISAyMam+pD4FrwlMhWPjlnJ3I9dC5Zjv22o+xkn45vOl01nQ0S1n9nUXgdgbestybhNK/1qe/5gkeG1LY9XM6cCpOhEoun1XGGSOHWKphqC1daqLcS/N7tf9WuYR/uQV+RrxV3PAhwUie+qERWf72uCkAoYeF/v9xhxcrO5Sp/hTwn/fgqwDmNiC+MzRHalIVhfLCpsEknsE9l8Fj+iILSnJa+THXwYNTx+gHM5z8BDX0bacwwy9wL2pEciehreCYdFjcTqXKd5LI9gdU/xvmHUkCI/ZafFm9Bwgj/7V6dQaCVDonJWANFKL0ly0woyO2a6CO+ebIn+SV/6WJy4za2bnGzgEF3MC6UJFCT/X3qq+t78nuNut5igqBX1IBWiycAVYdhMeJX0evN6oaI8tvQuDCDpLYFR1H39Q+4ImSjE/jpvy2gdKA7kwroMVdB4MCGPYDKQQ27wNdv7aDkLk1G8FT3sx3vgp23ZvtBic8oSCS4+MfxWefKXEMNXq3Br9ajlI1MY2/LIceO6clGV/p2DUeALyd26Ya8SIEJ1bqN1/VFul1pLpoMSjBpuYoPxqrcqw1z2mrKS7pH+5BWxXkDDBQXDiPgNfyFKNt98NJc67M3ORjVJ2dzWRQg75Q8xFdLPX7uNGxCFwh39Vl3HclCy0FYz6d77SctFxExm/RhnITIcyp2kbesW3ISHakeFae+G+lynbK19rfr/9b0jNH1yJZY1XVUoA727a2YWq6+rfDgJ6BNpp4Y16nxRLDywZTT i9KoZmle dpIzXfKR684V9QRvmq71zX0MtEhL+K6gxxcstbOMILb4S+YlNoHXYKcNoL5w+XjADMn1v5T9fOmTHozPAoQe1LjTCtI2PkvsfGdjRT71VewuYYF2w2mM6ufSBHGN3eb493OKj/PD2PXRqhZYyioLx/T2CzytkbwDRrnXr+ZhARJoXh+e+LebCpT62J57Wp16y6aXd3awwkYys+yCYi3o6PDRorv65Z1CiAo39vXwj3HI7aiMd6SKOIcgMFYbkRFgNkQ6x32/JGQpt6RXg/fQW6iWc5yoVnSVUCIq2H5TtYspjkG61u0BTGoKhVWrquu2iV92LWSec4bsyeEVNHPa1t2uhgAFkAe6CI/5hvLE9VLmSaZHKfl64ZBdKwzi0vv+PdihWL4nGWK1M9lg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Two fixes and two cleanups for userfaultfd. Note that the third patch yields a small change in the ABI, but we seem to have concluded that that's acceptable in this case. --- Changes in v3: - Propagate tags. (David, Jason) - Move the uffd unregistration fixes patch before the VM_WARN_ON_ONCE() conversion patch, as per David. - Update comments and commit message of 2/4, as per David. - Update the commit message in 3/4 with more details about various conversions, as per David. - Convert two additional WARN_ON()s in 3/4, as per David. - Link to v2: https://lore.kernel.org/r/20250607-uffd-fixes-v2-0-339dafe9a2fe@columbia.edu Changes in v2: - Remove Pavel Emelyanov from To: due to bouncing email. - Propagate tags. (David, Peter) - Add a patch converting userfaultfd BUG_ON()s to VM_WARN_ON_ONCE(). - Move the "different uffd" check in Patch 3 (prev. Patch 2) before the vma_can_userfault() check due to the wp_async bug, as per James. - Change the added BUG_ON() in Patch 3 to a VM_WARN_ON_ONCE, as per James and David. - Reorder the assertions in Patch 3 to simplify them and avoid the wp_async bug, as per James. - Update the Patch 3 commit message to include more details, as per Peter. - Link to v1: https://lore.kernel.org/r/20250603-uffd-fixes-v1-0-9c638c73f047@columbia.edu --- Tal Zussman (4): userfaultfd: correctly prevent registering VM_DROPPABLE regions userfaultfd: prevent unregistering VMAs through a different userfaultfd userfaultfd: remove (VM_)BUG_ON()s userfaultfd: remove UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET fs/userfaultfd.c | 78 ++++++++++++++++++++++--------------------- include/linux/userfaultfd_k.h | 6 +--- mm/userfaultfd.c | 68 ++++++++++++++++++------------------- 3 files changed, 74 insertions(+), 78 deletions(-) --- base-commit: 546b1c9e93c2bb8cf5ed24e0be1c86bb089b3253 change-id: 20250531-uffd-fixes-142331b15e63 Best regards, -- Tal Zussman