From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A0FC7115A for ; Thu, 19 Jun 2025 10:38:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E80548D0002; Thu, 19 Jun 2025 06:38:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E580A8D0001; Thu, 19 Jun 2025 06:38:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D95658D0002; Thu, 19 Jun 2025 06:38:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C92CA8D0001 for ; Thu, 19 Jun 2025 06:38:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7533AC0AB5 for ; Thu, 19 Jun 2025 10:38:35 +0000 (UTC) X-FDA: 83571801390.18.6989645 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf03.hostedemail.com (Postfix) with ESMTP id B2FAE20005 for ; Thu, 19 Jun 2025 10:38:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KQnBwOlJ; spf=pass (imf03.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750329513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L5jiRnPn+cyq0oPM5H1Yb0Fjy4Bm6o6AvZqwUI3hmr8=; b=JxNg7qq9ANpits8OCSMp9MFMg/KW6wU4tbiJYPbO92XQmBhsl6wz3Qg4BzpKLjhaYmVZXc SK6gYOZ0QbaPEc2toPgxtwrQn8pQ2EwQo836gxQ8FtXOIK3lOoUxmKympxbKWWL3a5kCdw bujUllm5DLdxCC5VDfOg0q5wPjUXifg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KQnBwOlJ; spf=pass (imf03.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750329513; a=rsa-sha256; cv=none; b=CI0UFhVYAW0KmwtPmPu+A5+DgRUtOMZBJ66fuIn2MnRRhG+cWCVrr4La4NW2JAddWktZz5 9yRawGADz4Q2nROvjIxFihNsjFZ3FeIOt3vSE2tKMYtTiYv7hVj8jshin3wa/MOpFIOo/E 7uayumvqK+2RuwMJoC6teBd3FxXJ9RE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7974244963; Thu, 19 Jun 2025 10:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9399BC4CEEA; Thu, 19 Jun 2025 10:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750329512; bh=vnHi+RdO+P6c9f2EfRap8UJxGiKK7J1jHomttd6Dip8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KQnBwOlJJ/89T7M179iD1AtWZGIGb6wExbxzEknJVqHP/+9vTjvDTX3WnS8Vl+orG u2Bt6exz0WK/3MZMehqzjT4znWzKTsFxaQTLvg2R/mo8n3tPn+oIbBSM9TpWgdfbM4 T2Op7PQVXLgQ+hT50NfZRiYUKBX6CCwRJhflJhWVjROvGmPK9TkA95vq4wOqGZ9Xgq pbjint9ouDMlfGd7gyKC8pDHxLhf4DN6zVnHTxDixSYlOlct243FQi0nY0uWrZs9dN 1B/bxwbD22dnbtjigtRUuLzXCoBJTTaZiJSkvxBeXhnbT2yJOD7YnQkMGJJh8n1mtQ Dota6Cqy1zlAw== Date: Thu, 19 Jun 2025 12:38:25 +0200 From: Christian Brauner To: Vlastimil Babka Cc: Shivank Garg , david@redhat.com, akpm@linux-foundation.org, paul@paul-moore.com, rppt@kernel.org, viro@zeniv.linux.org.uk, seanjc@google.com, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Message-ID: <20250619-fixpunkt-querfeldein-53eb22d0135f@brauner> References: <20250619073136.506022-2-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B2FAE20005 X-Stat-Signature: bfjyguu1e1bxez5fhhhc3zkub3e6jy4a X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750329513-922825 X-HE-Meta: U2FsdGVkX1/hcImAZ7NQ6UrIGCa3sdCKryWtWEMImSopR2jkiiX8e1uy/Bf11+9SSnS4BaKnjNVaRb1LSX56AIKEjv0e8pEqFpEPwFECqgqhXQYRXVHpMgiis0BFAf2OAoWnQAV8CXUgZzxYXcIZvH1FuPM3NbB1mT9DocOlnX4MNPJhELNe7J+OVTk8608tqcOUhl3d294/4OSYpi1w4yvR0lh7m9VJGcEDF5iW7PwD50iKHyg8b2g8F1WlmfLsje06K0jZ2JStnG4/22bdfG3K/5nW/+KniSNvuA/Nq8oJuFniM5DnVGA9d8jrcWYeICB2CZN7HNOdDsA02JKkSl6KuJUId+vuKGyVXoy05HHEDwbBxBYJnTU/p8R53QPtnhhjLxza4l6NgEurqkAFGUz8TIABaJxUzoiMHyU/zNnr6VO0Zp8itLnA6uLLvbsdBFFPGSKvHCa3NmWDotGX0zgR8N0g/Abn8ykp8+npg9kyuwt5i1SNPfPxLW0UPOjxAcen94an0WJk9BpxNzJrK1ezYZkfxIUgTQiRqyny3TIW7ObFsD2nFY2Xi93Qg+fwyV1IyTVEVfC+VilpSg9ZnY4HWOK8OfNgMzHHRZi/tlWC+QkhsOnnx8H8eTuRaVTderyxeqGHcePnHBusqbgGWWHiGlOVz9VjxYCWD4iJsqpWj4LIf+8PBs9dOhkgLvQR5HmGpSp/qnVp+lTyRI9avglWiV9P1frONnZWT9JjfAwZR6cjFm/7iR4I4WczqXVkEJp49zdScaOdJqNTX5zIodPUuIok/L3AfbuSlxFw3ncPBSlfmPtAHiWL8USuiAAhTnsJl1eizWhIOP9il2vRqOo13UW4OZIaJPQfps58KHxfKC4AHRayt+6Pil2DIWGIQmkDIkQT0ey+5RyYPiDqzhJ2C9IwQXL3s6iBueJi/x9/2IcFxYVJN8ywE9MJmH7ebjiMBPAF6E3baVNDVrY hJqfrlHg VFJjO7p+JNGfDq4KDP8wnhw0+4tEoLKYRarQhjAEl4sK3CrwwjbkkaHqn2QrrCWPo39580SGVK966M0EvoDWawfXD04vd3ZHuK88mqnJ4BRUZpGPNgxe/MmJMAFOrI1ayZugAQ1JW3pro2xoI7G8LoP+3SlXpZHtGXEyE4IIycbsoEKRwnrN0SoaKt8fezgi0a9Zy71th1gypgQN5rOr8Qze5xXZ3KSoo77jChplVz0Yx6UdR1Ov1G+wrWsSdPxofVhE0qNJs5OqbWOFNJo+Ju5d3cjYiPOv77LB4AuJj7PswVRcCqJJOgF5FKIrf+Ul8hLhGKB3071+6Pe03gVqJQEgm94MF+NlayJCyuLXd9QLeK0Vi/xB10DLaVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 19, 2025 at 11:13:49AM +0200, Vlastimil Babka wrote: > On 6/19/25 09:31, Shivank Garg wrote: > > Export anon_inode_make_secure_inode() to allow KVM guest_memfd to create > > anonymous inodes with proper security context. This replaces the current > > pattern of calling alloc_anon_inode() followed by > > inode_init_security_anon() for creating security context manually. > > > > This change also fixes a security regression in secretmem where the > > S_PRIVATE flag was not cleared after alloc_anon_inode(), causing > > LSM/SELinux checks to be bypassed for secretmem file descriptors. > > > > As guest_memfd currently resides in the KVM module, we need to export this > > Could we use the new EXPORT_SYMBOL_GPL_FOR_MODULES() thingy to make this > explicit for KVM? Oh? Enlighten me about that, if you have a second, please.