From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91F1C7115A for ; Wed, 18 Jun 2025 17:40:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D27F6B00A5; Wed, 18 Jun 2025 13:40:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75BDC6B00A6; Wed, 18 Jun 2025 13:40:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 589276B00A7; Wed, 18 Jun 2025 13:40:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3DC4F6B00A5 for ; Wed, 18 Jun 2025 13:40:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 002FD120834 for ; Wed, 18 Jun 2025 17:40:30 +0000 (UTC) X-FDA: 83569235862.15.93BBC05 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id ACF0C18000D for ; Wed, 18 Jun 2025 17:40:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NJpSklCS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268428; a=rsa-sha256; cv=none; b=vrrk0RZ1tH/S+ZXvBY8Zh6gEzmK6NTHUa6GqqeSCqjGeKndBIzEtJb6aePajiWmtRdbkv0 7o0hmti/MeLfFywHXWI2E/NewruP/nUKOoQ6Mrlq3H5EIEh2tZMsEzOqdnRijms2JGPxZa 96Jav4+PZYUHDa1PeLBR0Q0MQvpoGCo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NJpSklCS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S7FgUVlGmmQh/Fden7VOoWF093l0D6F2nUhdFZr7YaQ=; b=Df7pkVkYNtPuqktMLVRAeS4h4PnD3qi+iJ5Qh27ygUqz/kIksVt2jivgmIY84mNsPAy1Dl VdClVqSuNWimSd9vIPmaNWw0Y0ks6oYscZW6n2PQ+JLFJrBBz/tZ5UX0EpQ8tbjVKs52vL ss1sXxYDU5EvJDwlcVWNsS5Cd7lWvzA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750268428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S7FgUVlGmmQh/Fden7VOoWF093l0D6F2nUhdFZr7YaQ=; b=NJpSklCS+qC/2H+g3tk9QoeR1ANJ4xCxJJXTeQ+CczF02Rb5n4RokZGMEpEhQU9gI2mMkn L8s5hsQtWL5USkfkkzeDBMXKNR6RA+ABhFLDws0EhA1IqOTbxeA/8CMW9A6ILP82L/HoRw bqVg+MmJRspEU0luPZ2v3PFJrZ1yzfE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-WQALQjqcOwSJar1eQgBmaQ-1; Wed, 18 Jun 2025 13:40:26 -0400 X-MC-Unique: WQALQjqcOwSJar1eQgBmaQ-1 X-Mimecast-MFC-AGG-ID: WQALQjqcOwSJar1eQgBmaQ_1750268425 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4eb6fcd88so4232557f8f.1 for ; Wed, 18 Jun 2025 10:40:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750268425; x=1750873225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S7FgUVlGmmQh/Fden7VOoWF093l0D6F2nUhdFZr7YaQ=; b=FPtsPbBYYULmXrBx5q+gTPQgbYQR/jkBpRYenUZ3G6XqUDyMfbw0aLetlEFg6BRx17 t/8qQ6iAmOGdNHk+zhc/nxTe+wCW91EFAwKbweTEnSkjHb5bv1lvn5Du3DFyvUW5VFgW NtbxpS+wg0ZHXaRfZGYShm31DfrzKTVCDizAmVVCJMdUJqz5MFmLYogYfe0+NKleUuAg EgH2UfaretN+6wgmVJirwy5dzHq7GwdHnnU43ptMUoEqXVUjbPe1+9YuCli5zSwInVWA ss8WRlb6PhqRTN6FBsKiADvWzYzUUtHnC2wKxu2U/PzNqznvaze8dhkL/wvaNnwyHrIi awIQ== X-Gm-Message-State: AOJu0YyXtOCE2r9brlQEVOhZAkCT5UvkKpdd3KBkUg+ysuhig6hyKt2n gIFf8udRXv+/ub4eqSzEuPIM0mnU/YZsZgtJdIjGojqDgsGlqVVq4yciz3uSRqQPCQmLlOIF5nq 4A7fHDFgAnEG+zB8g1ZyFWyJcKZg9IPUWqOkVTWTSis4wFhHnGHeh X-Gm-Gg: ASbGncvZTOFoUftxsDqSLRUHMxgfBHJfRSZ8TKb4Xe9hb4xOTSXdft0a9C2T32HV6tI CIMQU+HehDw6TC+m3sL8gVTXxjtkXqI109azFgPqih5kDXKxJrAZzYhhDeHexOx/m3BiJlQDtvr mYYgAkukwHEb/KGSptrFgu5rEWNaApYc5KJWkk/eP3Tw44rK/X6Lzh2VNHIe6+KMAoHIfufzrWf yS5zzGDOaWUne1Y2YI6Nycu2MY+eP7DaK5/YruzQtRsG4y39Vlf9GiZei8slm4LazEUiDkWtqv2 +qAuYZWWbKpsfBYz0Ytpjw+X/H2EJiaDtMpg3w67Qf8P6fg/rkmQTpkrfKVBn8y0XCLLDRMGNM/ dkTnHiQ== X-Received: by 2002:a05:6000:2c0f:b0:3a4:ed2f:e80c with SMTP id ffacd0b85a97d-3a5723a3f92mr15706258f8f.31.1750268425278; Wed, 18 Jun 2025 10:40:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEayKPP2LeH5F/Ng3XTSzlfhGIAIvFkyNEolXxAmF4Ok7MzyUOG21uTMpu2qvZTdT619UlY2Q== X-Received: by 2002:a05:6000:2c0f:b0:3a4:ed2f:e80c with SMTP id ffacd0b85a97d-3a5723a3f92mr15706239f8f.31.1750268424824; Wed, 18 Jun 2025 10:40:24 -0700 (PDT) Received: from localhost (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568a547ecsm17734777f8f.17.2025.06.18.10.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 10:40:24 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH RFC 03/29] mm/zsmalloc: drop PageIsolated() related VM_BUG_ONs Date: Wed, 18 Jun 2025 19:39:46 +0200 Message-ID: <20250618174014.1168640-4-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250618174014.1168640-1-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J0twv3e52WopAFKJK6YOn2J6VGJlq6YiZUzr-2rdBo8_1750268425 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Queue-Id: ACF0C18000D X-Rspamd-Server: rspam10 X-Stat-Signature: wfwcxxzfry4nros9yjnmkmpnqcq9ryte X-HE-Tag: 1750268428-298013 X-HE-Meta: U2FsdGVkX1+AHIQ/LhCAPBepUA71mYFBiur2qpMejIhhhQ+yLuHpRGeBX2xhQjwqkX3d8fsBOGH9U1qPt43VYbTIAaJyABy0hrBZTdmfgpKUaAu6nykqDT5n9wMmETW/PbqkCwrUdILW6qRTl296As3+6wTJDmEx9eWCO5Hwk/ApGTplSdJ2aMKLuXmElovZp8hkYLDseb6IScMJMwHdjmmJ9yr0JV6POAF0RmDLI4cuzxS9LSihfS4ANo6LBp4RE0o01+2a58knQDx5joQaEYQcQtF1DsiCHAD3rCrig4dYKRzbdrmN6vyfQBmVbk+2iJopS8c3AsZlSh7GRcfW2SK67CX6KEVP0MqbnJWMaNanUV/q9F9vzXzidtxag+UWKLdb7OO5or9OesCB0xAWnQadRhQD+9q58nlbWP6t3CYWWNArjSig1Dj8i84GLKGRIoLkefGESnmN2dnWysJQ/BjAfhSpmjiLMQ1B/HtuR2KXAEyeK2YDw4yaSq93LBTeXK7vgHIrALADp+WsFqp5ivxT6R/LPcMNG9fTonn12R4amLVQO3DInXcleG3zWHB1yp10VzxelVd0XdiWGB1JhAJTdFsw/fSwyrGOTmFy/rEIamE9blYh+HEI2U5+wwphCurgEO0inZCaMbFVfms4+0J60gWt7ryJNrxEWjIBAl+kEfVtapfLIeNB1B5X6Kp062OcgTtInPEj3ndzaOAFrrc63Ik9qg0rGUrmNjo/aJ91rdPhUAMlOu1XbsIChR72CxHUmBAzGgV/GkVCTcB7urUlFOSR1a0xEb7Ma9x6UL0MNOiVtajIcQlSx8QyGZ24ag8Pv4kzVkQ5dikRWBPgt6Wg6JVty33uJx3TdsLElkEatlOslDBSI6bPS5k/wce/X/l0Yu/wZXDffB/5usCaFyJ3rKZfHRgXs7zHOLS/gVmUjDul72SgEveEHKyJ6RGck3fmJUL2bz+ThYDV2PE Ac7DT3ER Q6RXLRe9CfhQKQotr7zPWxjoJIIhaEAQYAxsSLKFWsO5rPwtCYXnbxGlp+NpWy87WTvgw7d5/4YatRJMOu9IxfiMiw2kox3eeLFu/29R/ojpyTqAMWGBc8k3pHbBdE4Y5lnBrnfZFLHl0iyLSh60RRcY2fRJBYujn4ZV0xwJu9XtTJaqsT1kcuzT6iJetaLGMPpfMopPD6nmCojffWrcP/GxsdIUIylCNs2lkdGDN+gtDHl6zAZ51HPnWMhsGZ4ZJHxL4qHHWIWApCPTOOZ3r2OSAkdC/ZEpr0raltb3Vrbg95qLJanof9QOGOxQDFDTzco8OxKhiIAkjCuHKe4EDPq+m/E8hHUqTB3PK3NiQF8SwpNCM5AuAIw1fw9/aUkM+72hcWTQ3bBBV7pnelwrjhn8AyDE1AVPwdgYt6N1KtyscpR1/OeQQ3kr6ML6t8HTX17WwgwQDAYnSCEW2lyMkRdaeZJRuEETwg1YBHAUaYJAjhUVNwUHKXEnRHBaJIFSASQrSn3qOmXPqeyP+S+Ww0Dc2TNKR3bb8YbEA+vyjt8FmCSUZvac7HopJO00HDLrbM4By1Ej3i7sIM1d/8VAy+N9jssyVjG41UnJ2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's drop these checks; these are conditions the core migration code must make sure will hold either way, no need to double check. Signed-off-by: David Hildenbrand --- mm/zpdesc.h | 5 ----- mm/zsmalloc.c | 5 ----- 2 files changed, 10 deletions(-) diff --git a/mm/zpdesc.h b/mm/zpdesc.h index d3df316e5bb7b..5cb7e3de43952 100644 --- a/mm/zpdesc.h +++ b/mm/zpdesc.h @@ -168,11 +168,6 @@ static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc) __ClearPageZsmalloc(zpdesc_page(zpdesc)); } -static inline bool zpdesc_is_isolated(struct zpdesc *zpdesc) -{ - return PageIsolated(zpdesc_page(zpdesc)); -} - static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) { return page_zone(zpdesc_page(zpdesc)); diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 999b513c7fdff..7f1431f2be98f 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1719,8 +1719,6 @@ static bool zs_page_isolate(struct page *page, isolate_mode_t mode) * Page is locked so zspage couldn't be destroyed. For detail, look at * lock_zspage in free_zspage. */ - VM_BUG_ON_PAGE(PageIsolated(page), page); - return true; } @@ -1739,8 +1737,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, unsigned long old_obj, new_obj; unsigned int obj_idx; - VM_BUG_ON_PAGE(!zpdesc_is_isolated(zpdesc), zpdesc_page(zpdesc)); - /* The page is locked, so this pointer must remain valid */ zspage = get_zspage(zpdesc); pool = zspage->pool; @@ -1811,7 +1807,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, static void zs_page_putback(struct page *page) { - VM_BUG_ON_PAGE(!PageIsolated(page), page); } static const struct movable_operations zsmalloc_mops = { -- 2.49.0