From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D777C7115A for ; Wed, 18 Jun 2025 17:41:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 341226B00C8; Wed, 18 Jun 2025 13:41:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CAD96B00C9; Wed, 18 Jun 2025 13:41:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 144436B00CA; Wed, 18 Jun 2025 13:41:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F3B1F6B00C8 for ; Wed, 18 Jun 2025 13:41:38 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C96021D52D1 for ; Wed, 18 Jun 2025 17:41:38 +0000 (UTC) X-FDA: 83569238676.24.F71F7EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 97C7380010 for ; Wed, 18 Jun 2025 17:41:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UWfD8hTU; spf=pass (imf30.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EpLhIwgxSmOTAUjcHZTQRVGXB1xFFa6Mgym/mVDU2pw=; b=DAc+/WZDRJFCilwN0FjA4VOsA0nmPF47wzbIvkP3sC5llCZ2VhN8cgmaCnF+kNUpQwbpMF /ArBacWdBR/Q+kV6uApF/a93R4eJp7OzdzMYobo2UWRicyxYouCKJOPn9ZhtGo3GWjA6vy TOBH9U3WsTuupFRO2LCRY4cP148b1rw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268496; a=rsa-sha256; cv=none; b=PKvl96izftangAXgE+p96r4XTjyWrZsP9N/BNlHdRu+L7h3HpGFwjE9l+tbczIKaGogWIv scOZtYgLALPkm+VxKeom3zpiEzkjJEikDQdEXZzAJvQ5wL+ZYXf0Rav9zrPCevrFrUFVm/ 7jWVoKKh+evGM28OQ+8Wg+QHnr5QMe8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UWfD8hTU; spf=pass (imf30.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750268496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpLhIwgxSmOTAUjcHZTQRVGXB1xFFa6Mgym/mVDU2pw=; b=UWfD8hTUsa0oM0FL6Hf4Y7TQHmJL54mykDcfurG0ecQ/jvfv5N3FS+PIpn8400yu4wYTIU j1Txo6wmxQ9MEQ4/b0VUtnW7GirM1ufxmIPRPUGzeqM42qdDp8iMgec7QSOblQ2QGygPHT WIyyQIZYal/GaktRmu0cUshAFG60HHE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-lefuptQaO6y6g-jSBbMBbA-1; Wed, 18 Jun 2025 13:41:34 -0400 X-MC-Unique: lefuptQaO6y6g-jSBbMBbA-1 X-Mimecast-MFC-AGG-ID: lefuptQaO6y6g-jSBbMBbA_1750268493 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4eec544c6so2847261f8f.0 for ; Wed, 18 Jun 2025 10:41:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750268493; x=1750873293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EpLhIwgxSmOTAUjcHZTQRVGXB1xFFa6Mgym/mVDU2pw=; b=PJNEHazx7SLD2N+a94ZLknjM8fhP1OShmZ7sJdywUnD16lAN9FuNJJIxf4lTobmIMZ VDemiIn5FImgYjpM0y7VJxwD7qvGr37Y9NwzWiNGPlD719UeiQEWtTCiZDLN7UR80KOi lDNnpDbP3REZIRJdBhz61271wjr3im4QjQFrWkAVYtZ7rYrfn8rxK3z+VPlNi1zjYkKn +3u67GqDiX71FIVWkT6oNXj4E40pPJ8Alpw3WzvGW1CkAYhZstBEvX+L08NXrvirsCxW 4mftS+cN4eUP/9xMvqJZpY7InTVeZ9f/1T2QppbfQkMUadkumWO7sGi5prg2tzW2+h96 r/Gg== X-Gm-Message-State: AOJu0YxLgBDR1qO9w1trNtII7xtjkxELablyU8nz114ZpAbHUwcy2u2s m1Fdswu8QI3VzG4uiIGVvhwrOOhl8BNyYsyhNNh6V/iNNZPVVmiMTPsbxLxgUOgxz27WFSFTG04 /3uoK+qjOx31uBMdmsVm4jfntdRiuVS2yEf6FHxELAuwqr6UFv9k36kh2S5n2t94= X-Gm-Gg: ASbGnctdtojbYzl0exXUZaTLQTBu8rShUvZ2eJvgKXvE9uf7CgfBaXSGOkWVjxx6zA8 LAQOlTQaC7/Fxdz5Pj+Z0i5S6nRKELCztWLf0h5kfDjB/xwJIW6UHEvcsZircsucy2EA5g+fo3u PCjK7CXCWT9W8JqSLeUMklqF+8k00UcwYG1SwQRDSLnMqpP6XwZUYnWvhKsj3CYVXk5pEhUfUQ3 RwOwR4dtUkSqlH0GC7iVYo14vRK++uxQvhc2z36mm4qZaqg0MtartwVsIXf4sowMkyrh1/g5e93 0kgJSWs1gUYWwWMZ4Fh1CqgzlUTIYiRAg7FE6TnAJE85JY51UzulFu6UNtEEh/t6GR3ctJiJhbx /vO46ug== X-Received: by 2002:a05:6000:708:b0:3a5:5278:e635 with SMTP id ffacd0b85a97d-3a572367577mr14018486f8f.3.1750268493487; Wed, 18 Jun 2025 10:41:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIdYJ4byKGNqSckw7stdQWmP9a+mk+8zzlUOQQiezgX3FefY2T8iN/DegCcyfhV4fwKQhI6A== X-Received: by 2002:a05:6000:708:b0:3a5:5278:e635 with SMTP id ffacd0b85a97d-3a572367577mr14018429f8f.3.1750268493058; Wed, 18 Jun 2025 10:41:33 -0700 (PDT) Received: from localhost (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b5bfefsm17100889f8f.88.2025.06.18.10.41.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 10:41:32 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH RFC 28/29] mm/balloon_compaction: "movable_ops" doc updates Date: Wed, 18 Jun 2025 19:40:11 +0200 Message-ID: <20250618174014.1168640-29-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250618174014.1168640-1-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 33QuG_zWdyhPuuRG7deNFitbd_e6gBw0eO0De5Yrwiw_1750268493 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam03 X-Stat-Signature: do3ng8fezr83w4pdf6aoq3nxd1b7y5me X-Rspam-User: X-Rspamd-Queue-Id: 97C7380010 X-HE-Tag: 1750268496-19996 X-HE-Meta: U2FsdGVkX1/QokIFLEfAvSvSNQZ8vMOEYub2MD3GMj7cQ7WiLgbjtvnj/y4QqtNzdBEdjfrd/9AQJR8PqONTiuZwCM4IqEUFu3crzWDVDV6QthZpRBsxtIFjhKVItv7hpdUcfNXkJhlCdsUxpbzhZj2tE0lVebAMvxJDLwiNHy/2vjNxqT4fRKqMzdcszbalTqvv67yaTCeXST4Kklb7OEARm/aMY1N8rMhxFX6Ih6qddHEdx14/sOaw7yhq2sDiCMwiaQqUwlqnqsJEJ9JQBhpO0W5JNgw/ai8YgE385sqnKUFKo7LIgUUuiCACixc+eOZh/LvfxWddG5HHX+6VJPYCH3PT+907XLEJcU0nMAfireOMeiMtnTj7xPT24icy7QTbJiVxckc9rIg2j3fxoVpUWz5x9/2yeqxSjjpYm4kuOVOFCDcMFRBdUFqgFYufrf5VxYVw1y1dYw2LP1ZZURhgJGnPHmXIS37I30vqfumCvjQPubmIDrLf8zsSIv6nG93vFM3rOstku0wXtKWQyyOsC4h9m7ESo1g4sfEehlj+Fvv3RH5aca2stLv/uUwYmJaGpWCPj8KzxMQ3DTeTlPjO3lMhyc0guKGJUquzA0/xOY5jmXJYBqLvWMFH4LTSvBTUpr2wdQ0ud/3F/mcPsH9OvU7XrjgF7pVe5WG9j6aQO/tQoIAi5cjWS+Ia5X/t6KaimOY9NjKJ/xKOnYlij0IzdORx1z+Kx5zQSL04dLFWyFtwZg0GoI/dPjh05zPtH7H+pnjGaEwVSg20LWg4mUBQNj/rX0oFEas1JJ6ujhD++Gb4zdOkeraQkvNUHMIHFobWR7C6Gi85G6/83gwxma/y+IfGSzGg4eN71lHZHiYW5UXLu0VvGpwna8Q0V1bWaVL1vBAe1Yda2FO3yQHR3nAldMB1/nIMY+Y69EsvYaYR6ebDV7ZCTDINd9xS5Tx2PEluUbj3ebJSA4f4s4P wzpfurF3 oDo+el0XwCJMh9oiqGIvYz6JzKTvRsuEHvxB57adI1QCd4ICPW0CB0XrlONkFkzWRAHcWkjkwyz9EF8N9rb6SBiLxisQEdTcwECpyB405K7YnXL/ef2mca4JEfjCSZ/fBkXyH0/EU84toI2edOvqEK/XoWkuQ/Q91KcG2OPc7e4sV7Yu3vtwQvx4lhflfnSS/344UwNewkv8JRflDKm7HMb8Ej+x5UM9Oc/XuFM3acD2QHHg/7oc41XlIKE6UscvUfWZBqyJUFDT4Y0pabEwuqOyNXouJA8TM/WBgOaxcEDnidrlX0l9kc6FVltaWUlNIqc71nglqzxuspkRt6tTKDws3zRThKlDHujIO6lMhaOFIJU62ivf0TJU4XpwLY6RAGB2aM1JbimgmzXJec6/DnkEpe+KFAI3lLHm+i11xx3iAmJKaK9yzfmA8pgXvyQ2Pmharpf7kEhjYwvuLvtkRr6yAC+s2Q0JH0xMkvRvbiX2dnsKPy6WtNmeroABo0dyQ3WTl36Rjr1nDmbkrO+rhRNhGZbE1oNbKBf36TCc9MIJzvPSw/paeEJ04t+gL5dBlKlwhBkqGRqrRbiRexOa5ugHi/BsyQF9EZtO0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's bring the docs up-to-date. Setting PG_movable_ops + page->private very likely still requires to be performed under documented locks: it's complicated. We will rework this in the future, as we will try avoiding using the page lock. Signed-off-by: David Hildenbrand --- include/linux/balloon_compaction.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index b222b0737c466..2fecfead91d26 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h @@ -4,12 +4,13 @@ * * Common interface definitions for making balloon pages movable by compaction. * - * Balloon page migration makes use of the general non-lru movable page + * Balloon page migration makes use of the general "movable_ops page migration" * feature. * * page->private is used to reference the responsible balloon device. - * page->mapping is used in context of non-lru page migration to reference - * the address space operations for page isolation/migration/compaction. + * That these pages have movable_ops, and which movable_ops apply, + * is derived from the page type (PageOffline()) combined with the + * PG_movable_ops flag (PageMovableOps()). * * As the page isolation scanning step a compaction thread does is a lockless * procedure (from a page standpoint), it might bring some racy situations while @@ -17,12 +18,10 @@ * and safely perform balloon's page compaction and migration we must, always, * ensure following these simple rules: * - * i. when updating a balloon's page ->mapping element, strictly do it under - * the following lock order, independently of the far superior - * locking scheme (lru_lock, balloon_lock): + * i. Setting the PG_movable_ops flag and page->private with the following + * lock order * +-page_lock(page); * +--spin_lock_irq(&b_dev_info->pages_lock); - * ... page->mapping updates here ... * * ii. isolation or dequeueing procedure must remove the page from balloon * device page list under b_dev_info->pages_lock. -- 2.49.0