From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6226FC7115A for ; Wed, 18 Jun 2025 17:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00CC66B00C0; Wed, 18 Jun 2025 13:41:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED8196B00C2; Wed, 18 Jun 2025 13:41:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2A2B6B00C3; Wed, 18 Jun 2025 13:41:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B69AA6B00C0 for ; Wed, 18 Jun 2025 13:41:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8A1DABBC51 for ; Wed, 18 Jun 2025 17:41:27 +0000 (UTC) X-FDA: 83569238214.12.014F171 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 31127180006 for ; Wed, 18 Jun 2025 17:41:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O3XloQT6; spf=pass (imf16.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OFGM8ws286HsZ+G2nyb5/sPhilYYDV0QN54X+S74Jfc=; b=GqMZtlBcQIn9Lyls+7tS2DAAelBH/SMMV6yhcFsdktNZmbb5tEhI9wXMk2YKPEXF1n9M1y iPsCAMqYYH0QAJqUzs+8Cb9gqRE0/I4h2dwxrqvqXQZ2dQDy6ISuPprfgJgc/pOpS+xUw1 VFeh9ttCLSofv1QgtxXBKjNvoewQXPQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O3XloQT6; spf=pass (imf16.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268485; a=rsa-sha256; cv=none; b=UDmKlIZfE+7Rh0k8bX3En8T95buP7z4GwNQPmNSAZEOrbbLcnPakrsCtQfZIkUN0H6ox++ CNUZj54tmFLo4kFgyGWpL1qZ2TfLVh2YzQ4bXT+vO4HPhzkuVLm97tnTxCRaYK97JKNU9D VgqB5wkqyzSHV7wEgPMBS3U+2UJR7JY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750268484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OFGM8ws286HsZ+G2nyb5/sPhilYYDV0QN54X+S74Jfc=; b=O3XloQT6ooh9X3KJ3vv3REGTMGb6EBIJMgEm2tJGK+7zxA1FkGcUlCIAvHh+GQG9b9EuEI gP67qTEK8xlA0PnLZ/wtX3ReNTz7qfwDCWUruX3lYgud6lPfRqfdV7ct57Lw8Ym8qzCAUJ KcKp6X62DEoUkYIJDMznKvRwnT4J7NA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-76X2IeLRNZexdHxSOOvZ6g-1; Wed, 18 Jun 2025 13:41:21 -0400 X-MC-Unique: 76X2IeLRNZexdHxSOOvZ6g-1 X-Mimecast-MFC-AGG-ID: 76X2IeLRNZexdHxSOOvZ6g_1750268480 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a50816ccc6so3929139f8f.1 for ; Wed, 18 Jun 2025 10:41:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750268480; x=1750873280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OFGM8ws286HsZ+G2nyb5/sPhilYYDV0QN54X+S74Jfc=; b=l8ovT+UUU5Hne7JwOG4jKAJiwH+nddLnRVRBlYmtsJhI30mWaAv45lMM1xVUGBCvZK wappCRdZHWGvqIUlcWLkOGdeJ7m3QFdhwZDS8IuvPnZ5dXOdeHgi2Y0Sl6HhzUrBdarD NNoyJmI6VqpYu+8Jll5pvsYnUlEifMv4Gi74TOpdBX347FPR4RZUJ1e68a83w0KYEYyf pJJ7u6dX3oqj2K1IR1AWp+Txd1k9OFNiCuiXd7c5hZfm9u0hFHU0UwsIm9bXc9NEgeFE 66PHqyIFw/NIK4Y/K6hL2A4I8lv1jFHB5wnBFY2ux5UxHdPZVYLUKtWBpD8G+tjDPnWZ B43A== X-Gm-Message-State: AOJu0YwMCi7EOPjEGCd4a5a/jq7PlwjEzTixHnabh7TruiI9uXP/Fc/l SICMWjeI1CyZEIokoz+/sWs6rDxAJs6J28Aj6JFYoo4nfoPXdKu5JKD3tImHv+/q6lcnfGv0hLl igRSNSzuz9KDAl6chNEgqMzTm1WOqGiBo58tb/inA1WTP8VkpUXSAVM4tUkDXjDA= X-Gm-Gg: ASbGncstNYPKwU3RfkznAUaD2fumek/fwELIpqLIxQOYHeEt5ZIHT1u/fir0itX1BQL ptDxQY5N3Fkvg4CQO8u0lO1CfHzo6ChmbBcR3WkhaYVmzL/sKFPmR22bPaIaV3Den8ksOsgmFut vvUtF36Ip/HfH37D2NOvOoO0Gz1lWqaSky3hILr4Plf4q8Ypv1JP97vYW5/QID5WdbrhekQPq2b KBFnhoUYQAFD8YB8l8nJ2RWXIx87Jbup/Y46rdh0Hr08YnOU60wIuAKwTRg2sck04+Vz6Xbv/GN lWbZxIElJ9wb+1nsUTqY0FNyu7otiSPZjNFGEZqCOE0tjmvqp2CTY0p4twhYPDsDuJCcjgXe40l hCUmMuw== X-Received: by 2002:a05:6000:2f88:b0:3a4:f8e9:cef2 with SMTP id ffacd0b85a97d-3a572e6be35mr15379303f8f.36.1750268479816; Wed, 18 Jun 2025 10:41:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGgOLn/JzQiVrSw8561br8iJzDS6W98mGXalaJQyvnuLaRLghELBqFwLLjepyMMgs/X1CCpA== X-Received: by 2002:a05:6000:2f88:b0:3a4:f8e9:cef2 with SMTP id ffacd0b85a97d-3a572e6be35mr15379264f8f.36.1750268479340; Wed, 18 Jun 2025 10:41:19 -0700 (PDT) Received: from localhost (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b62ba7sm17866251f8f.91.2025.06.18.10.41.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 10:41:18 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH RFC 23/29] mm/page-alloc: remove PageMappingFlags() Date: Wed, 18 Jun 2025 19:40:06 +0200 Message-ID: <20250618174014.1168640-24-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250618174014.1168640-1-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: G4UrFdXxtEAP8oGg20mNvxVwAs4wHqxbjwEXWdEUhy0_1750268480 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 31127180006 X-Stat-Signature: 7t9y1jjq6x6hofdu8bxtmbhq4drzmmx7 X-HE-Tag: 1750268485-464089 X-HE-Meta: U2FsdGVkX19YzOasPI8gyLT6FZw0ow9bWtIBlqGMwMymjmC5wkLMtdhH9Fqseqa5pcVv5o6JoHu2dCGxr+xCgtnp1N4TmGUeqeQgRZfIYufsZv9m0g47Y7sRdGSxz3vL8DwhM1AB8FSIXIqNKpcyb0yAYMjKmlYYzENjb2R3zFpfdmeZZyzd4SXvwb4GgcGh8PlnFBqj4vbzOxShcrG08MaU3SGskoXTt72XEpzpdEaRISumBFh1OasPHN3/bIo8q/2nKcK4cBbn0kvacK8cyOyVRVeIY2CEgdPYxzv2XxTKe6wFqo/fw41F3RtQ6HoQ0AsMEXWbjjJHYTlaoYUBvfAzPC4vOqalRY+4gK/rMkI11HDCAHVE5+0rrlvxuDUsSzN7dUiF5R7/ptNhwWR6TTMaX4DlhQMxXp28pJyCNzAOoi7Zpwm+bv2aRRBHHl+Rp33X+Tc2MzFrrMz8L1a1ISyPw/dlA6gL90jh4U/ZzCoClUxjZnq36mDwkwsvK7sXQqFKznATzUdD+2SQlvf3fkXNEl2TSsMrYx8G+7iPkJsZB/5iCqF6FEs6pdcuM1rSZjbqmjNnErM4HajGetrULBNsM44FyPjTQ6Ksbqv6idZj3b9yjes4ybRZgu+V+FyQcIdjP5k8HlvMkI2CGgWfoXB7TeB8r8Cxm1LZELgZQzo3EFWX9gaZMh56BVGrs3Gm+Gv39G5jOcCfSRjxjTV8sErMDnD84+af984j6omiPda5/xBtm3FlHipMNQsv8fqnZirTYEJ7KuNRKtLFw8xzkJYoHeL3IteJuxXo0iN63J88KPkN8DWBxTQIpX9as80sX4S8TKH1Y0lqhr3TpXkGMd3nc8p9TTU8gqwQYU7deqQ0gQVCpJuxR9VhJprOiJIkQ3+f1VX+wQtiQEew0G9sQcqIVLwTFTpLhxp51JpNGld0r78q5NCBcTHF5WNflgpWiVb1uxavOHz7Pxr0gCr NOETBrTU M0TXr0NG9z1HjPIQvWM0b1lZjAoZgCHnJdJMmyQl3C45rv82kuWe3zMgRc15HHjLfKmKuXcwaXhuTj2zU4if6EDWcjIMwyM5ED7iFN+Nq8S7EsJAnGx3qctSn/4kD+8xZX/RpSrDSuI22LlzJg9azTTBlwK891jfTPwdj+VD+w2l2IsDU7+/01JxWSvYVhnOGqJV3XmlmpLI2l/cQn6mDfOiGs2UnV4jrYWqPdWZSl0w6Libkrr5uDdQoZMFfCWgiLuXRqMWCDlbyhf0ZS7F+xl1YMea3CZOLzrc75JqQQVV7c1X6lygagqDzDyGQJcsilAbj8v+rbHRvmv3vbgkXcULv8gqJ9vkh2DM4RoIOsNzSWilGemSDI7X+9L0Z/MXmj7jdd5FIgU8ALHvoOejEWoxh037uAqbGwr7Ee2EWDHa6PV6zFIed3ewyITW7qDEjFx4M9eqJv0WlhPgVx+mcWH/ea3fVEW7YyNwkPyVxvyoVV47Td5w30MxjiC3oddjG4Mv22WaLrAe0hlM7clmRmtbR+rXumfdkuyfnhXYBtCqdG9OJF6s4UHumvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We can now simply check for PageAnon() and remove PageMappingFlags(). ... and while at it, use the folio instead and operate on folio->mapping. Signed-off-by: David Hildenbrand --- include/linux/page-flags.h | 5 ----- mm/page_alloc.c | 7 +++---- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index abed972e902e1..f539bd5e14200 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -723,11 +723,6 @@ static __always_inline bool folio_mapping_flags(const struct folio *folio) return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) != 0; } -static __always_inline bool PageMappingFlags(const struct page *page) -{ - return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) != 0; -} - static __always_inline bool folio_test_anon(const struct folio *folio) { return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != 0; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index a134b9fa9520e..a0ebcc5f54bb2 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1375,10 +1375,9 @@ __always_inline bool free_pages_prepare(struct page *page, (page + i)->flags &= ~PAGE_FLAGS_CHECK_AT_PREP; } } - if (PageMappingFlags(page)) { - if (PageAnon(page)) - mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); - page->mapping = NULL; + if (folio_test_anon(folio)) { + mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); + folio->mapping = NULL; } if (unlikely(page_has_type(page))) page->page_type = UINT_MAX; -- 2.49.0