From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E0CC71157 for ; Wed, 18 Jun 2025 17:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 190E46B0089; Wed, 18 Jun 2025 13:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 142826B0095; Wed, 18 Jun 2025 13:40:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFD0C6B00A3; Wed, 18 Jun 2025 13:40:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DEF596B0095 for ; Wed, 18 Jun 2025 13:40:25 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7B7441D0851 for ; Wed, 18 Jun 2025 17:40:25 +0000 (UTC) X-FDA: 83569235610.26.CCFEF25 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 4CFA54000B for ; Wed, 18 Jun 2025 17:40:23 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A7zeA9na; spf=pass (imf07.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ztkVXhL49uhBZn35+Dz91j/1BkEFGTeWr88qG2zBn1I=; b=6Haed5qWjbtvCzLA1J+9/7q/5P2/4EymWjapVV43iU0WV7ETyFbRl0i9VEsQJvPBsp+70+ bDMKX8iJ+J04ilOOaZzTbMdIv27lF8nltXM3RA8u4HzXLKX9FuC64w/PRGxCFP6dxOsEI/ jMC9j2+OJFjr0RvbQyH1IjHy1I62Jrg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A7zeA9na; spf=pass (imf07.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268423; a=rsa-sha256; cv=none; b=G/CCT6baoSLHs5M3A9Vj6b6ctba7XE4R0PwEn4EHE0RjSpNrKdnYqkMnWrkmMLXpMqlKxd A9CumYikK49p0d69uSSxk+dAI1N9fTLU7V93fdFjPRAcLUtNplhlxQbuHw+isWg0Z7xaR/ qcGaVHu1cEMMpLf1JY3N7KQ6TMeh1r4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750268422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ztkVXhL49uhBZn35+Dz91j/1BkEFGTeWr88qG2zBn1I=; b=A7zeA9nayFIPuyR+a2hQ0HDl/NMWD30aGpXQ5P49dghledM57aJrJR548gXJ8GBH/OVDxs uslNK1mqJNaRvGgA2CB6AO9Trz6BLlinoYglJSrLwmoizClZ3s+bgvyvA5JJq/S0c8F+Qm jGDruWHxEHivVIF94kcOuyu7+Ee2HEk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-31uk7NuFNjaYhXpCIfQoJQ-1; Wed, 18 Jun 2025 13:40:21 -0400 X-MC-Unique: 31uk7NuFNjaYhXpCIfQoJQ-1 X-Mimecast-MFC-AGG-ID: 31uk7NuFNjaYhXpCIfQoJQ_1750268420 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a56b3dee17so508814f8f.0 for ; Wed, 18 Jun 2025 10:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750268420; x=1750873220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ztkVXhL49uhBZn35+Dz91j/1BkEFGTeWr88qG2zBn1I=; b=JynVk7gwrxEbVWnBgvxx6ZpViqk0nKBa4nXUmJvbh1HQGXq4O6n5P9iG+tMpHcYwv/ NPa1XE95Ew1pdPzGIlb8pOksOKtl+INSooXcuq45eN7wFKx2Qew75e8XeeGtsGR9Z6wW ZATm/XY9FQWJa9MMJZwa9SrKIfecxKX+f3Mm01upuPku1kb6YNwUBSt6Z7WQVh+Gtgql Z7A3supGPBPyWE9nuqynMcvzynv4ID+/Gt7eQV1ErqriFGH8QSL5ivEkatTtRjHw3F43 1EnHH41aYfCwg5++1u+k4rcjOhLb0orn3AiZ3Qiv2ujtD9irMsVYf9d7hqk3c1AEN7n2 znZQ== X-Gm-Message-State: AOJu0Yymdz8ncHEE4D30xK76ydfBCN2+odVOFk3PkbPP+hqCrwIHSnNG dAIcq+DGpslFabt5oK6+BsmbXhMiGgx1dxciiQ5UsBEjWPrmLrr1/HmXYfmCWDa+C+Gt1K0/Sy+ yY6TwNWCH56U9pKBwChI1nzHY7HlibndSCRQXw8tm3/sXJTzsT+rp X-Gm-Gg: ASbGncs5myanMDdKyhFE4w8hmwDGN+fajMtROhRj9UGdJoDNuw3gxTpoveQxE8FeriY HBrdlCZRQeDLIdPV20lp8OS49l5kMXp4iRIcQ7RQk87hXqohq3fxx6DWBtQneKthE3j8HF4JViT cmnc23gDm2+MQsZM/OypomoT7LgWFza/LLwTLoJqNfQ8k9eR/r9I80Emeb8o9AN+UFmCx+mbkMj j4t8sySVNaigJvawtuNmU2Rf+s1GvvidPQNEnY1pD0un7F2DWIni5+MFHY2L8yYCCAc+0vabA/1 S26ShPIYRQKT8GNB1Fx6edRL9vOZ72i/K8CGHGj+j+Jjqq1D0hTo7uQWaKi1R3z4aBi2Zy2vrz0 GFHlLbQ== X-Received: by 2002:a05:6000:22c1:b0:3a4:f7dd:6fad with SMTP id ffacd0b85a97d-3a6c96bde70mr478025f8f.14.1750268420115; Wed, 18 Jun 2025 10:40:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdKc/sogX7P8eUPuNrS35oj8SOpb+inlndXsECh3VUw/sMAlaRsKTNBWIAReSnT0M7eOt7jg== X-Received: by 2002:a05:6000:22c1:b0:3a4:f7dd:6fad with SMTP id ffacd0b85a97d-3a6c96bde70mr477976f8f.14.1750268419626; Wed, 18 Jun 2025 10:40:19 -0700 (PDT) Received: from localhost (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a568b0898fsm17901600f8f.54.2025.06.18.10.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 10:40:19 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH RFC 01/29] mm/balloon_compaction: we cannot have isolated pages in the balloon list Date: Wed, 18 Jun 2025 19:39:44 +0200 Message-ID: <20250618174014.1168640-2-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250618174014.1168640-1-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9fDUbMhjfEyE9wqjtdzMezM0CQ85bwxAHfY3iZJvv00_1750268420 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4CFA54000B X-Stat-Signature: itjshnywakskcijsoja97giqngnjspfm X-HE-Tag: 1750268423-464393 X-HE-Meta: U2FsdGVkX1+JtvEmWdaOTKiEqcBUofmGfyrapML+qJwxEp4DiTCTs6120iLiDL7OMGVXmnFp9GJKrXaSxSOEZbF9Gt/HSlOnu0A6kd+2z1aLX6ti6ecOHgOrGXyygfFsFMJb+yqy9YgNiTAGpH+Aiz+OSQlcJsjAE2Z3GJ6y6KNzYNgWrsOnGWZvl3dcSGJdAkH5ivgLqtwXJDkANjfHTaDSVRv34NgWix+1ichNhhNZcTlyBCkJTO58KMUa5wSil3Sk9Dh73Bavyi4qSt7JTexJDDOXElmhlSjAOVrsGcJXrB69X9M+iCm0+3OFyEVI041jvGYjlLQDfRY4Q6MRhuwlw46HOekmTmcCFYYtyCnp6SFmESGbxXGEPQhWgiz6K9KrtGcQD7TaOMLNhrESrCIB6GToVRgePFbwSzz4vI1kzWmxjdPvSHrXn2I4ZJ2GSwoMb8HmbChWdqGa2nc4a6q7KnPsbDAg8FYIZ3ZZ9c7n745VioZgtJv/uu7KDdrVi5RJ6r0Roi4USnwDiRnuJ96vZhXk4RzYn5cA5wT9E9ZFv6zkBfL0P+2wYAk9U6EgcA4KxhMUlFp8hs3XQA3JpRl3gOgh50omFNUcJkl/BYi510enJrLufl6YkCBmFXRNWzU0IOg7Diu1hsfSS1fvs44AW51M+WNbePAgPeW15/bz/Ya68L+hMJodG8cKC2uddka2HnRGdWagldk0FFpRj2TxjQyLjERk7Rq31l3HjWwnHJdZExhpRBIOZb+T45duihf+5HueQzEOu5/Zzn/LIvv4wF5+Wex1pLeLdU8ZnPDqFJlLcH2IfTHw+YkdDfN59J+u4ZH8PxZ8Zepun23zWxuUCD+IKxcZZXOXkD9zQyjojazgfWdELZ7W1nmvB5h0HzrWAjmx/ulcJNOsJc8JAjztrRCo1srv2j6AZ+xXv88OGqdJCV/IqjRbAY5fGqopFK455F3ImyN4mQfAlVJ +LVGrFAj +r4VR5bKaBVk5nBylkGydUicpJ8MYZmXR263DklHgEX/MtnHl2Hewo6OuUu3I7oa3w2n7Skj0/ZAHkunWDMbN1YiyEfIyYYPdp7B5z8KjdhM8c/GXuHLIP1BLE5TifSmLJhkRn9Z0yNdn6fNE80opOo0L7e3gfZ4+9BL9RDVypXgbTwff5ZaglYbHXJZVvoRsH9HitLKbw9jGfad9rhvNJ1jf1B8+Wd4nBlU8Hm7KDEMWqdF4BdQECB4UKg0uOa/6mt8Kk3y/6w7iCY9yPy02nSHiPGswN6hSS7nOj9O/2BATNIAqBeyGaWd6YxeZ2gHHVzqisXVAD21eTJJQamgGft1ouej/53/4wInvBPFxWoosTibRPd5iuoimtP2YHC8Ns588wnR5GBY1JTaK5l1AZef7ID0a3og5i78nqeJ6WP4U9+cakq6W334FaFcw4CiqTkXCgDEZcycbWKVqgBnZH9OjsYKIpJygowPFprFd92MQ44tOYqly6FdNLozGr0phbty2vU14h+X7ZY1F2SUjN2x9eoeSmIvFKNoGuuajxbeJz/exa6rsSty+0jLlI0dPf9dDYAHsKsLsAW38ugss5q0TB8fyWbyyqDMI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The core will set PG_isolated only after mops->isolate_page() was called. In case of the balloon, that is where we will remove it from the balloon list. So we cannot have isolated pages in the balloon list. Let's drop this unnecessary check. Signed-off-by: David Hildenbrand --- mm/balloon_compaction.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index d3e00731e2628..fcb60233aa35d 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -94,12 +94,6 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, if (!trylock_page(page)) continue; - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION) && - PageIsolated(page)) { - /* raced with isolation */ - unlock_page(page); - continue; - } balloon_page_delete(page); __count_vm_event(BALLOON_DEFLATE); list_add(&page->lru, pages); -- 2.49.0