From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDBAC7115A for ; Wed, 18 Jun 2025 17:06:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B15276B0093; Wed, 18 Jun 2025 13:06:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC4C06B0095; Wed, 18 Jun 2025 13:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98C396B0096; Wed, 18 Jun 2025 13:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 889B36B0093 for ; Wed, 18 Jun 2025 13:06:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 28DD65A877 for ; Wed, 18 Jun 2025 17:06:13 +0000 (UTC) X-FDA: 83569149426.16.9D52F60 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id EE24640007 for ; Wed, 18 Jun 2025 17:06:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NHroZLiP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G3RePS1F; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NHroZLiP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G3RePS1F; spf=pass (imf11.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750266371; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SAxHe4/SFOgVVfwP/YkVikw5O0UdBvLzL0DaWVhZNTM=; b=bNMYy5X5FBNnvunKTmKcNvuupCqjrk8nNdy/SG001P92yXDpSie5iQhnXQQUr8oIX32mx5 s7jOguyTSLTJySrGGDNSyuom1N0XYha/8m3o6d79a0VErbVu7ydoiKhbBId67BED8/hrj4 u+Ff6oJQdkGkKVjvHYBHBBD9YJIhMzg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NHroZLiP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G3RePS1F; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NHroZLiP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G3RePS1F; spf=pass (imf11.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750266371; a=rsa-sha256; cv=none; b=rkbTa0GGWnm4ZBhYzyK5jnYl5g3aSdCu1CSYhpF5KMntUb52vljEaCKHGAzD4gSw7sBFIn eaCJKU5NhixRtqbyHvTKzK3VyQrIcJURkRUnor4tJ1oD43lF+W5m5O4H8JDQxgeI0hmeL8 kgdkvyUF5RYCVGCU4f9HqH4hfMfpyfk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7590421179; Wed, 18 Jun 2025 17:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750266368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SAxHe4/SFOgVVfwP/YkVikw5O0UdBvLzL0DaWVhZNTM=; b=NHroZLiPV+1/rO8sD9qZX/5PHN5D5Rfo5Zb5aOHdYXCyTajLXhRkymKkUo6NqEKT1i51Wq 3jzRv5I50TsK881TQSExVKFBTV1uPJb21aJuIaeXllkCTjwU0SL7U9SX534GcVuTrf9MkN z5adrX6FKDM+9HUfScghJAj+d4/N4Kw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750266368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SAxHe4/SFOgVVfwP/YkVikw5O0UdBvLzL0DaWVhZNTM=; b=G3RePS1FfsxZPpVKpINLhWACefVqXMozYLP/NJ+59JpdNLld0DBJsRsQUOr6wb7MNlldLN KfEZjWEX4nPtmqCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750266368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SAxHe4/SFOgVVfwP/YkVikw5O0UdBvLzL0DaWVhZNTM=; b=NHroZLiPV+1/rO8sD9qZX/5PHN5D5Rfo5Zb5aOHdYXCyTajLXhRkymKkUo6NqEKT1i51Wq 3jzRv5I50TsK881TQSExVKFBTV1uPJb21aJuIaeXllkCTjwU0SL7U9SX534GcVuTrf9MkN z5adrX6FKDM+9HUfScghJAj+d4/N4Kw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750266368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SAxHe4/SFOgVVfwP/YkVikw5O0UdBvLzL0DaWVhZNTM=; b=G3RePS1FfsxZPpVKpINLhWACefVqXMozYLP/NJ+59JpdNLld0DBJsRsQUOr6wb7MNlldLN KfEZjWEX4nPtmqCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D50B313721; Wed, 18 Jun 2025 17:06:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4kJvM//xUmgeMgAAD6G6ig (envelope-from ); Wed, 18 Jun 2025 17:06:07 +0000 Date: Wed, 18 Jun 2025 19:06:06 +0200 From: David Sterba To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings Message-ID: <20250618170606.GI4037@suse.cz> Reply-To: dsterba@suse.cz References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspamd-Action: no action X-Rspamd-Queue-Id: EE24640007 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: f9mmytba889xasr5ge7gabbd9zoji566 X-HE-Tag: 1750266370-779385 X-HE-Meta: U2FsdGVkX1++tf1KV+7J7SZsVRw3V/xNLbAsZYwMCiWUOU/xF2ryhSo344KmzfRN/P2KmyFrTjBv5+bEhmLPFEzJfWhXMB1y8C97J1BPViyo9g74rmJgQWeiPeZdCFziGXzt0gWNxGmgHzuGwUx0JH8HT/D9evaey/OiBnlA4JPIPat512Y7aUqlgxkAt2xMVtBXizeBKCZM1gOoPp8x3HShAFv9us+iZisLgTc9rJzQdM1+kVY2ESUqePN5skOcQjCeqgSbeKJU+OsV2h9WC0KGNOOMhY0uIt4hYjXFUPsSkKgXl+r42U4vazsDNsmMMHJ4pIiz5dS/MGVDuIILd9DQ5/f2o81sPB+htclSQuMco6Dad1GCd0K5xIvu/ADvWbYDud54Y022B7LJQttky3tzH7+BOzJT95uR0sx0l5QeW+zDhLuEUAZ3RipzO1s/vW1DDrLr4qHC2QXF4aEBdjf0vGTRXr7UDtV7EtMEdYPN/K6OU3zCReCZsj4/eJmk+IV+wbNbCoeln3/bPF3kjtszaEKjY2hXBOCe8ahRowJxfTS6AAb43UGlNp34WYLz22dOVhUqR6KgpV5DxyULtIt+eUf136geTaaYGg+7joV10/lYTX3v3Tz6M5ApgqLrO7gOPI07k5e0bfnP4rFfqIv04rvIOfFCik/KSxNnsOPxdUXF2rV/rk7+OlItxQqt1gn/RpiuRGT0AqG7f3b9gYW5FonRYZQKWzWeaGE39v5HFv8YQyj4X/Pq5faXTliwjLfvVgdI3Upbd6etPSCt5h30UjXNv+CX4stN2JIBRkkAEJMEkmNLy6dgQvJLmOTYggOOsyYrpGiEcjLEYi3UnLxu+UXtF10CSOs1Hc11prtOdWSXpYf/AcCohYlG+gg/nWdmrUdbADMSzqu9QRY57Huk+0lbYyTIkQzJ/q/3i4sLnHNrTKo+AvpvweaNIKucaeKqlEOV09TvjzlNlnX iz9CErg2 6X+pejhQD5Upwqh7hsNsSMGrvKiRxMJyCOEOpqxuF2ayuSra5BE1pLSh4mR02Ci2HAhp7RKq5IWgD4Y54iQIkLXrWyUzKZ4S3EhkAqBhKNdERePjjiH0mkOcn+e9e8hqmqVGN12RNMSpU0yAC7D2cpoWp9oJE+C0mwcOqGAypfd8cIMj7MpbfBGIcRQHP5HExXEgt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 08:33:29PM +0100, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handling > can be performed more safely without complicated and bug-prone state > unwinding required should an error arise. > > This hook also avoids passing a pointer to a not-yet-correctly-established > VMA avoiding any issues with referencing this data structure. > > It rather provides a pointer to the new struct vm_area_desc descriptor type > which contains all required state and allows easy setting of required > parameters without any consideration needing to be paid to locking or > reference counts. > > Note that nested filesystems like overlayfs are compatible with an > .mmap_prepare() callback since commit bb666b7c2707 ("mm: add mmap_prepare() > compatibility layer for nested file systems"). > > In this patch we apply this change to file systems with relatively simple > mmap() hook logic - exfat, ceph, f2fs, bcachefs, zonefs, btrfs, ocfs2, > orangefs, nilfs2, romfs, ramfs and aio. > > Signed-off-by: Lorenzo Stoakes > --- For > fs/btrfs/file.c | 7 ++++--- Acked-by: David Sterba