From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B16C7115A for ; Wed, 18 Jun 2025 23:43:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C7DA6B00A5; Wed, 18 Jun 2025 19:43:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 176D86B00A6; Wed, 18 Jun 2025 19:43:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06C566B00B8; Wed, 18 Jun 2025 19:43:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E83E46B00A5 for ; Wed, 18 Jun 2025 19:43:38 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4E633140F07 for ; Wed, 18 Jun 2025 23:43:38 +0000 (UTC) X-FDA: 83570150916.16.3A694CB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 793FB40006 for ; Wed, 18 Jun 2025 23:43:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NCuGKisd; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750290216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sPttGS6LclHkCEW7sayI9oSLjBqR7TgsZCdWPSm2Zcs=; b=EEutnl9AewMIuZXXcr64ubO/7e/bSzAZRyXukMMqlqA0SvmyDddR/HLMFxaGrOPyzeo85l 5uS/gQmyIEu5ZcLkWkFf6U8GNODJafYLXfy2pGwQ8J/GMGR8K8W0BNcqQVUy9ALmZfI3fq b/N/HE0mNPbJJ0AlmAXmXZ+IumoKO6Y= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NCuGKisd; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750290216; a=rsa-sha256; cv=none; b=W5u0zWBAv/L+NxrdHlLwCnreuHjB0lotKhX3aPGuNR7tvuZO8jfkIZvdm2GPd6e9R3N1On BtVwGNORiK/twFCI+AJ4kU2suxjGcbmyXyqmmXTlbVjQ/qYVqr/83Pz2dYeZ3jGsUcldcp 9uklQNnKwVvaPL53ER/czyuB+TMcjoQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D4B385C64D9; Wed, 18 Jun 2025 23:41:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDFF8C4CEE7; Wed, 18 Jun 2025 23:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750290215; bh=kjolxyeR6uYiKLj+UphTP3FPE1jfe9eMmKX+xYpXrfA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NCuGKisdUUBMLRMCy31Zvp+2t1QwaN7ATSS53e+cjr9BcGUcgkaKeejqH860ShP75 5NWuzA2y5Hj6POaK0Hp/q4xl3MP3ey5N3AYpajp1bSa5ykwnY0RHLGrlItH5TVzePe j7rONLLwd5Xl/dhCDMvJrCMu3xUMTaY9aqdQMozQ= Date: Wed, 18 Jun 2025 16:43:34 -0700 From: Andrew Morton To: Zhongkun He Cc: mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kent Overstreet Subject: Re: [PATCH] mm: rename the oldflags and parameter in memalloc_flags_*() Message-Id: <20250618164334.54616cb2d70a1ee3c1f28a81@linux-foundation.org> In-Reply-To: <20250618070328.2192849-1-hezhongkun.hzk@bytedance.com> References: <20250618070328.2192849-1-hezhongkun.hzk@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 793FB40006 X-Stat-Signature: k3gougdmhwx4hidkqbxti4pefzoo5d9o X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750290216-185198 X-HE-Meta: U2FsdGVkX1/T7tK+bVEoZ/0akMnOzI/5qYAawy4dwUVCHpA/h2FKqV4gkSWMQJNvSSeQxv3kfWQyYSPBNACZLnYKv1vNEyQ7Qoh2iyiwb893+Kc/fz8vkCIbGEoQLBEasJe3zwH7vpLYY3HiGv4sgwbDOyMD5DDO6q9hxdu8ug6Jxv13pRbJ6iywhVD4knnddH7YTDgDDRIwScB5BKaLB2L0jK4ZRmYzfYIu3eQ7qTGh/O/4De7TzqBG8XpYPM5V4FCPhx+6apc5jtx88T1tMaZE2k/N/7Vjn4BazSYgTYr3PU77YR9BQ8VPDTBPsSH5MCUiGS5Y9VjSCcnrKBLn6naEwHzWTtxy/iMH5cSv3MFCweOXWSREB9byuJ/5Xpi8U88A7+t3AKMzMcPpmv3C/yyNET2DsVrN+NCT5VfxcwAX8ZBcppsUj1pOpNQ+5X3YTYOusN2GUQ7FhQyd9O3DYufr3TVsn/zmD/1RZBWD8z9eFM+BrLsGrX+eb4ZZNj1mHtQQ1iKAqaf3yeAIf/QgviAlDnRg5FbaI2EGTaj1an49SXgLeS5eOg1skCT7uQZWO82Tck6KTkAFSy7QORZLSowldptsKKDOxaJOfWi5v3ZFubxAvQ1XC4EFeZk7l2OzYK2wxcmgJTVA29v5vryW3QlQTPnmkoVwDmLwNSsaetWIHaNsoAp8V8thjs4v14ujJ8s5ZfMYl+a3q5B8TtUPIzHyqaDYKZ4hhj5tQ9HqAWWnXXqnEpcR+Vo/04zmrT1Hg381/9Ajzn5p28laNU19Q63m/CxouefdLJ7/pogdTWP6zfqZhTgUW1Gaalqa9EYHftK0IzWQRV7+Q5wI8SYHNS8z0jlSX+xTy8PqNWrES0WlnxQECyA+p0PABrkeq94tUapPkedKIp1lfygBwAOwjV/cAymvipCibDKvka66TlMFQBB1b1Nm9D1BXO9aTSgim3MlAXf4qu0/WfPOFYC +QxK4xob sLQx/YguJQvKa4CN1jMxsa5SlaCZmLyPXx0v/uzcaMKpKZh7UGMavWzcwPf+CE41FP95hv+qzxVyS8jp60CCKJVDgxxfi2LOeTA9ZAXI5lszI5qVfkxS5feV8nQ6sDSXMF4Qh7tDZ5HNKwRIUO0h8KY4rBycC4kf21+5yuy1nLnnUzKvUnY6vem8CsFjNrjFDsEj3h/jQ0v8NGjFsRRbnWx1DFRTMT20e+mM1tt1Pa0wbV/bJc41L1StkZ/JYpH7Ips40aC3NQYOq8AawRBXCtebKV15hH5Lot9AKcyaIubLLK0HKhg5k8wDZ63wZ3o0cFFRg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 18 Jun 2025 15:03:28 +0800 Zhongkun He wrote: > The variable name oldflags can indeed be misleading, because > it does not store the complete original value of flags. > Instead, it records which flags from the given set are not > currently set. So rename it. > Your email client is mangling the patches in strange ways. Please send yourself a patch, figure out why it didn't apply? > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -322,21 +322,21 @@ static inline void might_alloc(gfp_t gfp_mask) > } > > /** > - * memalloc_flags_save - Add a PF_* flag to current->flags, save old value > + * memalloc_flags_save - Add a PF_* flag to current->flags, return saved flags mask > * > * This allows PF_* flags to be conveniently added, irrespective of current > * value, and then the old version restored with memalloc_flags_restore(). > */ > -static inline unsigned memalloc_flags_save(unsigned flags) > +static inline unsigned int memalloc_flags_save(unsigned int flags_mask) > { > - unsigned oldflags = ~current->flags & flags; > - current->flags |= flags; > - return oldflags; > + unsigned int saved_flags_mask = ~current->flags & flags_mask; > + > + current->flags |= flags_mask; > + return saved_flags_mask; > } > > -static inline void memalloc_flags_restore(unsigned flags) > +static inline void memalloc_flags_restore(unsigned int flags_mask) > { > - current->flags &= ~flags; > + current->flags &= ~flags_mask; > } I guess so. Maybe. A bit. Kent, what do you think?