From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F64C71157 for ; Wed, 18 Jun 2025 21:17:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B68246B00B8; Wed, 18 Jun 2025 17:17:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B180F6B00B9; Wed, 18 Jun 2025 17:17:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B93F6B00BA; Wed, 18 Jun 2025 17:17:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8A4AA6B00B8 for ; Wed, 18 Jun 2025 17:17:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D972D102314 for ; Wed, 18 Jun 2025 21:17:21 +0000 (UTC) X-FDA: 83569782282.01.8A6E942 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 17013180002 for ; Wed, 18 Jun 2025 21:17:19 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xalkmmc9; spf=pass (imf16.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750281440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKT1ifgDcehUIE1HAe53SQPyP8IuUX2gapbhAhmqJBM=; b=Y3QuPjaXyah4somsOJhps33sPZOwPtlzm3zWx86N6Pt3tjEQH3qp31a3Y++RsesdH0B2C6 QzFgvsmifapPy+sPfm8/oFJ9hSF3Y3B75C6dDHyFcXkmRjMdskuXa0ek2Md2MEx0JdnqY/ LRWdKWMZnctD2heppQMN+GNY5XVB71o= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xalkmmc9; spf=pass (imf16.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750281440; a=rsa-sha256; cv=none; b=2KD1sQ2h7iI+nLoqz8SxRqFt+hB06HgB2+o6yKtWc9AujvP4Vl1hfFbCPrHb+Fn4BJgGrs 8j7pa59I4vN2sRue+u2X8ZY0RPUCjx9KEb8DqZjA4UR99JsefJ+LMKjNsOavixTvIc+/fY v5sLc9bu2+oH+4NR1ct6az/wfzhUkbY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2AD4B5C6501; Wed, 18 Jun 2025 21:15:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5740BC4CEEF; Wed, 18 Jun 2025 21:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750281438; bh=KOEdlJiFTe+BKwO/glGv/UDTx5u3EWhGFs42UjnrPvk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xalkmmc9lBVHnHqvSKVAyn2X9Z/p24HQJAE1EnfIInP6cyPmXNiIiZdgA4Vz9P0Ka vlTMUlRBiP7lfkGLnRMehreY/IaGQQL0FHJ0jyGMaOziObPyRrFqkWMd4h58jcOoBJ E50oJhdMsrxnP66TK66u/iwiozRJcVrd8WfoZhVD6YN8Y6rpYOI+opR+fbMZxSWahP NQfPVwI/LPEodjKco+bjeFFspeachc2uyBv+g/pACl5ktiuPgBDNxZxHulA/BmhDb8 k96qY8/zzGBB/NbudKj3nDtjRMaCjMbPEdYGJlexw5KuiI6+B5D/hOnEC97J15D3wl CGmTR+mfC8Lcg== Date: Wed, 18 Jun 2025 14:17:17 -0700 From: Kees Cook To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Christian Brauner , Jan Kara , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Oscar Salvador , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: update core kernel code to use vm_flags_t consistently Message-ID: <202506181416.A32D378A6@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 17013180002 X-Stat-Signature: uemnhpkmzk4pap8oq1nmyr4kdktadmps X-HE-Tag: 1750281439-38098 X-HE-Meta: U2FsdGVkX1+wamaa6rxAUrfZVl3Dd1EI+RRd4/8ehtZXvgEbCMSDmoMafWElQ5IGSxKGR+jAaWrngVHQ4g/o7z31WcHgjqsiD+O+zPlpu5J2BFvtHSz+L4MUV+wlHSuBpX4PqBYXBR9/6lFK+lv9qQUWYqEYsIWe/3qene16je00Qsc5wCA4b+y2cQOSYDXo1/DQOuCXgSno7inFsc1RtsnRFXG02DHVZtA5Z3MjlnH7q+prU3VYJ9gCBbZhsi5S7AIGxKpPQoqrCMY5q5izkDpwiObCvmcbpXBwb23+tfMFf0jX1ZL9k+88h92o9wRHpPENWiwJZQUtsJ+rtrD7g7tImihlZ7BG59z4ROGDZRRKqcwWdOhUPZjzmXchO68OgQJI/0qRCQtBxxwbeuvQOMUoJjB0ZBKhfBfJJLjEHu1q/cZcmBCmnjvCxOKRfBaadG94w/0K6wY6lUlYu4XU4J5PSoDfMUycBA9Enei7si4/xRFgcXnnvwrr8CUdVqN5xAZLBI3QALF2t32cHFPo78/KVR/agLbBNcDL99oDEojs0/gFMJZ9e0Rab7pXNKt8trhH8LzuEtX4Y4zXNNqSplNhyQsP6+50oQ8Q02XjKtwLn2O52Kh9odw3zg/F2xvHwonD+0LrBdSGz7qLJigLzPzLAmYIHX4n+dljEG6B5ethbTs512JoeGH3dDwBjuAwnLgMnybuUPU/7T7aDd+5lz36RYyP5q+VgOEUYi/xXFG8aaFr1p0PJx8Z7D9epbgR8CQPUvPXHtEOZ09ORUyFYiZxmtbOxOhu9jEFyanFbvTJOKy+xzMJrKrScIUpU3amrl55saLNRBK38oz+iiLjtIw58CN2ojme3B6KcVSWzmtb9c1V8X4UhiAB4jFFIK/f1d9X2jTm5IznAaOs5OwB0ONDR461SeRSt3/f6z2pmClHznEMCUjB2J1TqgfxuCtMrhEaWTUBQgbAyebPZos KTq+D0ZX TOteySLyG8SbGVewKYfOzc30EG9+5cC77lFDj+h/Wufd93O6X0cCm04BeSwTXCAAian8BTz48Im7qYmiLJTRki54nTLw6vnIH+LuZkfxgFr/ME0BVwdY7vx4UnBLW8AP+sM2fZPF0tEF2p1UNxqKMJ0TTWM68DUC9NJfjcUex2nLSJJhbmO3HcUKuZkIvur58Rdy3MMLsG/Nf11xvnFpbXk4idpIG+G28nvx+Yvm5+GHM71VnSgqcXjAF8IqteF83BoihxWlgsHKWqOOW8v1tguvxoWjSBDpo1/JquhrKe13J2IwZVdzum0zMMJ3PV0WIYu1OlivYk5MOefGraoY6BirFIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 08:42:53PM +0100, Lorenzo Stoakes wrote: > The core kernel code is currently very inconsistent in its use of > vm_flags_t vs. unsigned long. This prevents us from changing the type of > vm_flags_t in the future and is simply not correct, so correct this. Thank you for doing this! > > While this results in rather a lot of churn, it is a critical pre-requisite > for a future planned change to VMA flag type. > > Additionally, update VMA userland tests to account for the changes. > > To make review easier and to break things into smaller parts, driver and > architecture-specific changes is left for a subsequent commit. > > The code has been adjusted to cascade the changes across all calling code > as far as is needed. > > We will adjust architecture-specific and driver code in a subsequent patch. > > Overall, this patch does not introduce any functional change. > > Signed-off-by: Lorenzo Stoakes > --- > fs/exec.c | 2 +- Acked-by: Kees Cook -- Kees Cook