From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E79E3C71157 for ; Wed, 18 Jun 2025 11:56:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 882596B0096; Wed, 18 Jun 2025 07:56:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 859496B0098; Wed, 18 Jun 2025 07:56:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 796B66B0099; Wed, 18 Jun 2025 07:56:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6A1066B0096 for ; Wed, 18 Jun 2025 07:56:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 238C11A07C6 for ; Wed, 18 Jun 2025 11:56:26 +0000 (UTC) X-FDA: 83568368772.19.CDD3875 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf03.hostedemail.com (Postfix) with ESMTP id 2ADA420003 for ; Wed, 18 Jun 2025 11:56:24 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=KgHqNvIL; spf=pass (imf03.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.42 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750247784; a=rsa-sha256; cv=none; b=Q9pOaJQEqbVct7+pQ6n4jVY09GKK2y+pg51/pYuK+BoTdJd7P9WVWhyEqB8ewGpz0gecym BQ8vWlpXxlU+cfa8+fw+xRmxlw9bQq1jh/q8LwbbOPFpFO4KNmbzGUMxRsgpsP4bcmT+Nb pCrV5ELgDvmOMPJwqqVBNs3BFoCPnXg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=KgHqNvIL; spf=pass (imf03.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.42 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750247784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eOLPsPcgBQpr9WRtPyiXFyxl6s0ASLsL9YN12T1AgKg=; b=skfpSLt1AWbJL1iCZMXCuiraeQEiz05J7MbipItuVhp+kLW92lXSAR8R1VgxP7KDxOwQLO pZcApAXmSAj3diuWjv9pwMawFmMy8S29jyl+PV2kYfW47yhr9XxXiYjeQuH8ul5CGQP19N xDohpoCzsYAoQDeDGBryzJnR55HUCus= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6f8aa9e6ffdso61934756d6.3 for ; Wed, 18 Jun 2025 04:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1750247783; x=1750852583; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eOLPsPcgBQpr9WRtPyiXFyxl6s0ASLsL9YN12T1AgKg=; b=KgHqNvILhAGYOnMN6TpoerBLXU09PMtMGtecB4MbLsPzB8RecFM6YurMpD707ONTgg qb6x9lDM/ikuHHIsshuKAF3V1zrK1y/CyubsnAIt5qFieZ2+DqgqtuU056tNOZSHjl7d gOloVcz52DRfRXWQduAmODx++grSBcE3rB/d7n0VwupuBK5DrORNezHNECmYUKRgP/J1 h9tkhkaElcBTuTqTiEB3ZStM6ZKM2s1sKi9vkSMginTML1SONHHqikHM6GYMGHoxzCLP FKq9ReS/JQbwl4zBTP7j7ovx054RiW79JnUM08KidNNo/CIO4oqn/JfSNyphTxV/7p6o PaEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750247783; x=1750852583; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eOLPsPcgBQpr9WRtPyiXFyxl6s0ASLsL9YN12T1AgKg=; b=KQRtk1DRScf5RrFDiZn8iC7CAND/XqzrVyha0KYDQvNVVH/ioPpplXnhaKs67XlyxV uziFpzXoHLiR3EWrp0Ihs8V62equIf1JZLF/ICl8atl2u1yRJ8wqcLstSRCij4okr4bt D4Z7R8se2PzMbKPOW9Rx60eG+7EPIXo/SqxFnsdn92x21IkprwqooJpPQcNsp8SnqYiS BxTSB2/PFJxZjtRKz3gQ82Du4MUVq2dGvaD1fFY8pDn6a+T0ckywNt0nUBn0vFUNCyVX KXai8+HTBAJQBfyEXGiUWevalCPmzsIf6rFMUVdUQDRCgrLdGZAgWvg1xUIc/dSHFBw3 1NVg== X-Forwarded-Encrypted: i=1; AJvYcCUiyTJTNETX4luO5X0coc16AuwDmsosCmzuwzQRWVpyiEm4W6ggH1u5Cp+rDnn3sqrVhDD5/rV4OA==@kvack.org X-Gm-Message-State: AOJu0YzJ+bZltopX74y3/LthfXKtlOkvSPkjaysJvgRm99RhI37gwwWv E5c9iL9vmkD7uz8Zjxktk8EUJl4HmWqzP1aZf46TtXQy+iiBfMatC9zLjypZmYOzJZM= X-Gm-Gg: ASbGncvZ5iaO1l51w8D/BIHvS46GlvrvAPCzPq8aojxm7paYoeBPQFgAHveJky/u7oI BViTF+1kaVgKkEWj46a9iVfJBXCk1XF7ZBEXdzJIyzv5kwtzzufXUxpMjpFPwl831d/l9sQnEIX M8Ie4LA6qwIB1x4K0js2qsKT5IHERV2e39fVFCAyH35Gnq87GjvnvRgK/m5wA5ERIRxT9X0ee6K NTRWpBWZIgl3j0oaCcLivBlOjfdpq4ZQ41zvNCOfjT/LVQxryfDIcsA5MzkxtnC4O4rrpWIkteI IGM+W2aRrJAI/mBRAW74n6sdc4qGWj38Ev9B/hZWyMfjSdIOlS0ZKPM0bx+2XardUo2AEK7Scgj M+UqQcRfDKqR390kuEr2aTM4acuaDvI+amcSCsQ== X-Google-Smtp-Source: AGHT+IFK5sEY0xKiG/3LSQ/e2KNGGOzNmfpbdDjrbjeKIyXRBISXKdZ2vU04k+YsgVsnDuL9/XDSDA== X-Received: by 2002:a05:6214:570d:b0:6f8:bfbf:5d29 with SMTP id 6a1803df08f44-6fb476297damr257611906d6.5.1750247783171; Wed, 18 Jun 2025 04:56:23 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c841d0sm71929076d6.111.2025.06.18.04.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 04:56:22 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uRrOw-00000006lbV-0sBw; Wed, 18 Jun 2025 08:56:22 -0300 Date: Wed, 18 Jun 2025 08:56:22 -0300 From: Jason Gunthorpe To: David Hildenbrand Cc: lizhe.67@bytedance.com, akpm@linux-foundation.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, peterx@redhat.com Subject: Re: [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() Message-ID: <20250618115622.GM1376515@ziepe.ca> References: <20250617152210.GA1552699@ziepe.ca> <20250618062820.8477-1-lizhe.67@bytedance.com> <20250618113626.GK1376515@ziepe.ca> <9c31da33-8579-414a-9b2a-21d7d8049050@redhat.com> <20250618114629.GL1376515@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2ADA420003 X-Stat-Signature: qxzdgrmxicf4gckmttz76iixrrbm4qnk X-Rspam-User: X-HE-Tag: 1750247783-467044 X-HE-Meta: U2FsdGVkX1+XErbXR3oiWcQ/ENBPj9EDScoZaTD96B3mFzoHm9ProzK9mPKNtLBP4oGrqhaUE/8/3KvWcsFVbSENjCByq6sbIVCbuPeiWBMqySKFCkzkd+B8sINM9ab8UBXJBRqZRd8nT8Tl/cNBQEPDo+XesISGL1tGmfPeNGwNQbxZvi3tokDEQ84LuJWxqYq4iVJLI7+Dgno6DgiU3EmrAxsp6a56NxN/vJpNmz+M+4mh3oYLPTqRb5unAd4f2+BJzBywnGN0ISa9Nkmqv6CVbGbPjBKFMyL17obr3a/W+MXNTXZ1tqzNZN34jyAvrEYTO58+5LDZ2ToLI3zR2AC3afeQaKbphgi5ozB0YgiGBRcrom80rz6wPVKTrpdA9E5pwGtbVdMWHiU2d3ksGp35KmkqPcun1mSMkPE/vxdYu4VJ6mAfvu4PiwaFtk6aSB6358MEJo18SEt4P/CHPukFLUfEdjsnfpv0C9DPA0cvH/9PCLs3dXUO5DC/EPfABkLnGXPqw77FIWaCawQgkslHVuKprx7Gsx5QtlOZxdyTgdvhQDZT5JNA/m7EehAE8pPjhkb12fgsSGcT4ylSi5TwjL6Ui00NfAW+nqVkLT/xbjwAKoNNBfGMQg43FItc/nJa4qGPadzawqQcVPY07gLm351J6ZWXnm1/7ENZW/NRN+mdoFE+Gwb+jUuw8o7oVZnrscLxsqddppoqR+WGKh7LpeoCG+OF6hNr9ghGd437uQREr2qOKK/kFXfAIiMdS9TeK34LLHq5dZUv1EM2XTE544kwWl317fDa1uUuJs0U1o92/NI8YXVJWIwLmL3y4stiO6UlIvJDvC254Lq427U16P8EJ6hvMO+BAg1myJL1WPmuNRveodzR5/vtidQZMo0047XDEtz4xXI7XH9KH2oKRJekLI+/iN+KmNBaGNSzckkYlcAlKFp66+7KQEoeSvDG+o91nHknMGfsmci nlBRDV98 pzaoBXaespbgd1jksPOGk7Mwh0NQ0d5uETDcV+TCA7tEpRVFixmigjUyz0o7DCVqrTP6P6zg7cFA/cxdUfuPyV0CJ2TRTXv0BWSxj/eaktES/gXMsWIrW5ajIB8YOXeXfR/22s1n16oJhVVQo993/TIsvqhaUfyt+dnbmecwT0vRwcrh8fQ6Tad+Q0VSUkq+QGMemHnMzB7fYCSZWaMqZ4vQGZIAw9f7DD67MCHrAsjYdkIr62MEW5kUEsI8KqVQYQ+TtvmF+rbHKu0kVQ5+wdbo75A+nbhn1PE1kzrFXMjNc53AeBc2ZBQD8K+0CPN44rg0mF476h3uJRmU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 01:52:37PM +0200, David Hildenbrand wrote: > I thought we also wanted to optimize out the > is_invalid_reserved_pfn() check for each subpage of a folio. VFIO keeps a tracking structure for the ranges, you can record there if a reserved PFN was ever placed into this range and skip the check entirely. It would be very rare for reserved PFNs and non reserved will to be mixed within the same range, userspace could cause this but nothing should. Jason