From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FD5C7115B for ; Wed, 18 Jun 2025 07:03:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 090A66B008A; Wed, 18 Jun 2025 03:03:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 068956B008C; Wed, 18 Jun 2025 03:03:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC0416B0092; Wed, 18 Jun 2025 03:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DD41E6B008A for ; Wed, 18 Jun 2025 03:03:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 94387100D6A for ; Wed, 18 Jun 2025 07:03:41 +0000 (UTC) X-FDA: 83567631042.16.77C08F2 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf01.hostedemail.com (Postfix) with ESMTP id 0EDDA4000B for ; Wed, 18 Jun 2025 07:03:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MoBg7Qai; spf=pass (imf01.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750230219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=uG8xsZ+H9Uc7SQoPGGBdFgpzo+4wm51Bu3+zxETd9+U=; b=XC5ILVjQOoMGAFMviGqRlsY6ukGyjCpx7qYc7eOE1TH6M/wyawrEeQ02ygkOnNWr34bTS7 KIvsI2vviyRbJHzBlqRMjHqzlYcUCUk7WJTuT9veOYkBbrJD6jTgTIAbp01watR6yUlUlf dNch2iHpA9KPdMaH+AtmrB6EsoT4T44= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MoBg7Qai; spf=pass (imf01.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750230219; a=rsa-sha256; cv=none; b=Rb4u4gIT6UZifVuO9iqkx+R7GraU+zYWpoMcEhKhDxdsYO7qopm90qll2f1blbIyQfrdsy 8fUPYEzPy4mCjO+KT/EyZDBnF4omof7XnfreqaMrUUox2vqJrFLIJm3dZVl6PJz9JCDb9T e8SWsVNswyY7u6BdSM9JY6DJG5MojeE= Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-312e747d2d8so362167a91.0 for ; Wed, 18 Jun 2025 00:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1750230217; x=1750835017; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uG8xsZ+H9Uc7SQoPGGBdFgpzo+4wm51Bu3+zxETd9+U=; b=MoBg7Qai5Zz3GktN0cFSD8l5qH9h8pLsAGgonC3Vvn3++ZWVfgJ7jElRLl9RYKM06S +CgeptDEL05jldxcg1X1Sxpi9I6q3SPAcObRYL7Iw2BO9byKUN37MpMYki/cvMuuctol gTfcdLGNGRtTXyIXwuq921TAFyIe1yjzSEMGJk8X8Vl7ua7rDIKuhjOXyH8D9cqX+MDf afNAcjN3t3+a/JqYYVskg7PgmtueqnElYd2BPtp7N56Fm2g5iCcqcdjmm6gEWyJth9x8 mplQgFRGpZ5B06e3wq3i7yMEYWS7h0Pko3d9tn6gRAdntYk72tEVeMPaiZsfplKX721j DJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750230217; x=1750835017; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uG8xsZ+H9Uc7SQoPGGBdFgpzo+4wm51Bu3+zxETd9+U=; b=k/2jqRqEo5l9wr9dl9GABk1nDLVTLhNlo1+KRYo4bd73IbsuQDsnK0jO33ro0b45fZ pmG8FbI9VdzyvNev5VPFykFbvfclR9I2GUnWq5RKOZbkcWHMSvVoxQO5HpM6YzOwNpYp lwxDJ+hi2Lad5ItXIoEotcM2KFNsx7diLLQhMIu7fTuRL/W8b1N++0sBX3Q3UL4zn59a 7P760ro5N+BRhhkz3ITs9xFAJZPvHrGXy/32VnaANERkPv975e+S2Xur0QVo2z6tg3cs yqSm9ipnuDMJCnRgXJ6zFxBAylDnbAY59TkaulZVcWGDhi+VZtu0eaOMV5iVDcUL9Fms N1mg== X-Gm-Message-State: AOJu0YzpYA8IQj7h4a4/epp73OeGo41Qsyy2q9Q51UzM3pJUj0/uOnJN 3CAJUmE6N3tWHDuIn5WSXkxajTLImVY/GzrPauRGT2B6pO5hA2pqTsldqcyRNDpL44g= X-Gm-Gg: ASbGncuxa8zFCbVA9MTsFSR10ACh0tjK01KJ3lcDVAqAyiLrC5XD2ytWSGcI3gH9haW EdM1fRXqizaB0MXvKoDtsd15K5IeQknJC/AofMqAPVvquC1AMf8bpQhWe6OimcgyulvCDYse02S 9FUhtihyAtCeSVOQ1SdEmnFlaF7ZiUfvMyGiLP0VsialVl9hqF2eX0V6CdmReya3t4VnogeRiK1 XfymbbUTZ6nsOoeLUcCCvsTXT0pZDfrZnbn16Uuw6PElFI/+SJwixKgBhMBjmGVEqhIpK8UCzPb nq4i/hconJ+l9BMTmeSnUn78GB9Ci2OukuPQ79KXuZC979Zrrwgk2ZP1ekVCthqe5UYFX+hNhcB cc+YBAYCemvU= X-Google-Smtp-Source: AGHT+IEia4oaMaFBaQctANxpaCc0PHtuF2nnE4zjAiyUURSumP489zVqZFiRFyiBJKlP9CCUFtwuxA== X-Received: by 2002:a17:90a:ec8d:b0:311:83d3:fd9c with SMTP id 98e67ed59e1d1-3157bee54a1mr2219843a91.0.1750230217484; Wed, 18 Jun 2025 00:03:37 -0700 (PDT) Received: from n37-069-081.byted.org ([115.190.40.13]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-313c1c4e4cbsm11899869a91.27.2025.06.18.00.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jun 2025 00:03:36 -0700 (PDT) From: Zhongkun He To: akpm@linux-foundation.org, mhocko@suse.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhongkun He Subject: [PATCH] mm: rename the oldflags and parameter in memalloc_flags_*() Date: Wed, 18 Jun 2025 15:03:28 +0800 Message-Id: <20250618070328.2192849-1-hezhongkun.hzk@bytedance.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0EDDA4000B X-Stat-Signature: 3ygon7kby5zpfqcomfhfei4p35gtmh36 X-HE-Tag: 1750230218-51705 X-HE-Meta: U2FsdGVkX1/p08uVsvEdHNZHtv9URpB0CZWt8mF8PQ4mtecxS/GXpjTAMvFg2OJVr6xDPF+KGLvRfondkQG3XMygfuGPvdEYkVZ6ZTeqJfx3UKdIUydJ+55vSt/LjkxJcEvj+v4xZLvLdVkrV4933FZt067UZGWad6j32jQ33+s4YigvYS1ClrcCO9His9Lk+ik0bYc1DAPVN/662S/Vtbm7RMb0WLLHKY42ipET8wYPwvf21MRf01D6vw+jQEE5IJkED39XSw5RrSMJ11Di8sB2MZplDWMVHQHZdSv7738dBYzCDI0+JDP2JGh+phBQY3+nFJeZmADVIzRGXD2o79DTaTh4EB2dYthek0hzm31sMq611gMEsJADvDXj1+vbJKLg5Ml/ee0d2/uU8mduhxDczXbhB39aKWkOUSkc7j/HbNfbctZBUYLdk94UrRdJRPZJmaUepksLgZ/o8pv/x97PohssNr4QSNa8p1d15eZXwGL9QWS1N66LHkqwS8NtgfRIWFb8EPKJ3bqTkkPmCcJ0YE9moGnShdJ9TIF2KwATLDB7Hf5m8DFvGgTy25lcKVHnuy4izctg3gvKsb6NPjms50Hq4HBfihOa5K909RfXMMI5L7+sBbwr7HX6t0hsXgBb9YeyCG5bQUNpdRnDY3oYzYeGBvw0fn8ukpHfw5ZI9pRrN2yP0rU0pui3SFTKOqvG6qSPZO1HvttTywhVpjxh/SfwJehjDZBUU88sGyTeP0ycR2SAUi9RtMDHLBeSYZmhWOQGp46QZVn0+UznnNdqGwxdkDPSUpeWA2BUfPrK4wtjH2Cj4ksc+O8qN2T2ZANADdu0/WKsSmo2AMRqnq4gvv4aF5Sj3vM4dTG/1ozF6C5HCGCwyF5gLEmVr6pB3jAP5BrUARzp2C3ZePgSzXuGR4rAgQBDKvUjFPoyPEUN87//qyuw4UiXEdWmPTjmQ92+gnYYhh77tckHUv+ GD8ZsQb/ bhRHwFQCFpFxh5PfKpkHitCKEAgrUtQT9ts76fYpYMBErTDkZUbhZUvntsdIDC9gev3mFD20btdTMXXBhCERbCKEqJO30SXjnU5RjKz9KVNCjucv0ja9rFGOsQPvd+fmcl9vdPfRthEY6Dr0mujB8A7YYnvCObXHg9AG0fGnbeqSpRJo9ImQjnXgnYofpt4OL2sQjsD0ruR4pLHy96TLWsNLHtMxpu1hS4j2Glstlx1Zrl8RHeFveuqO8WBbDxq1AU3JbA6W6ZU+2WtGL6Waov33yqLRblMW99CV8iTyjN6y/o7RCFovfDvwh4goTfzF4lYbSrE8BAbt/TEph0nIP4jUcy7xngtl4rAeP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The variable name oldflags can indeed be misleading, because it does not store the complete original value of flags. Instead, it records which flags from the given set are not currently set. So rename it. Signed-off-by: Zhongkun He --- include/linux/sched/mm.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h index b13474825130..6b4b54e8db92 100644 --- a/include/linux/sched/mm.h +++ b/include/linux/sched/mm.h @@ -322,21 +322,21 @@ static inline void might_alloc(gfp_t gfp_mask) } /** - * memalloc_flags_save - Add a PF_* flag to current->flags, save old value + * memalloc_flags_save - Add a PF_* flag to current->flags, return saved flags mask * * This allows PF_* flags to be conveniently added, irrespective of current * value, and then the old version restored with memalloc_flags_restore(). */ -static inline unsigned memalloc_flags_save(unsigned flags) +static inline unsigned int memalloc_flags_save(unsigned int flags_mask) { - unsigned oldflags = ~current->flags & flags; - current->flags |= flags; - return oldflags; + unsigned int saved_flags_mask = ~current->flags & flags_mask; + + current->flags |= flags_mask; + return saved_flags_mask; } -static inline void memalloc_flags_restore(unsigned flags) +static inline void memalloc_flags_restore(unsigned int flags_mask) { - current->flags &= ~flags; + current->flags &= ~flags_mask; } /** -- 2.39.5