From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D100C71157 for ; Wed, 18 Jun 2025 03:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B50306B008A; Tue, 17 Jun 2025 23:45:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B275B6B008C; Tue, 17 Jun 2025 23:45:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3D206B0092; Tue, 17 Jun 2025 23:45:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 94CC76B008A for ; Tue, 17 Jun 2025 23:45:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A9B7E121CBB for ; Wed, 18 Jun 2025 03:45:20 +0000 (UTC) X-FDA: 83567131200.05.524B896 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf06.hostedemail.com (Postfix) with ESMTP id 1CEC2180002 for ; Wed, 18 Jun 2025 03:45:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YuxfRSYu; spf=pass (imf06.hostedemail.com: domain of cuiyunhui@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=cuiyunhui@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750218319; a=rsa-sha256; cv=none; b=nGCIoDfcJW4pOMglm6V+6AZKj0iebebrWQG5wvMeA08N44Pppo4wYsaxelu+O9QhPk7EHV Aar2YplEpEJNPK6Y489qrLdW0zOHuhbG32hB63Ax+RsNRzEAnnYC7l6L4qq4tgmdGAeAq7 L92WGehX4lG414AHeEMuSdSVkWiEM64= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YuxfRSYu; spf=pass (imf06.hostedemail.com: domain of cuiyunhui@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=cuiyunhui@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750218319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=0fLkDwiiUZSss6sfPf8N7ZCd7V1JUEtWvKlq+l/gMKQ=; b=6X07ZXf+veY/wrTGp3P6qnU78yqCq+7BeRkjohTc29PoyKKvevaEReU0hkewWU/8Gx5leV P6vnKxTzK8JhHqw/R3LsPMLJjUJROWcjlGqjjeEjzBwDD0azDV3zDGGDycBeNNBQJ/Ohpr UHe4fn38e9FfXrK0sOkbqELnU/A6jZw= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2353a2bc210so57099955ad.2 for ; Tue, 17 Jun 2025 20:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1750218317; x=1750823117; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0fLkDwiiUZSss6sfPf8N7ZCd7V1JUEtWvKlq+l/gMKQ=; b=YuxfRSYuuO+FRkp3KqpyAtFnD4dnu/LrfzwYZ8O2DKCj3banDkzfnRBkwjg6fHE7dU 2NuJThhn8gd0451V/uDad8xQ4vZ2eOEFPJer0D/DvW027LLyhugPymaT/m+NR8NzidCB PTPXrpZ0kMSKuLAR+7DMd5EmRC1MnCnPNTKzciF0amdqs8vCDUTYmJv+/VzPeVLXTT6q 1TmYTo6EggyKu3xFktVLgSBFMzYDxcimkFj4Rm1susDnu+KU4IENOgJVzVl/fnJ8vMAT GeMyiGitAm0EfBLZYvj2Lim1MpuB6bazvTLL8j8SWPptlK5cRluRx4HUjEIKt8ROtZiX 01cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750218317; x=1750823117; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0fLkDwiiUZSss6sfPf8N7ZCd7V1JUEtWvKlq+l/gMKQ=; b=SGHjzC+XpuauTf7TV+RjZbo9imdgpykBkUC1j1D/VnaUSZ2raBJhdwgivubutBqveS emya7VfH0KSyzuxDgll8gyJRi/XOyxLEKAcOtnsuKFPBaxGPpnXSfWXL4DnzwsNf/5iO hgpPCL+pPpCuI2xh8GvY8MBAkWDnjnxrgytFOctBapQ5/0uTLACvByeOvN53//qg2TMD 87QCunEx1/G1cEjWa5Hzg0kG//2PkGv3Zn9o8E0qNj/nFbnV1gYJLz9EBix5a3O1W5Ea RY0tHDkeWLfZC+T06z3fX1/lUAFn8MrHbS2W4vCe4FBFszAVpuZ9I+WTUV/D4PZFxVgK uyPg== X-Forwarded-Encrypted: i=1; AJvYcCWYbw/klkKVx1+2Ak1ndcynlOCmjTgGSlutb30HImZrr/moyRyrlvPA+/rkpwPVxGpcZGSY/9HdCQ==@kvack.org X-Gm-Message-State: AOJu0YxqGb964krfq6ZzOxQ6Gp3xnXwiq6xUueEt2DhiUDlMUj1c7lJ5 Ha3whFcIpUWc5zrkVGb+ZyBYgEalw8AFy7gzbfg2ujcMKV8bL9uUTzvnO6pI5m57eJo= X-Gm-Gg: ASbGncv9ZzUfM7zKbsbKTlNZT+bIAfg9HJMHRwyAgW/qZtxxTUSnmzUleO4cYFdQb4u if/xSiuHh3DQ8VeIxcFW1Gm15csbmLAppVVVOMB9pOOiSsVTKAlNwGKtE82zLd6Q/xMlV8sx+Kf r2fO0fEFKJqU7/NqCFBglL98ykkr0WZUaCAf84zei90bUomSsD2Bbty4Liwu5Om832REjmNCxw1 GsKScD3LFcqIHkCU68NxkV1a26keZse5S80Yan5TY9hAWc7YjuzI2KQ+pSuxqaXh3A+5S2Vew9n LlxjJexG8ou6tP2JSLTr8j5pdwLsbXOVpO6i7cdRZ0epycBJZF7iykExfp7XqEnxW3wuCBfHSBP HNdV4zq9t17c58b+U+vTg X-Google-Smtp-Source: AGHT+IE7APHlRGasYy3yQ78VvuLvAp4la4XPZdrCuapexPi4U7QqDMCjcD3jPQHCJAuIypThc8r5lw== X-Received: by 2002:a17:902:d489:b0:234:c2e7:a0e4 with SMTP id d9443c01a7336-2366b32e46bmr212010545ad.3.1750218316850; Tue, 17 Jun 2025 20:45:16 -0700 (PDT) Received: from L6YN4KR4K9.bytedance.net ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365d8a1ab8sm89333465ad.84.2025.06.17.20.45.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 17 Jun 2025 20:45:16 -0700 (PDT) From: Yunhui Cui To: yury.norov@gmail.com, linux@rasmusvillemoes.dk, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, dennis@kernel.org, tj@kernel.org, cl@gentwo.org, linux-mm@kvack.org Cc: Yunhui Cui Subject: [PATCH RFC 1/2] riscv: remove irqflags.h inclusion in asm/bitops.h Date: Wed, 18 Jun 2025 11:43:27 +0800 Message-Id: <20250618034328.21904-1-cuiyunhui@bytedance.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1CEC2180002 X-Stat-Signature: 9adqbb9dq8ribeqodkqbw37751h4kqro X-Rspam-User: X-HE-Tag: 1750218317-984140 X-HE-Meta: U2FsdGVkX1+gN68rG6jcdPOwP437YBKZ4mTHunt7KE2hKEZRzr94NWgbpqBHV4MIkzla8NlVR7a9nDNfzdJal2m89H2HGFhbUtwbDlHe8I4x0yAT/WgN2rEInrMV0+NjWsC1MougJhX5iDCfppKK/q/PsRR6az/IWG3+Y4eG74WDqF3jDiDpzDiiUyBcJ//9XMTPUe3+4T+34VGc/IioHtAaLsWmoqbpy1RSnriDffpLAYoMuFLfaPp8DSwIzwVquQPKvGQSFaI5GYDp3BPXOG3f86q6zP9SjHCzO+Ng5CkeT95Ss7cDeOpXoWdWBGO9ZPzsqvnsEmvJiTQJHE0l54hn4eegt7p11V+qtGMUUAGW4GvDUTd/tiD3DqqNuoNZoo+MNylX/l8PtxZJKfpKI4m+RVViIcXCNXani+2d8LqswRaPFGoLxh9sipEMwMSsXglQOoXGSHWdlPj+c+ropF3f6HwOldpEo1lq3xeD0f45boPKyWrO88V//1As62vDTtcuJBPWY+w0Imvuug00Wxkl/KR5mAmSRka2RoWMQNVVn79tk2TgrYa/tjBk+8uxTekVJah120Em/nD5dJt/oF6rYLRlTT4M50f2uymd+l46ebXCfhbqNNyL6DarRblfk9gKHLVM0Uz+JP6KKnpNhrPhCH6VuVcNo29Y8obExAYSiFqb4XLVMEJUFv3TiwW7wJomgXgeseyYPa/Q2J/J/WwA05eFIq28PalmB34cP4qvAwhgUCOg1k0/XkWXFFRoojhTccr6P7NR4tuh44n2njddNj5FJTdEsrBCMQup0YS41DglDJ9fK9xi6I7ujDhNbDd7KHGQOXbn4pl5V4O7Fv0uM2+Ft/zlvDfcM3FHhFWF0Xu58HwN6DT9gdlHyGd6+bpP9YLL9h3qzgqzjAqkf2/DBqkYvizcK11kx9qtSsK/cF9eYKx/TByWUr3MwR294AKOipqnunhUruwPEce mp9yInJn yfGMxQlQMPEJ5m2hd45T4U6mpOC+KvYgu6lUC/O/vP5PVcgwY02zxygx5tkBGzE0+1MRieq4j056KVXhqdWLWf4/5Sg4AXymRlEvw9VQ9r4IQiX0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The arch/riscv/include/asm/bitops.h does not functionally require including /linux/irqflags.h. Additionally, adding arch/riscv/include/asm/percpu.h causes a circular inclusion: kernel/bounds.c ->include/linux/log2.h ->include/linux/bitops.h ->arch/riscv/include/asm/bitops.h ->include/linux/irqflags.h ->include/linux/find.h ->return val ? __ffs(val) : size; ->arch/riscv/include/asm/bitops.h The compilation log is as follows: CC kernel/bounds.s In file included from ./include/linux/bitmap.h:11, from ./include/linux/cpumask.h:12, from ./arch/riscv/include/asm/processor.h:55, from ./arch/riscv/include/asm/thread_info.h:42, from ./include/linux/thread_info.h:60, from ./include/asm-generic/preempt.h:5, from ./arch/riscv/include/generated/asm/preempt.h:1, from ./include/linux/preempt.h:79, from ./arch/riscv/include/asm/percpu.h:8, from ./include/linux/irqflags.h:19, from ./arch/riscv/include/asm/bitops.h:14, from ./include/linux/bitops.h:68, from ./include/linux/log2.h:12, from kernel/bounds.c:13: ./include/linux/find.h: In function 'find_next_bit': ./include/linux/find.h:66:30: error: implicit declaration of function '__ffs' [-Wimplicit-function-declaration] 66 | return val ? __ffs(val) : size; | ^~~~~ Signed-off-by: Yunhui Cui --- arch/riscv/include/asm/bitops.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h index d59310f74c2ba..d9837b3cf05fe 100644 --- a/arch/riscv/include/asm/bitops.h +++ b/arch/riscv/include/asm/bitops.h @@ -11,7 +11,6 @@ #endif /* _LINUX_BITOPS_H */ #include -#include #include #include -- 2.39.5